René's URL Explorer Experiment


Title: fix(core): remove static dependency from @angular/core to @angular/compiler by mhevery · Pull Request #26734 · angular/angular · GitHub

Open Graph Title: fix(core): remove static dependency from @angular/core to @angular/compiler by mhevery · Pull Request #26734 · angular/angular

X Title: fix(core): remove static dependency from @angular/core to @angular/compiler by mhevery · Pull Request #26734 · angular/angular

Description: With Ivy we need @Component decorator to compile the component. For this reason @Component depends on @angular/compiler. We expect that the the compiler will than be tree-shaken away as part of the production build. Unfortunately the @angular/compiler is large enough that the mare act of parsing and loading (even if not executing) is causing negative build time regression. This change fixes this by making the dependency between @Component decorator and @angular/compiler to be late bound (runtime) rather than statically bound (compile time). This means that for JIT mode it is not sufficient to just load @angular/core to have @angular/compiler loaded. Instead it is necessary to load @angular/compiler either explicitly or implicitly thought @angular/platform-browser-dynamic.

Open Graph Description: With Ivy we need @Component decorator to compile the component. For this reason @Component depends on @angular/compiler. We expect that the the compiler will than be tree-shaken away as part of the...

X Description: With Ivy we need @Component decorator to compile the component. For this reason @Component depends on @angular/compiler. We expect that the the compiler will than be tree-shaken away as part of the...

Opengraph URL: https://github.com/angular/angular/pull/26734

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:91aef0f0-19f1-8cfc-a728-69a49081edf6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90E4:EDA7A:1D79387:256E04B:6B015EC4
html-safe-nonce3362005f3af4c4e94eb0c130be3b25b3a2798f1ddf9ee89b82779bb0019faa65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEU0OkVEQTdBOjFENzkzODc6MjU2RTA0Qjo2QjAxNUVDNCIsInZpc2l0b3JfaWQiOiIxNjIwMTAzMzY5OTc4ODk2MDY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4e53dcf178c8f31d5eb7fdc555b5697f46e4cb5ce7ca69364a3fe1ee4e4c884f
hovercard-subject-tagpull_request:225578174
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/26734/files
twitter:imagehttps://avatars.githubusercontent.com/u/111951?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/111951?s=400&v=4
og:image:altWith Ivy we need @Component decorator to compile the component. For this reason @Component depends on @angular/compiler. We expect that the the compiler will than be tree-shaken away as part of the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/26734/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26734%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26734%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26734/files
Reloadhttps://github.com/angular/angular/pull/26734/files
Reloadhttps://github.com/angular/angular/pull/26734/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
mhevery:core_does_not_depend_on_compilerhttps://github.com/mhevery/angular/tree/core_does_not_depend_on_compiler
Conversation 34 https://github.com/angular/angular/pull/26734
Commits 1 https://github.com/angular/angular/pull/26734/commits
Checks 0 https://github.com/angular/angular/pull/26734/checks
Files changed https://github.com/angular/angular/pull/26734/files
Please reload this pagehttps://github.com/angular/angular/pull/26734/files
fix(core): remove static dependency from @angular/core to @angular/compiler https://github.com/angular/angular/pull/26734/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/26734/files
c4f71ff fix(core): Remove static dependency from @angular/core to @angular/co… mhevery Oct 24, 2018 https://github.com/angular/angular/pull/26734/commits/c4f71ff16cbad9f73eed646adc7a14412bbdd9d9
Clear filters https://github.com/angular/angular/pull/26734/files
Please reload this pagehttps://github.com/angular/angular/pull/26734/files
Please reload this pagehttps://github.com/angular/angular/pull/26734/files
directive.ts https://github.com/angular/angular/pull/26734/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
package.json https://github.com/angular/angular/pull/26734/files#diff-11f1c967e7b88e8bb1ad9292bc77da6ad6ac034c264ce56eed069eb1e19865de
compiler.ts https://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
compiler_facade_interface.ts https://github.com/angular/angular/pull/26734/files#diff-e577765cc283f392cc088f070123dfd505773dde21e8fe0ffb950b68c2eda23f
jit_compiler_facade.ts https://github.com/angular/angular/pull/26734/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
r3_module_compiler.ts https://github.com/angular/angular/pull/26734/files#diff-46eddfe0653c3d025ebd259fa5fbcdc433e419a5a259c490c4ad27822d4cef76
api.ts https://github.com/angular/angular/pull/26734/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
t2_api.ts https://github.com/angular/angular/pull/26734/files#diff-9509f4e1d32c86500e886bd34e1b8a240d708d2014a8d98648a5fb1f71c8060f
util.ts https://github.com/angular/angular/pull/26734/files#diff-78e6a6885e8d6b7b42896d94f6cde5cca9411e86b752a4af8fa91d409cdd852b
compiler_facade_interface_spec.ts https://github.com/angular/angular/pull/26734/files#diff-6586fcaf15d59acfaa2efaeed02f6c6dea28203c20216663a8b5e7bcb4c9f459
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-cd5507f504d52875511a065db827ce5cd6edf05699e4c99bc0e1cb0c2fa79b4e
package.json https://github.com/angular/angular/pull/26734/files#diff-0b810c38f3c138a3d5e44854edefd5eb966617ca84e62f06511f60acc40546c7
di.ts https://github.com/angular/angular/pull/26734/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
compiler_facade.ts https://github.com/angular/angular/pull/26734/files#diff-74a49442ae735c34462bd0f73d4375423a71750037f8489429501f8a6ac000c6
compiler_facade_interface.ts https://github.com/angular/angular/pull/26734/files#diff-32c4ab90d88f15250f10b39e2d86e729430d86722072487ddf464bf0e908794a
directive.ts https://github.com/angular/angular/pull/26734/files#diff-4f93f07077211da349d6cebe7f4042363eb78ddcd97872c8359cd05a5de386b6
injectable.ts https://github.com/angular/angular/pull/26734/files#diff-3ed5d475d58fdd46dd733fc47f4a2f9147396319f31633c5086bf5765846ad36
module.ts https://github.com/angular/angular/pull/26734/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
pipe.ts https://github.com/angular/angular/pull/26734/files#diff-e419bfcdc3d843083d851ea810afd857e78fedd5d2a9bcab451cf1f2da043483
util.ts https://github.com/angular/angular/pull/26734/files#diff-2505d49c61f188910cc94a95c74531b0f2eb6e7235e2641e493cbf321b71f0b2
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-3d0e0d8f14c28ff28bd3f2e7bd9f195e56289f9c8c4bedee55e671f79c2f6657
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
treeshaking_spec.ts https://github.com/angular/angular/pull/26734/files#diff-828f4c5d780c89d43b30fa55e1599870f7a98a82412c893e4b23c13e0e2eb8db
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-41f24810cc5764e0313933f46b60ae1410296fb160235f21a70e38b226d15283
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
treeshaking_spec.ts https://github.com/angular/angular/pull/26734/files#diff-d037f28f791a0162e7cd3522f8ee843fe4a98cb203f4e834962bc385ed013259
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-f8d92177604f5e2b14d427257fb84cbc50d0ee8b09ba7fb2741dd1135b5ddf62
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
treeshaking_spec.ts https://github.com/angular/angular/pull/26734/files#diff-5fae7bb058f75042060654eba324413c4833461d31b4f600a2b7ccb5692df121
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-e0e2a6c428bafd8c0bceaacc0d5d69d2f0603e7525eca10b4692b8526f28e0e4
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
todo_e2e_spec.ts https://github.com/angular/angular/pull/26734/files#diff-c311589475ee6fc9fa6665113eef5ca4b9364cc7873c065f8491f8e558900b9f
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-eb6d7a5c886b65a20894bd24ac31952f5732cebb818b0a22bb83fab3c19c6866
bundle.golden_symbols.json https://github.com/angular/angular/pull/26734/files#diff-4ba724a475f72693b99f62d0eda8cab654bcab8fa33875c27d80f7873203e08f
todo_e2e_spec.ts https://github.com/angular/angular/pull/26734/files#diff-df82df305fdec7e05fe689f050bfd80aa8f529a8c4d360bd2a4b7b21387fbb42
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-a1bbbf89952cbb0e556756019cc5e6e678bdd2e3be263e82896ff0e7906cda2a
back_patch_types_specs.ts https://github.com/angular/angular/pull/26734/files#diff-b19d51b6cc0d17f78b9818d169d4b556c3e9ea7db6d29406af6ee0f088b41fe4
patch_types_spec.ts https://github.com/angular/angular/pull/26734/files#diff-7fb149a4015da6fd5e30d88476a040290dd53ec8d810fb328fed59b175b83d13
small_app_spec.ts https://github.com/angular/angular/pull/26734/files#diff-c17762ebe7cbe74a6c44fa3b9ab5aa98d472ba29ac983168d688484fc7a15b3d
jit_spec.ts https://github.com/angular/angular/pull/26734/files#diff-03031f63a1e5967132268a6535e9e1f802064d0c9e49bd7ea56e759b942fd543
directive_spec.ts https://github.com/angular/angular/pull/26734/files#diff-822a94d31b669ec54f6181e83c11c092a8c62d4bbf6c9f24a45e3986ec8cba57
load_domino.ts https://github.com/angular/angular/pull/26734/files#diff-d1d1e71d3e03bce7db0f4c42eaffcc6910eef9703d7ca78a418a4095da6ffb83
BUILD.bazel https://github.com/angular/angular/pull/26734/files#diff-a01a9484113cc3c1146ccc722cba2e9195685c6e2154cac70608976f021d6858
init_browser_spec.ts https://github.com/angular/angular/pull/26734/files#diff-97e01e581728c0933431e2cb283ae2ca9725c5454144a2e98d4c99bedacd67f9
init_node_spec.ts https://github.com/angular/angular/pull/26734/files#diff-2eacbf85c9c5d92ac7fc759cb855f7c74423b4bcf609c182188648068f5bffa9
packages/compiler-cli/src/ngtsc/annotations/src/directive.tshttps://github.com/angular/angular/pull/26734/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
View file https://github.com/mhevery/angular/blob/c4f71ff16cbad9f73eed646adc7a14412bbdd9d9/packages/compiler-cli/src/ngtsc/annotations/src/directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26734/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26734/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/26734/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
https://github.com/angular/angular/pull/26734/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
packages/compiler/package.jsonhttps://github.com/angular/angular/pull/26734/files#diff-11f1c967e7b88e8bb1ad9292bc77da6ad6ac034c264ce56eed069eb1e19865de
View file https://github.com/mhevery/angular/blob/c4f71ff16cbad9f73eed646adc7a14412bbdd9d9/packages/compiler/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26734/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26734/files#diff-11f1c967e7b88e8bb1ad9292bc77da6ad6ac034c264ce56eed069eb1e19865de
packages/compiler/src/compiler.tshttps://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
View file https://github.com/mhevery/angular/blob/c4f71ff16cbad9f73eed646adc7a14412bbdd9d9/packages/compiler/src/compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26734/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
https://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
https://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
https://github.com/angular/angular/pull/26734/files#diff-ac4064faf987a33dfff2f047785143fa56f89fc726a192ca9ba5c3954f2ccd92
packages/compiler/src/compiler_facade_interface.tshttps://github.com/angular/angular/pull/26734/files#diff-e577765cc283f392cc088f070123dfd505773dde21e8fe0ffb950b68c2eda23f
View file https://github.com/mhevery/angular/blob/c4f71ff16cbad9f73eed646adc7a14412bbdd9d9/packages/compiler/src/compiler_facade_interface.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26734/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/26734/files
Please reload this pagehttps://github.com/angular/angular/pull/26734/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.