| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1c0de208-cfec-0235-5b35-7d6be9a6315d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 95C8:1C9FF9:BBD020:FF98F6:6A619C39 |
| html-safe-nonce | 55a5122eee3e979ee428bb6e7ac4bfd75f350e772f544da3631109b797f92130 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUM4OjFDOUZGOTpCQkQwMjA6RkY5OEY2OjZBNjE5QzM5IiwidmlzaXRvcl9pZCI6IjI5OTQ2NDU0MDE3OTcyMzc4MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a3cf748382b32074631b19c4f121d2eec8cc99a410e19d3c29450dd618daa029 |
| hovercard-subject-tag | pull_request:223679784 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/26521/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/95d5352be2e32b8657e5e63764a9c4637de02c45ba437052d71b5e56638fb439/angular/angular/pull/26521 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/95d5352be2e32b8657e5e63764a9c4637de02c45ba437052d71b5e56638fb439/angular/angular/pull/26521 |
| og:image:alt | Fixes #24618 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasonaden |
| hostname | github.com |
| expected-hostname | github.com |
| None | c28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd05235d52ffb3318513d883a56c87a121015c8b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/26521#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26521 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26521 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/26521 |
| Reload | https://github.com/angular/angular/pull/26521 |
| Reload | https://github.com/angular/angular/pull/26521 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27.5k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
101k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
978
| https://github.com/angular/angular/issues |
|
Pull requests
161
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
24
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| jasonaden | https://github.com/jasonaden |
| angular:master | https://github.com/angular/angular/tree/master |
| jasonaden:FW-153_url_returned_from_guards | https://github.com/jasonaden/angular/tree/FW-153_url_returned_from_guards |
| Conversation | https://github.com/angular/angular/pull/26521 |
| Commits7 (7) | https://github.com/angular/angular/pull/26521/commits |
| Checks | https://github.com/angular/angular/pull/26521/checks |
| Files changed | https://github.com/angular/angular/pull/26521/files |
| Redirect if a guard returns a UrlTree | https://github.com/angular/angular/pull/26521#top |
| jasonaden | https://github.com/jasonaden |
| angular:master | https://github.com/angular/angular/tree/master |
| jasonaden:FW-153_url_returned_from_guards | https://github.com/jasonaden/angular/tree/FW-153_url_returned_from_guards |
|
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#issue-371173389 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| #24618 | https://github.com/angular/angular/issues/24618 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
|
| https://github.com/jasonaden |
| refactor(router): add type guards for router guards | https://github.com/angular/angular/pull/26521/commits/6543b7b8852c5c8dcb1684b4b68e2acaf95151fd |
| 6543b7b | https://github.com/angular/angular/pull/26521/commits/6543b7b8852c5c8dcb1684b4b68e2acaf95151fd |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| benlesh | https://github.com/benlesh |
| October 17, 2018 16:52 | https://github.com/angular/angular/pull/26521#event-1910124713 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#event-1910124730 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-430706752 |
| https://pr26521-ef48f54.ngbuilds.io/ | https://pr26521-ef48f54.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/benlesh |
| benlesh | https://github.com/benlesh |
|
Oct 17, 2018
| https://github.com/angular/angular/pull/26521#pullrequestreview-165741398 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26521/files |
| benlesh | https://github.com/benlesh |
| https://github.com/angular/angular/pull/26521#pullrequestreview-165741398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| packages/router/test/router.spec.ts | https://github.com/angular/angular/pull/26521/files#diff-d6c3501982a955764313ebf0d479f8d466379cafc9fff33b7c48fe4cd901b3ed |
| benlesh | https://github.com/benlesh |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#discussion_r226018769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| gkalpak | https://github.com/gkalpak |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#discussion_r226024780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| jasonaden | https://github.com/jasonaden |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#discussion_r226094989 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Oct 17, 2018
| https://github.com/angular/angular/pull/26521#pullrequestreview-165751856 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26521/files |
| packages/router/src/utils/type_guards.ts | https://github.com/angular/angular/pull/26521/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/benlesh |
| benlesh | https://github.com/benlesh |
|
Oct 17, 2018
| https://github.com/angular/angular/pull/26521#pullrequestreview-165850712 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26521/files |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-430802903 |
| https://pr26521-a1f41fc.ngbuilds.io/ | https://pr26521-a1f41fc.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/a1f41fcedead8f29e567aad568ddaa9c483a1cf2..94328f9f041063bf661e7e68e6c1771299551b67 |
| a1f41fc | https://github.com/angular/angular/commit/a1f41fcedead8f29e567aad568ddaa9c483a1cf2 |
| 94328f9 | https://github.com/angular/angular/commit/94328f9f041063bf661e7e68e6c1771299551b67 |
|
Compare
| https://github.com/angular/angular/compare/a1f41fcedead8f29e567aad568ddaa9c483a1cf2..94328f9f041063bf661e7e68e6c1771299551b67 |
| October 17, 2018 22:14 | https://github.com/angular/angular/pull/26521#event-1910824105 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-430809447 |
| https://pr26521-94328f9.ngbuilds.io/ | https://pr26521-94328f9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| jasonaden | https://github.com/jasonaden |
| October 17, 2018 15:20 | https://github.com/angular/angular/pull/26521#commits-pushed-8021972 |
|
| https://github.com/jasonaden |
| refactor(router): add type definitions for guard functions | https://github.com/angular/angular/pull/26521/commits/802197269bd61b08c44411f98fdb777cfe636456 |
| 8021972 | https://github.com/angular/angular/pull/26521/commits/802197269bd61b08c44411f98fdb777cfe636456 |
|
| https://github.com/jasonaden |
| refactor(router): remove type casting from wrapIntoObservable private… | https://github.com/angular/angular/pull/26521/commits/4069aae3e1130b738ce26d1ccc2b39a4719724be |
| 4069aae | https://github.com/angular/angular/pull/26521/commits/4069aae3e1130b738ce26d1ccc2b39a4719724be |
|
| https://github.com/jasonaden |
| feat(router): allow redirect from guards by returning UrlTree | https://github.com/angular/angular/pull/26521/commits/b5c615d9aa38d86cf87c36fd02fe2d45c1c884b4 |
| b5c615d | https://github.com/angular/angular/pull/26521/commits/b5c615d9aa38d86cf87c36fd02fe2d45c1c884b4 |
|
| https://github.com/jasonaden |
| feat(router): allow guards to return UrlTree as well as boolean | https://github.com/angular/angular/pull/26521/commits/25104202dd048abcf55cfa05851d0973992c5238 |
| 2510420 | https://github.com/angular/angular/pull/26521/commits/25104202dd048abcf55cfa05851d0973992c5238 |
|
| https://github.com/jasonaden |
| feat(router): guard returning UrlTree cancels current navigation and … | https://github.com/angular/angular/pull/26521/commits/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
| 1cb4a3b | https://github.com/angular/angular/pull/26521/commits/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
| angular#24618 | https://github.com/angular/angular/issues/24618 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/94328f9f041063bf661e7e68e6c1771299551b67..1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
| 94328f9 | https://github.com/angular/angular/commit/94328f9f041063bf661e7e68e6c1771299551b67 |
| 1cb4a3b | https://github.com/angular/angular/commit/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
|
Compare
| https://github.com/angular/angular/compare/94328f9f041063bf661e7e68e6c1771299551b67..1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
| October 17, 2018 22:21 | https://github.com/angular/angular/pull/26521#event-1910834199 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Oct 17, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-430810526 |
| Presubmit | http://test/OCL:217592184:BASE:217598835:1539815001338:d5cb61c1 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| IgorMinar | https://github.com/IgorMinar |
| October 18, 2018 00:33 | https://github.com/angular/angular/pull/26521#event-1910993773 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| Oct 18, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-430835202 |
| Global Presubmit | https://test.corp.google.com/OCL:217592184:BASE:217619644:1539822702393:e18f5a52 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/sarunint |
| sarunint | https://github.com/sarunint |
|
Oct 18, 2018
| https://github.com/angular/angular/pull/26521#pullrequestreview-165948349 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
| sarunint | https://github.com/sarunint |
| https://github.com/angular/angular/pull/26521#pullrequestreview-165948349 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| packages/router/src/interfaces.ts | https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27#diff-7ed40abf6798511743df16f21838b8e4833911726307c7571cae4585597226fb |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| packages/router/src/interfaces.ts | https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27#diff-7ed40abf6798511743df16f21838b8e4833911726307c7571cae4585597226fb |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| packages/router/src/interfaces.ts | https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27#diff-7ed40abf6798511743df16f21838b8e4833911726307c7571cae4585597226fb |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| packages/router/src/interfaces.ts | https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27#diff-7ed40abf6798511743df16f21838b8e4833911726307c7571cae4585597226fb |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 30, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-434432531 |
| https://pr26521-eeeb56b.ngbuilds.io/ | https://pr26521-eeeb56b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/eeeb56b002d43ddacb09976743b445e04c7b5324..43e34dc258b33be43ad682b07562f672d1a79ab3 |
| eeeb56b | https://github.com/angular/angular/commit/eeeb56b002d43ddacb09976743b445e04c7b5324 |
| 43e34dc | https://github.com/angular/angular/commit/43e34dc258b33be43ad682b07562f672d1a79ab3 |
|
Compare
| https://github.com/angular/angular/compare/eeeb56b002d43ddacb09976743b445e04c7b5324..43e34dc258b33be43ad682b07562f672d1a79ab3 |
| October 30, 2018 19:26 | https://github.com/angular/angular/pull/26521#event-1936072504 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 30, 2018 | https://github.com/angular/angular/pull/26521#issuecomment-434438400 |
| https://pr26521-43e34dc.ngbuilds.io/ | https://pr26521-43e34dc.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
|
| https://github.com/jasonaden |
| fixup! feat(router): guard returning UrlTree cancels current navigati… | https://github.com/angular/angular/pull/26521/commits/43e505ef068c25b0134a87ff55aee93c95009767 |
| 43e505e | https://github.com/angular/angular/pull/26521/commits/43e505ef068c25b0134a87ff55aee93c95009767 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| force-pushed | https://github.com/angular/angular/compare/43e34dc258b33be43ad682b07562f672d1a79ab3..43e505ef068c25b0134a87ff55aee93c95009767 |
| 43e34dc | https://github.com/angular/angular/commit/43e34dc258b33be43ad682b07562f672d1a79ab3 |
| 43e505e | https://github.com/angular/angular/commit/43e505ef068c25b0134a87ff55aee93c95009767 |
|
Compare
| https://github.com/angular/angular/compare/43e34dc258b33be43ad682b07562f672d1a79ab3..43e505ef068c25b0134a87ff55aee93c95009767 |
| October 30, 2018 19:47 | https://github.com/angular/angular/pull/26521#event-1936119998 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
| Oct 31, 2018 | https://github.com/angular/angular/pull/26521#event-1938380631 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Oct 31, 2018 | https://github.com/angular/angular/pull/26521#event-1938380937 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Oct 31, 2018 | https://github.com/angular/angular/pull/26521#event-1939241432 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| 9f4299d | https://github.com/angular/angular/commit/9f4299d47babf4d3feb5fe701cd1701aa616f798 |
| Oct 31, 2018 | https://github.com/angular/angular/pull/26521#event-1939332470 |
| matsko | https://github.com/matsko |
|
Oct 31, 2018
| https://github.com/angular/angular/pull/26521#ref-commit-6712492 |
|
| https://github.com/jasonaden |
|
| https://github.com/matsko |
| refactor(router): add type definitions for guard functions ( | https://github.com/angular/angular/commit/6712492dc29eba018fb2eae056f268eabc485a72 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| ) | https://github.com/angular/angular/commit/6712492dc29eba018fb2eae056f268eabc485a72 |
| 6712492 | https://github.com/angular/angular/commit/6712492dc29eba018fb2eae056f268eabc485a72 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| matsko | https://github.com/matsko |
|
Oct 31, 2018
| https://github.com/angular/angular/pull/26521#ref-commit-17586f1 |
|
| https://github.com/jasonaden |
|
| https://github.com/matsko |
| refactor(router): remove type casting from wrapIntoObservable private… | https://github.com/angular/angular/commit/17586f1e94289e733deb382b38521c3e424d7774 |
| 17586f1 | https://github.com/angular/angular/commit/17586f1e94289e733deb382b38521c3e424d7774 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| matsko | https://github.com/matsko |
|
Oct 31, 2018
| https://github.com/angular/angular/pull/26521#ref-commit-152ca66 |
|
| https://github.com/jasonaden |
|
| https://github.com/matsko |
| feat(router): allow redirect from guards by returning UrlTree ( | https://github.com/angular/angular/commit/152ca66ebaa61737b4ef0321570ad6b75235980d |
| #26521 | https://github.com/angular/angular/pull/26521 |
| ) | https://github.com/angular/angular/commit/152ca66ebaa61737b4ef0321570ad6b75235980d |
| 152ca66 | https://github.com/angular/angular/commit/152ca66ebaa61737b4ef0321570ad6b75235980d |
| #26521 | https://github.com/angular/angular/pull/26521 |
| matsko | https://github.com/matsko |
|
Oct 31, 2018
| https://github.com/angular/angular/pull/26521#ref-commit-081f95c |
|
| https://github.com/jasonaden |
|
| https://github.com/matsko |
| feat(router): allow guards to return UrlTree as well as boolean ( | https://github.com/angular/angular/commit/081f95c812ab194dadad8e549c93cbbe9cc945f8 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| ) | https://github.com/angular/angular/commit/081f95c812ab194dadad8e549c93cbbe9cc945f8 |
| 081f95c | https://github.com/angular/angular/commit/081f95c812ab194dadad8e549c93cbbe9cc945f8 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| matsko | https://github.com/matsko |
|
Oct 31, 2018
| https://github.com/angular/angular/pull/26521#ref-commit-4e9f2e5 |
|
| https://github.com/jasonaden |
|
| https://github.com/matsko |
| feat(router): guard returning UrlTree cancels current navigation and … | https://github.com/angular/angular/commit/4e9f2e58957b65d08ff97bbc6374673597c65fa5 |
|
| https://github.com/angular/angular/commit/4e9f2e58957b65d08ff97bbc6374673597c65fa5#comments |
| 4e9f2e5 | https://github.com/angular/angular/commit/4e9f2e58957b65d08ff97bbc6374673597c65fa5 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| #24618 | https://github.com/angular/angular/issues/24618 |
| #26521 | https://github.com/angular/angular/pull/26521 |
| https://github.com/Airblader |
| Airblader | https://github.com/Airblader |
|
Nov 17, 2018
| https://github.com/angular/angular/pull/26521#ref-issue-381904518 |
|
NavigationExtras when returning URLTree from guard
#27148
| https://github.com/angular/angular/issues/27148 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
Apr 4, 2019
| https://github.com/angular/angular/pull/26521#ref-issue-416631206 |
|
Router Resolve should have official support for UrlTree based redirection
#29089
| https://github.com/angular/angular/issues/29089 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/26521#issuecomment-531470098 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/26521#event-2634076367 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26521 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/26521/files/ef48f54622d0a644d1b868ab37a326b31c3e1bed |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/sarunint |
|
sarunint
| https://github.com/sarunint |
|
| https://github.com/angular/angular/pull/26521/files/1cb4a3b2096c64ce1508d4ebfd55151898eb2b27 |
|
| https://github.com/myrddraall |
|
myrddraall
| https://github.com/myrddraall |
|
| https://github.com/angular/angular/pull/26521/files/43e505ef068c25b0134a87ff55aee93c95009767 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/26521/files/ef48f54622d0a644d1b868ab37a326b31c3e1bed |
|
| https://github.com/benlesh |
|
benlesh
| https://github.com/benlesh |
|
| https://github.com/angular/angular/pull/26521/files/ef48f54622d0a644d1b868ab37a326b31c3e1bed |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
feature(router): Provide a way to coalesce multiple failed guards so only a single redirect is called
| https://github.com/angular/angular/issues/24618 |
| Please reload this page | https://github.com/angular/angular/pull/26521 |
|
| https://github.com/jasonaden |
|
| https://github.com/mary-poppins |
|
| https://github.com/JoostK |
|
| https://github.com/benlesh |
|
| https://github.com/sarunint |
|
| https://github.com/myrddraall |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |