René's URL Explorer Experiment


Title: fix(ivy): removing false-negative assert in getOrCreateNodeInjector function by AndrewKushnir · Pull Request #26305 · angular/angular · GitHub

Open Graph Title: fix(ivy): removing false-negative assert in getOrCreateNodeInjector function by AndrewKushnir · Pull Request #26305 · angular/angular

X Title: fix(ivy): removing false-negative assert in getOrCreateNodeInjector function by AndrewKushnir · Pull Request #26305 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) Does this PR introduce a breaking change? [ ] Yes [x] No

X Description: PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) Does this PR introduce a breaking change? [ ] Yes [x] No

Opengraph URL: https://github.com/angular/angular/pull/26305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:25c95438-1370-bcec-d0fc-748acb9ffd5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE0C:11EACE:C8D58F:10CFFF6:6B00FC15
html-safe-noncea18a9208e5b34e1d6de7f3000c9359a0c8a7d2fac022af7f94cfc28749f4aa1a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTBDOjExRUFDRTpDOEQ1OEY6MTBDRkZGNjo2QjAwRkMxNSIsInZpc2l0b3JfaWQiOiIyMjExMDQxNzUxNjM5NjQ0MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf7ed2015c17d6531bdbffb3783e76a4942e1e1468276c3bb6db260df90f6b941
hovercard-subject-tagpull_request:221226253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/26305/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/863f28c49be14058f1c8c76355d468a378d5efb0972d5e788d9a6eb3b2851165/angular/angular/pull/26305
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/863f28c49be14058f1c8c76355d468a378d5efb0972d5e788d9a6eb3b2851165/angular/angular/pull/26305
og:image:altPR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) Does this PR introduce a breaking change? [ ] Yes [x] No
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/26305#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26305
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26305
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26305
Reloadhttps://github.com/angular/angular/pull/26305
Reloadhttps://github.com/angular/angular/pull/26305
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:di-assert-rmhttps://github.com/AndrewKushnir/angular/tree/di-assert-rm
Conversationhttps://github.com/angular/angular/pull/26305
Commits5 (5)https://github.com/angular/angular/pull/26305/commits
Checkshttps://github.com/angular/angular/pull/26305/checks
Files changedhttps://github.com/angular/angular/pull/26305/files
fix(ivy): removing false-negative assert in getOrCreateNodeInjector functionhttps://github.com/angular/angular/pull/26305#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:di-assert-rmhttps://github.com/AndrewKushnir/angular/tree/di-assert-rm
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Oct 8, 2018https://github.com/angular/angular/pull/26305#issue-367931098
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Oct 8, 2018https://github.com/angular/angular/pull/26305#event-1891172404
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
October 8, 2018 19:56https://github.com/angular/angular/pull/26305#event-1891172419
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 8, 2018https://github.com/angular/angular/pull/26305#event-1891172533
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 8, 2018https://github.com/angular/angular/pull/26305#issuecomment-427960889
https://pr26305-9dbd148.ngbuilds.io/https://pr26305-9dbd148.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/kara
karahttps://github.com/kara
Oct 8, 2018 https://github.com/angular/angular/pull/26305#pullrequestreview-162656629
View reviewed changes https://github.com/angular/angular/pull/26305/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/26305#pullrequestreview-162656629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
packages/core/test/render3/compiler_canonical/pipes_spec.tshttps://github.com/angular/angular/pull/26305/files#diff-71ffa8fd3cc7a2020f9ef783b629d4e4c09ce49989d1b18eeeed8adc1a5268a0
karahttps://github.com/kara
Oct 8, 2018https://github.com/angular/angular/pull/26305#discussion_r223510915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
packages/core/test/render3/compiler_canonical/pipes_spec.tshttps://github.com/angular/angular/pull/26305/files#diff-71ffa8fd3cc7a2020f9ef783b629d4e4c09ce49989d1b18eeeed8adc1a5268a0
karahttps://github.com/kara
Oct 8, 2018https://github.com/angular/angular/pull/26305#discussion_r223511168
Please reload this pagehttps://github.com/angular/angular/pull/26305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
packages/core/test/render3/compiler_canonical/pipes_spec.tshttps://github.com/angular/angular/pull/26305/files#diff-71ffa8fd3cc7a2020f9ef783b629d4e4c09ce49989d1b18eeeed8adc1a5268a0
karahttps://github.com/kara
Oct 8, 2018https://github.com/angular/angular/pull/26305#discussion_r223511559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
packages/core/test/render3/compiler_canonical/pipes_spec.tshttps://github.com/angular/angular/pull/26305/files#diff-71ffa8fd3cc7a2020f9ef783b629d4e4c09ce49989d1b18eeeed8adc1a5268a0
karahttps://github.com/kara
Oct 8, 2018https://github.com/angular/angular/pull/26305#discussion_r223512615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 8, 2018https://github.com/angular/angular/pull/26305#issuecomment-428003135
https://pr26305-2883edb.ngbuilds.io/https://pr26305-2883edb.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Oct 8, 2018https://github.com/angular/angular/pull/26305#issuecomment-428003621
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 8, 2018https://github.com/angular/angular/pull/26305#issuecomment-428004191
https://pr26305-dd6d3f9.ngbuilds.io/https://pr26305-dd6d3f9.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26305
AndrewKushnirhttps://github.com/AndrewKushnir
October 8, 2018 17:36https://github.com/angular/angular/pull/26305#commits-pushed-8486c18
https://github.com/AndrewKushnir
fix(ivy): removing unnecessary assert in getOrCreateNodeInjector func…https://github.com/angular/angular/pull/26305/commits/8486c18eae1e52391d524c9436102c74542c6b18
8486c18https://github.com/angular/angular/pull/26305/commits/8486c18eae1e52391d524c9436102c74542c6b18
https://github.com/AndrewKushnir
fixup! fix(ivy): removing unnecessary assert in getOrCreateNodeInject…https://github.com/angular/angular/pull/26305/commits/b99d7edc8a52b08e9ca21584fe77f307bbc50576
b99d7edhttps://github.com/angular/angular/pull/26305/commits/b99d7edc8a52b08e9ca21584fe77f307bbc50576
https://github.com/AndrewKushnir
fixup! fix(ivy): removing unnecessary assert in getOrCreateNodeInject…https://github.com/angular/angular/pull/26305/commits/b8e57e14a948af22a05381268dfd8eb1e1a84c0e
b8e57e1https://github.com/angular/angular/pull/26305/commits/b8e57e14a948af22a05381268dfd8eb1e1a84c0e
https://github.com/AndrewKushnir
fixup! fix(ivy): removing unnecessary assert in getOrCreateNodeInject…https://github.com/angular/angular/pull/26305/commits/e779362d0925ab8bb26b20abd5cc400d0c080b91
e779362https://github.com/angular/angular/pull/26305/commits/e779362d0925ab8bb26b20abd5cc400d0c080b91
https://github.com/AndrewKushnir
fixup! fix(ivy): removing unnecessary assert in getOrCreateNodeInject…https://github.com/angular/angular/pull/26305/commits/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
74560f9https://github.com/angular/angular/pull/26305/commits/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/dd6d3f90ee4b2b2a76e09af1ff0680f2e786f79e..74560f9d4d66cb25170dfb8941a9f5f17a6dae62
dd6d3f9https://github.com/angular/angular/commit/dd6d3f90ee4b2b2a76e09af1ff0680f2e786f79e
74560f9https://github.com/angular/angular/commit/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
Compare https://github.com/angular/angular/compare/dd6d3f90ee4b2b2a76e09af1ff0680f2e786f79e..74560f9d4d66cb25170dfb8941a9f5f17a6dae62
October 9, 2018 00:37https://github.com/angular/angular/pull/26305#event-1891573076
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 9, 2018https://github.com/angular/angular/pull/26305#issuecomment-428022580
74560f9https://github.com/angular/angular/commit/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
https://pr26305-74560f9.ngbuilds.io/https://pr26305-74560f9.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 9, 2018 https://github.com/angular/angular/pull/26305#ref-pullrequest-365917308
Test bed with context discovery #26211 https://github.com/angular/angular/pull/26211
https://github.com/kara
karahttps://github.com/kara
Oct 9, 2018 https://github.com/angular/angular/pull/26305#pullrequestreview-162986677
View reviewed changes https://github.com/angular/angular/pull/26305/files/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
karahttps://github.com/kara
https://github.com/angular/angular/pull/26305#pullrequestreview-162986677
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/kara
karahttps://github.com/kara
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 9, 2018https://github.com/angular/angular/pull/26305#event-1893363358
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Oct 9, 2018https://github.com/angular/angular/pull/26305#event-1893620539
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
e564420https://github.com/angular/angular/commit/e5644204dc8007434e3d18582d10cc0bbb91935a
Oct 9, 2018https://github.com/angular/angular/pull/26305#event-1894221956
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26305#issuecomment-531445623
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26305#event-2633926583
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26305
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/26305/files/74560f9d4d66cb25170dfb8941a9f5f17a6dae62
Please reload this pagehttps://github.com/angular/angular/pull/26305
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Please reload this pagehttps://github.com/angular/angular/pull/26305
https://github.com/AndrewKushnir
https://github.com/mary-poppins
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.