René's URL Explorer Experiment


Title: fix(upgrade): properly destroy upgraded component elements and descendants by jbedard · Pull Request #26209 · angular/angular · GitHub

Open Graph Title: fix(upgrade): properly destroy upgraded component elements and descendants by jbedard · Pull Request #26209 · angular/angular

X Title: fix(upgrade): properly destroy upgraded component elements and descendants by jbedard · Pull Request #26209 · angular/angular

Description: Fixes #26208 PR Type [x] Bugfix What is the current behavior? Upgraded AngularJS dom elements are not destroyed properly (via jQuery) causing events+data to not be cleaned up. Child elements do no...

Open Graph Description: Fixes #26208 PR Type [x] Bugfix What is the current behavior? Upgraded AngularJS dom elements are not destroyed properly (via jQuery) causing events+data to not be cleaned up. Child elements do no...

X Description: Fixes #26208 PR Type [x] Bugfix What is the current behavior? Upgraded AngularJS dom elements are not destroyed properly (via jQuery) causing events+data to not be cleaned up. Child elements do no...

Opengraph URL: https://github.com/angular/angular/pull/26209

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:42b20d89-e9d0-851d-61f9-f9a2943ec6d5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD78:193CDB:C73827:105DDFF:696AFC28
html-safe-nonce00aee9f3755a990151e3c686fed5dd1b89989401389a597849012c966530ffd9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDc4OjE5M0NEQjpDNzM4Mjc6MTA1RERGRjo2OTZBRkMyOCIsInZpc2l0b3JfaWQiOiI4NTY5NjkyMTkzODU5MjM4OTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc55aa982c5e2f895ecd40c7b3cbb5622e5c92f0ee441d57cc3aeb45f2f3b6465
hovercard-subject-tagpull_request:219592627
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/26209/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c3746beb68076e49458d81839fbc81c589e21a701f2bb64de30e3399b8198912/angular/angular/pull/26209
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c3746beb68076e49458d81839fbc81c589e21a701f2bb64de30e3399b8198912/angular/angular/pull/26209
og:image:altFixes #26208 PR Type [x] Bugfix What is the current behavior? Upgraded AngularJS dom elements are not destroyed properly (via jQuery) causing events+data to not be cleaned up. Child elements do no...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbedard
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/26209#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26209
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26209
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26209
Reloadhttps://github.com/angular/angular/pull/26209
Reloadhttps://github.com/angular/angular/pull/26209
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27k https://github.com/login?return_to=%2Fangular%2Fangular
Star 99.7k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 1k https://github.com/angular/angular/issues
Pull requests 104 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects 2 https://github.com/angular/angular/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/angular/angular/security
Please reload this pagehttps://github.com/angular/angular/pull/26209
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/angular/angular/pull/26209#issue-comment-box
jbedardhttps://github.com/jbedard
angular:masterhttps://github.com/angular/angular/tree/master
jbedard:upgraded-cleandatahttps://github.com/jbedard/angular/tree/upgraded-cleandata
fix(upgrade): properly destroy upgraded component elements and descendants https://github.com/angular/angular/pull/26209#top
jbedardhttps://github.com/jbedard
angular:masterhttps://github.com/angular/angular/tree/master
jbedard:upgraded-cleandatahttps://github.com/jbedard/angular/tree/upgraded-cleandata
Conversation 47 https://github.com/angular/angular/pull/26209
Commits 4 https://github.com/angular/angular/pull/26209/commits
Checks 0 https://github.com/angular/angular/pull/26209/checks
Files changed https://github.com/angular/angular/pull/26209/files
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
https://github.com/jbedard
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#issue-365750717
#26208https://github.com/angular/angular/issues/26208
#26208https://github.com/angular/angular/issues/26208
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 2, 2018https://github.com/angular/angular/pull/26209#event-1878425761
https://github.com/jbedard
jbedardhttps://github.com/jbedard
force-pushedhttps://github.com/angular/angular/compare/53267b42c9cabae02f2db9887999b42594155c01..528fe26240eb94b69a27ea0146679e16f83d472d
53267b4https://github.com/angular/angular/commit/53267b42c9cabae02f2db9887999b42594155c01
528fe26https://github.com/angular/angular/commit/528fe26240eb94b69a27ea0146679e16f83d472d
Compare https://github.com/angular/angular/compare/53267b42c9cabae02f2db9887999b42594155c01..528fe26240eb94b69a27ea0146679e16f83d472d
October 2, 2018 06:28https://github.com/angular/angular/pull/26209#event-1878464715
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
comp: upgrade/static https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%2Fstatic%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Oct 2, 2018https://github.com/angular/angular/pull/26209#event-1878897118
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 2, 2018 https://github.com/angular/angular/pull/26209#pullrequestreview-160652868
View reviewed changes https://github.com/angular/angular/pull/26209/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/26209#pullrequestreview-160652868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/src/common/angular1.tshttps://github.com/angular/angular/pull/26209/files#diff-f4bc608dcf49f1570178492bb5a4a118aa82dfe2546ceb9919a1431e22805803
gkalpakhttps://github.com/gkalpak
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r221896309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222029617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222030318
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
gkalpakhttps://github.com/gkalpak
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222041684
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222044818
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
gkalpakhttps://github.com/gkalpak
Oct 3, 2018https://github.com/angular/angular/pull/26209#discussion_r222262843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/src/common/upgrade_helper.tshttps://github.com/angular/angular/pull/26209/files#diff-3611fb7a0f6bd5f6a1232eb1c4ef96614548842996994fdd9bc111a682c53592
gkalpakhttps://github.com/gkalpak
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r221898019
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
AngularJS implementationhttps://github.com/angular/angular.js/blob/26ddc5f830f902a3d22f4b2aab70d86d4d688c82/src/jqLite.js#L306-L312
jsLiteAcceptsData()https://github.com/angular/angular.js/blob/26ddc5f830f902a3d22f4b2aab70d86d4d688c82/src/jqLite.js#L307
if (element.querySelectorAll)https://github.com/angular/angular.js/blob/26ddc5f830f902a3d22f4b2aab70d86d4d688c82/src/jqLite.js#L309
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222049232
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
acceptsDatahttps://github.com/jquery/jquery/blob/58c6ca9822afa42d3b40cca8edb0abe90a2bcb34/src/data/var/acceptData.js#L10-L16
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r222051192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
jbedardhttps://github.com/jbedard
Oct 3, 2018https://github.com/angular/angular/pull/26209#discussion_r222477676
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
jqLitehttps://github.com/angular/angular.js/blob/26ddc5f830f902a3d22f4b2aab70d86d4d688c82/src/jqLite.js#L306-L312
jQueryhttps://github.com/jquery/jquery/blob/e743cbd28553267f955f71ea7248377915613fd9/src/manipulation.js#L223
Please reload this pagehttps://github.com/angular/angular/pull/26209
gkalpakhttps://github.com/gkalpak
Oct 4, 2018https://github.com/angular/angular/pull/26209#discussion_r222567617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/test/static/integration/upgrade_component_spec.tshttps://github.com/angular/angular/pull/26209/files#diff-138f4e83e4db39f790084bbee8e6f49f21af7f72ba7683739d686bd7b95473e4
gkalpakhttps://github.com/gkalpak
Oct 2, 2018https://github.com/angular/angular/pull/26209#discussion_r221898778
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jbedard
jbedardhttps://github.com/jbedard
Oct 3, 2018https://github.com/angular/angular/pull/26209#issuecomment-426819796
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 4, 2018 https://github.com/angular/angular/pull/26209#pullrequestreview-161483741
View reviewed changes https://github.com/angular/angular/pull/26209/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/26209#pullrequestreview-161483741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
under certain circumstanceshttps://github.com/angular/angular/blob/aaaa34021c2d56f798d20e5a1f31b23972055170/packages/upgrade/src/dynamic/upgrade_ng1_adapter.ts#L168-L171
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/src/common/angular1.tshttps://github.com/angular/angular/pull/26209/files#diff-f4bc608dcf49f1570178492bb5a4a118aa82dfe2546ceb9919a1431e22805803
gkalpakhttps://github.com/gkalpak
Oct 4, 2018https://github.com/angular/angular/pull/26209#discussion_r222567958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/test/dynamic/upgrade_spec.tshttps://github.com/angular/angular/pull/26209/files#diff-2d4d0d23f889701902fc796e618c0f8d26f98ce3939253866b82eced4b82fff9
gkalpakhttps://github.com/gkalpak
Oct 4, 2018https://github.com/angular/angular/pull/26209#discussion_r222568701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jbedard
jbedardhttps://github.com/jbedard
force-pushedhttps://github.com/angular/angular/compare/d32c85c4f2b9892b4db34589874eaf24280010c7..f9b55a62ec07fa34f65a89321c4435fb83ef3a0e
d32c85chttps://github.com/angular/angular/commit/d32c85c4f2b9892b4db34589874eaf24280010c7
f9b55a6https://github.com/angular/angular/commit/f9b55a62ec07fa34f65a89321c4435fb83ef3a0e
Compare https://github.com/angular/angular/compare/d32c85c4f2b9892b4db34589874eaf24280010c7..f9b55a62ec07fa34f65a89321c4435fb83ef3a0e
October 5, 2018 08:20https://github.com/angular/angular/pull/26209#event-1886517089
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 5, 2018 https://github.com/angular/angular/pull/26209#pullrequestreview-161972574
View reviewed changes https://github.com/angular/angular/pull/26209/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/26209#pullrequestreview-161972574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/src/common/upgrade_helper.tshttps://github.com/angular/angular/pull/26209/files#diff-3611fb7a0f6bd5f6a1232eb1c4ef96614548842996994fdd9bc111a682c53592
Please reload this pagehttps://github.com/angular/angular/pull/26209
packages/upgrade/test/dynamic/upgrade_spec.tshttps://github.com/angular/angular/pull/26209/files#diff-2d4d0d23f889701902fc796e618c0f8d26f98ce3939253866b82eced4b82fff9
gkalpakhttps://github.com/gkalpak
Oct 5, 2018https://github.com/angular/angular/pull/26209#discussion_r222958629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 5, 2018https://github.com/angular/angular/pull/26209#event-1886785120
https://github.com/jbedard
jbedardhttps://github.com/jbedard
force-pushedhttps://github.com/angular/angular/compare/f9b55a62ec07fa34f65a89321c4435fb83ef3a0e..e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae
f9b55a6https://github.com/angular/angular/commit/f9b55a62ec07fa34f65a89321c4435fb83ef3a0e
e383c49https://github.com/angular/angular/commit/e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae
Compare https://github.com/angular/angular/compare/f9b55a62ec07fa34f65a89321c4435fb83ef3a0e..e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae
October 5, 2018 17:07https://github.com/angular/angular/pull/26209#event-1887662299
https://github.com/jbedard
fix(upgrade): properly destroy upgraded component elements and descen…https://github.com/angular/angular/pull/26209/commits/10bf47eb443d3f79a55855f5e2d39cf67d97d29e
10bf47ehttps://github.com/angular/angular/pull/26209/commits/10bf47eb443d3f79a55855f5e2d39cf67d97d29e
angular#26208https://github.com/angular/angular/issues/26208
https://github.com/jbedard
jbedardhttps://github.com/jbedard
force-pushedhttps://github.com/angular/angular/compare/e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae..10bf47eb443d3f79a55855f5e2d39cf67d97d29e
e383c49https://github.com/angular/angular/commit/e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae
10bf47ehttps://github.com/angular/angular/commit/10bf47eb443d3f79a55855f5e2d39cf67d97d29e
Compare https://github.com/angular/angular/compare/e383c49bb9f429e3fb31b8d265f9e1a0375cd8ae..10bf47eb443d3f79a55855f5e2d39cf67d97d29e
October 5, 2018 17:42https://github.com/angular/angular/pull/26209#event-1887730853
https://github.com/jbedard
jbedardhttps://github.com/jbedard
Oct 5, 2018https://github.com/angular/angular/pull/26209#issuecomment-427455670
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 6, 2018https://github.com/angular/angular/pull/26209#event-1888492400
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 6, 2018https://github.com/angular/angular/pull/26209#issuecomment-427558848
@jbedardhttps://github.com/jbedard
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 8, 2018https://github.com/angular/angular/pull/26209#issuecomment-427926197
Presubmithttp://test/OCL:216214304:BASE:216214360:1539021616695:3a8b4574
Please reload this pagehttps://github.com/angular/angular/pull/26209
jasonadenhttps://github.com/jasonaden
Oct 8, 2018 https://github.com/angular/angular/pull/26209#ref-commit-623adbb
https://github.com/jbedard
https://github.com/jasonaden
fix(upgrade): properly destroy upgraded component elements and descen…https://github.com/angular/angular/commit/623adbbdf7c052f8f493bd79f863f4647bfa6cde
623adbbhttps://github.com/angular/angular/commit/623adbbdf7c052f8f493bd79f863f4647bfa6cde
#26209https://github.com/angular/angular/pull/26209
#26208https://github.com/angular/angular/issues/26208
#26209https://github.com/angular/angular/pull/26209
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
5a31bdehttps://github.com/angular/angular/commit/5a31bde6496c63d82d86227d7772c2127c28b08c
Oct 8, 2018https://github.com/angular/angular/pull/26209#event-1891085142
jasonadenhttps://github.com/jasonaden
Oct 8, 2018 https://github.com/angular/angular/pull/26209#ref-commit-9623e7c
https://github.com/jasonaden
Revert "fix(upgrade): properly destroy upgraded component elements an…https://github.com/jasonaden/angular/commit/9623e7c639bd30bb03869b9e62a64cf86969ce3e
9623e7chttps://github.com/jasonaden/angular/commit/9623e7c639bd30bb03869b9e62a64cf86969ce3e
angular#26209https://github.com/angular/angular/pull/26209
5a31bdehttps://github.com/jasonaden/angular/commit/5a31bde6496c63d82d86227d7772c2127c28b08c
jasonadenhttps://github.com/jasonaden
Oct 8, 2018 https://github.com/angular/angular/pull/26209#ref-commit-b22c376
https://github.com/jasonaden
Revert "fix(upgrade): properly destroy upgraded component elements an…https://github.com/angular/angular/commit/b22c3761234c153ffe160c45f6a0970b3efee599
b22c376https://github.com/angular/angular/commit/b22c3761234c153ffe160c45f6a0970b3efee599
#26209https://github.com/angular/angular/pull/26209
623adbbhttps://github.com/angular/angular/commit/623adbbdf7c052f8f493bd79f863f4647bfa6cde
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 8, 2018https://github.com/angular/angular/pull/26209#event-1891355360
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 8, 2018https://github.com/angular/angular/pull/26209#issuecomment-427988380
@gkalpakhttps://github.com/gkalpak
@jbedardhttps://github.com/jbedard
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 8, 2018https://github.com/angular/angular/pull/26209#event-1891362280
jasonadenhttps://github.com/jasonaden
Oct 10, 2018 https://github.com/angular/angular/pull/26209#ref-commit-7466a99
https://github.com/jasonaden
Revert "fix(upgrade): properly destroy upgraded component elements an…https://github.com/jasonaden/angular/commit/7466a99dda68cbfada4bc986a9bca80b87e05702
7466a99https://github.com/jasonaden/angular/commit/7466a99dda68cbfada4bc986a9bca80b87e05702
angular#26209https://github.com/angular/angular/pull/26209
912f3d1https://github.com/jasonaden/angular/commit/912f3d186f4ce5c4a97268775509cfb6285916c2
jasonadenhttps://github.com/jasonaden
Oct 10, 2018 https://github.com/angular/angular/pull/26209#ref-commit-65555fe
https://github.com/jasonaden
Revert "fix(upgrade): properly destroy upgraded component elements an…https://github.com/angular/angular/commit/65555fe35d9ae3e073c8d293923a0c21e742e019
65555fehttps://github.com/angular/angular/commit/65555fe35d9ae3e073c8d293923a0c21e742e019
#26209https://github.com/angular/angular/pull/26209
6da3867https://github.com/angular/angular/commit/6da3867d638baa71eea8f3e3741e0afccc98e86b
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 10, 2018https://github.com/angular/angular/pull/26209#event-1896732288
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 10, 2018https://github.com/angular/angular/pull/26209#issuecomment-428746664
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Oct 10, 2018https://github.com/angular/angular/pull/26209#issuecomment-428747513
https://travis-ci.org/angular/angular/jobs/439854930https://travis-ci.org/angular/angular/jobs/439854930
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jbedard
jbedardhttps://github.com/jbedard
Oct 10, 2018https://github.com/angular/angular/pull/26209#issuecomment-428750194
@gkalpakhttps://github.com/gkalpak
f5447a3https://github.com/angular/angular/commit/f5447a315d7189867bcd20e0eaaaba6d9d54b0b8
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 10, 2018https://github.com/angular/angular/pull/26209#issuecomment-428752230
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
fixup! fix(upgrade): properly destroy upgraded component elements and…https://github.com/angular/angular/pull/26209/commits/3586fc6bfaa043cc8ee59fc07b4ecc9d8c76a8ff
3586fc6https://github.com/angular/angular/pull/26209/commits/3586fc6bfaa043cc8ee59fc07b4ecc9d8c76a8ff
https://github.com/googlebot
googlebothttps://github.com/googlebot
Oct 10, 2018https://github.com/angular/angular/pull/26209#issuecomment-428754028
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Oct 10, 2018https://github.com/angular/angular/pull/26209#event-1896791812
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 11, 2018https://github.com/angular/angular/pull/26209#issuecomment-428855004
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/mhevery
mheveryhttps://github.com/mhevery
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Oct 11, 2018https://github.com/angular/angular/pull/26209#event-1899160074
https://github.com/googlebot
googlebothttps://github.com/googlebot
Oct 11, 2018https://github.com/angular/angular/pull/26209#issuecomment-429093571
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Oct 11, 2018https://github.com/angular/angular/pull/26209#issuecomment-429121042
http://test/OCL:216758713:BASE:216758772:1539292493195:9b1e806bhttp://test/OCL:216758713:BASE:216758772:1539292493195:9b1e806b
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 11, 2018 https://github.com/angular/angular/pull/26209#pullrequestreview-164037388
View reviewed changes https://github.com/angular/angular/pull/26209/files/3586fc6bfaa043cc8ee59fc07b4ecc9d8c76a8ff
https://github.com/mhevery
mheveryhttps://github.com/mhevery
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Oct 11, 2018https://github.com/angular/angular/pull/26209#event-1899510154
mheveryhttps://github.com/mhevery
Oct 12, 2018 https://github.com/angular/angular/pull/26209#ref-commit-4f09f7d
https://github.com/jbedard
https://github.com/mhevery
fix(upgrade): properly destroy upgraded component elements and descen…https://github.com/angular/angular/commit/4f09f7db732eac93e90fe50072509225c4fe6355
4f09f7dhttps://github.com/angular/angular/commit/4f09f7db732eac93e90fe50072509225c4fe6355
#26209https://github.com/angular/angular/pull/26209
#26208https://github.com/angular/angular/issues/26208
#26209https://github.com/angular/angular/pull/26209
https://github.com/mhevery
mheveryhttps://github.com/mhevery
071934ehttps://github.com/angular/angular/commit/071934e92ab638b7b69374bbe1a19109c0353b97
Oct 12, 2018https://github.com/angular/angular/pull/26209#event-1899827687
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Oct 12, 2018https://github.com/angular/angular/pull/26209#issuecomment-429224534
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26209#issuecomment-531445731
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26209#event-2633926940
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26209
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/26209/files/3586fc6bfaa043cc8ee59fc07b4ecc9d8c76a8ff
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Upgraded element children not destroyed/cleaned https://github.com/angular/angular/issues/26208
Please reload this pagehttps://github.com/angular/angular/pull/26209
https://github.com/jbedard
https://github.com/gkalpak
https://github.com/jasonaden
https://github.com/googlebot
https://github.com/IgorMinar
https://github.com/mhevery
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.