René's URL Explorer Experiment


Title: build: fix bad merge to patch branch by gregmagolan · Pull Request #26168 · angular/angular · GitHub

Open Graph Title: build: fix bad merge to patch branch by gregmagolan · Pull Request #26168 · angular/angular

X Title: build: fix bad merge to patch branch by gregmagolan · Pull Request #26168 · angular/angular

Description: Fix bad merge in #25774. Included temporary workaround to not turn on tsickle when building rxjs as this creates build failures: RROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/rxjs/BUILD.bazel:7:1: Compiling TypeScript (ES5 with ES Modules) @rxjs//:lib failed (Exit 1) external/rxjs/internal/Subscription.ts:9:1 - warning TS0: @class annotations are redundant with TypeScript equivalents 9 /** ~~~ 10 * Represents a disposable resource, such as the execution of an Observable. A ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... 20 */ ~~~ 21 export class Subscription implements SubscriptionLike { ... Work-around to be removed once we can generate a named UMD rxjs bundle and no longer build rxjs from source with Bazel.

Open Graph Description: Fix bad merge in #25774. Included temporary workaround to not turn on tsickle when building rxjs as this creates build failures: RROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d117...

X Description: Fix bad merge in #25774. Included temporary workaround to not turn on tsickle when building rxjs as this creates build failures: RROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d117...

Opengraph URL: https://github.com/angular/angular/pull/26168

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6b4e1cfe-e5df-34be-04c0-7186dd5638bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA19E:1087D4:1F7E7A9:2A0BBBC:6B017F17
html-safe-nonce1c9c4430120129e6158a5221aa658163a75f8f92679fe2cd5a60d0e5efdf61da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTlFOjEwODdENDoxRjdFN0E5OjJBMEJCQkM6NkIwMTdGMTciLCJ2aXNpdG9yX2lkIjoiMzIzNjMwMjA2NzQyOTYzNzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac20ccb46391b045486ccc239cbe349e80a5f0e7b7cf1f256aadc4e71d3e6bf638
hovercard-subject-tagpull_request:219101353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/26168/files
twitter:imagehttps://avatars.githubusercontent.com/u/520826?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/520826?s=400&v=4
og:image:altFix bad merge in #25774. Included temporary workaround to not turn on tsickle when building rxjs as this creates build failures: RROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d117...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/26168/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26168%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26168%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26168/files
Reloadhttps://github.com/angular/angular/pull/26168/files
Reloadhttps://github.com/angular/angular/pull/26168/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gregmagolanhttps://github.com/gregmagolan
angular:6.1.xhttps://github.com/angular/angular/tree/6.1.x
Conversation 10 https://github.com/angular/angular/pull/26168
Commits 6 https://github.com/angular/angular/pull/26168/commits
Checks 0 https://github.com/angular/angular/pull/26168/checks
Files changed https://github.com/angular/angular/pull/26168/files
Please reload this pagehttps://github.com/angular/angular/pull/26168/files
build: fix bad merge to patch branch https://github.com/angular/angular/pull/26168/files#top
Show all changes 6 commits https://github.com/angular/angular/pull/26168/files
c3f9559 build: fix bad merge to patch branch alexeagle Sep 28, 2018 https://github.com/angular/angular/pull/26168/commits/c3f95594ec15a54a4e72e7c0041b3bc7f5367a6a
6b190f7 build(bazel): don't turn on tsickle for esm5 for rxjs gregmagolan Sep 28, 2018 https://github.com/angular/angular/pull/26168/commits/6b190f764e5fc389ceb4a2fdb73ea075995f6439
05301ed build: compile fix in typescript_version.ts gregmagolan Oct 1, 2018 https://github.com/angular/angular/pull/26168/commits/05301ed6aec64a17296dee546ae4b5fc8ed44a23
6dd3bae build: golden file update gregmagolan Oct 1, 2018 https://github.com/angular/angular/pull/26168/commits/6dd3bae99fc0fdfe60a8d7b8b4bc772aeb3afc4c
9529150 build: golden file update gregmagolan Oct 1, 2018 https://github.com/angular/angular/pull/26168/commits/9529150eae60343de71f6ffa35f1c63726211ca2
add4df6 build: use presence of angularCompilerOptions to indicate we should r… alexeagle Oct 2, 2018 https://github.com/angular/angular/pull/26168/commits/add4df657135ec8a3468cde3f48c39873953e1fc
Clear filters https://github.com/angular/angular/pull/26168/files
Please reload this pagehttps://github.com/angular/angular/pull/26168/files
Please reload this pagehttps://github.com/angular/angular/pull/26168/files
modify_tsconfig.js https://github.com/angular/angular/pull/26168/files#diff-f6db29f5809e83d9d89fed6ff50a74f87b43f4652737842ef0c9390091bfb5d6
core_package.spec.ts https://github.com/angular/angular/pull/26168/files#diff-24af4eaf0d60baf23c81327aebf6a76a0a8d4f334871f48bbb9a5df297219ff6
typescript_version.ts https://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
bundle.golden_symbols.json https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
bundle.golden_symbols.json https://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
packages/bazel/src/modify_tsconfig.jshttps://github.com/angular/angular/pull/26168/files#diff-f6db29f5809e83d9d89fed6ff50a74f87b43f4652737842ef0c9390091bfb5d6
View file https://github.com/angular/angular/blob/add4df657135ec8a3468cde3f48c39873953e1fc/packages/bazel/src/modify_tsconfig.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26168/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26168/files#diff-f6db29f5809e83d9d89fed6ff50a74f87b43f4652737842ef0c9390091bfb5d6
https://github.com/angular/angular/pull/26168/files#diff-f6db29f5809e83d9d89fed6ff50a74f87b43f4652737842ef0c9390091bfb5d6
packages/bazel/test/ng_package/core_package.spec.tshttps://github.com/angular/angular/pull/26168/files#diff-24af4eaf0d60baf23c81327aebf6a76a0a8d4f334871f48bbb9a5df297219ff6
View file https://github.com/angular/angular/blob/add4df657135ec8a3468cde3f48c39873953e1fc/packages/bazel/test/ng_package/core_package.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26168/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26168/files#diff-24af4eaf0d60baf23c81327aebf6a76a0a8d4f334871f48bbb9a5df297219ff6
https://github.com/angular/angular/pull/26168/files#diff-24af4eaf0d60baf23c81327aebf6a76a0a8d4f334871f48bbb9a5df297219ff6
packages/compiler-cli/src/diagnostics/typescript_version.tshttps://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
View file https://github.com/angular/angular/blob/add4df657135ec8a3468cde3f48c39873953e1fc/packages/compiler-cli/src/diagnostics/typescript_version.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26168/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
https://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
https://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
https://github.com/angular/angular/pull/26168/files#diff-bd516635cdb856fc55d050ad776c634ed55193402d7452d3b4ec8eff5c2e6ced
packages/core/test/bundling/hello_world_r2/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
View file https://github.com/angular/angular/blob/add4df657135ec8a3468cde3f48c39873953e1fc/packages/core/test/bundling/hello_world_r2/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26168/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
https://github.com/angular/angular/pull/26168/files#diff-b7f4766a9c4d6af9860217372dfdf643f5962ac736f865612fd9f4cc8d1d0135
packages/core/test/bundling/injection/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
View file https://github.com/angular/angular/blob/add4df657135ec8a3468cde3f48c39873953e1fc/packages/core/test/bundling/injection/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26168/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
https://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
https://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
https://github.com/angular/angular/pull/26168/files#diff-4bb311b05854eebb61aacf3fd3ce53473592b612024bce95fd0b5737f2dfaafb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.