René's URL Explorer Experiment


Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular · GitHub

Open Graph Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular

X Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular

Description: This PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling getDirectives (please not that we can't parametrize this function with includeComponents as results are cached).

Open Graph Description: This PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...

X Description: This PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...

Opengraph URL: https://github.com/angular/angular/pull/26113

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1c11fff-15e4-2bfa-fdad-5abe488c2f4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC46:2270F4:C50D1F:1077E30:6B00F8BC
html-safe-nonce150cbb28d5088d8420bdb77ec080ad81a0d6abefabefd00fcf4bbc301338e87e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQ2OjIyNzBGNDpDNTBEMUY6MTA3N0UzMDo2QjAwRjhCQyIsInZpc2l0b3JfaWQiOiI1NjI3MDc2NzE5MTg2ODY4NDEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca9745f19a8bbdd458a33b66867112f4ed855ab0f1d51b7a4f7f8c4d249b02113
hovercard-subject-tagpull_request:218264992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/26113/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:altThis PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/26113/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26113/files
Reloadhttps://github.com/angular/angular/pull/26113/files
Reloadhttps://github.com/angular/angular/pull/26113/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:discovery_util_fixes_featqureshttps://github.com/pkozlowski-opensource/angular/tree/discovery_util_fixes_featqures
Conversation 32 https://github.com/angular/angular/pull/26113
Commits 1 https://github.com/angular/angular/pull/26113/commits
Checks 0 https://github.com/angular/angular/pull/26113/checks
Files changed https://github.com/angular/angular/pull/26113/files
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
fix(ivy): take components into account when discovering directives https://github.com/angular/angular/pull/26113/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/26113/files
8210f54 fix(ivy): take components into account when discovering directives pkozlowski-opensource Sep 26, 2018 https://github.com/angular/angular/pull/26113/commits/8210f54180a507bfe28d62040147b78cca528054
Clear filters https://github.com/angular/angular/pull/26113/files
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
context_discovery.ts https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
discovery_utils.ts https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
bundle.golden_symbols.json https://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
discovery_utils_spec.ts https://github.com/angular/angular/pull/26113/files#diff-bff2454888e0d0ea25106edb3da121cd1ab6fd0827cbd0b2bbe3076d9cc3b39c
integration_spec.ts https://github.com/angular/angular/pull/26113/files#diff-2259816480187d7b1e935e7b80bdc7bbb67e923a166c54c6b077459017b10654
packages/core/src/render3/context_discovery.tshttps://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
View file https://github.com/pkozlowski-opensource/angular/blob/8210f54180a507bfe28d62040147b78cca528054/packages/core/src/render3/context_discovery.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26113/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113/files#r220994347
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113/files#r221942800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@karahttps://github.com/kara
we've got both directive indices and directive instances on LContexthttps://github.com/angular/angular/blob/a2878b0b1d5af279400a33d7d200140c1c88648e/packages/core/src/render3/context_discovery.ts#L51-L59
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
karahttps://github.com/kara
Oct 2, 2018https://github.com/angular/angular/pull/26113/files#r222039320
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113/files#r222043113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
packages/core/src/render3/discovery_utils.tshttps://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
View file https://github.com/pkozlowski-opensource/angular/blob/8210f54180a507bfe28d62040147b78cca528054/packages/core/src/render3/discovery_utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26113/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113/files#r220983368
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113/files#r220988636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113/files#r220993908
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113/files#r221944572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@karahttps://github.com/kara
https://github.com/angular/angular/pull/26113/files#r221942800https://github.com/angular/angular/pull/26113/files#r221942800
Please reload this pagehttps://github.com/angular/angular/pull/26113/files
https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
packages/core/test/bundling/animation_world/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
View file https://github.com/pkozlowski-opensource/angular/blob/8210f54180a507bfe28d62040147b78cca528054/packages/core/test/bundling/animation_world/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26113/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
https://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
https://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
https://github.com/angular/angular/pull/26113/files#diff-e9083709df6104c08fdad339ad040cb30780f47f42a99b1aecdfbc8648cbc005
packages/core/test/render3/discovery_utils_spec.tshttps://github.com/angular/angular/pull/26113/files#diff-bff2454888e0d0ea25106edb3da121cd1ab6fd0827cbd0b2bbe3076d9cc3b39c
View file https://github.com/pkozlowski-opensource/angular/blob/8210f54180a507bfe28d62040147b78cca528054/packages/core/test/render3/discovery_utils_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26113/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26113/files#diff-bff2454888e0d0ea25106edb3da121cd1ab6fd0827cbd0b2bbe3076d9cc3b39c
https://github.com/angular/angular/pull/26113/files#diff-bff2454888e0d0ea25106edb3da121cd1ab6fd0827cbd0b2bbe3076d9cc3b39c
packages/core/test/render3/integration_spec.tshttps://github.com/angular/angular/pull/26113/files#diff-2259816480187d7b1e935e7b80bdc7bbb67e923a166c54c6b077459017b10654
View file https://github.com/pkozlowski-opensource/angular/blob/8210f54180a507bfe28d62040147b78cca528054/packages/core/test/render3/integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/26113/{{ revealButtonHref }}
https://github.com/angular/angular/pull/26113/files#diff-2259816480187d7b1e935e7b80bdc7bbb67e923a166c54c6b077459017b10654
https://github.com/angular/angular/pull/26113/files#diff-2259816480187d7b1e935e7b80bdc7bbb67e923a166c54c6b077459017b10654
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.