René's URL Explorer Experiment


Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular · GitHub

Open Graph Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular

X Title: fix(ivy): take components into account when discovering directives by pkozlowski-opensource · Pull Request #26113 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...

X Description: This PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...

Opengraph URL: https://github.com/angular/angular/pull/26113

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:787e6a6e-b2da-a798-1f85-05716049c209
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BD0:CC1A4:97E52F:C2E65A:6B00EE9D
html-safe-noncedbbd7360af8d1c639293bb043df9a000b6e236844659f488cece21bd958a6924
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQwOkNDMUE0Ojk3RTUyRjpDMkU2NUE6NkIwMEVFOUQiLCJ2aXNpdG9yX2lkIjoiNzE1NTczOTcwMTA2MjcyNTI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac92ba5e028e0507906fed85cdf0e93369a53a9ff4ea209d25c04fac67224f27d0
hovercard-subject-tagpull_request:218264992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/26113/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3f41f0529feba3fbd21d8b334dc0199815289690b3a506cff3d56c8e54ff13b6/angular/angular/pull/26113
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f41f0529feba3fbd21d8b334dc0199815289690b3a506cff3d56c8e54ff13b6/angular/angular/pull/26113
og:image:altThis PR fixes an issue where the includeComponents argument to the discoverDirectiveIndices was not taken into account. Additionally it returns components as part of directives list when calling ge...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/26113#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/26113
Reloadhttps://github.com/angular/angular/pull/26113
Reloadhttps://github.com/angular/angular/pull/26113
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:discovery_util_fixes_featqureshttps://github.com/pkozlowski-opensource/angular/tree/discovery_util_fixes_featqures
Conversationhttps://github.com/angular/angular/pull/26113
Commits1 (1)https://github.com/angular/angular/pull/26113/commits
Checkshttps://github.com/angular/angular/pull/26113/checks
Files changedhttps://github.com/angular/angular/pull/26113/files
fix(ivy): take components into account when discovering directiveshttps://github.com/angular/angular/pull/26113#top
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:discovery_util_fixes_featqureshttps://github.com/pkozlowski-opensource/angular/tree/discovery_util_fixes_featqures
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 26, 2018https://github.com/angular/angular/pull/26113#issue-363960616
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 26, 2018https://github.com/angular/angular/pull/26113#event-1868020243
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/83e6567e3de9300610bbc6676e473bcd301b8578..5be12f82c8fa86b26872755e176a1d52ca994d39
83e6567https://github.com/angular/angular/commit/83e6567e3de9300610bbc6676e473bcd301b8578
5be12f8https://github.com/angular/angular/commit/5be12f82c8fa86b26872755e176a1d52ca994d39
Compare https://github.com/angular/angular/compare/83e6567e3de9300610bbc6676e473bcd301b8578..5be12f82c8fa86b26872755e176a1d52ca994d39
September 26, 2018 10:36https://github.com/angular/angular/pull/26113#event-1868030050
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Sep 26, 2018https://github.com/angular/angular/pull/26113#issuecomment-424668917
https://pr26113-23a9b33.ngbuilds.io/https://pr26113-23a9b33.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Sep 26, 2018https://github.com/angular/angular/pull/26113#issuecomment-424669475
https://pr26113-83e6567.ngbuilds.io/https://pr26113-83e6567.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Sep 26, 2018https://github.com/angular/angular/pull/26113#issuecomment-424669952
https://pr26113-5be12f8.ngbuilds.io/https://pr26113-5be12f8.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Sep 26, 2018https://github.com/angular/angular/pull/26113#event-1868259558
https://github.com/kara
karahttps://github.com/kara
Sep 26, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159095874
View reviewed changes https://github.com/angular/angular/pull/26113/files
packages/core/src/render3/context_discovery.tshttps://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
karahttps://github.com/kara
Sep 26, 2018https://github.com/angular/angular/pull/26113#discussion_r220644815
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 26, 2018https://github.com/angular/angular/pull/26113#discussion_r220648996
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220867333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Sep 26, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159175676
View reviewed changes https://github.com/angular/angular/pull/26113/files
packages/core/src/render3/context_discovery.tshttps://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
JoostKhttps://github.com/JoostK
Sep 26, 2018https://github.com/angular/angular/pull/26113#discussion_r220705066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
matskohttps://github.com/matsko
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220775604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220866342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/matsko
matskohttps://github.com/matsko
Sep 27, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159262483
View reviewed changes https://github.com/angular/angular/pull/26113/files
packages/core/src/render3/discovery_utils.tshttps://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
matskohttps://github.com/matsko
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220776003
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220866831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Sep 27, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159280902
View reviewed changes https://github.com/angular/angular/pull/26113/files
mheveryhttps://github.com/mhevery
https://github.com/angular/angular/pull/26113#pullrequestreview-159280902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
packages/core/src/render3/discovery_utils.tshttps://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
mheveryhttps://github.com/mhevery
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220791188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220866572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Sep 27, 2018https://github.com/angular/angular/pull/26113#event-1870058333
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/5be12f82c8fa86b26872755e176a1d52ca994d39..1d68e5856862fadea1ce80564c4d7411e7ff8952
5be12f8https://github.com/angular/angular/commit/5be12f82c8fa86b26872755e176a1d52ca994d39
1d68e58https://github.com/angular/angular/commit/1d68e5856862fadea1ce80564c4d7411e7ff8952
Compare https://github.com/angular/angular/compare/5be12f82c8fa86b26872755e176a1d52ca994d39..1d68e5856862fadea1ce80564c4d7411e7ff8952
September 27, 2018 12:46https://github.com/angular/angular/pull/26113#event-1870961943
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Sep 27, 2018https://github.com/angular/angular/pull/26113#issuecomment-425079477
https://pr26113-1d68e58.ngbuilds.io/https://pr26113-1d68e58.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Sep 27, 2018https://github.com/angular/angular/pull/26113#event-1871041912
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#issuecomment-425141333
ci(docs-infra): run the script in the correct folder #26136https://github.com/angular/angular/pull/26136
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Sep 27, 2018https://github.com/angular/angular/pull/26113#event-1871443736
https://github.com/matsko
matskohttps://github.com/matsko
Sep 27, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159522712
View reviewed changes https://github.com/angular/angular/pull/26113/files
https://github.com/kara
karahttps://github.com/kara
Sep 27, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159521962
View reviewed changes https://github.com/angular/angular/pull/26113/files
packages/core/src/render3/context_discovery.tshttps://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220982760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220988061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
packages/core/src/render3/discovery_utils.tshttps://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220983368
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220988636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220993908
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#discussion_r221944572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@karahttps://github.com/kara
https://github.com/angular/angular/pull/26113/files#r221942800https://github.com/angular/angular/pull/26113/files#r221942800
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/1d68e5856862fadea1ce80564c4d7411e7ff8952..04ed6afe4fa17f308ab0144399f0daef08abc35a
1d68e58https://github.com/angular/angular/commit/1d68e5856862fadea1ce80564c4d7411e7ff8952
04ed6afhttps://github.com/angular/angular/commit/04ed6afe4fa17f308ab0144399f0daef08abc35a
Compare https://github.com/angular/angular/compare/1d68e5856862fadea1ce80564c4d7411e7ff8952..04ed6afe4fa17f308ab0144399f0daef08abc35a
September 27, 2018 16:18https://github.com/angular/angular/pull/26113#event-1871540475
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Sep 27, 2018https://github.com/angular/angular/pull/26113#issuecomment-425156874
https://pr26113-04ed6af.ngbuilds.io/https://pr26113-04ed6af.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/kara
karahttps://github.com/kara
Sep 27, 2018 https://github.com/angular/angular/pull/26113#pullrequestreview-159536428
View reviewed changes https://github.com/angular/angular/pull/26113/files
packages/core/src/render3/context_discovery.tshttps://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86
karahttps://github.com/kara
Sep 27, 2018https://github.com/angular/angular/pull/26113#discussion_r220994347
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#discussion_r221942800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@karahttps://github.com/kara
we've got both directive indices and directive instances on LContexthttps://github.com/angular/angular/blob/a2878b0b1d5af279400a33d7d200140c1c88648e/packages/core/src/render3/context_discovery.ts#L51-L59
Please reload this pagehttps://github.com/angular/angular/pull/26113
karahttps://github.com/kara
Oct 2, 2018https://github.com/angular/angular/pull/26113#discussion_r222039320
Please reload this pagehttps://github.com/angular/angular/pull/26113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#discussion_r222043113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/kara
karahttps://github.com/kara
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Sep 27, 2018https://github.com/angular/angular/pull/26113#event-1871595798
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Oct 2, 2018https://github.com/angular/angular/pull/26113#event-1879217984
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#issuecomment-426269286
@karahttps://github.com/kara
#26113 (comment)https://github.com/angular/angular/pull/26113#discussion_r221942800
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/04ed6afe4fa17f308ab0144399f0daef08abc35a..2d71f63411ea1d5546533c515f94aae4f02cf785
04ed6afhttps://github.com/angular/angular/commit/04ed6afe4fa17f308ab0144399f0daef08abc35a
2d71f63https://github.com/angular/angular/commit/2d71f63411ea1d5546533c515f94aae4f02cf785
Compare https://github.com/angular/angular/compare/04ed6afe4fa17f308ab0144399f0daef08abc35a..2d71f63411ea1d5546533c515f94aae4f02cf785
October 2, 2018 13:17https://github.com/angular/angular/pull/26113#event-1879277917
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 2, 2018https://github.com/angular/angular/pull/26113#issuecomment-426272631
https://pr26113-2d71f63.ngbuilds.io/https://pr26113-2d71f63.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/2d71f63411ea1d5546533c515f94aae4f02cf785..8210f54180a507bfe28d62040147b78cca528054
2d71f63https://github.com/angular/angular/commit/2d71f63411ea1d5546533c515f94aae4f02cf785
8210f54https://github.com/angular/angular/commit/8210f54180a507bfe28d62040147b78cca528054
Compare https://github.com/angular/angular/compare/2d71f63411ea1d5546533c515f94aae4f02cf785..8210f54180a507bfe28d62040147b78cca528054
October 2, 2018 13:52https://github.com/angular/angular/pull/26113#event-1879372726
https://github.com/pkozlowski-opensource
fix(ivy): take components into account when discovering directiveshttps://github.com/angular/angular/pull/26113/commits/8210f54180a507bfe28d62040147b78cca528054
8210f54https://github.com/angular/angular/pull/26113/commits/8210f54180a507bfe28d62040147b78cca528054
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Oct 2, 2018https://github.com/angular/angular/pull/26113#issuecomment-426284542
8210f54https://github.com/angular/angular/commit/8210f54180a507bfe28d62040147b78cca528054
https://pr26113-8210f54.ngbuilds.io/https://pr26113-8210f54.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018 https://github.com/angular/angular/pull/26113#ref-pullrequest-365917308
Test bed with context discovery #26211 https://github.com/angular/angular/pull/26211
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#issuecomment-426362051
#26113 (comment)https://github.com/angular/angular/pull/26113#discussion_r222043113
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/26113#event-1879960990
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26113#issuecomment-531442355
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/26113#event-2633903449
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/26113/files/5be12f82c8fa86b26872755e176a1d52ca994d39
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/26113/files/8210f54180a507bfe28d62040147b78cca528054
https://github.com/matsko
matsko https://github.com/matsko
https://github.com/angular/angular/pull/26113/files/1d68e5856862fadea1ce80564c4d7411e7ff8952
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/26113/files/5be12f82c8fa86b26872755e176a1d52ca994d39
Please reload this pagehttps://github.com/angular/angular/pull/26113
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Please reload this pagehttps://github.com/angular/angular/pull/26113
https://github.com/pkozlowski-opensource
https://github.com/mary-poppins
https://github.com/matsko
https://github.com/mhevery
https://github.com/JoostK
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.