| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:787e6a6e-b2da-a798-1f85-05716049c209 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BD0:CC1A4:97E52F:C2E65A:6B00EE9D |
| html-safe-nonce | dbbd7360af8d1c639293bb043df9a000b6e236844659f488cece21bd958a6924 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQwOkNDMUE0Ojk3RTUyRjpDMkU2NUE6NkIwMEVFOUQiLCJ2aXNpdG9yX2lkIjoiNzE1NTczOTcwMTA2MjcyNTI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 92ba5e028e0507906fed85cdf0e93369a53a9ff4ea209d25c04fac67224f27d0 |
| hovercard-subject-tag | pull_request:218264992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/26113/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3f41f0529feba3fbd21d8b334dc0199815289690b3a506cff3d56c8e54ff13b6/angular/angular/pull/26113 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3f41f0529feba3fbd21d8b334dc0199815289690b3a506cff3d56c8e54ff13b6/angular/angular/pull/26113 |
| og:image:alt | This PR fixes an issue where the includeComponents argument to the
discoverDirectiveIndices was not taken into account.
Additionally it returns components as part of directives list when
calling ge... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pkozlowski-opensource |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/26113#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/26113 |
| Reload | https://github.com/angular/angular/pull/26113 |
| Reload | https://github.com/angular/angular/pull/26113 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| angular:master | https://github.com/angular/angular/tree/master |
| pkozlowski-opensource:discovery_util_fixes_featqures | https://github.com/pkozlowski-opensource/angular/tree/discovery_util_fixes_featqures |
| Conversation | https://github.com/angular/angular/pull/26113 |
| Commits1 (1) | https://github.com/angular/angular/pull/26113/commits |
| Checks | https://github.com/angular/angular/pull/26113/checks |
| Files changed | https://github.com/angular/angular/pull/26113/files |
| fix(ivy): take components into account when discovering directives | https://github.com/angular/angular/pull/26113#top |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| angular:master | https://github.com/angular/angular/tree/master |
| pkozlowski-opensource:discovery_util_fixes_featqures | https://github.com/pkozlowski-opensource/angular/tree/discovery_util_fixes_featqures |
|
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#issue-363960616 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#event-1868020243 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| force-pushed | https://github.com/angular/angular/compare/83e6567e3de9300610bbc6676e473bcd301b8578..5be12f82c8fa86b26872755e176a1d52ca994d39 |
| 83e6567 | https://github.com/angular/angular/commit/83e6567e3de9300610bbc6676e473bcd301b8578 |
| 5be12f8 | https://github.com/angular/angular/commit/5be12f82c8fa86b26872755e176a1d52ca994d39 |
|
Compare
| https://github.com/angular/angular/compare/83e6567e3de9300610bbc6676e473bcd301b8578..5be12f82c8fa86b26872755e176a1d52ca994d39 |
| September 26, 2018 10:36 | https://github.com/angular/angular/pull/26113#event-1868030050 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-424668917 |
| https://pr26113-23a9b33.ngbuilds.io/ | https://pr26113-23a9b33.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-424669475 |
| https://pr26113-83e6567.ngbuilds.io/ | https://pr26113-83e6567.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-424669952 |
| https://pr26113-5be12f8.ngbuilds.io/ | https://pr26113-5be12f8.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#event-1868259558 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Sep 26, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159095874 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| packages/core/src/render3/context_discovery.ts | https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86 |
| kara | https://github.com/kara |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220644815 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220648996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220867333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Sep 26, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159175676 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| packages/core/src/render3/context_discovery.ts | https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86 |
| JoostK | https://github.com/JoostK |
| Sep 26, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220705066 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| matsko | https://github.com/matsko |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220775604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220866342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
|
Sep 27, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159262483 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| packages/core/src/render3/discovery_utils.ts | https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651 |
| matsko | https://github.com/matsko |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220776003 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220866831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Sep 27, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159280902 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| mhevery | https://github.com/mhevery |
| https://github.com/angular/angular/pull/26113#pullrequestreview-159280902 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| packages/core/src/render3/discovery_utils.ts | https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651 |
| mhevery | https://github.com/mhevery |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220791188 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220866572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#event-1870058333 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| force-pushed | https://github.com/angular/angular/compare/5be12f82c8fa86b26872755e176a1d52ca994d39..1d68e5856862fadea1ce80564c4d7411e7ff8952 |
| 5be12f8 | https://github.com/angular/angular/commit/5be12f82c8fa86b26872755e176a1d52ca994d39 |
| 1d68e58 | https://github.com/angular/angular/commit/1d68e5856862fadea1ce80564c4d7411e7ff8952 |
|
Compare
| https://github.com/angular/angular/compare/5be12f82c8fa86b26872755e176a1d52ca994d39..1d68e5856862fadea1ce80564c4d7411e7ff8952 |
| September 27, 2018 12:46 | https://github.com/angular/angular/pull/26113#event-1870961943 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-425079477 |
| https://pr26113-1d68e58.ngbuilds.io/ | https://pr26113-1d68e58.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#event-1871041912 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-425141333 |
| ci(docs-infra): run the script in the correct folder #26136 | https://github.com/angular/angular/pull/26136 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#event-1871443736 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
|
Sep 27, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159522712 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Sep 27, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159521962 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| packages/core/src/render3/context_discovery.ts | https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86 |
| kara | https://github.com/kara |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220982760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220988061 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| packages/core/src/render3/discovery_utils.ts | https://github.com/angular/angular/pull/26113/files#diff-c06b2696f85e542bea9002abcc8ac59b5b49f232f5c3cf45d25ba812722de651 |
| kara | https://github.com/kara |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220983368 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220988636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| kara | https://github.com/kara |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220993908 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#discussion_r221944572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kara | https://github.com/kara |
| https://github.com/angular/angular/pull/26113/files#r221942800 | https://github.com/angular/angular/pull/26113/files#r221942800 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| force-pushed | https://github.com/angular/angular/compare/1d68e5856862fadea1ce80564c4d7411e7ff8952..04ed6afe4fa17f308ab0144399f0daef08abc35a |
| 1d68e58 | https://github.com/angular/angular/commit/1d68e5856862fadea1ce80564c4d7411e7ff8952 |
| 04ed6af | https://github.com/angular/angular/commit/04ed6afe4fa17f308ab0144399f0daef08abc35a |
|
Compare
| https://github.com/angular/angular/compare/1d68e5856862fadea1ce80564c4d7411e7ff8952..04ed6afe4fa17f308ab0144399f0daef08abc35a |
| September 27, 2018 16:18 | https://github.com/angular/angular/pull/26113#event-1871540475 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-425156874 |
| https://pr26113-04ed6af.ngbuilds.io/ | https://pr26113-04ed6af.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Sep 27, 2018
| https://github.com/angular/angular/pull/26113#pullrequestreview-159536428 |
|
View reviewed changes
| https://github.com/angular/angular/pull/26113/files |
| packages/core/src/render3/context_discovery.ts | https://github.com/angular/angular/pull/26113/files#diff-486088afc042422a38c17952107e82d77ab114f2356059f2281f1fbc980eaf86 |
| kara | https://github.com/kara |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#discussion_r220994347 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#discussion_r221942800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kara | https://github.com/kara |
| we've got both directive indices and directive instances on LContext | https://github.com/angular/angular/blob/a2878b0b1d5af279400a33d7d200140c1c88648e/packages/core/src/render3/context_discovery.ts#L51-L59 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| kara | https://github.com/kara |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#discussion_r222039320 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#discussion_r222043113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Sep 27, 2018 | https://github.com/angular/angular/pull/26113#event-1871595798 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#event-1879217984 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-426269286 |
| @kara | https://github.com/kara |
| #26113 (comment) | https://github.com/angular/angular/pull/26113#discussion_r221942800 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| force-pushed | https://github.com/angular/angular/compare/04ed6afe4fa17f308ab0144399f0daef08abc35a..2d71f63411ea1d5546533c515f94aae4f02cf785 |
| 04ed6af | https://github.com/angular/angular/commit/04ed6afe4fa17f308ab0144399f0daef08abc35a |
| 2d71f63 | https://github.com/angular/angular/commit/2d71f63411ea1d5546533c515f94aae4f02cf785 |
|
Compare
| https://github.com/angular/angular/compare/04ed6afe4fa17f308ab0144399f0daef08abc35a..2d71f63411ea1d5546533c515f94aae4f02cf785 |
| October 2, 2018 13:17 | https://github.com/angular/angular/pull/26113#event-1879277917 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-426272631 |
| https://pr26113-2d71f63.ngbuilds.io/ | https://pr26113-2d71f63.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| force-pushed | https://github.com/angular/angular/compare/2d71f63411ea1d5546533c515f94aae4f02cf785..8210f54180a507bfe28d62040147b78cca528054 |
| 2d71f63 | https://github.com/angular/angular/commit/2d71f63411ea1d5546533c515f94aae4f02cf785 |
| 8210f54 | https://github.com/angular/angular/commit/8210f54180a507bfe28d62040147b78cca528054 |
|
Compare
| https://github.com/angular/angular/compare/2d71f63411ea1d5546533c515f94aae4f02cf785..8210f54180a507bfe28d62040147b78cca528054 |
| October 2, 2018 13:52 | https://github.com/angular/angular/pull/26113#event-1879372726 |
|
| https://github.com/pkozlowski-opensource |
| fix(ivy): take components into account when discovering directives | https://github.com/angular/angular/pull/26113/commits/8210f54180a507bfe28d62040147b78cca528054 |
| 8210f54 | https://github.com/angular/angular/pull/26113/commits/8210f54180a507bfe28d62040147b78cca528054 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-426284542 |
| 8210f54 | https://github.com/angular/angular/commit/8210f54180a507bfe28d62040147b78cca528054 |
| https://pr26113-8210f54.ngbuilds.io/ | https://pr26113-8210f54.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
|
Oct 2, 2018
| https://github.com/angular/angular/pull/26113#ref-pullrequest-365917308 |
|
Test bed with context discovery
#26211
| https://github.com/angular/angular/pull/26211 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#issuecomment-426362051 |
| #26113 (comment) | https://github.com/angular/angular/pull/26113#discussion_r222043113 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/pkozlowski-opensource |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Oct 2, 2018 | https://github.com/angular/angular/pull/26113#event-1879960990 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/26113#issuecomment-531442355 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/26113#event-2633903449 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F26113 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/26113/files/5be12f82c8fa86b26872755e176a1d52ca994d39 |
|
| https://github.com/kara |
|
kara
| https://github.com/kara |
|
| https://github.com/angular/angular/pull/26113/files/8210f54180a507bfe28d62040147b78cca528054 |
|
| https://github.com/matsko |
|
matsko
| https://github.com/matsko |
|
| https://github.com/angular/angular/pull/26113/files/1d68e5856862fadea1ce80564c4d7411e7ff8952 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/26113/files/5be12f82c8fa86b26872755e176a1d52ca994d39 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Please reload this page | https://github.com/angular/angular/pull/26113 |
|
| https://github.com/pkozlowski-opensource |
|
| https://github.com/mary-poppins |
|
| https://github.com/matsko |
|
| https://github.com/mhevery |
|
| https://github.com/JoostK |
|
| https://github.com/kara |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |