René's URL Explorer Experiment


Title: fix(common): add generics to NgIf declaration by piotrtomiak · Pull Request #25983 · angular/angular · GitHub

Open Graph Title: fix(common): add generics to NgIf declaration by piotrtomiak · Pull Request #25983 · angular/angular

X Title: fix(common): add generics to NgIf declaration by piotrtomiak · Pull Request #25983 · angular/angular

Description: This change allows IDE to analyze type of the variable in ngIf context. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? The issue has been originally filed with Webstorm - https://youtrack.jetbrains.com/issue/WEB-31760 . In the following example code (login$: Observable):

{{ login. }}
login type is detected as any and no content assist is available for the variable fields. What is the new behavior? It will be possible to provide content assist by IDE on the login fields, similarly to how it's done for ngFor template. Does this PR introduce a breaking change? [x] Yes [ ] No Consumers of ngIf API through templates will not be affected. It is possible that AoT compilation might expose some issues, but I am not familiar with the process, so it's hard for me to tell. Other information If PR is accepted it would be good to release the fix on all currently active release branches, so that users can take benefit from the fix even if they are on older version of Angular.

Open Graph Description: This change allows IDE to analyze type of the variable in ngIf context. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https:...

X Description: This change allows IDE to analyze type of the variable in ngIf context. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https:...

Opengraph URL: https://github.com/angular/angular/pull/25983

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:927fda26-99a0-fe37-4e7c-243094dd585a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE8E:26ECEB:2128498:2A243D5:6B015F42
html-safe-nonce2a44322e65f6b328c1834f070735c4774dbe415fecc10d7c8af46357701cfaef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERThFOjI2RUNFQjoyMTI4NDk4OjJBMjQzRDU6NkIwMTVGNDIiLCJ2aXNpdG9yX2lkIjoiODg4Mzk2NzIxMjA0MzIyMTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc34a129e84ced7c99945da5a88c6ff45142f037457c9338f22c30c41457e4db2
hovercard-subject-tagpull_request:215929017
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/25983/files
twitter:imagehttps://avatars.githubusercontent.com/u/4244523?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4244523?s=400&v=4
og:image:altThis change allows IDE to analyze type of the variable in ngIf context. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https:...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/25983/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25983%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25983%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/25983/files
Reloadhttps://github.com/angular/angular/pull/25983/files
Reloadhttps://github.com/angular/angular/pull/25983/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
piotrtomiakhttps://github.com/piotrtomiak
angular:masterhttps://github.com/angular/angular/tree/master
piotrtomiak:ng-if-genericshttps://github.com/piotrtomiak/angular/tree/ng-if-generics
Conversation 9 https://github.com/angular/angular/pull/25983
Commits 1 https://github.com/angular/angular/pull/25983/commits
Checks 0 https://github.com/angular/angular/pull/25983/checks
Files changed https://github.com/angular/angular/pull/25983/files
Please reload this pagehttps://github.com/angular/angular/pull/25983/files
fix(common): add generics to NgIf declaration https://github.com/angular/angular/pull/25983/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/25983/files
16f08b3 feat(common): add generics to NgIf declaration piotrtomiak Sep 17, 2018 https://github.com/angular/angular/pull/25983/commits/16f08b3ba548e2961c811dff80df0107b1994ff8
Clear filters https://github.com/angular/angular/pull/25983/files
Please reload this pagehttps://github.com/angular/angular/pull/25983/files
Please reload this pagehttps://github.com/angular/angular/pull/25983/files
packages/common/src/directives/ng_if.tshttps://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
View file https://github.com/piotrtomiak/angular/blob/16f08b3ba548e2961c811dff80df0107b1994ff8/packages/common/src/directives/ng_if.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/25983/{{ revealButtonHref }}
https://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com/angular/angular/pull/25983/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.