René's URL Explorer Experiment


Title: fix(router): better ngZone checking for warning by trotyl · Pull Request #25839 · angular/angular · GitHub

Open Graph Title: fix(router): better ngZone checking for warning by trotyl · Pull Request #25839 · angular/angular

X Title: fix(router): better ngZone checking for warning by trotyl · Pull Request #25839 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Closes #25837 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#c...

X Description: Closes #25837 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#c...

Opengraph URL: https://github.com/angular/angular/pull/25839

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7c2c908-ac6b-82b0-a6e0-c4fe3d47ae4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE79E:269AD9:1590625:1CD5532:6B01371D
html-safe-nonce14a3adb098e79be2353457df2bb3ca6b83af7c300018980a7a79e4a460c84b4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzlFOjI2OUFEOToxNTkwNjI1OjFDRDU1MzI6NkIwMTM3MUQiLCJ2aXNpdG9yX2lkIjoiMTU3NjA4ODQ3MjExNTAzMzg4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace520c1c2e84b8b543e60920e5c70b2c3f2836583f2ee95ba6309566b25485d60
hovercard-subject-tagpull_request:213541072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/25839/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5426f1f23b335f95bf6441cb2633c1cd7f18fde26c9f2f933bda37b8df122cc1/angular/angular/pull/25839
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5426f1f23b335f95bf6441cb2633c1cd7f18fde26c9f2f933bda37b8df122cc1/angular/angular/pull/25839
og:image:altCloses #25837 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrotyl
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/25839#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25839
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25839
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/25839
Reloadhttps://github.com/angular/angular/pull/25839
Reloadhttps://github.com/angular/angular/pull/25839
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
trotylhttps://github.com/trotyl
angular:masterhttps://github.com/angular/angular/tree/master
trotyl:better-ngzone-checkinghttps://github.com/trotyl/angular/tree/better-ngzone-checking
Conversationhttps://github.com/angular/angular/pull/25839
Commits1 (1)https://github.com/angular/angular/pull/25839/commits
Checkshttps://github.com/angular/angular/pull/25839/checks
Files changedhttps://github.com/angular/angular/pull/25839/files
fix(router): better ngZone checking for warninghttps://github.com/angular/angular/pull/25839#top
trotylhttps://github.com/trotyl
angular:masterhttps://github.com/angular/angular/tree/master
trotyl:better-ngzone-checkinghttps://github.com/trotyl/angular/tree/better-ngzone-checking
https://github.com/trotyl
trotylhttps://github.com/trotyl
Sep 6, 2018https://github.com/angular/angular/pull/25839#issue-357556728
#25837https://github.com/angular/angular/issues/25837
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#25837https://github.com/angular/angular/issues/25837
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 6, 2018https://github.com/angular/angular/pull/25839#event-1829823986
https://github.com/kara
karahttps://github.com/kara
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Oct 11, 2018https://github.com/angular/angular/pull/25839#event-1899458618
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 24, 2019https://github.com/angular/angular/pull/25839#event-2094595619
https://github.com/atscott
atscotthttps://github.com/atscott
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
Jun 19, 2020https://github.com/angular/angular/pull/25839#event-3462818938
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
June 19, 2020 14:55https://github.com/angular/angular/pull/25839#event-3462819547
https://github.com/atscott
atscotthttps://github.com/atscott
JiaLiPassionhttps://github.com/JiaLiPassion
August 5, 2020 20:17https://github.com/angular/angular/pull/25839#event-3626285804
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 5, 2020https://github.com/angular/angular/pull/25839#issuecomment-669480119
@JiaLiPassionhttps://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Aug 6, 2020https://github.com/angular/angular/pull/25839#issuecomment-669627381
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/trotyl
https://github.com/atscott
fix(router): better ngZone checking for warninghttps://github.com/angular/angular/pull/25839/commits/7ab7aa74d632a455ad969e3843abf3c8f2510791
7ab7aa7https://github.com/angular/angular/pull/25839/commits/7ab7aa74d632a455ad969e3843abf3c8f2510791
angular#25837https://github.com/angular/angular/issues/25837
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/c56e5a7eed322a1dd6c41a3ea6831bd3df28cde1..7ab7aa74d632a455ad969e3843abf3c8f2510791
c56e5a7https://github.com/angular/angular/commit/c56e5a7eed322a1dd6c41a3ea6831bd3df28cde1
7ab7aa7https://github.com/angular/angular/commit/7ab7aa74d632a455ad969e3843abf3c8f2510791
Compare https://github.com/angular/angular/compare/c56e5a7eed322a1dd6c41a3ea6831bd3df28cde1..7ab7aa74d632a455ad969e3843abf3c8f2510791
December 29, 2020 17:58https://github.com/angular/angular/pull/25839#event-4155349358
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
Dec 29, 2020https://github.com/angular/angular/pull/25839#event-4155349709
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
Dec 29, 2020https://github.com/angular/angular/pull/25839#event-4155349754
https://github.com/atscott
atscotthttps://github.com/atscott
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 29, 2020https://github.com/angular/angular/pull/25839#event-4155352135
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 29, 2020 https://github.com/angular/angular/pull/25839#pullrequestreview-559643287
View reviewed changes https://github.com/angular/angular/pull/25839/files/7ab7aa74d632a455ad969e3843abf3c8f2510791
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/25839#pullrequestreview-559643287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
presubmithttp://test/OCL:349436696:BASE:349436719:1609264825416:a53c5bda
@JiaLiPassionhttps://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jan 8, 2021https://github.com/angular/angular/pull/25839#event-4186303753
https://github.com/atscott
atscotthttps://github.com/atscott
JiaLiPassionhttps://github.com/JiaLiPassion
January 8, 2021 22:29https://github.com/angular/angular/pull/25839#event-4186304997
atscotthttps://github.com/atscott
Jan 11, 2021 https://github.com/angular/angular/pull/25839#ref-commit-adf42da
https://github.com/trotyl
https://github.com/atscott
fix(router): better ngZone checking for warning (https://github.com/angular/angular/commit/adf42daed6f37ecbd9b2ec911f34ccd96b626ad9
#25839https://github.com/angular/angular/pull/25839
)https://github.com/angular/angular/commit/adf42daed6f37ecbd9b2ec911f34ccd96b626ad9
adf42dahttps://github.com/angular/angular/commit/adf42daed6f37ecbd9b2ec911f34ccd96b626ad9
#25837https://github.com/angular/angular/issues/25837
#25839https://github.com/angular/angular/pull/25839
https://github.com/atscott
atscotthttps://github.com/atscott
7695468https://github.com/angular/angular/commit/76954688b18f1509d4c9cca41b8e113ee423d4db
Jan 11, 2021https://github.com/angular/angular/pull/25839#event-4192281660
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 11, 2021https://github.com/angular/angular/pull/25839#issuecomment-777624542
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 11, 2021https://github.com/angular/angular/pull/25839#event-4320813115
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25839
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/25839/files/7ab7aa74d632a455ad969e3843abf3c8f2510791
Please reload this pagehttps://github.com/angular/angular/pull/25839
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
"Navigation triggered outside Angular zone" warning in unit tests https://github.com/angular/angular/issues/25837
Please reload this pagehttps://github.com/angular/angular/pull/25839
https://github.com/trotyl
https://github.com/atscott
https://github.com/JiaLiPassion
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.