René's URL Explorer Experiment


Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular · GitHub

Open Graph Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular

X Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular

Description: This PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This change unblocks some of the tests for ngTemplateOutlet.

Open Graph Description: This PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This chang...

X Description: This PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This c...

Opengraph URL: https://github.com/angular/angular/pull/25685

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:44db94ae-47b3-fb0f-fd60-0259b34e9405
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98B2:2C4BED:147E59C:1A14264:6B012AE6
html-safe-nonce4caa544368ca9cf6ba70a0da11b52f6ba555b635dc359ad69651287e93076760
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEIyOjJDNEJFRDoxNDdFNTlDOjFBMTQyNjQ6NkIwMTJBRTYiLCJ2aXNpdG9yX2lkIjoiMzk3MDk2MjAwNDQzNjM5Njc3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac33747939a025d0ec896b763594a58e51fc1a6c3756f9c223be9c82222c4aab3f
hovercard-subject-tagpull_request:211121733
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/25685/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:altThis PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This chang...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/25685/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25685%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25685%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/25685/files
Reloadhttps://github.com/angular/angular/pull/25685/files
Reloadhttps://github.com/angular/angular/pull/25685/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:ivy_test_bed_module_injectorhttps://github.com/pkozlowski-opensource/angular/tree/ivy_test_bed_module_injector
Conversation 8 https://github.com/angular/angular/pull/25685
Commits 1 https://github.com/angular/angular/pull/25685/commits
Checks 0 https://github.com/angular/angular/pull/25685/checks
Files changed https://github.com/angular/angular/pull/25685/files
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
fix(ivy): expose module injector ivy's TestBed impl https://github.com/angular/angular/pull/25685/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/25685/files
90f9ec0 fix(ivy): expose module injector ivy's TestBed impl pkozlowski-opensource Aug 27, 2018 https://github.com/angular/angular/pull/25685/commits/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
Clear filters https://github.com/angular/angular/pull/25685/files
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
component_ref.ts https://github.com/angular/angular/pull/25685/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
debug.ts https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
test_bed_spec.ts https://github.com/angular/angular/pull/25685/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
r3_test_bed.ts https://github.com/angular/angular/pull/25685/files#diff-9b9f5f1ca2ffb7b4ca877f6362c86e97031bb15f0a9a48083c986cab148210f7
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/25685/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
View file https://github.com/pkozlowski-opensource/angular/blob/90f9ec044b093f94679c2b8b2e8ce58ebcb86072/packages/core/src/render3/component_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/25685/{{ revealButtonHref }}
https://github.com/angular/angular/pull/25685/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
mheveryhttps://github.com/mhevery
Aug 28, 2018https://github.com/angular/angular/pull/25685/files#r213499035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular/packages/core/src/debug/debug_node.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L167-L169
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
angular/packages/core/src/render3/element_discovery.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/render3/element_discovery.ts#L39-L66
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 29, 2018https://github.com/angular/angular/pull/25685/files#r213599617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mheveryhttps://github.com/mhevery
angular/packages/core/src/debug/debug_node.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L167-L169
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
DebugNodehttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L19
DebugElementhttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L43
indexDebugNodehttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L175
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
https://github.com/angular/angular/pull/25685/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
packages/core/src/render3/debug.tshttps://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
View file https://github.com/pkozlowski-opensource/angular/blob/90f9ec044b093f94679c2b8b2e8ce58ebcb86072/packages/core/src/render3/debug.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/25685/{{ revealButtonHref }}
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 27, 2018https://github.com/angular/angular/pull/25685/files#r213021183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
mheveryhttps://github.com/mhevery
Aug 28, 2018https://github.com/angular/angular/pull/25685/files#r213495045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular/packages/core/src/render3/element_discovery.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/render3/element_discovery.ts#L39-L66
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
Please reload this pagehttps://github.com/angular/angular/pull/25685/files
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
https://github.com/angular/angular/pull/25685/files#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
packages/core/test/test_bed_spec.tshttps://github.com/angular/angular/pull/25685/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
View file https://github.com/pkozlowski-opensource/angular/blob/90f9ec044b093f94679c2b8b2e8ce58ebcb86072/packages/core/test/test_bed_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/25685/{{ revealButtonHref }}
https://github.com/angular/angular/pull/25685/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
https://github.com/angular/angular/pull/25685/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
packages/core/testing/src/r3_test_bed.tshttps://github.com/angular/angular/pull/25685/files#diff-9b9f5f1ca2ffb7b4ca877f6362c86e97031bb15f0a9a48083c986cab148210f7
View file https://github.com/pkozlowski-opensource/angular/blob/90f9ec044b093f94679c2b8b2e8ce58ebcb86072/packages/core/testing/src/r3_test_bed.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/25685/{{ revealButtonHref }}
https://github.com/angular/angular/pull/25685/files#diff-9b9f5f1ca2ffb7b4ca877f6362c86e97031bb15f0a9a48083c986cab148210f7
https://github.com/angular/angular/pull/25685/files#diff-9b9f5f1ca2ffb7b4ca877f6362c86e97031bb15f0a9a48083c986cab148210f7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.