René's URL Explorer Experiment


Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular · GitHub

Open Graph Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular

X Title: fix(ivy): expose module injector ivy's TestBed impl by pkozlowski-opensource · Pull Request #25685 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This chang...

X Description: This PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This c...

Opengraph URL: https://github.com/angular/angular/pull/25685

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:460914ff-9592-adbd-ed81-ecd658b537b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AA4:7A60E:E64007:1298CFF:6B00FC12
html-safe-nonce40654064bef7ce8b0503188397b5e1710b716cfa5e297ae4eab3ba836078a31c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUE0OjdBNjBFOkU2NDAwNzoxMjk4Q0ZGOjZCMDBGQzEyIiwidmlzaXRvcl9pZCI6Ijc1NzQyMjYwNzE1NDYwMzUyMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47f497747fc2bf480e324a758db16d5555b5c37cad21ce55c668a9227caad9e8
hovercard-subject-tagpull_request:211121733
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/25685/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bfc12fef62932355be779e96a76e46563cc15bc7254b0049cc41e07db9873397/angular/angular/pull/25685
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfc12fef62932355be779e96a76e46563cc15bc7254b0049cc41e07db9873397/angular/angular/pull/25685
og:image:altThis PR changes the ivy's TestBed implementation - previously no injector was available for the root node (one created to contain test component). Now such node gets module injector. This chang...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/25685#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25685
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25685
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/25685
Reloadhttps://github.com/angular/angular/pull/25685
Reloadhttps://github.com/angular/angular/pull/25685
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:ivy_test_bed_module_injectorhttps://github.com/pkozlowski-opensource/angular/tree/ivy_test_bed_module_injector
Conversationhttps://github.com/angular/angular/pull/25685
Commits1 (1)https://github.com/angular/angular/pull/25685/commits
Checkshttps://github.com/angular/angular/pull/25685/checks
Files changedhttps://github.com/angular/angular/pull/25685/files
fix(ivy): expose module injector ivy's TestBed implhttps://github.com/angular/angular/pull/25685#top
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:ivy_test_bed_module_injectorhttps://github.com/pkozlowski-opensource/angular/tree/ivy_test_bed_module_injector
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 27, 2018https://github.com/angular/angular/pull/25685#issue-354334582
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 27, 2018https://github.com/angular/angular/pull/25685#event-1810690485
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Aug 27, 2018https://github.com/angular/angular/pull/25685#event-1810691082
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 27, 2018https://github.com/angular/angular/pull/25685#issuecomment-416241240
https://pr25685-f5d6b68.ngbuilds.io/https://pr25685-f5d6b68.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/f5d6b68cd9cfce0e514d2c88b5bb425a848bcc0f..90f9ec044b093f94679c2b8b2e8ce58ebcb86072
f5d6b68https://github.com/angular/angular/commit/f5d6b68cd9cfce0e514d2c88b5bb425a848bcc0f
90f9ec0https://github.com/angular/angular/commit/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
Compare https://github.com/angular/angular/compare/f5d6b68cd9cfce0e514d2c88b5bb425a848bcc0f..90f9ec044b093f94679c2b8b2e8ce58ebcb86072
August 27, 2018 14:24https://github.com/angular/angular/pull/25685#event-1810729571
https://github.com/pkozlowski-opensource
fix(ivy): expose module injector ivy's TestBed implhttps://github.com/angular/angular/pull/25685/commits/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
90f9ec0https://github.com/angular/angular/pull/25685/commits/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 27, 2018https://github.com/angular/angular/pull/25685#issuecomment-416248365
90f9ec0https://github.com/angular/angular/commit/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
https://pr25685-90f9ec0.ngbuilds.io/https://pr25685-90f9ec0.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 27, 2018 https://github.com/angular/angular/pull/25685#pullrequestreview-149767720
View reviewed changes https://github.com/angular/angular/pull/25685/files/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
packages/core/src/render3/debug.tshttps://github.com/angular/angular/pull/25685/files/90f9ec044b093f94679c2b8b2e8ce58ebcb86072#diff-e13b0e33e013eb46535602d358ce492c310d9c443c95e48094526d8669dbfcf9
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 27, 2018https://github.com/angular/angular/pull/25685#discussion_r213021183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/25685
mheveryhttps://github.com/mhevery
Aug 28, 2018https://github.com/angular/angular/pull/25685#discussion_r213495045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular/packages/core/src/render3/element_discovery.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/render3/element_discovery.ts#L39-L66
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Aug 27, 2018https://github.com/angular/angular/pull/25685#event-1811284793
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Aug 28, 2018 https://github.com/angular/angular/pull/25685#pullrequestreview-150348890
View reviewed changes https://github.com/angular/angular/pull/25685/files/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/25685/files/90f9ec044b093f94679c2b8b2e8ce58ebcb86072#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
mheveryhttps://github.com/mhevery
Aug 28, 2018https://github.com/angular/angular/pull/25685#discussion_r213499035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular/packages/core/src/debug/debug_node.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L167-L169
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
angular/packages/core/src/render3/element_discovery.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/render3/element_discovery.ts#L39-L66
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
Please reload this pagehttps://github.com/angular/angular/pull/25685
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 29, 2018https://github.com/angular/angular/pull/25685#discussion_r213599617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mheveryhttps://github.com/mhevery
angular/packages/core/src/debug/debug_node.tshttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L167-L169
29761eahttps://github.com/angular/angular/commit/29761ea5f8e4bae68442236f4a0abc1666487a35
DebugNodehttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L19
DebugElementhttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L43
indexDebugNodehttps://github.com/angular/angular/blob/29761ea5f8e4bae68442236f4a0abc1666487a35/packages/core/src/debug/debug_node.ts#L175
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/25685#issuecomment-426290234
#26211https://github.com/angular/angular/pull/26211
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 2, 2018https://github.com/angular/angular/pull/25685#event-1879441504
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/25685#issuecomment-531439819
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 14, 2019https://github.com/angular/angular/pull/25685#event-2633892480
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25685
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/25685/files/90f9ec044b093f94679c2b8b2e8ce58ebcb86072
Please reload this pagehttps://github.com/angular/angular/pull/25685
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Please reload this pagehttps://github.com/angular/angular/pull/25685
https://github.com/pkozlowski-opensource
https://github.com/mary-poppins
https://github.com/mhevery
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.