| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2aa25e7-eeeb-b132-bbf1-a60145a83234 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C6AE:95C88:1626235:1D4809B:6B012F07 |
| html-safe-nonce | 04e30b7b8d3edd6b69ef1f6a483faf14182c79f1c2b8b65e8f8c236db04b3bc4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkFFOjk1Qzg4OjE2MjYyMzU6MUQ0ODA5Qjo2QjAxMkYwNyIsInZpc2l0b3JfaWQiOiI0NTM3MzAyMjYzMzA3MjUxNDYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6d7e693ea55c76e249f052ca60e190f3fa5d4aeef2229b628c0ee9e01dcb195c |
| hovercard-subject-tag | pull_request:204477636 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/25163/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8c249bb8b6182732e2e9986a689e508b3707dda7fa56b4bee5ec6ab9d45c4ff5/angular/angular/pull/25163 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8c249bb8b6182732e2e9986a689e508b3707dda7fa56b4bee5ec6ab9d45c4ff5/angular/angular/pull/25163 |
| og:image:alt | This also fixes CI tests, which were accidentally broken in #24663.
Closes #25165. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/25163#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/25163 |
| Reload | https://github.com/angular/angular/pull/25163 |
| Reload | https://github.com/angular/angular/pull/25163 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:test-fix-done-typings | https://github.com/gkalpak/angular/tree/test-fix-done-typings |
| Conversation | https://github.com/angular/angular/pull/25163 |
| Commits2 (2) | https://github.com/angular/angular/pull/25163/commits |
| Checks | https://github.com/angular/angular/pull/25163/checks |
| Files changed | https://github.com/angular/angular/pull/25163/files |
| test: fix typings for DoneFn | https://github.com/angular/angular/pull/25163#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:test-fix-done-typings | https://github.com/gkalpak/angular/tree/test-fix-done-typings |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issue-345286087 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| #24663 | https://github.com/angular/angular/pull/24663 |
| #25165 | https://github.com/angular/angular/pull/25165 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757641251 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757641932 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#ref-pullrequest-345275309 |
|
ci: add type to done callback
#25161
| https://github.com/angular/angular/pull/25161 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757652991 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757653072 |
|
| https://github.com/gkalpak |
| test: fix typings for DoneFn | https://github.com/angular/angular/pull/25163/commits/5a68162547a59e4b50ed06a0f78671de8885b69d |
| 5a68162 | https://github.com/angular/angular/pull/25163/commits/5a68162547a59e4b50ed06a0f78671de8885b69d |
| angular#24663 | https://github.com/angular/angular/pull/24663 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb..5a68162547a59e4b50ed06a0f78671de8885b69d |
| 8aa4d85 | https://github.com/angular/angular/commit/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb |
| 5a68162 | https://github.com/angular/angular/commit/5a68162547a59e4b50ed06a0f78671de8885b69d |
|
Compare
| https://github.com/angular/angular/compare/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb..5a68162547a59e4b50ed06a0f78671de8885b69d |
| July 27, 2018 16:25 | https://github.com/angular/angular/pull/25163#event-1757656631 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issuecomment-408470166 |
| https://pr25163-8aa4d85.ngbuilds.io/ | https://pr25163-8aa4d85.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/alexeagle |
| alexeagle | https://github.com/alexeagle |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#pullrequestreview-141181817 |
|
View reviewed changes
| https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issuecomment-408472576 |
| 5a68162 | https://github.com/angular/angular/commit/5a68162547a59e4b50ed06a0f78671de8885b69d |
| https://pr25163-5a68162.ngbuilds.io/ | https://pr25163-5a68162.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#pullrequestreview-141187217 |
|
View reviewed changes
| https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d |
|
| https://github.com/gkalpak |
| fixup! test: fix typings for DoneFn | https://github.com/angular/angular/pull/25163/commits/3617cd7e3deecc8e4a2c94dd72f06a798ce16688 |
| 3617cd7 | https://github.com/angular/angular/pull/25163/commits/3617cd7e3deecc8e4a2c94dd72f06a798ce16688 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#pullrequestreview-141190500 |
|
View reviewed changes
| https://github.com/angular/angular/pull/25163/files/3617cd7e3deecc8e4a2c94dd72f06a798ce16688 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757709139 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issuecomment-408478518 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| public API golden file | https://github.com/angular/angular/pull/25163/files#diff-06a7a4c8d110ad13148ca89fd955d385R151 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issuecomment-408479558 |
| 3617cd7 | https://github.com/angular/angular/commit/3617cd7e3deecc8e4a2c94dd72f06a798ce16688 |
| https://pr25163-3617cd7.ngbuilds.io/ | https://pr25163-3617cd7.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#issuecomment-408497469 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#ref-pullrequest-345293357 |
|
test: fix typing in the largetable benchmark
#25165
| https://github.com/angular/angular/pull/25165 |
| IgorMinar | https://github.com/IgorMinar |
|
Jul 27, 2018
| https://github.com/angular/angular/pull/25163#ref-commit-39abe7b |
|
| https://github.com/gkalpak |
|
| https://github.com/IgorMinar |
| test: fix typings for | https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8 |
| DoneFn | https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8 |
| ( | https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8 |
| #25163 | https://github.com/angular/angular/pull/25163 |
| ) | https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8 |
| 39abe7b | https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8 |
| #24663 | https://github.com/angular/angular/pull/24663 |
| #25163 | https://github.com/angular/angular/pull/25163 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| 3426784 | https://github.com/angular/angular/commit/342678486dc08c82ab5a0dd89f93b67567e4e964 |
| Jul 27, 2018 | https://github.com/angular/angular/pull/25163#event-1757854895 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| July 27, 2018 18:20 | https://github.com/angular/angular/pull/25163#event-1757865755 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/25163#issuecomment-531395072 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/25163#event-2633594836 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/25163#ref-commit-5a5b040 |
|
| https://github.com/gkalpak |
|
| https://github.com/IgorMinar |
| test: fix typings for | https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9 |
| DoneFn | https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9 |
| ( | https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9 |
| angular#25163 | https://github.com/angular/angular/pull/25163 |
| ) | https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9 |
| 5a5b040 | https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9 |
| angular#24663 | https://github.com/angular/angular/pull/24663 |
| angular#25163 | https://github.com/angular/angular/pull/25163 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163 |
|
| https://github.com/alexeagle |
|
alexeagle
| https://github.com/alexeagle |
|
| https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/25163/files/3617cd7e3deecc8e4a2c94dd72f06a798ce16688 |
|
| https://github.com/jasonaden |
|
jasonaden
| https://github.com/jasonaden |
|
| https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
| Please reload this page | https://github.com/angular/angular/pull/25163 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/IgorMinar |
|
| https://github.com/alexeagle |
|
| https://github.com/jasonaden |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |