René's URL Explorer Experiment


Title: test: fix typings for `DoneFn` by gkalpak · Pull Request #25163 · angular/angular · GitHub

Open Graph Title: test: fix typings for `DoneFn` by gkalpak · Pull Request #25163 · angular/angular

X Title: test: fix typings for `DoneFn` by gkalpak · Pull Request #25163 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This also fixes CI tests, which were accidentally broken in #24663. Closes #25165.

X Description: This also fixes CI tests, which were accidentally broken in #24663. Closes #25165.

Opengraph URL: https://github.com/angular/angular/pull/25163

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a2aa25e7-eeeb-b132-bbf1-a60145a83234
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6AE:95C88:1626235:1D4809B:6B012F07
html-safe-nonce04e30b7b8d3edd6b69ef1f6a483faf14182c79f1c2b8b65e8f8c236db04b3bc4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkFFOjk1Qzg4OjE2MjYyMzU6MUQ0ODA5Qjo2QjAxMkYwNyIsInZpc2l0b3JfaWQiOiI0NTM3MzAyMjYzMzA3MjUxNDYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6d7e693ea55c76e249f052ca60e190f3fa5d4aeef2229b628c0ee9e01dcb195c
hovercard-subject-tagpull_request:204477636
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/25163/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c249bb8b6182732e2e9986a689e508b3707dda7fa56b4bee5ec6ab9d45c4ff5/angular/angular/pull/25163
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c249bb8b6182732e2e9986a689e508b3707dda7fa56b4bee5ec6ab9d45c4ff5/angular/angular/pull/25163
og:image:altThis also fixes CI tests, which were accidentally broken in #24663. Closes #25165.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/25163#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/25163
Reloadhttps://github.com/angular/angular/pull/25163
Reloadhttps://github.com/angular/angular/pull/25163
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:test-fix-done-typingshttps://github.com/gkalpak/angular/tree/test-fix-done-typings
Conversationhttps://github.com/angular/angular/pull/25163
Commits2 (2)https://github.com/angular/angular/pull/25163/commits
Checkshttps://github.com/angular/angular/pull/25163/checks
Files changedhttps://github.com/angular/angular/pull/25163/files
test: fix typings for DoneFnhttps://github.com/angular/angular/pull/25163#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:test-fix-done-typingshttps://github.com/gkalpak/angular/tree/test-fix-done-typings
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 27, 2018https://github.com/angular/angular/pull/25163#issue-345286087
Please reload this pagehttps://github.com/angular/angular/pull/25163
#24663https://github.com/angular/angular/pull/24663
#25165https://github.com/angular/angular/pull/25165
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757641251
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
area: build & ci https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757641932
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 27, 2018 https://github.com/angular/angular/pull/25163#ref-pullrequest-345275309
ci: add type to done callback #25161 https://github.com/angular/angular/pull/25161
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757652991
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757653072
https://github.com/gkalpak
test: fix typings for DoneFnhttps://github.com/angular/angular/pull/25163/commits/5a68162547a59e4b50ed06a0f78671de8885b69d
5a68162https://github.com/angular/angular/pull/25163/commits/5a68162547a59e4b50ed06a0f78671de8885b69d
angular#24663https://github.com/angular/angular/pull/24663
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb..5a68162547a59e4b50ed06a0f78671de8885b69d
8aa4d85https://github.com/angular/angular/commit/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb
5a68162https://github.com/angular/angular/commit/5a68162547a59e4b50ed06a0f78671de8885b69d
Compare https://github.com/angular/angular/compare/8aa4d8578850d592b0b9b0fe285ea73fcb0f3eeb..5a68162547a59e4b50ed06a0f78671de8885b69d
July 27, 2018 16:25https://github.com/angular/angular/pull/25163#event-1757656631
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 27, 2018https://github.com/angular/angular/pull/25163#issuecomment-408470166
https://pr25163-8aa4d85.ngbuilds.io/https://pr25163-8aa4d85.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
Jul 27, 2018 https://github.com/angular/angular/pull/25163#pullrequestreview-141181817
View reviewed changes https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 27, 2018https://github.com/angular/angular/pull/25163#issuecomment-408472576
5a68162https://github.com/angular/angular/commit/5a68162547a59e4b50ed06a0f78671de8885b69d
https://pr25163-5a68162.ngbuilds.io/https://pr25163-5a68162.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
Jul 27, 2018 https://github.com/angular/angular/pull/25163#pullrequestreview-141187217
View reviewed changes https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d
https://github.com/gkalpak
fixup! test: fix typings for DoneFnhttps://github.com/angular/angular/pull/25163/commits/3617cd7e3deecc8e4a2c94dd72f06a798ce16688
3617cd7https://github.com/angular/angular/pull/25163/commits/3617cd7e3deecc8e4a2c94dd72f06a798ce16688
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jul 27, 2018 https://github.com/angular/angular/pull/25163#pullrequestreview-141190500
View reviewed changes https://github.com/angular/angular/pull/25163/files/3617cd7e3deecc8e4a2c94dd72f06a798ce16688
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757709139
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jul 27, 2018https://github.com/angular/angular/pull/25163#issuecomment-408478518
Please reload this pagehttps://github.com/angular/angular/pull/25163
public API golden filehttps://github.com/angular/angular/pull/25163/files#diff-06a7a4c8d110ad13148ca89fd955d385R151
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 27, 2018https://github.com/angular/angular/pull/25163#issuecomment-408479558
3617cd7https://github.com/angular/angular/commit/3617cd7e3deecc8e4a2c94dd72f06a798ce16688
https://pr25163-3617cd7.ngbuilds.io/https://pr25163-3617cd7.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jul 27, 2018https://github.com/angular/angular/pull/25163#issuecomment-408497469
Please reload this pagehttps://github.com/angular/angular/pull/25163
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Jul 27, 2018 https://github.com/angular/angular/pull/25163#ref-pullrequest-345293357
test: fix typing in the largetable benchmark #25165 https://github.com/angular/angular/pull/25165
IgorMinarhttps://github.com/IgorMinar
Jul 27, 2018 https://github.com/angular/angular/pull/25163#ref-commit-39abe7b
https://github.com/gkalpak
https://github.com/IgorMinar
test: fix typings forhttps://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8
DoneFnhttps://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8
(https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8
#25163https://github.com/angular/angular/pull/25163
)https://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8
39abe7bhttps://github.com/angular/angular/commit/39abe7b7c10863c40bafd124fa4240e7a71224a8
#24663https://github.com/angular/angular/pull/24663
#25163https://github.com/angular/angular/pull/25163
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
3426784https://github.com/angular/angular/commit/342678486dc08c82ab5a0dd89f93b67567e4e964
Jul 27, 2018https://github.com/angular/angular/pull/25163#event-1757854895
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
July 27, 2018 18:20https://github.com/angular/angular/pull/25163#event-1757865755
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/25163#issuecomment-531395072
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/25163#event-2633594836
adhambaouzhttps://github.com/adhambaouz
Nov 20, 2026 https://github.com/angular/angular/pull/25163#ref-commit-5a5b040
https://github.com/gkalpak
https://github.com/IgorMinar
test: fix typings forhttps://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9
DoneFnhttps://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9
(https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9
angular#25163https://github.com/angular/angular/pull/25163
)https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9
5a5b040https://github.com/adhambaouz/angular/commit/5a5b0400acf99b7bc6e969f9b223976a93b7b8e9
angular#24663https://github.com/angular/angular/pull/24663
angular#25163https://github.com/angular/angular/pull/25163
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25163
https://github.com/alexeagle
alexeagle https://github.com/alexeagle
https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/25163/files/3617cd7e3deecc8e4a2c94dd72f06a798ce16688
https://github.com/jasonaden
jasonaden https://github.com/jasonaden
https://github.com/angular/angular/pull/25163/files/5a68162547a59e4b50ed06a0f78671de8885b69d
Please reload this pagehttps://github.com/angular/angular/pull/25163
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: build & ci https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Please reload this pagehttps://github.com/angular/angular/pull/25163
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/IgorMinar
https://github.com/alexeagle
https://github.com/jasonaden
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.