| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:73f06fac-51b4-02b5-ff09-aeb3f3c50b70 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6D2:36EF3:111E48:16DC27:6B01606A |
| html-safe-nonce | 4a80943715f2cf89a2643fe7ddedbca11d16476c670048cac0fd23fe2f09e2b2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkQyOjM2RUYzOjExMUU0ODoxNkRDMjc6NkIwMTYwNkEiLCJ2aXNpdG9yX2lkIjoiMjg1NTk5NDU3NjA2ODUwMTYxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 11f08043871483c9dfb29ac84975269c140e015f48761201396ad3fc814b6d35 |
| hovercard-subject-tag | pull_request:203876059 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/25090/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | Sits on top of #25060.
PR Checklist
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/25090/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25090%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F25090%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/25090/files |
| Reload | https://github.com/angular/angular/pull/25090/files |
| Reload | https://github.com/angular/angular/pull/25090/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:feat-ngcc-non-flat-formats | https://github.com/gkalpak/angular/tree/feat-ngcc-non-flat-formats |
|
Conversation
23
| https://github.com/angular/angular/pull/25090 |
|
Commits
8
| https://github.com/angular/angular/pull/25090/commits |
|
Checks
0
| https://github.com/angular/angular/pull/25090/checks |
|
Files changed
| https://github.com/angular/angular/pull/25090/files |
| Please reload this page | https://github.com/angular/angular/pull/25090/files |
|
feat(ivy): fix and enable esm2015/esm5 processing in ngcc
| https://github.com/angular/angular/pull/25090/files#top |
|
Show all changes
8 commits
| https://github.com/angular/angular/pull/25090/files |
|
3cb44e3
feat(ivy): use the ReflectionHost to resolve parameters and initializers
alxhub Jul 20, 2018
| https://github.com/angular/angular/pull/25090/commits/3cb44e34d4ec3b4de8b7c5b38567ed806722ad77 |
|
f479fd5
feat(ivy): implement `getDefinitionOfFunction` on ES2015 and ES5 refl…
petebacondarwin Jul 25, 2018
| https://github.com/angular/angular/pull/25090/commits/f479fd5862e68777d3e3ecabcdcb46efe64ae8a8 |
|
da09227
fix(ivy): allow `FunctionExpression` to indicate a method declaration
petebacondarwin Jul 16, 2018
| https://github.com/angular/angular/pull/25090/commits/da09227cae3bca5a380f8f3485f9db12a47bf116 |
|
d3fe384
refactor(ivy): remove unused arg from ngcc `Analyzer`
gkalpak Jul 24, 2018
| https://github.com/angular/angular/pull/25090/commits/d3fe3842a051680978c1f0ff48030370583ff68b |
|
db88cb1
feat(ivy): add support for esm2015 and esm5 in ngcc `PackageParser`
gkalpak Jul 24, 2018
| https://github.com/angular/angular/pull/25090/commits/db88cb16ce61f14c7405ba1f9b4feca6126bf7de |
|
613bc8b
fix(ivy): correctly detect classes in ngcc `Esm5ReflectionHost`
gkalpak Jul 25, 2018
| https://github.com/angular/angular/pull/25090/commits/613bc8baf47156a65a552793b7a3a9bd69973ada |
|
b60e4b9
feat(ivy): enable processing of esm5 format in ngcc
gkalpak Jul 25, 2018
| https://github.com/angular/angular/pull/25090/commits/b60e4b93bf0326588dacedc7fedcde053a5b9317 |
|
af5a439
fixup! fix(ivy): correctly detect classes in ngcc `Esm5ReflectionHost`
gkalpak Aug 20, 2018
| https://github.com/angular/angular/pull/25090/commits/af5a439556b0f068cf617bfd9a8998537f089286 |
|
Clear filters
| https://github.com/angular/angular/pull/25090/files |
| Please reload this page | https://github.com/angular/angular/pull/25090/files |
| Please reload this page | https://github.com/angular/angular/pull/25090/files |
|
analyzer.ts
| https://github.com/angular/angular/pull/25090/files#diff-1b918d33943c21698778fd9169c963493f5ed555d801aa3100e466ddde8c3d10 |
|
esm2015_host.ts
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
esm5_host.ts
| https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
|
ngcc_host.ts
| https://github.com/angular/angular/pull/25090/files#diff-cdf9b47e18f89f8f93a1265da7e5886c846abe87385c43e916f4d10b9f3ac5bd |
|
main.ts
| https://github.com/angular/angular/pull/25090/files#diff-f447617663c0238e717e3c26143620625b04506a6ef51e655954c0ba80f2a59a |
|
package_transformer.ts
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
esm2015_host_spec.ts
| https://github.com/angular/angular/pull/25090/files#diff-31fe9ad0a9b21727920f50084cd20ecf140a15f6548a07c5b1cce403f8b6055f |
|
esm5_host_spec.ts
| https://github.com/angular/angular/pull/25090/files#diff-eeb3594a52755bcb8d17f3e27713159bb829ed4b0ad533f034276398a0372041 |
|
ng_module.ts
| https://github.com/angular/angular/pull/25090/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8 |
|
reflection.ts
| https://github.com/angular/angular/pull/25090/files#diff-1edf42ff14c686eb5e49d287235e9e8bb61bd42e50aaf2061249b0e109142a72 |
|
reflector.ts
| https://github.com/angular/angular/pull/25090/files#diff-8cf5a16864560e3865d4e4d6804b2e09ff109b3446e567774f059c3acc0132de |
|
resolver.ts
| https://github.com/angular/angular/pull/25090/files#diff-cb3aeb6b721343e2b552c6118504459cc1254a23e325b818efe4b206e64192b0 |
|
reflector_spec.ts
| https://github.com/angular/angular/pull/25090/files#diff-1b1aee08add9023cf4f0fcaf478f428f767d979f598535a1d7ee362a0afcc8a1 |
|
ngcc_spec.ts
| https://github.com/angular/angular/pull/25090/files#diff-d07e068abb461105b4a03551e75567dbc74457de8b6e98958ea855a5da347016 |
| packages/compiler-cli/src/ngcc/src/analyzer.ts | https://github.com/angular/angular/pull/25090/files#diff-1b918d33943c21698778fd9169c963493f5ed555d801aa3100e466ddde8c3d10 |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/analyzer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-1b918d33943c21698778fd9169c963493f5ed555d801aa3100e466ddde8c3d10 |
|
| https://github.com/angular/angular/pull/25090/files#diff-1b918d33943c21698778fd9169c963493f5ed555d801aa3100e466ddde8c3d10 |
|
| https://github.com/angular/angular/pull/25090/files#diff-1b918d33943c21698778fd9169c963493f5ed555d801aa3100e466ddde8c3d10 |
| packages/compiler-cli/src/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/host/esm2015_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
|
| https://github.com/angular/angular/pull/25090/files#diff-444b6bb4b348703ed64780a9f33cadd563dedf143bd80a86785bd835da6bfd14 |
| packages/compiler-cli/src/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/host/esm5_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
|
| https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
|
| https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
|
| https://github.com/angular/angular/pull/25090/files#diff-a438ca62230be53a9ed7a3abc9dd235e3a11391e9f92d8b56a14f79f68c6b11a |
| packages/compiler-cli/src/ngcc/src/host/ngcc_host.ts | https://github.com/angular/angular/pull/25090/files#diff-cdf9b47e18f89f8f93a1265da7e5886c846abe87385c43e916f4d10b9f3ac5bd |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/host/ngcc_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-cdf9b47e18f89f8f93a1265da7e5886c846abe87385c43e916f4d10b9f3ac5bd |
| packages/compiler-cli/src/ngcc/src/main.ts | https://github.com/angular/angular/pull/25090/files#diff-f447617663c0238e717e3c26143620625b04506a6ef51e655954c0ba80f2a59a |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/main.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-f447617663c0238e717e3c26143620625b04506a6ef51e655954c0ba80f2a59a |
| packages/compiler-cli/src/ngcc/src/transform/package_transformer.ts | https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
View file
| https://github.com/gkalpak/angular/blob/af5a439556b0f068cf617bfd9a8998537f089286/packages/compiler-cli/src/ngcc/src/transform/package_transformer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/25090/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
| alxhub | https://github.com/alxhub |
| Aug 7, 2018 | https://github.com/angular/angular/pull/25090/files#r208334543 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/25090/files |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
|
| https://github.com/angular/angular/pull/25090/files#diff-5f999069b9d710fdf58fc5ed719d7024f64c1974c0d184dc3b3cc19184d6fad6 |
| Please reload this page | https://github.com/angular/angular/pull/25090/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |