| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0cae53e6-460e-506a-6cba-d03e6f06a667 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C4E:842EC:126BE8A:18A01DA:6B01239D |
| html-safe-nonce | 6159bdee670ecf91232f5e6423aade59d74e45e1f6af85a174be0f7f1c7467b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzRFOjg0MkVDOjEyNkJFOEE6MThBMDFEQTo2QjAxMjM5RCIsInZpc2l0b3JfaWQiOiI4MDYzOTIwOTQ1Nzc5OTI2MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 73f33d2c2eef7aa7bac41728d7a63dd11cf24189f7dc262ce9389074da3d6a27 |
| hovercard-subject-tag | pull_request:201115365 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/24861/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e6888454eea3a8bdfc9612c18b575838f79fca8be423136a02ac0f96c8d2cacf/angular/angular/pull/24861 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e6888454eea3a8bdfc9612c18b575838f79fca8be423136a02ac0f96c8d2cacf/angular/angular/pull/24861 |
| og:image:alt | Adds a new optional parameter to the renderer.selectRootElement method:
Before:
renderer.selectRootElement(rootSelectorOrNode);
renderer.selectRootElement(rootSelectorOrNode, preserveContents?:boo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | robwormald |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/24861#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24861 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24861 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/24861 |
| Reload | https://github.com/angular/angular/pull/24861 |
| Reload | https://github.com/angular/angular/pull/24861 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| robwormald | https://github.com/robwormald |
| angular:master | https://github.com/angular/angular/tree/master |
| robwormald:elements-shadow-dom-fix | https://github.com/robwormald/angular/tree/elements-shadow-dom-fix |
| Conversation | https://github.com/angular/angular/pull/24861 |
| Commits9 (9) | https://github.com/angular/angular/pull/24861/commits |
| Checks | https://github.com/angular/angular/pull/24861/checks |
| Files changed | https://github.com/angular/angular/pull/24861/files |
| Elements shadow dom fix | https://github.com/angular/angular/pull/24861#top |
| robwormald | https://github.com/robwormald |
| angular:master | https://github.com/angular/angular/tree/master |
| robwormald:elements-shadow-dom-fix | https://github.com/robwormald/angular/tree/elements-shadow-dom-fix |
|
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issue-340784848 |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/angular/angular/blob/master/packages/core/src/view/services.ts#L756 | https://github.com/angular/angular/blob/master/packages/core/src/view/services.ts#L756 |
| #24859 | https://github.com/angular/angular/issues/24859 |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#event-1731215868 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404641835 |
| https://pr24861-1eec884.ngbuilds.io/ | https://pr24861-1eec884.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| force-pushed | https://github.com/angular/angular/compare/458cf2ffdd32cae47e33990c3d6ab0e82cebc5e1..525ca3ecb3e6df439c17417061c5f77f424d1237 |
| 458cf2f | https://github.com/angular/angular/commit/458cf2ffdd32cae47e33990c3d6ab0e82cebc5e1 |
| 525ca3e | https://github.com/angular/angular/commit/525ca3ecb3e6df439c17417061c5f77f424d1237 |
|
Compare
| https://github.com/angular/angular/compare/458cf2ffdd32cae47e33990c3d6ab0e82cebc5e1..525ca3ecb3e6df439c17417061c5f77f424d1237 |
| July 12, 2018 21:36 | https://github.com/angular/angular/pull/24861#event-1731347377 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404658552 |
| https://pr24861-458cf2f.ngbuilds.io/ | https://pr24861-458cf2f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Jul 12, 2018
| https://github.com/angular/angular/pull/24861#pullrequestreview-136814658 |
|
View reviewed changes
| https://github.com/angular/angular/pull/24861/files |
| packages/platform-browser/src/dom/dom_renderer.ts | https://github.com/angular/angular/pull/24861/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6 |
| mhevery | https://github.com/mhevery |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202167418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/platform-browser/src/dom/dom_renderer.ts | https://github.com/angular/angular/pull/24861/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6 |
| mhevery | https://github.com/mhevery |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202187766 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/platform-browser/src/dom/dom_renderer.ts | https://github.com/angular/angular/pull/24861/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6 |
| mhevery | https://github.com/mhevery |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202188027 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404660709 |
| https://pr24861-525ca3e.ngbuilds.io/ | https://pr24861-525ca3e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Jul 12, 2018
| https://github.com/angular/angular/pull/24861#pullrequestreview-136842708 |
|
View reviewed changes
| https://github.com/angular/angular/pull/24861/files |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| force-pushed | https://github.com/angular/angular/compare/7a08d698ba5e57a0f7c7859f7a9dd2516565414d..8617d87fa380f4813d45dc46f1cd47ad31043d4d |
| 7a08d69 | https://github.com/angular/angular/commit/7a08d698ba5e57a0f7c7859f7a9dd2516565414d |
| 8617d87 | https://github.com/angular/angular/commit/8617d87fa380f4813d45dc46f1cd47ad31043d4d |
|
Compare
| https://github.com/angular/angular/compare/7a08d698ba5e57a0f7c7859f7a9dd2516565414d..8617d87fa380f4813d45dc46f1cd47ad31043d4d |
| July 12, 2018 21:50 | https://github.com/angular/angular/pull/24861#event-1731370861 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404662841 |
| https://pr24861-7a08d69.ngbuilds.io/ | https://pr24861-7a08d69.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404664351 |
| https://pr24861-8617d87.ngbuilds.io/ | https://pr24861-8617d87.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#event-1731469414 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 12, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-404677856 |
| https://pr24861-8d290e2.ngbuilds.io/ | https://pr24861-8d290e2.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 15, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-405125385 |
| https://pr24861-8cafe35.ngbuilds.io/ | https://pr24861-8cafe35.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| force-pushed | https://github.com/angular/angular/compare/8cafe350749800b7edd4d6a85ed004b5600364ac..1f5de462a799440fd8d6c97b9ad703c15e1ca280 |
| 8cafe35 | https://github.com/angular/angular/commit/8cafe350749800b7edd4d6a85ed004b5600364ac |
| 1f5de46 | https://github.com/angular/angular/commit/1f5de462a799440fd8d6c97b9ad703c15e1ca280 |
|
Compare
| https://github.com/angular/angular/compare/8cafe350749800b7edd4d6a85ed004b5600364ac..1f5de462a799440fd8d6c97b9ad703c15e1ca280 |
| July 15, 2018 23:10 | https://github.com/angular/angular/pull/24861#event-1734387440 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 15, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-405125851 |
| https://pr24861-1f5de46.ngbuilds.io/ | https://pr24861-1f5de46.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-405135358 |
| https://pr24861-f9b7adc.ngbuilds.io/ | https://pr24861-f9b7adc.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jul 16, 2018
| https://github.com/angular/angular/pull/24861#pullrequestreview-137504909 |
|
View reviewed changes
| https://github.com/angular/angular/pull/24861/files |
| packages/platform-browser/testing/src/browser_util.ts | https://github.com/angular/angular/pull/24861/files#diff-8f2401f3e3bc7382a0b035c52401c4721ce42acc67eb5daa096cec60a2e3a069 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202747165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| robwormald | https://github.com/robwormald |
| Aug 7, 2018 | https://github.com/angular/angular/pull/24861#discussion_r208417746 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| IgorMinar | https://github.com/IgorMinar |
| Aug 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r210697185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @robwormald | https://github.com/robwormald |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/platform-browser/testing/src/browser_util.ts | https://github.com/angular/angular/pull/24861/files#diff-8f2401f3e3bc7382a0b035c52401c4721ce42acc67eb5daa096cec60a2e3a069 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202747649 |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/elements/test/slots_spec.ts | https://github.com/angular/angular/pull/24861/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202747811 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/elements/test/slots_spec.ts | https://github.com/angular/angular/pull/24861/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202748896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/elements/test/slots_spec.ts | https://github.com/angular/angular/pull/24861/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202758654 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/elements/test/slots_spec.ts | https://github.com/angular/angular/pull/24861/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202760092 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/elements/test/slots_spec.ts | https://github.com/angular/angular/pull/24861/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577 |
| gkalpak | https://github.com/gkalpak |
| Jul 16, 2018 | https://github.com/angular/angular/pull/24861#discussion_r202760459 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| force-pushed | https://github.com/angular/angular/compare/1afc17ba68bd39040558b178d5c96d2cc1187bbe..41e091411b0b7d40d37ff6477df946bf4f25c849 |
| 1afc17b | https://github.com/angular/angular/commit/1afc17ba68bd39040558b178d5c96d2cc1187bbe |
| 41e0914 | https://github.com/angular/angular/commit/41e091411b0b7d40d37ff6477df946bf4f25c849 |
|
Compare
| https://github.com/angular/angular/compare/1afc17ba68bd39040558b178d5c96d2cc1187bbe..41e091411b0b7d40d37ff6477df946bf4f25c849 |
| July 31, 2018 22:04 | https://github.com/angular/angular/pull/24861#event-1763882772 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 31, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-409385551 |
| https://pr24861-41e0914.ngbuilds.io/ | https://pr24861-41e0914.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/benoitjchevalier |
| benoitjchevalier | https://github.com/benoitjchevalier |
|
Jul 31, 2018
| https://github.com/angular/angular/pull/24861#ref-issue-332747824 |
|
ng-content, slot and content elements don't work with nested Angular custom elements
#24536
| https://github.com/angular/angular/issues/24536 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Aug 2, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-410024560 |
| http://test/OCL:207128490:BASE:207128536:1533232686068:75ae6d95 | http://test/OCL:207128490:BASE:207128536:1533232686068:75ae6d95 |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Aug 2, 2018 | https://github.com/angular/angular/pull/24861#event-1768369774 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Aug 2, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-410024620 |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Aug 2, 2018
| https://github.com/angular/angular/pull/24861#pullrequestreview-142987155 |
|
View reviewed changes
| https://github.com/angular/angular/pull/24861/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/24861#pullrequestreview-142987155 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| packages/core/src/render/api.ts | https://github.com/angular/angular/pull/24861/files#diff-27d607ed41e9c29ab0b7613e43c3bd0e00da2b7da742b5c371329530f14bcbcc |
| IgorMinar | https://github.com/IgorMinar |
| Aug 2, 2018 | https://github.com/angular/angular/pull/24861#discussion_r207383277 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| IgorMinar | https://github.com/IgorMinar |
| Aug 2, 2018 | https://github.com/angular/angular/pull/24861#discussion_r207383758 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Aug 3, 2018 | https://github.com/angular/angular/pull/24861#event-1768907701 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| force-pushed | https://github.com/angular/angular/compare/41e091411b0b7d40d37ff6477df946bf4f25c849..0f88a25c872492ecd3c5c58f71166c48e7af93bd |
| 41e0914 | https://github.com/angular/angular/commit/41e091411b0b7d40d37ff6477df946bf4f25c849 |
| 0f88a25 | https://github.com/angular/angular/commit/0f88a25c872492ecd3c5c58f71166c48e7af93bd |
|
Compare
| https://github.com/angular/angular/compare/41e091411b0b7d40d37ff6477df946bf4f25c849..0f88a25c872492ecd3c5c58f71166c48e7af93bd |
| August 7, 2018 23:38 | https://github.com/angular/angular/pull/24861#event-1776545258 |
| https://github.com/robwormald |
| robwormald | https://github.com/robwormald |
| IgorMinar | https://github.com/IgorMinar |
| August 7, 2018 23:41 | https://github.com/angular/angular/pull/24861#event-1776549416 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Aug 30, 2018 | https://github.com/angular/angular/pull/24861#issuecomment-417483842 |
| a81d30f | https://github.com/angular/angular/commit/a81d30f0dd22417e3fa5d77ed284c5de65bf4e31 |
| https://pr24861-a81d30f.ngbuilds.io/ | https://pr24861-a81d30f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 6e828bb | https://github.com/angular/angular/commit/6e828bba884daff3936cf7530c5a8eb3e4fa1796 |
| Aug 31, 2018 | https://github.com/angular/angular/pull/24861#event-1819731023 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-1d8e821 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| ci: update chrome version to 67 ( | https://github.com/angular/angular/commit/1d8e821276564cd0247f58b195b99b2f2fbd9c9b |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/1d8e821276564cd0247f58b195b99b2f2fbd9c9b |
| 1d8e821 | https://github.com/angular/angular/commit/1d8e821276564cd0247f58b195b99b2f2fbd9c9b |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-6e6489a |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| ci: update firefox version to 61 ( | https://github.com/angular/angular/commit/6e6489a40847de16eceed718152427d3239d135b |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/6e6489a40847de16eceed718152427d3239d135b |
| 6e6489a | https://github.com/angular/angular/commit/6e6489a40847de16eceed718152427d3239d135b |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-d76a7d6 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| test(core): update Web Platform feature detection ( | https://github.com/angular/angular/commit/d76a7d6f7cadee28988110cdb47b8d39c6e7144f |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/d76a7d6f7cadee28988110cdb47b8d39c6e7144f |
| d76a7d6 | https://github.com/angular/angular/commit/d76a7d6f7cadee28988110cdb47b8d39c6e7144f |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-4815b92 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| test(elements): add basic integration test for angular elements ( | https://github.com/angular/angular/commit/4815b924952205b2a9bcb21fd59fc07ccc22ff51 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/4815b924952205b2a9bcb21fd59fc07ccc22ff51 |
| 4815b92 | https://github.com/angular/angular/commit/4815b924952205b2a9bcb21fd59fc07ccc22ff51 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-c9844a2 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| feat(elements): enable Shadow DOM v1 and slots ( | https://github.com/angular/angular/commit/c9844a2f0132c757711a1a1004120ddf058e47f6 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/c9844a2f0132c757711a1a1004120ddf058e47f6 |
| c9844a2 | https://github.com/angular/angular/commit/c9844a2f0132c757711a1a1004120ddf058e47f6 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-a8210d0 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| fix(elements): strict null checks ( | https://github.com/angular/angular/commit/a8210d010be8ff054859d3e1a6e9fd00c2a6bd64 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/a8210d010be8ff054859d3e1a6e9fd00c2a6bd64 |
| a8210d0 | https://github.com/angular/angular/commit/a8210d010be8ff054859d3e1a6e9fd00c2a6bd64 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-a080ffc |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| fix(elements): add compiler to integration ( | https://github.com/angular/angular/commit/a080ffc74386293c9e47c760995a2235b03ff510 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/a080ffc74386293c9e47c760995a2235b03ff510 |
| a080ffc | https://github.com/angular/angular/commit/a080ffc74386293c9e47c760995a2235b03ff510 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| mhevery | https://github.com/mhevery |
|
Aug 31, 2018
| https://github.com/angular/angular/pull/24861#ref-commit-6143da6 |
|
| https://github.com/robwormald |
|
| https://github.com/mhevery |
| fix(elements): add compiler dependency ( | https://github.com/angular/angular/commit/6143da66b2449e4da57b95d9a144866fd0c2da26 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| ) | https://github.com/angular/angular/commit/6143da66b2449e4da57b95d9a144866fd0c2da26 |
| 6143da6 | https://github.com/angular/angular/commit/6143da66b2449e4da57b95d9a144866fd0c2da26 |
| #24861 | https://github.com/angular/angular/pull/24861 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/24861#issuecomment-531428327 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 14, 2019 | https://github.com/angular/angular/pull/24861#event-2633827438 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24861 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/24861/files/7a08d698ba5e57a0f7c7859f7a9dd2516565414d |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/24861/files/fe157a591c7c5a605571dda740fa8a315d14d362 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/24861/files/ae1055888f0f0fd87d51650a9434fa418373a83c |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
Renderer should not clear host contents when using Shadow DOM
| https://github.com/angular/angular/issues/24859 |
| Please reload this page | https://github.com/angular/angular/pull/24861 |
|
| https://github.com/robwormald |
|
| https://github.com/mary-poppins |
|
| https://github.com/mhevery |
|
| https://github.com/IgorMinar |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |