René's URL Explorer Experiment


Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular · GitHub

Open Graph Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular

X Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular

Description: Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right root module. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? NgModule with BrowserModule is always set as the root module. For a SSR app that is progressively bootstrapped the root module doesn't define the BrowserModule while the module with BrowserModule is loaded later. However tree shakable injectors always attach themselves to the NgModule with BrowserModule and not it's parent. What is the new behavior? This change allows a NgModule that imports BrowserModule to explicitly mark itself as not the root. Does this PR introduce a breaking change? [ ] Yes [x] No

Open Graph Description: Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...

X Description: Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...

Opengraph URL: https://github.com/angular/angular/pull/24814

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f5094ce9-f08c-cbe4-a345-a409704de3ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2B8:A99C2:E45331:125C109:6B00F689
html-safe-nonce548732167620b76c1fee81ab2b0ea79aad76e3581328b73a40a9eb6e0f1f8931
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkI4OkE5OUMyOkU0NTMzMToxMjVDMTA5OjZCMDBGNjg5IiwidmlzaXRvcl9pZCI6IjI4MzQ4OTk4OTE0Mzg4MTA3NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac56b5770339b9c2365a36bdf810debcf2ddd72e23bc807d3e3500aa2a51e5a89c
hovercard-subject-tagpull_request:200434883
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/24814/files
twitter:imagehttps://avatars.githubusercontent.com/u/85066?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/85066?s=400&v=4
og:image:altTree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/24814/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24814%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24814%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/24814/files
Reloadhttps://github.com/angular/angular/pull/24814/files
Reloadhttps://github.com/angular/angular/pull/24814/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
vikermanhttps://github.com/vikerman
angular:masterhttps://github.com/angular/angular/tree/master
vikerman:app-roothttps://github.com/vikerman/angular/tree/app-root
Conversation 4 https://github.com/angular/angular/pull/24814
Commits 1 https://github.com/angular/angular/pull/24814/commits
Checks 0 https://github.com/angular/angular/pull/24814/checks
Files changed https://github.com/angular/angular/pull/24814/files
Please reload this pagehttps://github.com/angular/angular/pull/24814/files
fix(core): mark NgModule as not the root if APP_ROOT is set to false https://github.com/angular/angular/pull/24814/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/24814/files
2a95865 fix(core): mark NgModule as not the root if APP_ROOT is set to false vikerman Jul 10, 2018 https://github.com/angular/angular/pull/24814/commits/2a95865ebf27ea366b7b9bd3758573b93c69ec47
Clear filters https://github.com/angular/angular/pull/24814/files
Please reload this pagehttps://github.com/angular/angular/pull/24814/files
Please reload this pagehttps://github.com/angular/angular/pull/24814/files
ng_module.ts https://github.com/angular/angular/pull/24814/files#diff-a7867b30bb8cf402f6b32e6cd22b4cfbe4f2ae288f38e65780f9280842775f17
ng_module_spec.ts https://github.com/angular/angular/pull/24814/files#diff-0e0eb920ec3803adcecaad11a29613e4460e86cd12cdfc571eb23a62b072f2d3
packages/core/src/view/ng_module.tshttps://github.com/angular/angular/pull/24814/files#diff-a7867b30bb8cf402f6b32e6cd22b4cfbe4f2ae288f38e65780f9280842775f17
View file https://github.com/vikerman/angular/blob/2a95865ebf27ea366b7b9bd3758573b93c69ec47/packages/core/src/view/ng_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24814/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24814/files#diff-a7867b30bb8cf402f6b32e6cd22b4cfbe4f2ae288f38e65780f9280842775f17
https://github.com/angular/angular/pull/24814/files#diff-a7867b30bb8cf402f6b32e6cd22b4cfbe4f2ae288f38e65780f9280842775f17
packages/core/test/view/ng_module_spec.tshttps://github.com/angular/angular/pull/24814/files#diff-0e0eb920ec3803adcecaad11a29613e4460e86cd12cdfc571eb23a62b072f2d3
View file https://github.com/vikerman/angular/blob/2a95865ebf27ea366b7b9bd3758573b93c69ec47/packages/core/test/view/ng_module_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24814/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24814/files#diff-0e0eb920ec3803adcecaad11a29613e4460e86cd12cdfc571eb23a62b072f2d3
https://github.com/angular/angular/pull/24814/files#diff-0e0eb920ec3803adcecaad11a29613e4460e86cd12cdfc571eb23a62b072f2d3
https://github.com/angular/angular/pull/24814/files#diff-0e0eb920ec3803adcecaad11a29613e4460e86cd12cdfc571eb23a62b072f2d3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.