René's URL Explorer Experiment


Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular · GitHub

Open Graph Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular

X Title: fix(core): mark NgModule as not the root if APP_ROOT is set to false by vikerman · Pull Request #24814 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...

X Description: Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...

Opengraph URL: https://github.com/angular/angular/pull/24814

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fa6a956c-614f-fca2-a68f-2b66f32a71ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8AA:20AA01:CCC562:10734DB:6B00EF61
html-safe-noncec198c425b8688d2dd383bbc06f6b9db0752b411168e85f562b30cc8e3df79025
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEFBOjIwQUEwMTpDQ0M1NjI6MTA3MzREQjo2QjAwRUY2MSIsInZpc2l0b3JfaWQiOiI1MTM4OTY2NzIxMjIyMjA5Mzc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc96cf208c7cbb17bc505775e4960b3c225ecc8e43f0b3e2f3af2e6ab7f81e828
hovercard-subject-tagpull_request:200434883
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/24814/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eaa9ec1f7f1a5fb2a38b6bd91d132bff03286e5cdc6dee3732a137ea0082a8bf/angular/angular/pull/24814
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eaa9ec1f7f1a5fb2a38b6bd91d132bff03286e5cdc6dee3732a137ea0082a8bf/angular/angular/pull/24814
og:image:altTree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevikerman
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/24814#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24814
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24814
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/24814
Reloadhttps://github.com/angular/angular/pull/24814
Reloadhttps://github.com/angular/angular/pull/24814
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
vikermanhttps://github.com/vikerman
angular:masterhttps://github.com/angular/angular/tree/master
vikerman:app-roothttps://github.com/vikerman/angular/tree/app-root
Conversationhttps://github.com/angular/angular/pull/24814
Commits1 (1)https://github.com/angular/angular/pull/24814/commits
Checkshttps://github.com/angular/angular/pull/24814/checks
Files changedhttps://github.com/angular/angular/pull/24814/files
fix(core): mark NgModule as not the root if APP_ROOT is set to falsehttps://github.com/angular/angular/pull/24814#top
vikermanhttps://github.com/vikerman
angular:masterhttps://github.com/angular/angular/tree/master
vikerman:app-roothttps://github.com/vikerman/angular/tree/app-root
https://github.com/vikerman
vikermanhttps://github.com/vikerman
Jul 10, 2018https://github.com/angular/angular/pull/24814#issue-339892503
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/vikerman
vikermanhttps://github.com/vikerman
alxhubhttps://github.com/alxhub
July 10, 2018 15:24https://github.com/angular/angular/pull/24814#event-1725832127
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jul 10, 2018https://github.com/angular/angular/pull/24814#event-1725832244
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Jul 10, 2018 https://github.com/angular/angular/pull/24814#pullrequestreview-135882884
View reviewed changes https://github.com/angular/angular/pull/24814/files
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 10, 2018https://github.com/angular/angular/pull/24814#issuecomment-403866542
https://pr24814-3d5cab0.ngbuilds.io/https://pr24814-3d5cab0.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/vikerman
vikermanhttps://github.com/vikerman
force-pushedhttps://github.com/angular/angular/compare/3d5cab0005fb385dd8a4fc517efcc9be4e38655a..fba5379cd3c2a5055ad7e33fe3571c8bf4223c65
3d5cab0https://github.com/angular/angular/commit/3d5cab0005fb385dd8a4fc517efcc9be4e38655a
fba5379https://github.com/angular/angular/commit/fba5379cd3c2a5055ad7e33fe3571c8bf4223c65
Compare https://github.com/angular/angular/compare/3d5cab0005fb385dd8a4fc517efcc9be4e38655a..fba5379cd3c2a5055ad7e33fe3571c8bf4223c65
July 10, 2018 16:02https://github.com/angular/angular/pull/24814#event-1725931480
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 10, 2018https://github.com/angular/angular/pull/24814#issuecomment-403880518
https://pr24814-fba5379.ngbuilds.io/https://pr24814-fba5379.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/vikerman
fix(core): mark NgModule as not the root if APP_ROOT is set to falsehttps://github.com/angular/angular/pull/24814/commits/2a95865ebf27ea366b7b9bd3758573b93c69ec47
2a95865https://github.com/angular/angular/pull/24814/commits/2a95865ebf27ea366b7b9bd3758573b93c69ec47
https://github.com/vikerman
vikermanhttps://github.com/vikerman
force-pushedhttps://github.com/angular/angular/compare/fba5379cd3c2a5055ad7e33fe3571c8bf4223c65..2a95865ebf27ea366b7b9bd3758573b93c69ec47
fba5379https://github.com/angular/angular/commit/fba5379cd3c2a5055ad7e33fe3571c8bf4223c65
2a95865https://github.com/angular/angular/commit/2a95865ebf27ea366b7b9bd3758573b93c69ec47
Compare https://github.com/angular/angular/compare/fba5379cd3c2a5055ad7e33fe3571c8bf4223c65..2a95865ebf27ea366b7b9bd3758573b93c69ec47
July 10, 2018 16:28https://github.com/angular/angular/pull/24814#event-1725991451
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jul 10, 2018https://github.com/angular/angular/pull/24814#issuecomment-403887755
2a95865https://github.com/angular/angular/commit/2a95865ebf27ea366b7b9bd3758573b93c69ec47
https://pr24814-2a95865.ngbuilds.io/https://pr24814-2a95865.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Jul 10, 2018 https://github.com/angular/angular/pull/24814#pullrequestreview-135942110
View reviewed changes https://github.com/angular/angular/pull/24814/files/2a95865ebf27ea366b7b9bd3758573b93c69ec47
https://github.com/mhevery
mheveryhttps://github.com/mhevery
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jul 10, 2018https://github.com/angular/angular/pull/24814#event-1726187137
https://github.com/mhevery
mheveryhttps://github.com/mhevery
1089261https://github.com/angular/angular/commit/1089261717ed44bf9ce72b05986084bfb00fc2e8
Jul 10, 2018https://github.com/angular/angular/pull/24814#event-1726209782
danielsoglhttps://github.com/danielsogl
Jul 25, 2018 https://github.com/angular/angular/pull/24814#ref-commit-db21c38
https://github.com/danielsogl
docs: refactor pipe example to use the HttpClienthttps://github.com/danielsogl/angular/commit/db21c38dbef0d040094df0a8dbec1a2c31608fdb
db21c38https://github.com/danielsogl/angular/commit/db21c38dbef0d040094df0a8dbec1a2c31608fdb
angular#19127https://github.com/angular/angular/pull/19127
angular#19127https://github.com/angular/angular/pull/19127
angular#22590https://github.com/angular/angular/pull/22590
angular#22590https://github.com/angular/angular/pull/22590
angular#23876https://github.com/angular/angular/pull/23876
angular#23876https://github.com/angular/angular/pull/23876
angular#24079https://github.com/angular/angular/pull/24079
angular#24079https://github.com/angular/angular/pull/24079
angular#24228https://github.com/angular/angular/pull/24228
angular#24228https://github.com/angular/angular/pull/24228
angular#24303https://github.com/angular/angular/pull/24303
angular#24303https://github.com/angular/angular/pull/24303
angular#24528https://github.com/angular/angular/pull/24528
angular#24528https://github.com/angular/angular/pull/24528
angular#24633https://github.com/angular/angular/pull/24633
angular#24633https://github.com/angular/angular/pull/24633
angular#24713https://github.com/angular/angular/pull/24713
angular#24713https://github.com/angular/angular/pull/24713
angular#24749https://github.com/angular/angular/pull/24749
angular#24749https://github.com/angular/angular/pull/24749
angular#24750https://github.com/angular/angular/pull/24750
angular#24750https://github.com/angular/angular/pull/24750
angular#24759https://github.com/angular/angular/pull/24759
angular#24759https://github.com/angular/angular/pull/24759
angular#19904https://github.com/angular/angular/pull/19904
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15
angular#23952https://github.com/angular/angular/issues/23952
angular#24733https://github.com/angular/angular/pull/24733
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#19904https://github.com/angular/angular/pull/19904
angular#22742https://github.com/angular/angular/pull/22742
angular#22742https://github.com/angular/angular/pull/22742
angular#23653https://github.com/angular/angular/pull/23653
angular#23653https://github.com/angular/angular/pull/23653
angular#24105https://github.com/angular/angular/pull/24105
angular#24105https://github.com/angular/angular/pull/24105
angular#24127https://github.com/angular/angular/pull/24127
angular#24127https://github.com/angular/angular/pull/24127
angular#24127https://github.com/angular/angular/pull/24127
angular#24127https://github.com/angular/angular/pull/24127
angular#24602https://github.com/angular/angular/pull/24602
angular#24602https://github.com/angular/angular/pull/24602
angular#24299https://github.com/angular/angular/pull/24299
angular#21420https://github.com/angular/angular/issues/21420
angular#24299https://github.com/angular/angular/pull/24299
angular#24658https://github.com/angular/angular/pull/24658
angular#24609https://github.com/angular/angular/issues/24609
angular#24658https://github.com/angular/angular/pull/24658
angular#24664https://github.com/angular/angular/pull/24664
angular#24664https://github.com/angular/angular/pull/24664
angular#24803https://github.com/angular/angular/pull/24803
d571a51https://github.com/danielsogl/angular/commit/d571a51739ce7641c62112ffdc9e478dc2115f04
angular#24803https://github.com/angular/angular/pull/24803
angular#24803https://github.com/angular/angular/pull/24803
87d56achttps://github.com/danielsogl/angular/commit/87d56acdaa0a57b8781809a9bc17ba94965647ad
angular#24803https://github.com/angular/angular/pull/24803
angular#24814https://github.com/angular/angular/pull/24814
angular#24814https://github.com/angular/angular/pull/24814
angular#24815https://github.com/angular/angular/pull/24815
angular#24815https://github.com/angular/angular/pull/24815
angular#22737https://github.com/angular/angular/pull/22737
angular#22737https://github.com/angular/angular/pull/22737
angular#22737https://github.com/angular/angular/pull/22737
angular#22737https://github.com/angular/angular/pull/22737
angular#22856https://github.com/angular/angular/pull/22856
angular#22856https://github.com/angular/angular/pull/22856
angular#24481https://github.com/angular/angular/pull/24481
angular#23463https://github.com/angular/angular/issues/23463
angular#22158https://github.com/angular/angular/issues/22158
angular#24481https://github.com/angular/angular/pull/24481
angular#24481https://github.com/angular/angular/pull/24481
angular#24481https://github.com/angular/angular/pull/24481
angular#24752https://github.com/angular/angular/pull/24752
angular#24752https://github.com/angular/angular/pull/24752
angular#24752https://github.com/angular/angular/pull/24752
angular#24752https://github.com/angular/angular/pull/24752
angular#24812https://github.com/angular/angular/pull/24812
angular#24812https://github.com/angular/angular/pull/24812
angular#24830https://github.com/angular/angular/pull/24830
angular#24807https://github.com/angular/angular/pull/24807
angular#24807https://github.com/angular/angular/pull/24807
angular#24817https://github.com/angular/angular/pull/24817
angular#24817https://github.com/angular/angular/pull/24817
angular#24831https://github.com/angular/angular/pull/24831
angular#24384https://github.com/angular/angular/issues/24384
angular#24831https://github.com/angular/angular/pull/24831
angular#22557https://github.com/angular/angular/pull/22557
angular#22557https://github.com/angular/angular/pull/22557
angular#23283https://github.com/angular/angular/pull/23283
angular#21468https://github.com/angular/angular/issues/21468
angular#23283https://github.com/angular/angular/pull/23283
angular#22631https://github.com/angular/angular/pull/22631
angular#22631https://github.com/angular/angular/pull/22631
angular#22735https://github.com/angular/angular/pull/22735
angular#22735https://github.com/angular/angular/pull/22735
angular#22735https://github.com/angular/angular/pull/22735
angular#22735https://github.com/angular/angular/pull/22735
angular#24451https://github.com/angular/angular/pull/24451
angular#24451https://github.com/angular/angular/pull/24451
angular#24734https://github.com/angular/angular/pull/24734
angular#24734https://github.com/angular/angular/pull/24734
IgorMinarhttps://github.com/IgorMinar
Jul 30, 2018 https://github.com/angular/angular/pull/24814#ref-commit-5399c17
https://github.com/danielsogl
https://github.com/IgorMinar
docs: refactor pipe example to use the HttpClient (https://github.com/angular/angular/commit/5399c17d8b4e4ce7d86ed0e029e876cc816ea33e
#22741https://github.com/angular/angular/pull/22741
)https://github.com/angular/angular/commit/5399c17d8b4e4ce7d86ed0e029e876cc816ea33e
5399c17https://github.com/angular/angular/commit/5399c17d8b4e4ce7d86ed0e029e876cc816ea33e
#19127https://github.com/angular/angular/pull/19127
#19127https://github.com/angular/angular/pull/19127
#22590https://github.com/angular/angular/pull/22590
#22590https://github.com/angular/angular/pull/22590
#23876https://github.com/angular/angular/pull/23876
#23876https://github.com/angular/angular/pull/23876
#24079https://github.com/angular/angular/pull/24079
#24079https://github.com/angular/angular/pull/24079
#24228https://github.com/angular/angular/pull/24228
#24228https://github.com/angular/angular/pull/24228
#24303https://github.com/angular/angular/pull/24303
#24303https://github.com/angular/angular/pull/24303
#24528https://github.com/angular/angular/pull/24528
#24528https://github.com/angular/angular/pull/24528
#24633https://github.com/angular/angular/pull/24633
#24633https://github.com/angular/angular/pull/24633
#24713https://github.com/angular/angular/pull/24713
#24713https://github.com/angular/angular/pull/24713
#24749https://github.com/angular/angular/pull/24749
#24749https://github.com/angular/angular/pull/24749
#24750https://github.com/angular/angular/pull/24750
#24750https://github.com/angular/angular/pull/24750
#24759https://github.com/angular/angular/pull/24759
#24759https://github.com/angular/angular/pull/24759
#19904https://github.com/angular/angular/pull/19904
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15
#23952https://github.com/angular/angular/issues/23952
#24733https://github.com/angular/angular/pull/24733
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#19904https://github.com/angular/angular/pull/19904
#22742https://github.com/angular/angular/pull/22742
#22742https://github.com/angular/angular/pull/22742
#23653https://github.com/angular/angular/pull/23653
#23653https://github.com/angular/angular/pull/23653
#24105https://github.com/angular/angular/pull/24105
#24105https://github.com/angular/angular/pull/24105
#24127https://github.com/angular/angular/pull/24127
#24127https://github.com/angular/angular/pull/24127
#24127https://github.com/angular/angular/pull/24127
#24127https://github.com/angular/angular/pull/24127
#24602https://github.com/angular/angular/pull/24602
#24602https://github.com/angular/angular/pull/24602
#24299https://github.com/angular/angular/pull/24299
#21420https://github.com/angular/angular/issues/21420
#24299https://github.com/angular/angular/pull/24299
#24658https://github.com/angular/angular/pull/24658
#24609https://github.com/angular/angular/issues/24609
#24658https://github.com/angular/angular/pull/24658
#24664https://github.com/angular/angular/pull/24664
#24664https://github.com/angular/angular/pull/24664
#24803https://github.com/angular/angular/pull/24803
d571a51https://github.com/angular/angular/commit/d571a51739ce7641c62112ffdc9e478dc2115f04
#24803https://github.com/angular/angular/pull/24803
#24803https://github.com/angular/angular/pull/24803
87d56achttps://github.com/angular/angular/commit/87d56acdaa0a57b8781809a9bc17ba94965647ad
#24803https://github.com/angular/angular/pull/24803
#24814https://github.com/angular/angular/pull/24814
#24814https://github.com/angular/angular/pull/24814
#24815https://github.com/angular/angular/pull/24815
#24815https://github.com/angular/angular/pull/24815
#22737https://github.com/angular/angular/pull/22737
#22737https://github.com/angular/angular/pull/22737
#22737https://github.com/angular/angular/pull/22737
#22737https://github.com/angular/angular/pull/22737
#22856https://github.com/angular/angular/pull/22856
#22856https://github.com/angular/angular/pull/22856
#24481https://github.com/angular/angular/pull/24481
#23463https://github.com/angular/angular/issues/23463
#22158https://github.com/angular/angular/issues/22158
#24481https://github.com/angular/angular/pull/24481
#24481https://github.com/angular/angular/pull/24481
#24481https://github.com/angular/angular/pull/24481
#24752https://github.com/angular/angular/pull/24752
#24752https://github.com/angular/angular/pull/24752
#24752https://github.com/angular/angular/pull/24752
#24752https://github.com/angular/angular/pull/24752
#24812https://github.com/angular/angular/pull/24812
#24812https://github.com/angular/angular/pull/24812
#24830https://github.com/angular/angular/pull/24830
#24807https://github.com/angular/angular/pull/24807
#24807https://github.com/angular/angular/pull/24807
#24817https://github.com/angular/angular/pull/24817
#24817https://github.com/angular/angular/pull/24817
#24831https://github.com/angular/angular/pull/24831
#24384https://github.com/angular/angular/issues/24384
#24831https://github.com/angular/angular/pull/24831
#22557https://github.com/angular/angular/pull/22557
#22557https://github.com/angular/angular/pull/22557
#23283https://github.com/angular/angular/pull/23283
#21468https://github.com/angular/angular/issues/21468
#23283https://github.com/angular/angular/pull/23283
#22631https://github.com/angular/angular/pull/22631
#22631https://github.com/angular/angular/pull/22631
#22735https://github.com/angular/angular/pull/22735
#22735https://github.com/angular/angular/pull/22735
#22735https://github.com/angular/angular/pull/22735
#22735https://github.com/angular/angular/pull/22735
#24451https://github.com/angular/angular/pull/24451
#24451https://github.com/angular/angular/pull/24451
#24734https://github.com/angular/angular/pull/24734
#24734https://github.com/angular/angular/pull/24734
#22741https://github.com/angular/angular/pull/22741
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/24814#issuecomment-531369196
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/24814#event-2633393212
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24814
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/24814/files/3d5cab0005fb385dd8a4fc517efcc9be4e38655a
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/24814/files/2a95865ebf27ea366b7b9bd3758573b93c69ec47
Please reload this pagehttps://github.com/angular/angular/pull/24814
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Please reload this pagehttps://github.com/angular/angular/pull/24814
https://github.com/vikerman
https://github.com/mary-poppins
https://github.com/mhevery
https://github.com/alxhub
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.