René's URL Explorer Experiment


Title: Build fix and remove karma reporter by gkalpak · Pull Request #24803 · angular/angular · GitHub

Open Graph Title: Build fix and remove karma reporter by gkalpak · Pull Request #24803 · angular/angular

X Title: Build fix and remove karma reporter by gkalpak · Pull Request #24803 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type [x] Build related changes What is the current behavior? Using outdated custom karma reporter (internal-angular). Due to incompatible changes in karma@1.0.0, the reporter no longer shows browser logs (such as console.log() etc.), since upgrading to latest karma in d571a51. What is the new behavior? The first commit fixes the internal-angular reporter, so that it shows logs as usual. The second commit removes the custom reporter altogether, since it isn't needed any more. (See the commit message for more info.) Does this PR introduce a breaking change? [ ] Yes [x] No

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/24803

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5958f794-04b0-1543-b2fb-3361c6d89538
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8378:29FFA9:B18BDC:E27840:6B00F680
html-safe-nonce28a267d6958ddde9f6a86f20fc14609a1fd4548239cfe78a59cd3141f7e2e32e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mzc4OjI5RkZBOTpCMThCREM6RTI3ODQwOjZCMDBGNjgwIiwidmlzaXRvcl9pZCI6IjMzNzI0OTk5Mzg1NjE4MTYxOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacba531337a83367a3004f5def1f6733a6d78e7bed0c03c2a8fc97a393d9f399a2
hovercard-subject-tagpull_request:200128417
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/24803/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/24803/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24803%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24803%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/24803/files
Reloadhttps://github.com/angular/angular/pull/24803/files
Reloadhttps://github.com/angular/angular/pull/24803/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:build-fix-and-remove-karma-reporterhttps://github.com/gkalpak/angular/tree/build-fix-and-remove-karma-reporter
Conversation 1 https://github.com/angular/angular/pull/24803
Commits 2 https://github.com/angular/angular/pull/24803/commits
Checks 0 https://github.com/angular/angular/pull/24803/checks
Files changed https://github.com/angular/angular/pull/24803/files
Please reload this pagehttps://github.com/angular/angular/pull/24803/files
Build fix and remove karma reporter https://github.com/angular/angular/pull/24803/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/24803/files
ab42105 build: make `internal-angular` karma reporter compatible with latest … gkalpak Jul 9, 2018 https://github.com/angular/angular/pull/24803/commits/ab4210551e312469bbfc76f5a69c5235abaf0d66
ef0a6fd build: remove unnecessary `internal-angular` karma reporter gkalpak Jul 9, 2018 https://github.com/angular/angular/pull/24803/commits/ef0a6fdb2f0bcb2d6984bd0b21f903dcb6e08ad6
Clear filters https://github.com/angular/angular/pull/24803/files
Please reload this pagehttps://github.com/angular/angular/pull/24803/files
Please reload this pagehttps://github.com/angular/angular/pull/24803/files
karma-js.conf.js https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
test-saucelabs.sh https://github.com/angular/angular/pull/24803/files#diff-92be46ea07055d451cab0bc5f9a8488411957d7a9cb9e7f19fc9b2a19156dbd1
reporter.js https://github.com/angular/angular/pull/24803/files#diff-358b1a868c4e7dd286f2492ebc4825a8e5cd98b00a4704e6ce75dbfaf36a1dd1
index.ts https://github.com/angular/angular/pull/24803/files#diff-6db5aa99fb265b0753d30b987e201bf6e490fc67c5c8cd51cae53414b9c0b5e5
tsc_watch.ts https://github.com/angular/angular/pull/24803/files#diff-4f03b6d1f73d29c0ee125b731365171eb4abacb25dded79f035da4ddb06b6ee3
karma-js.conf.jshttps://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
View file https://github.com/gkalpak/angular/blob/ef0a6fdb2f0bcb2d6984bd0b21f903dcb6e08ad6/karma-js.conf.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24803/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
https://github.com/angular/angular/pull/24803/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
scripts/ci/test-saucelabs.shhttps://github.com/angular/angular/pull/24803/files#diff-92be46ea07055d451cab0bc5f9a8488411957d7a9cb9e7f19fc9b2a19156dbd1
View file https://github.com/gkalpak/angular/blob/ef0a6fdb2f0bcb2d6984bd0b21f903dcb6e08ad6/scripts/ci/test-saucelabs.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24803/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24803/files#diff-92be46ea07055d451cab0bc5f9a8488411957d7a9cb9e7f19fc9b2a19156dbd1
tools/karma/reporter.jshttps://github.com/angular/angular/pull/24803/files#diff-358b1a868c4e7dd286f2492ebc4825a8e5cd98b00a4704e6ce75dbfaf36a1dd1
View file https://github.com/angular/angular/blob/3980640d53eb8bfdfd05d590addae77d09ebf379/tools/karma/reporter.js
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/24803/files
tools/tsc-watch/index.tshttps://github.com/angular/angular/pull/24803/files#diff-6db5aa99fb265b0753d30b987e201bf6e490fc67c5c8cd51cae53414b9c0b5e5
View file https://github.com/gkalpak/angular/blob/ef0a6fdb2f0bcb2d6984bd0b21f903dcb6e08ad6/tools/tsc-watch/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24803/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24803/files#diff-6db5aa99fb265b0753d30b987e201bf6e490fc67c5c8cd51cae53414b9c0b5e5
https://github.com/angular/angular/pull/24803/files#diff-6db5aa99fb265b0753d30b987e201bf6e490fc67c5c8cd51cae53414b9c0b5e5
tools/tsc-watch/tsc_watch.tshttps://github.com/angular/angular/pull/24803/files#diff-4f03b6d1f73d29c0ee125b731365171eb4abacb25dded79f035da4ddb06b6ee3
View file https://github.com/gkalpak/angular/blob/ef0a6fdb2f0bcb2d6984bd0b21f903dcb6e08ad6/tools/tsc-watch/tsc_watch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24803/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24803/files#diff-4f03b6d1f73d29c0ee125b731365171eb4abacb25dded79f035da4ddb06b6ee3
https://github.com/angular/angular/pull/24803/files#diff-4f03b6d1f73d29c0ee125b731365171eb4abacb25dded79f035da4ddb06b6ee3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.