René's URL Explorer Experiment


Title: refactor(ivy): replace pNextOrParent with TNode props by kara · Pull Request #24752 · angular/angular · GitHub

Open Graph Title: refactor(ivy): replace pNextOrParent with TNode props by kara · Pull Request #24752 · angular/angular

X Title: refactor(ivy): replace pNextOrParent with TNode props by kara · Pull Request #24752 · angular/angular

Description: This PR reworks content projection to remove LNode.pNextOrParent. Instead, we re-assign TNode.next for projected nodes during projectionDef sorting and use a stack to keep track of the latest projection nodes when walking the node tree. This is part of a larger effort to reduce our memory footprint and eventually remove LNode. Takeaways: The projectionDef() instruction no longer requires the allocation of a data slot. The instruction can be invoked directly because the data that used to be stored there is now stored on TNode. Similarly, the projection instruction no longer requires an arg for the projection def index because this info can be retrieved using TNode props. Since we are storing projection data on the component host TNode, we only need to sort projected nodes on the first template pass. Later passes can re-use existing data.

Open Graph Description: This PR reworks content projection to remove LNode.pNextOrParent. Instead, we re-assign TNode.next for projected nodes during projectionDef sorting and use a stack to keep track of the latest proje...

X Description: This PR reworks content projection to remove LNode.pNextOrParent. Instead, we re-assign TNode.next for projected nodes during projectionDef sorting and use a stack to keep track of the latest proje...

Opengraph URL: https://github.com/angular/angular/pull/24752

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e2ca0cac-d559-eafb-5d99-e7d22d730931
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB532:B53AF:B4C020:F1DFE9:6B00F33A
html-safe-nonceaf1a36e8784361c7e1196e10c95b74d975110fc61b3d07cbc87cc37662462562
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTMyOkI1M0FGOkI0QzAyMDpGMURGRTk6NkIwMEYzM0EiLCJ2aXNpdG9yX2lkIjoiNzUzNTkxMjY2OTc1MzE3Njg5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4a7893cc080f6fb3dfae5d35c5f1a78c1684d75a06121662388ce3b7f5be934
hovercard-subject-tagpull_request:199144082
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/24752/files
twitter:imagehttps://avatars.githubusercontent.com/u/3871688?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3871688?s=400&v=4
og:image:altThis PR reworks content projection to remove LNode.pNextOrParent. Instead, we re-assign TNode.next for projected nodes during projectionDef sorting and use a stack to keep track of the latest proje...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/24752/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24752%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24752%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/24752/files
Reloadhttps://github.com/angular/angular/pull/24752/files
Reloadhttps://github.com/angular/angular/pull/24752/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
karahttps://github.com/kara
angular:masterhttps://github.com/angular/angular/tree/master
kara:pNexthttps://github.com/kara/angular/tree/pNext
Conversation 20 https://github.com/angular/angular/pull/24752
Commits 10 https://github.com/angular/angular/pull/24752/commits
Checks 0 https://github.com/angular/angular/pull/24752/checks
Files changed https://github.com/angular/angular/pull/24752/files
Please reload this pagehttps://github.com/angular/angular/pull/24752/files
refactor(ivy): replace pNextOrParent with TNode props https://github.com/angular/angular/pull/24752/files#top
Show all changes 10 commits https://github.com/angular/angular/pull/24752/files
4e2ffc2 fix(ivy): support projecting into dynamic views kara Jul 3, 2018 https://github.com/angular/angular/pull/24752/commits/4e2ffc29356bff4a40e07b15e5016dc4ef840db4
9eff8e9 refactor(ivy): replace pNextOrParent with TNode props kara Jul 4, 2018 https://github.com/angular/angular/pull/24752/commits/9eff8e964d2cbaa0f31e58f5c459fac37a39ba2e
6dc8bc2 fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 6, 2018 https://github.com/angular/angular/pull/24752/commits/6dc8bc283509163d27e26cac1cde85653adc7a50
57477cc fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 6, 2018 https://github.com/angular/angular/pull/24752/commits/57477cc1b1c976f5ada41c13977cbc5f4fe0d9a0
77a3ed8 fixup! refactor(ivy): replace pNextOrParent with TNode props mhevery Jul 7, 2018 https://github.com/angular/angular/pull/24752/commits/77a3ed8fe3dce0a9a20c1dc48bf8cc67cb1b2269
8e920db fixup! refactor(ivy): replace pNextOrParent with TNode props mhevery Jul 7, 2018 https://github.com/angular/angular/pull/24752/commits/8e920dbea26e54e2549074293630186b1b1fae03
4027280 fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 7, 2018 https://github.com/angular/angular/pull/24752/commits/4027280938c02008b13faab4a960b5c815c07555
f6bbb08 fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 9, 2018 https://github.com/angular/angular/pull/24752/commits/f6bbb088be8158f47f5852015db26773b69c1d78
9b03d77 fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 9, 2018 https://github.com/angular/angular/pull/24752/commits/9b03d7728d31d1d20d0606baa3fb04dfd8527604
c5b8049 fixup! refactor(ivy): replace pNextOrParent with TNode props kara Jul 9, 2018 https://github.com/angular/angular/pull/24752/commits/c5b8049683ca415f217ed8e8c2aa76a895638b70
Clear filters https://github.com/angular/angular/pull/24752/files
Please reload this pagehttps://github.com/angular/angular/pull/24752/files
Please reload this pagehttps://github.com/angular/angular/pull/24752/files
template.ts https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
r3_compiler_compliance_spec.ts https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
i18n.ts https://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
instructions.ts https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
node.ts https://github.com/angular/angular/pull/24752/files#diff-2a84a3d294c4f2537683c6337765a2bfada02e8a7f9a39b061d69d0cc3a1de83
projection.ts https://github.com/angular/angular/pull/24752/files#diff-11c89c52e332c6c8a3e1a3e677eef668303a9aaf342354cf9505925a8db560fa
node_manipulation.ts https://github.com/angular/angular/pull/24752/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
bundle.golden_symbols.json https://github.com/angular/angular/pull/24752/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
content_projection_spec.ts https://github.com/angular/angular/pull/24752/files#diff-b3409abdcb64735f76e2cf91cd2633dbd05427b03975df0e3495abce4ed3f87b
query_spec.ts https://github.com/angular/angular/pull/24752/files#diff-b4846670eeb7dc11338987efa1ed1cfaf5eb24d006a2bac905d7dcabf45bff7a
content_spec.ts https://github.com/angular/angular/pull/24752/files#diff-6e3cf2036d9ae74ba5dc4c05a7cead64b45265ef6c1a9c85bd838813db429028
di_spec.ts https://github.com/angular/angular/pull/24752/files#diff-5d2f4a213c07bcfef1ee8a1f00e2f548878acb8a86eb6f3e8cf49eb81982b890
i18n_spec.ts https://github.com/angular/angular/pull/24752/files#diff-84da0a6c098802842313ab3dff8c314d0b832a4883db66cfc234eb88cdd1f1b4
integration_spec.ts https://github.com/angular/angular/pull/24752/files#diff-2259816480187d7b1e935e7b80bdc7bbb67e923a166c54c6b077459017b10654
lifecycle_spec.ts https://github.com/angular/angular/pull/24752/files#diff-e8e3966a05cb7c05939b8be5c6377e3dbd6d96506898f2ef9f94838013577310
node_selector_matcher_spec.ts https://github.com/angular/angular/pull/24752/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
view_container_ref_spec.ts https://github.com/angular/angular/pull/24752/files#diff-bc0c5f246d091099ca9f36ead2413e49c43d6d64ed6def1f49fb0a69caf7aa2b
packages/compiler/src/render3/view/template.tshttps://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
View file https://github.com/kara/angular/blob/c5b8049683ca415f217ed8e8c2aa76a895638b70/packages/compiler/src/render3/view/template.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/24752/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
packages/compiler/test/render3/r3_compiler_compliance_spec.tshttps://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
View file https://github.com/kara/angular/blob/c5b8049683ca415f217ed8e8c2aa76a895638b70/packages/compiler/test/render3/r3_compiler_compliance_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
https://github.com/angular/angular/pull/24752/files#diff-6652e65c1d278d8518372336c800886041d3b20f89ebbc347825db2191ce1671
packages/core/src/render3/i18n.tshttps://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
View file https://github.com/kara/angular/blob/c5b8049683ca415f217ed8e8c2aa76a895638b70/packages/core/src/render3/i18n.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
https://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
https://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
https://github.com/angular/angular/pull/24752/files#diff-5bd2d65569b1a2b90ce3a326fe46a4fdf452126950215ca6b69c1fca699f5fe5
packages/core/src/render3/instructions.tshttps://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
View file https://github.com/kara/angular/blob/c5b8049683ca415f217ed8e8c2aa76a895638b70/packages/core/src/render3/instructions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/24752/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
Please reload this pagehttps://github.com/angular/angular/pull/24752/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.