René's URL Explorer Experiment


Title: fix(service-worker): avoid network requests when looking up hashed resources in cache by gkalpak · Pull Request #24127 · angular/angular · GitHub

Open Graph Title: fix(service-worker): avoid network requests when looking up hashed resources in cache by gkalpak · Pull Request #24127 · angular/angular

X Title: fix(service-worker): avoid network requests when looking up hashed resources in cache by gkalpak · Pull Request #24127 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type [x] Bugfix [x] Refactoring (no functional changes, no api changes) What is the current behavior? Calling lookupResourceWithHash() might make a network request if a lazy asset-group of a previous version matches the URL. This is unintended, because lookupResourceWithHash() is supposed to retrieve resources from cache. This also affected lazy asset-groups, which ended up prefetching all of their matched resources. What is the new behavior? Calling lookupResourceWithHash() does not make a network request and only retrieves resources from the cache. Does this PR introduce a breaking change? [ ] Yes [x] No

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/24127

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b9837d64-1af6-f9e0-847c-9b4fcfddd8c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3D4:291B58:C4553:F7BD1:6B00F6DA
html-safe-nonce9d68f07c54b61c147bfac3a867fb29285e314ba95ffa0a2bf2233810340cc6b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0Q0OjI5MUI1ODpDNDU1MzpGN0JEMTo2QjAwRjZEQSIsInZpc2l0b3JfaWQiOiI1OTM0NTc4MDQyMzY1MDgxMzA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6bef8da32950eed29bb93122322d75457fa093587a1e9f627e287be0a2c3629d
hovercard-subject-tagpull_request:190571277
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/24127/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/24127/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24127%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F24127%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/24127/files
Reloadhttps://github.com/angular/angular/pull/24127/files
Reloadhttps://github.com/angular/angular/pull/24127/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-lazy-groupshttps://github.com/gkalpak/angular/tree/fix-sw-lazy-groups
Conversation 11 https://github.com/angular/angular/pull/24127
Commits 2 https://github.com/angular/angular/pull/24127/commits
Checks 0 https://github.com/angular/angular/pull/24127/checks
Files changed https://github.com/angular/angular/pull/24127/files
Please reload this pagehttps://github.com/angular/angular/pull/24127/files
fix(service-worker): avoid network requests when looking up hashed resources in cache https://github.com/angular/angular/pull/24127/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/24127/files
101015f refactor(service-worker): avoid unnecessary operations and remove unu… gkalpak May 25, 2018 https://github.com/angular/angular/pull/24127/commits/101015f41b48b6ff948ca8e468b85c567f7c5bd3
3743f97 fix(service-worker): avoid network requests when looking up hashed re… gkalpak May 25, 2018 https://github.com/angular/angular/pull/24127/commits/3743f97f934f3a11f60e9cd079ed76dad5a5060f
Clear filters https://github.com/angular/angular/pull/24127/files
Please reload this pagehttps://github.com/angular/angular/pull/24127/files
Please reload this pagehttps://github.com/angular/angular/pull/24127/files
app-version.ts https://github.com/angular/angular/pull/24127/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
driver.ts https://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
happy_spec.ts https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
packages/service-worker/worker/src/app-version.tshttps://github.com/angular/angular/pull/24127/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
View file https://github.com/gkalpak/angular/blob/3743f97f934f3a11f60e9cd079ed76dad5a5060f/packages/service-worker/worker/src/app-version.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24127/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24127/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
https://github.com/angular/angular/pull/24127/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
https://github.com/angular/angular/pull/24127/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
packages/service-worker/worker/src/driver.tshttps://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
View file https://github.com/gkalpak/angular/blob/3743f97f934f3a11f60e9cd079ed76dad5a5060f/packages/service-worker/worker/src/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24127/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
alxhubhttps://github.com/alxhub
Jul 3, 2018https://github.com/angular/angular/pull/24127/files#r199961459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/24127/files
https://github.com/angular/angular/pull/24127/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
packages/service-worker/worker/test/happy_spec.tshttps://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
View file https://github.com/gkalpak/angular/blob/3743f97f934f3a11f60e9cd079ed76dad5a5060f/packages/service-worker/worker/test/happy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/24127/{{ revealButtonHref }}
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/24127/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.