René's URL Explorer Experiment


Title: fix(aio): show embedded ToC (and other fixes) by gkalpak · Pull Request #23944 · angular/angular · GitHub

Open Graph Title: fix(aio): show embedded ToC (and other fixes) by gkalpak · Pull Request #23944 · angular/angular

X Title: fix(aio): show embedded ToC (and other fixes) by gkalpak · Pull Request #23944 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The main thing this PR fixes is showing the embedded ToC in narrow screens. On narrow screens (where there is not enough room on the right to show the floating ToC), an embedded ToC is shown (via a...

X Description: The main thing this PR fixes is showing the embedded ToC in narrow screens. On narrow screens (where there is not enough room on the right to show the floating ToC), an embedded ToC is shown (via a...

Opengraph URL: https://github.com/angular/angular/pull/23944

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d5ac470-38af-eefe-a1e4-59835b7a8490
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA06:169F0D:286F52:3796B2:6A61620D
html-safe-nonceecae7f9bd4023823f30a1dc3331c6015c13816bdf0322d206daca904d3390d03
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTA2OjE2OUYwRDoyODZGNTI6Mzc5NkIyOjZBNjE2MjBEIiwidmlzaXRvcl9pZCI6IjMwMzA4OTc1NTAwMDA0ODA3ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8324ce815eeb254f1cd986270f900002fa4346a4678c2b6b67c85658d490656a
hovercard-subject-tagpull_request:188514905
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/23944/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e371c2ed90d2a8829a792c46a36d03f8f7ce7c02684080798b90fc795ea5e68e/angular/angular/pull/23944
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e371c2ed90d2a8829a792c46a36d03f8f7ce7c02684080798b90fc795ea5e68e/angular/angular/pull/23944
og:image:altThe main thing this PR fixes is showing the embedded ToC in narrow screens. On narrow screens (where there is not enough room on the right to show the floating ToC), an embedded ToC is shown (via a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonec258d2b06b498220e3b94af28b26bbbf58f4203a6373725f779afcc867afd263
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5f67bc431418961e0814f1eb30a4231250e4726d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/23944#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23944
Reloadhttps://github.com/angular/angular/pull/23944
Reloadhttps://github.com/angular/angular/pull/23944
Please reload this pagehttps://github.com/angular/angular/pull/23944
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.5k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 978 https://github.com/angular/angular/issues
Pull requests 161 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-aio-embedded-tochttps://github.com/gkalpak/angular/tree/fix-aio-embedded-toc
Conversationhttps://github.com/angular/angular/pull/23944
Commits12 (12)https://github.com/angular/angular/pull/23944/commits
Checkshttps://github.com/angular/angular/pull/23944/checks
Files changedhttps://github.com/angular/angular/pull/23944/files
fix(aio): show embedded ToC (and other fixes)https://github.com/angular/angular/pull/23944#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-aio-embedded-tochttps://github.com/gkalpak/angular/tree/fix-aio-embedded-toc
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 16, 2018https://github.com/angular/angular/pull/23944#issue-323727800
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 16, 2018https://github.com/angular/angular/pull/23944#event-1630249397
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
comp: aio https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
May 16, 2018https://github.com/angular/angular/pull/23944#event-1630249895
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 16, 2018https://github.com/angular/angular/pull/23944#issuecomment-389613128
LazyCustomElementComponenthttps://github.com/angular/angular/pull/23944/commits/1a607e011ac9d9795e82cde5b923ab0cc3e78cca#diff-92f5584a0ad28a4ebbebc9bae41d26f0
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 16, 2018https://github.com/angular/angular/pull/23944#issuecomment-389616020
https://pr23944-e6204c6.ngbuilds.io/https://pr23944-e6204c6.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-121799282
View reviewed changes https://github.com/angular/angular/pull/23944/files
aio/src/app/custom-elements/elements-loader.tshttps://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189591332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189807893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
LazyCustomElementComponenthttps://github.com/angular/angular/pull/23944/commits/1a607e011ac9d9795e82cde5b923ab0cc3e78cca#diff-92f5584a0ad28a4ebbebc9bae41d26f0
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189819912
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189843814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-121800251
View reviewed changes https://github.com/angular/angular/pull/23944/files
aio/src/app/custom-elements/elements-loader.tshttps://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189592042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189807947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/angular/angular/pull/23944/files#r189807893https://github.com/angular/angular/pull/23944/files#r189807893
Please reload this pagehttps://github.com/angular/angular/pull/23944
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189843927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-121802812
View reviewed changes https://github.com/angular/angular/pull/23944/files
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189594093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189920072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-121803608
View reviewed changes https://github.com/angular/angular/pull/23944/files
aio/src/app/custom-elements/elements-loader.tshttps://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189594732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-121804098
View reviewed changes https://github.com/angular/angular/pull/23944/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/23944#pullrequestreview-121804098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189595148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189806145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189912635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189595824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189596262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189608934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189812692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
previous implementationhttps://github.com/angular/angular/pull/23944/files#diff-fc503f29d75fcbafa5044f3928565129L45
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189918939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189610347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 21, 2018https://github.com/angular/angular/pull/23944#discussion_r189611534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189810764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2018https://github.com/angular/angular/pull/23944#discussion_r189845841
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-390937713
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-390974177
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-390976931
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-390978024
Please reload this pagehttps://github.com/angular/angular/pull/23944
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-391022375
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 22, 2018https://github.com/angular/angular/pull/23944#issuecomment-391090037
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/e6204c618fd328cd1ad556bd46f7ecac4d038de7..41ddc300853b02e2efd2bb958cf33e26625b0575
e6204c6https://github.com/angular/angular/commit/e6204c618fd328cd1ad556bd46f7ecac4d038de7
41ddc30https://github.com/angular/angular/commit/41ddc300853b02e2efd2bb958cf33e26625b0575
Compare https://github.com/angular/angular/compare/e6204c618fd328cd1ad556bd46f7ecac4d038de7..41ddc300853b02e2efd2bb958cf33e26625b0575
May 23, 2018 08:23https://github.com/angular/angular/pull/23944#event-1641160838
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 23, 2018https://github.com/angular/angular/pull/23944#issuecomment-391271653
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/41ddc300853b02e2efd2bb958cf33e26625b0575..ccd81486068a97309ceff9c5b6032079cc598d7d
41ddc30https://github.com/angular/angular/commit/41ddc300853b02e2efd2bb958cf33e26625b0575
ccd8148https://github.com/angular/angular/commit/ccd81486068a97309ceff9c5b6032079cc598d7d
Compare https://github.com/angular/angular/compare/41ddc300853b02e2efd2bb958cf33e26625b0575..ccd81486068a97309ceff9c5b6032079cc598d7d
May 23, 2018 08:53https://github.com/angular/angular/pull/23944#event-1641226023
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 23, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-122584116
View reviewed changes https://github.com/angular/angular/pull/23944/files
aio/src/app/custom-elements/elements-loader.spec.tshttps://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e
petebacondarwinhttps://github.com/petebacondarwin
May 23, 2018https://github.com/angular/angular/pull/23944#discussion_r190246190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 23, 2018https://github.com/angular/angular/pull/23944#discussion_r190264068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 23, 2018 https://github.com/angular/angular/pull/23944#pullrequestreview-122584375
View reviewed changes https://github.com/angular/angular/pull/23944/files
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
May 23, 2018https://github.com/angular/angular/pull/23944#event-1641800590
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
May 23, 2018https://github.com/angular/angular/pull/23944#issuecomment-391347538
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 23, 2018https://github.com/angular/angular/pull/23944#issuecomment-391353331
https://pr23944-ccd8148.ngbuilds.io/https://pr23944-ccd8148.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 23, 2018https://github.com/angular/angular/pull/23944#issuecomment-391369096
https://pr23944-a807ef6.ngbuilds.io/https://pr23944-a807ef6.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/23944
gkalpakhttps://github.com/gkalpak
May 24, 2018 12:23https://github.com/angular/angular/pull/23944#commits-pushed-c534a7e
https://github.com/gkalpak
build(aio): update payload size limitshttps://github.com/angular/angular/pull/23944/commits/c534a7ebdaff9d2954dbf9375ea5fb07fca28b4d
c534a7ehttps://github.com/angular/angular/pull/23944/commits/c534a7ebdaff9d2954dbf9375ea5fb07fca28b4d
https://github.com/gkalpak
fix(aio): do not load custom elements again while already loadinghttps://github.com/angular/angular/pull/23944/commits/81dc4396ab1682b469d31559ca60a55eb481e2ad
81dc439https://github.com/angular/angular/pull/23944/commits/81dc4396ab1682b469d31559ca60a55eb481e2ad
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/a807ef6be851ea5e6675bbcb22984974850636f3..5531d203a122ba89927badd367f4eb75ed31454d
a807ef6https://github.com/angular/angular/commit/a807ef6be851ea5e6675bbcb22984974850636f3
5531d20https://github.com/angular/angular/commit/5531d203a122ba89927badd367f4eb75ed31454d
Compare https://github.com/angular/angular/compare/a807ef6be851ea5e6675bbcb22984974850636f3..5531d203a122ba89927badd367f4eb75ed31454d
May 24, 2018 10:47https://github.com/angular/angular/pull/23944#event-1643927699
gkalpakhttps://github.com/gkalpak
May 25, 2018 10:40https://github.com/angular/angular/pull/23944#commits-pushed-35ae767
https://github.com/gkalpak
fixup! fix(aio): do not load custom elements again while already loadinghttps://github.com/angular/angular/pull/23944/commits/35ae7672808e03a8a2783f15362979748144f9d1
35ae767https://github.com/angular/angular/pull/23944/commits/35ae7672808e03a8a2783f15362979748144f9d1
https://github.com/gkalpak
refactor(aio): order custom elements by selectorhttps://github.com/angular/angular/pull/23944/commits/90e10ad19430714dfb10245f0d9eef2bcc8b031f
90e10adhttps://github.com/angular/angular/pull/23944/commits/90e10ad19430714dfb10245f0d9eef2bcc8b031f
https://github.com/gkalpak
fixup! fix(aio): show embedded ToChttps://github.com/angular/angular/pull/23944/commits/dfbff1d5432fa6dc4df2ef1414b89c1c363840b5
dfbff1dhttps://github.com/angular/angular/pull/23944/commits/dfbff1d5432fa6dc4df2ef1414b89c1c363840b5
https://github.com/gkalpak
fix(aio): avoid loading the ToC component until it is necessaryhttps://github.com/angular/angular/pull/23944/commits/50320c901989d71470392882a3435ca9d4f4cd5f
50320c9https://github.com/angular/angular/pull/23944/commits/50320c901989d71470392882a3435ca9d4f4cd5f
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/5531d203a122ba89927badd367f4eb75ed31454d..0923da60783c890536b96aa5a2e678094ddab280
5531d20https://github.com/angular/angular/commit/5531d203a122ba89927badd367f4eb75ed31454d
0923da6https://github.com/angular/angular/commit/0923da60783c890536b96aa5a2e678094ddab280
Compare https://github.com/angular/angular/compare/5531d203a122ba89927badd367f4eb75ed31454d..0923da60783c890536b96aa5a2e678094ddab280
May 25, 2018 07:44https://github.com/angular/angular/pull/23944#event-1646005823
https://github.com/gkalpak
fixup! refactor(aio): rename method (loadContainingCustomElements -->…https://github.com/angular/angular/pull/23944/commits/38621f38f02cdcf66df4147bd3d231cb240deed4
38621f3https://github.com/angular/angular/pull/23944/commits/38621f38f02cdcf66df4147bd3d231cb240deed4
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/0923da60783c890536b96aa5a2e678094ddab280..38621f38f02cdcf66df4147bd3d231cb240deed4
0923da6https://github.com/angular/angular/commit/0923da60783c890536b96aa5a2e678094ddab280
38621f3https://github.com/angular/angular/commit/38621f38f02cdcf66df4147bd3d231cb240deed4
Compare https://github.com/angular/angular/compare/0923da60783c890536b96aa5a2e678094ddab280..38621f38f02cdcf66df4147bd3d231cb240deed4
May 25, 2018 07:46https://github.com/angular/angular/pull/23944#event-1646008754
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 25, 2018https://github.com/angular/angular/pull/23944#issuecomment-391972226
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 25, 2018https://github.com/angular/angular/pull/23944#issuecomment-391973585
https://pr23944-0923da6.ngbuilds.io/https://pr23944-0923da6.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 25, 2018https://github.com/angular/angular/pull/23944#issuecomment-391973827
38621f3https://github.com/angular/angular/commit/38621f38f02cdcf66df4147bd3d231cb240deed4
https://pr23944-38621f3.ngbuilds.io/https://pr23944-38621f3.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
May 25, 2018https://github.com/angular/angular/pull/23944#event-1646356830
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-8fef926
https://github.com/gkalpak
https://github.com/matsko
build(aio): update payload size limits (https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5
8fef926https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-6e31e22
https://github.com/gkalpak
https://github.com/matsko
fix(aio): do not load custom elements again while already loading (https://github.com/angular/angular/commit/6e31e22d4189ce2ce52ea9118de36bc7caaf8273
#2…https://github.com/angular/angular/pull/23944
6e31e22https://github.com/angular/angular/commit/6e31e22d4189ce2ce52ea9118de36bc7caaf8273
…3944https://github.com/angular/angular/pull/23944
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-434eb97
https://github.com/gkalpak
https://github.com/matsko
refactor(aio): order custom elements by selector (https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8
434eb97https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-c30fc52
https://github.com/gkalpak
https://github.com/matsko
feat(aio): add component for lazy-loading custom element (https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a
c30fc52https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-715135b
https://github.com/gkalpak
https://github.com/matsko
fix(aio): show embedded ToC (https://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b
715135bhttps://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-efa126f
https://github.com/gkalpak
https://github.com/matsko
fix(aio): avoid loading the ToC component until it is necessary (https://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4
efa126fhttps://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-f860752
https://github.com/gkalpak
https://github.com/matsko
refactor(aio): rename method (loadContainingCustomElements --> loadCo…https://github.com/angular/angular/commit/f860752902f96e28ffe6cdcfe9770b2d3cf71d3d
f860752https://github.com/angular/angular/commit/f860752902f96e28ffe6cdcfe9770b2d3cf71d3d
#23944https://github.com/angular/angular/pull/23944
#23944https://github.com/angular/angular/pull/23944
https://github.com/matsko
matskohttps://github.com/matsko
a6f34behttps://github.com/angular/angular/commit/a6f34be9f598bfa45abbb8426dddd46f6ed1e4e3
May 29, 2018https://github.com/angular/angular/pull/23944#event-1652234366
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-ae86cb3
https://github.com/gkalpak
https://github.com/matsko
fix(aio): do not load custom elements again while already loading (https://github.com/angular/angular/commit/ae86cb3be0c413544f8b17cfcd0e29ae21655b4c
#2…https://github.com/angular/angular/pull/23944
ae86cb3https://github.com/angular/angular/commit/ae86cb3be0c413544f8b17cfcd0e29ae21655b4c
…3944https://github.com/angular/angular/pull/23944
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-7a9c987
https://github.com/gkalpak
https://github.com/matsko
refactor(aio): order custom elements by selector (https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be
7a9c987https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-431a42a
https://github.com/gkalpak
https://github.com/matsko
feat(aio): add component for lazy-loading custom element (https://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595
431a42ahttps://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-6e05ae0
https://github.com/gkalpak
https://github.com/matsko
fix(aio): show embedded ToC (https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6
6e05ae0https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-7866684
https://github.com/gkalpak
https://github.com/matsko
fix(aio): avoid loading the ToC component until it is necessary (https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e
#23944https://github.com/angular/angular/pull/23944
)https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e
7866684https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e
#23944https://github.com/angular/angular/pull/23944
matskohttps://github.com/matsko
May 29, 2018 https://github.com/angular/angular/pull/23944#ref-commit-c2e1311
https://github.com/gkalpak
https://github.com/matsko
refactor(aio): rename method (loadContainingCustomElements --> loadCo…https://github.com/angular/angular/commit/c2e131119bedbb9761dcc88fae6c12cbdef25e07
c2e1311https://github.com/angular/angular/commit/c2e131119bedbb9761dcc88fae6c12cbdef25e07
#23944https://github.com/angular/angular/pull/23944
#23944https://github.com/angular/angular/pull/23944
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 30, 2018 07:44https://github.com/angular/angular/pull/23944#event-1652853085
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/23944#issuecomment-531311601
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/23944#event-2632955059
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/23944/files/ccd81486068a97309ceff9c5b6032079cc598d7d
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Please reload this pagehttps://github.com/angular/angular/pull/23944
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.