| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d5ac470-38af-eefe-a1e4-59835b7a8490 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA06:169F0D:286F52:3796B2:6A61620D |
| html-safe-nonce | ecae7f9bd4023823f30a1dc3331c6015c13816bdf0322d206daca904d3390d03 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTA2OjE2OUYwRDoyODZGNTI6Mzc5NkIyOjZBNjE2MjBEIiwidmlzaXRvcl9pZCI6IjMwMzA4OTc1NTAwMDA0ODA3ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8324ce815eeb254f1cd986270f900002fa4346a4678c2b6b67c85658d490656a |
| hovercard-subject-tag | pull_request:188514905 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/23944/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e371c2ed90d2a8829a792c46a36d03f8f7ce7c02684080798b90fc795ea5e68e/angular/angular/pull/23944 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e371c2ed90d2a8829a792c46a36d03f8f7ce7c02684080798b90fc795ea5e68e/angular/angular/pull/23944 |
| og:image:alt | The main thing this PR fixes is showing the embedded ToC in narrow screens.
On narrow screens (where there is not enough room on the right to show the floating ToC), an embedded ToC is shown (via a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | c258d2b06b498220e3b94af28b26bbbf58f4203a6373725f779afcc867afd263 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5f67bc431418961e0814f1eb30a4231250e4726d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/23944#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/23944 |
| Reload | https://github.com/angular/angular/pull/23944 |
| Reload | https://github.com/angular/angular/pull/23944 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27.5k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
101k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
978
| https://github.com/angular/angular/issues |
|
Pull requests
161
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
24
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-aio-embedded-toc | https://github.com/gkalpak/angular/tree/fix-aio-embedded-toc |
| Conversation | https://github.com/angular/angular/pull/23944 |
| Commits12 (12) | https://github.com/angular/angular/pull/23944/commits |
| Checks | https://github.com/angular/angular/pull/23944/checks |
| Files changed | https://github.com/angular/angular/pull/23944/files |
| fix(aio): show embedded ToC (and other fixes) | https://github.com/angular/angular/pull/23944#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-aio-embedded-toc | https://github.com/gkalpak/angular/tree/fix-aio-embedded-toc |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 16, 2018 | https://github.com/angular/angular/pull/23944#issue-323727800 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| May 16, 2018 | https://github.com/angular/angular/pull/23944#event-1630249397 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
comp: aio
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| May 16, 2018 | https://github.com/angular/angular/pull/23944#event-1630249895 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 16, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-389613128 |
| LazyCustomElementComponent | https://github.com/angular/angular/pull/23944/commits/1a607e011ac9d9795e82cde5b923ab0cc3e78cca#diff-92f5584a0ad28a4ebbebc9bae41d26f0 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 16, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-389616020 |
| https://pr23944-e6204c6.ngbuilds.io/ | https://pr23944-e6204c6.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 21, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-121799282 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| aio/src/app/custom-elements/elements-loader.ts | https://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189591332 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189807893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| LazyCustomElementComponent | https://github.com/angular/angular/pull/23944/commits/1a607e011ac9d9795e82cde5b923ab0cc3e78cca#diff-92f5584a0ad28a4ebbebc9bae41d26f0 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189819912 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| petebacondarwin | https://github.com/petebacondarwin |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189843814 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 21, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-121800251 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| aio/src/app/custom-elements/elements-loader.ts | https://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189592042 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189807947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/angular/angular/pull/23944/files#r189807893 | https://github.com/angular/angular/pull/23944/files#r189807893 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| petebacondarwin | https://github.com/petebacondarwin |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189843927 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 21, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-121802812 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189594093 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189920072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 21, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-121803608 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| aio/src/app/custom-elements/elements-loader.ts | https://github.com/angular/angular/pull/23944/files#diff-9f384d35430e2f285343a82d1d3407d0a2dfa16b2683ec43752a2cbfb98e609c |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189594732 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 21, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-121804098 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/23944#pullrequestreview-121804098 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189595148 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189806145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189912635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189595824 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189596262 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189608934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189812692 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| previous implementation | https://github.com/angular/angular/pull/23944/files#diff-fc503f29d75fcbafa5044f3928565129L45 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189918939 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189610347 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 21, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189611534 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189810764 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| petebacondarwin | https://github.com/petebacondarwin |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#discussion_r189845841 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-390937713 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-390974177 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-390976931 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-390978024 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391022375 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 22, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391090037 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/e6204c618fd328cd1ad556bd46f7ecac4d038de7..41ddc300853b02e2efd2bb958cf33e26625b0575 |
| e6204c6 | https://github.com/angular/angular/commit/e6204c618fd328cd1ad556bd46f7ecac4d038de7 |
| 41ddc30 | https://github.com/angular/angular/commit/41ddc300853b02e2efd2bb958cf33e26625b0575 |
|
Compare
| https://github.com/angular/angular/compare/e6204c618fd328cd1ad556bd46f7ecac4d038de7..41ddc300853b02e2efd2bb958cf33e26625b0575 |
| May 23, 2018 08:23 | https://github.com/angular/angular/pull/23944#event-1641160838 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391271653 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/41ddc300853b02e2efd2bb958cf33e26625b0575..ccd81486068a97309ceff9c5b6032079cc598d7d |
| 41ddc30 | https://github.com/angular/angular/commit/41ddc300853b02e2efd2bb958cf33e26625b0575 |
| ccd8148 | https://github.com/angular/angular/commit/ccd81486068a97309ceff9c5b6032079cc598d7d |
|
Compare
| https://github.com/angular/angular/compare/41ddc300853b02e2efd2bb958cf33e26625b0575..ccd81486068a97309ceff9c5b6032079cc598d7d |
| May 23, 2018 08:53 | https://github.com/angular/angular/pull/23944#event-1641226023 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 23, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-122584116 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| aio/src/app/custom-elements/elements-loader.spec.ts | https://github.com/angular/angular/pull/23944/files#diff-c0d7c47703493dcba3b1f18888e1d11fd0bba1b6379d4bfd9ef587ec0aab3a7e |
| petebacondarwin | https://github.com/petebacondarwin |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#discussion_r190246190 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#discussion_r190264068 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
May 23, 2018
| https://github.com/angular/angular/pull/23944#pullrequestreview-122584375 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23944/files |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#event-1641800590 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391347538 |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391353331 |
| https://pr23944-ccd8148.ngbuilds.io/ | https://pr23944-ccd8148.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 23, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391369096 |
| https://pr23944-a807ef6.ngbuilds.io/ | https://pr23944-a807ef6.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| gkalpak | https://github.com/gkalpak |
| May 24, 2018 12:23 | https://github.com/angular/angular/pull/23944#commits-pushed-c534a7e |
|
| https://github.com/gkalpak |
| build(aio): update payload size limits | https://github.com/angular/angular/pull/23944/commits/c534a7ebdaff9d2954dbf9375ea5fb07fca28b4d |
| c534a7e | https://github.com/angular/angular/pull/23944/commits/c534a7ebdaff9d2954dbf9375ea5fb07fca28b4d |
|
| https://github.com/gkalpak |
| fix(aio): do not load custom elements again while already loading | https://github.com/angular/angular/pull/23944/commits/81dc4396ab1682b469d31559ca60a55eb481e2ad |
| 81dc439 | https://github.com/angular/angular/pull/23944/commits/81dc4396ab1682b469d31559ca60a55eb481e2ad |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/a807ef6be851ea5e6675bbcb22984974850636f3..5531d203a122ba89927badd367f4eb75ed31454d |
| a807ef6 | https://github.com/angular/angular/commit/a807ef6be851ea5e6675bbcb22984974850636f3 |
| 5531d20 | https://github.com/angular/angular/commit/5531d203a122ba89927badd367f4eb75ed31454d |
|
Compare
| https://github.com/angular/angular/compare/a807ef6be851ea5e6675bbcb22984974850636f3..5531d203a122ba89927badd367f4eb75ed31454d |
| May 24, 2018 10:47 | https://github.com/angular/angular/pull/23944#event-1643927699 |
| gkalpak | https://github.com/gkalpak |
| May 25, 2018 10:40 | https://github.com/angular/angular/pull/23944#commits-pushed-35ae767 |
|
| https://github.com/gkalpak |
| fixup! fix(aio): do not load custom elements again while already loading | https://github.com/angular/angular/pull/23944/commits/35ae7672808e03a8a2783f15362979748144f9d1 |
| 35ae767 | https://github.com/angular/angular/pull/23944/commits/35ae7672808e03a8a2783f15362979748144f9d1 |
|
| https://github.com/gkalpak |
| refactor(aio): order custom elements by selector | https://github.com/angular/angular/pull/23944/commits/90e10ad19430714dfb10245f0d9eef2bcc8b031f |
| 90e10ad | https://github.com/angular/angular/pull/23944/commits/90e10ad19430714dfb10245f0d9eef2bcc8b031f |
|
| https://github.com/gkalpak |
| fixup! fix(aio): show embedded ToC | https://github.com/angular/angular/pull/23944/commits/dfbff1d5432fa6dc4df2ef1414b89c1c363840b5 |
| dfbff1d | https://github.com/angular/angular/pull/23944/commits/dfbff1d5432fa6dc4df2ef1414b89c1c363840b5 |
|
| https://github.com/gkalpak |
| fix(aio): avoid loading the ToC component until it is necessary | https://github.com/angular/angular/pull/23944/commits/50320c901989d71470392882a3435ca9d4f4cd5f |
| 50320c9 | https://github.com/angular/angular/pull/23944/commits/50320c901989d71470392882a3435ca9d4f4cd5f |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/5531d203a122ba89927badd367f4eb75ed31454d..0923da60783c890536b96aa5a2e678094ddab280 |
| 5531d20 | https://github.com/angular/angular/commit/5531d203a122ba89927badd367f4eb75ed31454d |
| 0923da6 | https://github.com/angular/angular/commit/0923da60783c890536b96aa5a2e678094ddab280 |
|
Compare
| https://github.com/angular/angular/compare/5531d203a122ba89927badd367f4eb75ed31454d..0923da60783c890536b96aa5a2e678094ddab280 |
| May 25, 2018 07:44 | https://github.com/angular/angular/pull/23944#event-1646005823 |
|
| https://github.com/gkalpak |
| fixup! refactor(aio): rename method (loadContainingCustomElements -->… | https://github.com/angular/angular/pull/23944/commits/38621f38f02cdcf66df4147bd3d231cb240deed4 |
| 38621f3 | https://github.com/angular/angular/pull/23944/commits/38621f38f02cdcf66df4147bd3d231cb240deed4 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/0923da60783c890536b96aa5a2e678094ddab280..38621f38f02cdcf66df4147bd3d231cb240deed4 |
| 0923da6 | https://github.com/angular/angular/commit/0923da60783c890536b96aa5a2e678094ddab280 |
| 38621f3 | https://github.com/angular/angular/commit/38621f38f02cdcf66df4147bd3d231cb240deed4 |
|
Compare
| https://github.com/angular/angular/compare/0923da60783c890536b96aa5a2e678094ddab280..38621f38f02cdcf66df4147bd3d231cb240deed4 |
| May 25, 2018 07:46 | https://github.com/angular/angular/pull/23944#event-1646008754 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 25, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391972226 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 25, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391973585 |
| https://pr23944-0923da6.ngbuilds.io/ | https://pr23944-0923da6.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 25, 2018 | https://github.com/angular/angular/pull/23944#issuecomment-391973827 |
| 38621f3 | https://github.com/angular/angular/commit/38621f38f02cdcf66df4147bd3d231cb240deed4 |
| https://pr23944-38621f3.ngbuilds.io/ | https://pr23944-38621f3.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| May 25, 2018 | https://github.com/angular/angular/pull/23944#event-1646356830 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-8fef926 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| build(aio): update payload size limits ( | https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5 |
| 8fef926 | https://github.com/angular/angular/commit/8fef926cd2db94de844737510a083bfff46694e5 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-6e31e22 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): do not load custom elements again while already loading ( | https://github.com/angular/angular/commit/6e31e22d4189ce2ce52ea9118de36bc7caaf8273 |
| #2… | https://github.com/angular/angular/pull/23944 |
| 6e31e22 | https://github.com/angular/angular/commit/6e31e22d4189ce2ce52ea9118de36bc7caaf8273 |
| …3944 | https://github.com/angular/angular/pull/23944 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-434eb97 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| refactor(aio): order custom elements by selector ( | https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8 |
| 434eb97 | https://github.com/angular/angular/commit/434eb971e4336f2740c448740ce6959c45c8e0a8 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-c30fc52 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| feat(aio): add component for lazy-loading custom element ( | https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a |
| c30fc52 | https://github.com/angular/angular/commit/c30fc52d99fb18d77461050d6b79e90f55ef604a |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-715135b |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): show embedded ToC ( | https://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b |
| 715135b | https://github.com/angular/angular/commit/715135b117b3a8d84d40cd16557dadb8cfbb211b |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-efa126f |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): avoid loading the ToC component until it is necessary ( | https://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4 |
| efa126f | https://github.com/angular/angular/commit/efa126f1572d91764882581c4c006a935b4e7ad4 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-f860752 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| refactor(aio): rename method (loadContainingCustomElements --> loadCo… | https://github.com/angular/angular/commit/f860752902f96e28ffe6cdcfe9770b2d3cf71d3d |
| f860752 | https://github.com/angular/angular/commit/f860752902f96e28ffe6cdcfe9770b2d3cf71d3d |
| #23944 | https://github.com/angular/angular/pull/23944 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| https://github.com/matsko |
| matsko | https://github.com/matsko |
| a6f34be | https://github.com/angular/angular/commit/a6f34be9f598bfa45abbb8426dddd46f6ed1e4e3 |
| May 29, 2018 | https://github.com/angular/angular/pull/23944#event-1652234366 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-ae86cb3 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): do not load custom elements again while already loading ( | https://github.com/angular/angular/commit/ae86cb3be0c413544f8b17cfcd0e29ae21655b4c |
| #2… | https://github.com/angular/angular/pull/23944 |
| ae86cb3 | https://github.com/angular/angular/commit/ae86cb3be0c413544f8b17cfcd0e29ae21655b4c |
| …3944 | https://github.com/angular/angular/pull/23944 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-7a9c987 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| refactor(aio): order custom elements by selector ( | https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be |
| 7a9c987 | https://github.com/angular/angular/commit/7a9c987e560643eea3ff2c65768a2235dcb727be |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-431a42a |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| feat(aio): add component for lazy-loading custom element ( | https://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595 |
| 431a42a | https://github.com/angular/angular/commit/431a42a238863f4b436e3cc88950eafb9e555595 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-6e05ae0 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): show embedded ToC ( | https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6 |
| 6e05ae0 | https://github.com/angular/angular/commit/6e05ae02a2bcc054043f1e3380dd326a08bc65f6 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-7866684 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| fix(aio): avoid loading the ToC component until it is necessary ( | https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e |
| #23944 | https://github.com/angular/angular/pull/23944 |
| ) | https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e |
| 7866684 | https://github.com/angular/angular/commit/7866684f2b7b5de2d911f18934638d8509361c3e |
| #23944 | https://github.com/angular/angular/pull/23944 |
| matsko | https://github.com/matsko |
|
May 29, 2018
| https://github.com/angular/angular/pull/23944#ref-commit-c2e1311 |
|
| https://github.com/gkalpak |
|
| https://github.com/matsko |
| refactor(aio): rename method (loadContainingCustomElements --> loadCo… | https://github.com/angular/angular/commit/c2e131119bedbb9761dcc88fae6c12cbdef25e07 |
| c2e1311 | https://github.com/angular/angular/commit/c2e131119bedbb9761dcc88fae6c12cbdef25e07 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| #23944 | https://github.com/angular/angular/pull/23944 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 30, 2018 07:44 | https://github.com/angular/angular/pull/23944#event-1652853085 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/23944#issuecomment-531311601 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/23944#event-2632955059 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23944 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/23944/files/ccd81486068a97309ceff9c5b6032079cc598d7d |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Please reload this page | https://github.com/angular/angular/pull/23944 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |