René's URL Explorer Experiment


Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23889 · angular/angular · GitHub

Open Graph Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23889 · angular/angular

X Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23889 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Backports #23625 to 5.2.x.

X Description: Backports #23625 to 5.2.x.

Opengraph URL: https://github.com/angular/angular/pull/23889

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:25f50781-91af-c4f4-f478-ec8dcf7961a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC75C:B53AF:1461240:1B1F91F:6B012E16
html-safe-nonce6504a4b920207f927150c44d87fa21c975b8f6d24d373b8c68ffac7f4ffa8e74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzVDOkI1M0FGOjE0NjEyNDA6MUIxRjkxRjo2QjAxMkUxNiIsInZpc2l0b3JfaWQiOiIyOTkxNzk5NDE5MDM4NDEyMzEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1156e8924bc07df38206d67b0c359329ce9a8755c94679ded067be434fcf067e
hovercard-subject-tagpull_request:187752787
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/23889/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/de05e8c02c90d95c07f4ee83b6ad9ef0ff3fdfa744bf32f9761934f2402b431d/angular/angular/pull/23889
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de05e8c02c90d95c07f4ee83b6ad9ef0ff3fdfa744bf32f9761934f2402b431d/angular/angular/pull/23889
og:image:altBackports #23625 to 5.2.x.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/23889#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23889
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23889
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23889
Reloadhttps://github.com/angular/angular/pull/23889
Reloadhttps://github.com/angular/angular/pull/23889
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
alxhubhttps://github.com/alxhub
angular:5.2.xhttps://github.com/angular/angular/tree/5.2.x
gkalpak:5.2.x-fix-sw-empty-clientIdhttps://github.com/gkalpak/angular/tree/5.2.x-fix-sw-empty-clientId
Conversationhttps://github.com/angular/angular/pull/23889
Commits3 (3)https://github.com/angular/angular/pull/23889/commits
Checkshttps://github.com/angular/angular/pull/23889/checks
Files changedhttps://github.com/angular/angular/pull/23889/files
fix(service-worker): correctly handle requests with empty clientIdhttps://github.com/angular/angular/pull/23889#top
alxhubhttps://github.com/alxhub
angular:5.2.xhttps://github.com/angular/angular/tree/5.2.x
gkalpak:5.2.x-fix-sw-empty-clientIdhttps://github.com/gkalpak/angular/tree/5.2.x-fix-sw-empty-clientId
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 14, 2018https://github.com/angular/angular/pull/23889#issue-322717878
#23625https://github.com/angular/angular/pull/23625
Please reload this pagehttps://github.com/angular/angular/pull/23889
gkalpakhttps://github.com/gkalpak
May 14, 2018 11:22https://github.com/angular/angular/pull/23889#commits-pushed-db35f4b
https://github.com/gkalpak
test(service-worker): improve adding clients inhttps://github.com/angular/angular/pull/23889/commits/db35f4b2e29d6f8d44683335a967b904dd39916b
SwTestHarnesshttps://github.com/angular/angular/pull/23889/commits/db35f4b2e29d6f8d44683335a967b904dd39916b
(https://github.com/angular/angular/pull/23889/commits/db35f4b2e29d6f8d44683335a967b904dd39916b
angu…https://github.com/angular/angular/pull/23625
db35f4bhttps://github.com/angular/angular/pull/23889/commits/db35f4b2e29d6f8d44683335a967b904dd39916b
…lar#23625https://github.com/angular/angular/pull/23625
angular#23625https://github.com/angular/angular/pull/23625
https://github.com/gkalpak
test(service-worker): support mock requests with null/empty client ID (https://github.com/angular/angular/pull/23889/commits/88c480f80498fb0dafdc553f24f9e91e3da03568
…https://github.com/angular/angular/pull/23625
88c480fhttps://github.com/angular/angular/pull/23889/commits/88c480f80498fb0dafdc553f24f9e91e3da03568
…angular#23625https://github.com/angular/angular/pull/23625
angular#23625https://github.com/angular/angular/pull/23625
https://github.com/gkalpak
fix(service-worker): correctly handle requests with emptyhttps://github.com/angular/angular/pull/23889/commits/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
clientIdhttps://github.com/angular/angular/pull/23889/commits/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
(https://github.com/angular/angular/pull/23889/commits/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
a…https://github.com/angular/angular/pull/23625
58dfa74https://github.com/angular/angular/pull/23889/commits/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
…ngular#23625https://github.com/angular/angular/pull/23625
https://github.com/w3c/ServiceWorker/blob/4cc72bd0f13359f16cc733d88bed4ea52ee063c0/docs/index.bs#L1392https://github.com/w3c/ServiceWorker/blob/4cc72bd0f13359f16cc733d88bed4ea52ee063c0/docs/index.bs#L1392
https://w3c.github.io/ServiceWorker/#fetchevent-interfacehttps://w3c.github.io/ServiceWorker/#fetchevent-interface
https://bugs.chromium.org/p/chromium/issues/detail?id=832105https://bugs.chromium.org/p/chromium/issues/detail?id=832105
angular#23526https://github.com/angular/angular/issues/23526
angular#23625https://github.com/angular/angular/pull/23625
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 14, 2018https://github.com/angular/angular/pull/23889#event-1624214496
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
target: lts https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20lts%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 14, 2018https://github.com/angular/angular/pull/23889#event-1624215501
https://github.com/googlebot
googlebothttps://github.com/googlebot
May 14, 2018https://github.com/angular/angular/pull/23889#issuecomment-388737677
Please reload this pagehttps://github.com/angular/angular/pull/23889
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 14, 2018https://github.com/angular/angular/pull/23889#event-1624215548
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
May 15, 2018 https://github.com/angular/angular/pull/23889#pullrequestreview-120372700
View reviewed changes https://github.com/angular/angular/pull/23889/files/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
May 15, 2018https://github.com/angular/angular/pull/23889#event-1627978470
https://github.com/alxhub
alxhubhttps://github.com/alxhub
bc27d4ahttps://github.com/angular/angular/commit/bc27d4aae4a07ae603637f4a0b1b53562ad9d6b7
May 15, 2018https://github.com/angular/angular/pull/23889#event-1627994211
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 16, 2018 15:49https://github.com/angular/angular/pull/23889#event-1629962205
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/23889#issuecomment-531291471
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/23889
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/23889#event-2632796532
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23889
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/23889/files/58dfa74a0ea6f01d8b7039989bd3b7f31bc57e0e
Please reload this pagehttps://github.com/angular/angular/pull/23889
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: service-worker https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: lts https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20lts%22
Please reload this pagehttps://github.com/angular/angular/pull/23889
https://github.com/gkalpak
https://github.com/googlebot
https://github.com/IgorMinar
https://github.com/alxhub
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.