| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c330e44c-aac2-052f-824d-d0cbaf67b7c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87EA:63875:14DFD69:1B9AE7D:6B01291B |
| html-safe-nonce | 9f9a8ce2032749d76c3f7ef569d601730c17132e04a2c0ac6d97719ceab5b8a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0VBOjYzODc1OjE0REZENjk6MUI5QUU3RDo2QjAxMjkxQiIsInZpc2l0b3JfaWQiOiI0OTkxNTM5NzEzOTI5MTkzNzU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 58ddef7838a4abd5af759ec915405df4abf760c11adc53e278035eeb1ff7e37c |
| hovercard-subject-tag | pull_request:187268830 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/23825/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ebca39a2be03d6cb6dba5f7d9016d7d9259f5cf229d7039d05a12d1a438756d2/angular/angular/pull/23825 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ebca39a2be03d6cb6dba5f7d9016d7d9259f5cf229d7039d05a12d1a438756d2/angular/angular/pull/23825 |
| og:image:alt | PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | andrewseguin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/23825#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23825 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23825 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/23825 |
| Reload | https://github.com/angular/angular/pull/23825 |
| Reload | https://github.com/angular/angular/pull/23825 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| andrewseguin | https://github.com/andrewseguin |
| angular:master | https://github.com/angular/angular/tree/master |
| andrewseguin:elements-fix-ctor | https://github.com/andrewseguin/angular/tree/elements-fix-ctor |
| Conversation | https://github.com/angular/angular/pull/23825 |
| Commits1 (1) | https://github.com/angular/angular/pull/23825/commits |
| Checks | https://github.com/angular/angular/pull/23825/checks |
| Files changed | https://github.com/angular/angular/pull/23825/files |
| fix(elements): always check to create strategy | https://github.com/angular/angular/pull/23825#top |
| andrewseguin | https://github.com/andrewseguin |
| angular:master | https://github.com/angular/angular/tree/master |
| andrewseguin:elements-fix-ctor | https://github.com/andrewseguin/angular/tree/elements-fix-ctor |
|
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#issue-322033040 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620393870 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
| IgorMinar | https://github.com/IgorMinar |
| vikerman | https://github.com/vikerman |
| May 10, 2018 18:25 | https://github.com/angular/angular/pull/23825#event-1620393874 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620393940 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#issuecomment-388144622 |
| https://pr23825-5ae467b.ngbuilds.io/ | https://pr23825-5ae467b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620422642 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
May 10, 2018
| https://github.com/angular/angular/pull/23825#pullrequestreview-119228492 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23825/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/23825#pullrequestreview-119228492 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620595365 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
| force-pushed | https://github.com/angular/angular/compare/5ae467b7b1bbf35a98adcccd6435772a9e0bf976..ea3df81bc930e6b06513c526bd523374ff7ab986 |
| 5ae467b | https://github.com/angular/angular/commit/5ae467b7b1bbf35a98adcccd6435772a9e0bf976 |
| ea3df81 | https://github.com/angular/angular/commit/ea3df81bc930e6b06513c526bd523374ff7ab986 |
|
Compare
| https://github.com/angular/angular/compare/5ae467b7b1bbf35a98adcccd6435772a9e0bf976..ea3df81bc930e6b06513c526bd523374ff7ab986 |
| May 10, 2018 20:32 | https://github.com/angular/angular/pull/23825#event-1620643754 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#issuecomment-388176751 |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
|
| https://github.com/andrewseguin |
| fix(elements): always check to create strategy | https://github.com/angular/angular/pull/23825/commits/a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
| a417ae4 | https://github.com/angular/angular/pull/23825/commits/a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
| https://github.com/andrewseguin |
| andrewseguin | https://github.com/andrewseguin |
| force-pushed | https://github.com/angular/angular/compare/ea3df81bc930e6b06513c526bd523374ff7ab986..a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
| ea3df81 | https://github.com/angular/angular/commit/ea3df81bc930e6b06513c526bd523374ff7ab986 |
| a417ae4 | https://github.com/angular/angular/commit/a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
|
Compare
| https://github.com/angular/angular/compare/ea3df81bc930e6b06513c526bd523374ff7ab986..a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
| May 10, 2018 20:34 | https://github.com/angular/angular/pull/23825#event-1620646604 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#issuecomment-388179750 |
| https://pr23825-ea3df81.ngbuilds.io/ | https://pr23825-ea3df81.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#issuecomment-388179975 |
| a417ae4 | https://github.com/angular/angular/commit/a417ae43e39e87f64f8b7fe75f62c48508fd14c8 |
| https://pr23825-a417ae4.ngbuilds.io/ | https://pr23825-a417ae4.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| vikerman | https://github.com/vikerman |
| May 10, 2018 23:06 | https://github.com/angular/angular/pull/23825#event-1620890536 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620890657 |
| IgorMinar | https://github.com/IgorMinar |
|
May 10, 2018
| https://github.com/angular/angular/pull/23825#ref-commit-d280077 |
|
| https://github.com/andrewseguin |
|
| https://github.com/IgorMinar |
| fix(elements): always check to create strategy ( | https://github.com/angular/angular/commit/d2800774120cdd25ecf8df0bf4717bc5f1689f90 |
| #23825 | https://github.com/angular/angular/pull/23825 |
| ) | https://github.com/angular/angular/commit/d2800774120cdd25ecf8df0bf4717bc5f1689f90 |
| d280077 | https://github.com/angular/angular/commit/d2800774120cdd25ecf8df0bf4717bc5f1689f90 |
| #23825 | https://github.com/angular/angular/pull/23825 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| b1cda36 | https://github.com/angular/angular/commit/b1cda3639fa9c63a74b5bcf0106ed33b204269b5 |
| May 10, 2018 | https://github.com/angular/angular/pull/23825#event-1620893094 |
| mashhoodr | https://github.com/mashhoodr |
|
May 28, 2018
| https://github.com/angular/angular/pull/23825#ref-commit-9219547 |
|
| https://github.com/andrewseguin |
|
| https://github.com/mashhoodr |
| fix(elements): always check to create strategy ( | https://github.com/mashhoodr/angular/commit/9219547da5268e81efa419323276164d09f072e1 |
| angular#23825 | https://github.com/angular/angular/pull/23825 |
| ) | https://github.com/mashhoodr/angular/commit/9219547da5268e81efa419323276164d09f072e1 |
| 9219547 | https://github.com/mashhoodr/angular/commit/9219547da5268e81efa419323276164d09f072e1 |
| angular#23825 | https://github.com/angular/angular/pull/23825 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Aug 13, 2019 | https://github.com/angular/angular/pull/23825#issuecomment-520870331 |
| a417ae4#diff-ad5cb9ab336c13dbe9a23278e0299e62L172 | https://github.com/angular/angular/commit/a417ae43e39e87f64f8b7fe75f62c48508fd14c8#diff-ad5cb9ab336c13dbe9a23278e0299e62L172 |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
|
Aug 13, 2019
| https://github.com/angular/angular/pull/23825#ref-issue-480273961 |
|
createCustomElement assumes node is attached to DOM before attributes are set.
#32122
| https://github.com/angular/angular/issues/32122 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/23825#issuecomment-531551525 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 15, 2019 | https://github.com/angular/angular/pull/23825#event-2634566566 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/23825#ref-commit-61fd7ea |
|
| https://github.com/andrewseguin |
|
| https://github.com/IgorMinar |
| fix(elements): always check to create strategy ( | https://github.com/adhambaouz/angular/commit/61fd7eadd0a4d1d6bbb08d0a7dabce37fe5b19e2 |
| angular#23825 | https://github.com/angular/angular/pull/23825 |
| ) | https://github.com/adhambaouz/angular/commit/61fd7eadd0a4d1d6bbb08d0a7dabce37fe5b19e2 |
| 61fd7ea | https://github.com/adhambaouz/angular/commit/61fd7eadd0a4d1d6bbb08d0a7dabce37fe5b19e2 |
| angular#23825 | https://github.com/angular/angular/pull/23825 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23825 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/23825/files/5ae467b7b1bbf35a98adcccd6435772a9e0bf976 |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Please reload this page | https://github.com/angular/angular/pull/23825 |
|
| https://github.com/andrewseguin |
|
| https://github.com/mary-poppins |
|
| https://github.com/IgorMinar |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |