René's URL Explorer Experiment


Title: fix(forms): improve select performance and ensure that selected option matches the ngModel value by theodorejb · Pull Request #23784 · angular/angular · GitHub

Open Graph Title: fix(forms): improve select performance and ensure that selected option matches the ngModel value by theodorejb · Pull Request #23784 · angular/angular

X Title: fix(forms): improve select performance and ensure that selected option matches the ngModel value by theodorejb · Pull Request #23784 · angular/angular

Description: Fixes #41330, fixes #14505, fixes #18430. PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix What is the current behavior? Currently Angular calls the writeValue() over and over for every individual option element that is added or removed from the DOM. This results in exponentially more _compareValue calls than the number of option elements (issue #41330). Furthermore, calling writeValue() when rendering individual option elements causes an issue in Safari and IE 11 where the first option element fails to be deselected when no option matches the select ngModel. This is because Angular sets the select element's value property before appending the option's child text node to the DOM (issue #14505). Finally, the current behavior causes an issue with delayed element removal when using the animations module (in all browsers). When a selected option is removed (so no option matches the ngModel anymore), Angular changes the select element value before actually removing the option from the DOM. Then when the option is finally removed from the DOM, the browser changes the select value to that of the first option, even though it doesn't match the ngModel (issue #18430). What is the new behavior? Rather than calling writeValue() over and over for individual option elements that are added/removed from the DOM, call it once after all the options have finished rendering via the afterNextRender function. This dramatically improves performance and results in correct behavior across all supported browsers. Does this PR introduce a breaking change? Yes No

Open Graph Description: Fixes #41330, fixes #14505, fixes #18430. PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have...

X Description: Fixes #41330, fixes #14505, fixes #18430. PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have...

Opengraph URL: https://github.com/angular/angular/pull/23784

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9d5e2454-3713-3bbe-1fc8-f512a5f8283c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA47E:1087D4:1917272:218456B:6B01532C
html-safe-nonce595c9e0b92968519cf8436ba8964637caa6fd5eaf8e9b032f068968ce63413d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDdFOjEwODdENDoxOTE3MjcyOjIxODQ1NkI6NkIwMTUzMkMiLCJ2aXNpdG9yX2lkIjoiNTkzNjk4MzQ3NjQzMTMwNjY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a88609a68e86fa2279c47e8981c3118b669c7003942f6da27c6261253ae6155
hovercard-subject-tagpull_request:186818108
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/23784/files
twitter:imagehttps://avatars.githubusercontent.com/u/3053271?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3053271?s=400&v=4
og:image:altFixes #41330, fixes #14505, fixes #18430. PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/23784/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23784%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23784%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23784/files
Reloadhttps://github.com/angular/angular/pull/23784/files
Reloadhttps://github.com/angular/angular/pull/23784/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
theodorejbhttps://github.com/theodorejb
angular:mainhttps://github.com/angular/angular/tree/main
Conversation 125 https://github.com/angular/angular/pull/23784
Commits 1 https://github.com/angular/angular/pull/23784/commits
Checks 0 https://github.com/angular/angular/pull/23784/checks
Files changed https://github.com/angular/angular/pull/23784/files
Please reload this pagehttps://github.com/angular/angular/pull/23784/files
fix(forms): improve select performance and ensure that selected option matches the ngModel value https://github.com/angular/angular/pull/23784/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/23784/files
ed4b45d fix(forms): improve select performance and ensure that selected optio… theodorejb May 15, 2020 https://github.com/angular/angular/pull/23784/commits/ed4b45de905106835a2d47020898313cb28cabf5
Clear filters https://github.com/angular/angular/pull/23784/files
Please reload this pagehttps://github.com/angular/angular/pull/23784/files
Please reload this pagehttps://github.com/angular/angular/pull/23784/files
select_control_value_accessor.ts https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
BUILD.bazel https://github.com/angular/angular/pull/23784/files#diff-b1db84e0f4818de08df7425ab89b52b0318f51416b09f2e9942e6f3ff5d369ce
directives_spec.ts https://github.com/angular/angular/pull/23784/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
value_accessor_integration_spec.ts https://github.com/angular/angular/pull/23784/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
packages/forms/src/directives/select_control_value_accessor.tshttps://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
View file https://github.com/angular/angular/blob/ed4b45de905106835a2d47020898313cb28cabf5/packages/forms/src/directives/select_control_value_accessor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
Please reload this pagehttps://github.com/angular/angular/pull/23784/files
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/23784/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
packages/forms/test/BUILD.bazelhttps://github.com/angular/angular/pull/23784/files#diff-b1db84e0f4818de08df7425ab89b52b0318f51416b09f2e9942e6f3ff5d369ce
View file https://github.com/angular/angular/blob/ed4b45de905106835a2d47020898313cb28cabf5/packages/forms/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23784/files#diff-b1db84e0f4818de08df7425ab89b52b0318f51416b09f2e9942e6f3ff5d369ce
https://github.com/angular/angular/pull/23784/files#diff-b1db84e0f4818de08df7425ab89b52b0318f51416b09f2e9942e6f3ff5d369ce
Please reload this pagehttps://github.com/angular/angular/pull/23784/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.