René's URL Explorer Experiment


Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23625 · angular/angular · GitHub

Open Graph Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23625 · angular/angular

X Title: fix(service-worker): correctly handle requests with empty `clientId` by gkalpak · Pull Request #23625 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type [x] Bugfix What is the current behavior? Requests from clients that are not assigned a client ID by the browser will produce fetch events with null or empty ('') clientIds. The ServiceWorker only handles null values correctly. Yet empty strings are also valid (see for example here and there). Related Chromium issue/discussion: #832105 Issue Number: #23526 What is the new behavior? The SW will interpret all falsy clientId valuesthe same (i.e. "no client ID assigned") and handle them appropriately. Does this PR introduce a breaking change? [ ] Yes [x] No Other information Fixes #23526.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/23625

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7fd9b21a-6abc-31ed-671c-678b39ce595b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id839C:11EACE:1D89DBE:2764580:6B016C3B
html-safe-noncea81f795fe677eff9f478e86b0b5c8ea1cd05ae9a87f094e14a5f6c7358459d6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzlDOjExRUFDRToxRDg5REJFOjI3NjQ1ODA6NkIwMTZDM0IiLCJ2aXNpdG9yX2lkIjoiODQ2NjAyNjYwODM3MTc4ODg1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca675d8571b46b75cb96436b704dba8c47d2e52739f50872ab752688e138b7dd8
hovercard-subject-tagpull_request:185083626
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/23625/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/23625/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23625%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23625%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23625/files
Reloadhttps://github.com/angular/angular/pull/23625/files
Reloadhttps://github.com/angular/angular/pull/23625/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-empty-clientIdhttps://github.com/gkalpak/angular/tree/fix-sw-empty-clientId
Conversation 9 https://github.com/angular/angular/pull/23625
Commits 4 https://github.com/angular/angular/pull/23625/commits
Checks 0 https://github.com/angular/angular/pull/23625/checks
Files changed https://github.com/angular/angular/pull/23625/files
Please reload this pagehttps://github.com/angular/angular/pull/23625/files
fix(service-worker): correctly handle requests with empty clientId https://github.com/angular/angular/pull/23625/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/23625/files
1c46c4b test(service-worker): improve adding clients in `SwTestHarness` gkalpak Apr 30, 2018 https://github.com/angular/angular/pull/23625/commits/1c46c4b4963679de13cf75493248a4f4d0ad9473
c8bf539 test(service-worker): support mock requests with null/empty client ID gkalpak Apr 30, 2018 https://github.com/angular/angular/pull/23625/commits/c8bf539c05e46a332ab9610bfefa46160e810262
59e88cb fixup! test(service-worker): improve adding clients in `SwTestHarness` gkalpak Apr 30, 2018 https://github.com/angular/angular/pull/23625/commits/59e88cb6a6a52a04d66ccf3e0a617e28527b108b
2ff1be0 fix(service-worker): correctly handle requests with empty `clientId` gkalpak Apr 30, 2018 https://github.com/angular/angular/pull/23625/commits/2ff1be0479718be033c8654f5a320bb0be22e395
Clear filters https://github.com/angular/angular/pull/23625/files
Please reload this pagehttps://github.com/angular/angular/pull/23625/files
Please reload this pagehttps://github.com/angular/angular/pull/23625/files
driver.ts https://github.com/angular/angular/pull/23625/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
happy_spec.ts https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
scope.ts https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
packages/service-worker/worker/src/driver.tshttps://github.com/angular/angular/pull/23625/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
View file https://github.com/gkalpak/angular/blob/2ff1be0479718be033c8654f5a320bb0be22e395/packages/service-worker/worker/src/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23625/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23625/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/23625/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
packages/service-worker/worker/test/happy_spec.tshttps://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
View file https://github.com/gkalpak/angular/blob/2ff1be0479718be033c8654f5a320bb0be22e395/packages/service-worker/worker/test/happy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23625/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/23625/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
packages/service-worker/worker/testing/scope.tshttps://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
View file https://github.com/gkalpak/angular/blob/2ff1be0479718be033c8654f5a320bb0be22e395/packages/service-worker/worker/testing/scope.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23625/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
https://github.com/angular/angular/pull/23625/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.