| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9b7da613-de54-37b8-73f4-16f49e31a4b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A672:DA744:22AD75F:2EAC40B:6B019E65 |
| html-safe-nonce | 3a3aa3ed7688c9f2fc580ac214116d261612c325dd2fda47f1b86f75cfb85e25 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjcyOkRBNzQ0OjIyQUQ3NUY6MkVBQzQwQjo2QjAxOUU2NSIsInZpc2l0b3JfaWQiOiIyNDExNzI1MTI2MDY1Mjk5MDQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c4076fb6cfb2655332b010bea11699eb6d52131cdd84bf92be3e53f5f08f5179 |
| hovercard-subject-tag | pull_request:181303171 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/23345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8e884dd9ed612db5b0c06602dae5cf71856b54d00ca057354b7a5739b75a378c/angular/angular/pull/23345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8e884dd9ed612db5b0c06602dae5cf71856b54d00ca057354b7a5739b75a378c/angular/angular/pull/23345 |
| og:image:alt | This change changes:
compiler uses directiveInject instead of inject for Directives
unifies the flags in di as well as render3
changes the signature of directiveInject to match inject In prep for ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhevery |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/23345#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23345 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23345 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/23345 |
| Reload | https://github.com/angular/angular/pull/23345 |
| Reload | https://github.com/angular/angular/pull/23345 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests143 (143) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| mhevery:injection_fix | https://github.com/mhevery/angular/tree/injection_fix |
| Conversation | https://github.com/angular/angular/pull/23345 |
| Commits4 (4) | https://github.com/angular/angular/pull/23345/commits |
| Checks | https://github.com/angular/angular/pull/23345/checks |
| Files changed | https://github.com/angular/angular/pull/23345/files |
| feat(ivy): support generation of flags for directive injection | https://github.com/angular/angular/pull/23345#top |
| mhevery | https://github.com/mhevery |
| angular:master | https://github.com/angular/angular/tree/master |
| mhevery:injection_fix | https://github.com/mhevery/angular/tree/injection_fix |
|
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issue-313857969 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| inject and directiveInject need bridging when used with Component.provides #23330 | https://github.com/angular/angular/issues/23330 |
| #23342 | https://github.com/angular/angular/issues/23342 |
| #23330 | https://github.com/angular/angular/issues/23330 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#event-1571797338 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| kara | https://github.com/kara |
| April 12, 2018 19:30 | https://github.com/angular/angular/pull/23345#event-1571797390 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Apr 12, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111762463 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/23345#pullrequestreview-111762463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| packages/compiler/test/render3/r3_view_compiler_di_spec.ts | https://github.com/angular/angular/pull/23345/files#diff-e795f4424c8f262d2b56c827d4107b821e61fa9d154bbbbc643ee96e72b37711 |
| kara | https://github.com/kara |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181197648 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181198848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Apr 12, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111763646 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/src/render3/di.ts | https://github.com/angular/angular/pull/23345/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110 |
| kara | https://github.com/kara |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181198604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181199276 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/520e4355892325e6f76f6d6e80394d8fd80f0a63..644e7141bddae6f642d62a26465799db996ae773 |
| 520e435 | https://github.com/angular/angular/commit/520e4355892325e6f76f6d6e80394d8fd80f0a63 |
| 644e714 | https://github.com/angular/angular/commit/644e7141bddae6f642d62a26465799db996ae773 |
|
Compare
| https://github.com/angular/angular/compare/520e4355892325e6f76f6d6e80394d8fd80f0a63..644e7141bddae6f642d62a26465799db996ae773 |
| April 12, 2018 19:41 | https://github.com/angular/angular/pull/23345#event-1571816139 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Apr 12, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111764933 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/23345#pullrequestreview-111764933 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380923218 |
| https://pr23345-4d6700a.ngbuilds.io/ | https://pr23345-4d6700a.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/7b8bcef4ef3f7d70cd4df6f6f60033a15e64d52c..8fd7d9535743ab3e4514502e1eba75002377ba52 |
| 7b8bcef | https://github.com/angular/angular/commit/7b8bcef4ef3f7d70cd4df6f6f60033a15e64d52c |
| 8fd7d95 | https://github.com/angular/angular/commit/8fd7d9535743ab3e4514502e1eba75002377ba52 |
|
Compare
| https://github.com/angular/angular/compare/7b8bcef4ef3f7d70cd4df6f6f60033a15e64d52c..8fd7d9535743ab3e4514502e1eba75002377ba52 |
| April 12, 2018 20:05 | https://github.com/angular/angular/pull/23345#event-1571861005 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Apr 12, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111772123 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/compiler/src/render3/r3_view_compiler.ts | https://github.com/angular/angular/pull/23345/files#diff-d24af5679ca1a2bf8001180c88c3cdd143767335ce47b292460ca6fc524ce9f4 |
| vicb | https://github.com/vicb |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181205388 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181258547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| packages/compiler/test/render3/r3_view_compiler_di_spec.ts | https://github.com/angular/angular/pull/23345/files#diff-e795f4424c8f262d2b56c827d4107b821e61fa9d154bbbbc643ee96e72b37711 |
| vicb | https://github.com/vicb |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181206225 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181258645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380930620 |
| https://pr23345-7b8bcef.ngbuilds.io/ | https://pr23345-7b8bcef.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380931861 |
| https://pr23345-8fd7d95.ngbuilds.io/ | https://pr23345-8fd7d95.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#event-1571903916 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/8fd7d9535743ab3e4514502e1eba75002377ba52..c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc |
| 8fd7d95 | https://github.com/angular/angular/commit/8fd7d9535743ab3e4514502e1eba75002377ba52 |
| c75e17f | https://github.com/angular/angular/commit/c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc |
|
Compare
| https://github.com/angular/angular/compare/8fd7d9535743ab3e4514502e1eba75002377ba52..c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc |
| April 12, 2018 20:32 | https://github.com/angular/angular/pull/23345#event-1571909325 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#event-1571913759 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380938418 |
| https://pr23345-c75e17f.ngbuilds.io/ | https://pr23345-c75e17f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc..49cb5912239d0c8b7d55dbabcfd64feee987881a |
| c75e17f | https://github.com/angular/angular/commit/c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc |
| 49cb591 | https://github.com/angular/angular/commit/49cb5912239d0c8b7d55dbabcfd64feee987881a |
|
Compare
| https://github.com/angular/angular/compare/c75e17fe040522bb06b8f45cd4b2f4b155b9a6dc..49cb5912239d0c8b7d55dbabcfd64feee987881a |
| April 12, 2018 20:50 | https://github.com/angular/angular/pull/23345#event-1571941989 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380942934 |
| https://pr23345-49cb591.ngbuilds.io/ | https://pr23345-49cb591.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Apr 12, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111830309 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/test/bundling/todo/index.ts | https://github.com/angular/angular/pull/23345/files#diff-732552566461d63a66b083390ea8fa4672d652d4ecfadd84e2fa9e66c975f96a |
| vicb | https://github.com/vicb |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181248644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181259317 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 12, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380972700 |
| https://pr23345-493ab9b.ngbuilds.io/ | https://pr23345-493ab9b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/493ab9b93c8f160848876357cce3e813206465cd..091c9e18f3446f1ecd054f0ecd10ed51d866a039 |
| 493ab9b | https://github.com/angular/angular/commit/493ab9b93c8f160848876357cce3e813206465cd |
| 091c9e1 | https://github.com/angular/angular/commit/091c9e18f3446f1ecd054f0ecd10ed51d866a039 |
|
Compare
| https://github.com/angular/angular/compare/493ab9b93c8f160848876357cce3e813206465cd..091c9e18f3446f1ecd054f0ecd10ed51d866a039 |
| April 13, 2018 00:50 | https://github.com/angular/angular/pull/23345#event-1572245203 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111845318 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/23345#pullrequestreview-111845318 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| packages/core/test/render3/di_spec.ts | https://github.com/angular/angular/pull/23345/files#diff-5d2f4a213c07bcfef1ee8a1f00e2f548878acb8a86eb6f3e8cf49eb81982b890 |
| kara | https://github.com/kara |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181259579 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181261292 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| packages/core/test/render3/di_spec.ts | https://github.com/angular/angular/pull/23345/files#diff-5d2f4a213c07bcfef1ee8a1f00e2f548878acb8a86eb6f3e8cf49eb81982b890 |
| kara | https://github.com/kara |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181259603 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181261421 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/019b4c1b7aec614cdc526e168e50e07df0abdeab..e2a3a2f88088dc42f0269a4bdec9ac0553bb37c8 |
| 019b4c1 | https://github.com/angular/angular/commit/019b4c1b7aec614cdc526e168e50e07df0abdeab |
| e2a3a2f | https://github.com/angular/angular/commit/e2a3a2f88088dc42f0269a4bdec9ac0553bb37c8 |
|
Compare
| https://github.com/angular/angular/compare/019b4c1b7aec614cdc526e168e50e07df0abdeab..e2a3a2f88088dc42f0269a4bdec9ac0553bb37c8 |
| April 13, 2018 00:57 | https://github.com/angular/angular/pull/23345#event-1572250758 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111848679 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/23345#pullrequestreview-111848679 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380988544 |
| https://pr23345-091c9e1.ngbuilds.io/ | https://pr23345-091c9e1.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380988795 |
| https://pr23345-019b4c1.ngbuilds.io/ | https://pr23345-019b4c1.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-380989411 |
| https://pr23345-e2a3a2f.ngbuilds.io/ | https://pr23345-e2a3a2f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111859173 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/src/di/defs.ts | https://github.com/angular/angular/pull/23345/files#diff-562d2e1b5c8c4a9486f3927460dd08d3ec020c2b99f4b3f19b81cca44b3669a6 |
| vicb | https://github.com/vicb |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181269707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181281628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111860075 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/src/di/injector.ts | https://github.com/angular/angular/pull/23345/files#diff-c9e6fec7b3e759d5c1a147f703c8d2aa238d90c1d511a3c8313ed1b379ce8c6f |
| vicb | https://github.com/vicb |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181270371 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181281684 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111860617 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/src/render3/interfaces/view.ts | https://github.com/angular/angular/pull/23345/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282 |
| vicb | https://github.com/vicb |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181270749 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181281758 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/trotyl |
| trotyl | https://github.com/trotyl |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-111872155 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files |
| packages/core/src/change_detection/differs/iterable_differs.ts | https://github.com/angular/angular/pull/23345/files#diff-62a378c800ece263aa4515f8eacd567d826d3500f7dabb71bd7a1b9a8c305da3 |
| trotyl | https://github.com/trotyl |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181278958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181281159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| alfaproject | https://github.com/alfaproject |
| Apr 14, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181544881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#event-1572403312 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381018281 |
| https://pr23345-27674e3.ngbuilds.io/ | https://pr23345-27674e3.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/27674e374d917c09b313a97f25d6b61fa2da5370..685546ed23cbf6939c4ecfcbf8120093797d3a88 |
| 27674e3 | https://github.com/angular/angular/commit/27674e374d917c09b313a97f25d6b61fa2da5370 |
| 685546e | https://github.com/angular/angular/commit/685546ed23cbf6939c4ecfcbf8120093797d3a88 |
|
Compare
| https://github.com/angular/angular/compare/27674e374d917c09b313a97f25d6b61fa2da5370..685546ed23cbf6939c4ecfcbf8120093797d3a88 |
| April 13, 2018 05:05 | https://github.com/angular/angular/pull/23345#event-1572456456 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381025979 |
| https://pr23345-685546e.ngbuilds.io/ | https://pr23345-685546e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#event-1572618769 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381049288 |
| @mhevery | https://github.com/mhevery |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#event-1574028290 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381244191 |
| @IgorMinar | https://github.com/IgorMinar |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381250461 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| mhevery | https://github.com/mhevery |
| April 13, 2018 13:36 | https://github.com/angular/angular/pull/23345#commits-pushed-ff13a1f |
|
| https://github.com/mhevery |
| feat(ivy): support generation of flags for directive injection | https://github.com/angular/angular/pull/23345/commits/ff13a1f08540aa9fc5d80f7fa150467fe6490399 |
| ff13a1f | https://github.com/angular/angular/pull/23345/commits/ff13a1f08540aa9fc5d80f7fa150467fe6490399 |
| angular#23330 | https://github.com/angular/angular/issues/23330 |
| angular#23342 | https://github.com/angular/angular/issues/23342 |
| angular#23330 | https://github.com/angular/angular/issues/23330 |
|
| https://github.com/mhevery |
| feat(ivy): support injection even if no injector present | https://github.com/angular/angular/pull/23345/commits/c869c882b4fe7b2dae819fd7ad605e69b00714fb |
| c869c88 | https://github.com/angular/angular/pull/23345/commits/c869c882b4fe7b2dae819fd7ad605e69b00714fb |
|
| https://github.com/mhevery |
| docs(ivy): Clean up incorrect comments | https://github.com/angular/angular/pull/23345/commits/8e0d74b4e072162f3465d71633a892e0505c4316 |
| 8e0d74b | https://github.com/angular/angular/pull/23345/commits/8e0d74b4e072162f3465d71633a892e0505c4316 |
|
| https://github.com/mhevery |
| fix(ivy): Update Todo app to take advantage of optional injector | https://github.com/angular/angular/pull/23345/commits/7cf605d02973d9b0c00e420a22c89c03e299e9da |
| 7cf605d | https://github.com/angular/angular/pull/23345/commits/7cf605d02973d9b0c00e420a22c89c03e299e9da |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| force-pushed | https://github.com/angular/angular/compare/685546ed23cbf6939c4ecfcbf8120093797d3a88..7cf605d02973d9b0c00e420a22c89c03e299e9da |
| 685546e | https://github.com/angular/angular/commit/685546ed23cbf6939c4ecfcbf8120093797d3a88 |
| 7cf605d | https://github.com/angular/angular/commit/7cf605d02973d9b0c00e420a22c89c03e299e9da |
|
Compare
| https://github.com/angular/angular/compare/685546ed23cbf6939c4ecfcbf8120093797d3a88..7cf605d02973d9b0c00e420a22c89c03e299e9da |
| April 13, 2018 20:36 | https://github.com/angular/angular/pull/23345#event-1574100400 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#issuecomment-381258875 |
| 7cf605d | https://github.com/angular/angular/commit/7cf605d02973d9b0c00e420a22c89c03e299e9da |
| https://pr23345-7cf605d.ngbuilds.io/ | https://pr23345-7cf605d.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| 6f213a7 | https://github.com/angular/angular/commit/6f213a74f22b9b4188b65d8757b5693e6ec41e0c |
| Apr 13, 2018 | https://github.com/angular/angular/pull/23345#event-1574182040 |
| IgorMinar | https://github.com/IgorMinar |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#ref-commit-da31db7 |
|
| https://github.com/mhevery |
|
| https://github.com/IgorMinar |
| feat(ivy): support injection even if no injector present ( | https://github.com/angular/angular/commit/da31db757ba6a97d20a80ed5b051c17413b7690e |
| #23345 | https://github.com/angular/angular/pull/23345 |
| ) | https://github.com/angular/angular/commit/da31db757ba6a97d20a80ed5b051c17413b7690e |
| da31db7 | https://github.com/angular/angular/commit/da31db757ba6a97d20a80ed5b051c17413b7690e |
| #23345 | https://github.com/angular/angular/pull/23345 |
| IgorMinar | https://github.com/IgorMinar |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#ref-commit-4384a92 |
|
| https://github.com/mhevery |
|
| https://github.com/IgorMinar |
| docs(ivy): Clean up incorrect comments ( | https://github.com/angular/angular/commit/4384a922717a9529f33def656134f98ecb70bf28 |
| #23345 | https://github.com/angular/angular/pull/23345 |
| ) | https://github.com/angular/angular/commit/4384a922717a9529f33def656134f98ecb70bf28 |
| 4384a92 | https://github.com/angular/angular/commit/4384a922717a9529f33def656134f98ecb70bf28 |
| #23345 | https://github.com/angular/angular/pull/23345 |
| IgorMinar | https://github.com/IgorMinar |
|
Apr 13, 2018
| https://github.com/angular/angular/pull/23345#ref-commit-f4017ce |
|
| https://github.com/mhevery |
|
| https://github.com/IgorMinar |
| fix(ivy): Update Todo app to take advantage of optional injector ( | https://github.com/angular/angular/commit/f4017ce5e3d959ac02c4e38fc099e66504f25e4f |
| #23345 | https://github.com/angular/angular/pull/23345 |
| f4017ce | https://github.com/angular/angular/commit/f4017ce5e3d959ac02c4e38fc099e66504f25e4f |
| https://github.com/angular/angular/pull/23345 |
| #23345 | https://github.com/angular/angular/pull/23345 |
| https://github.com/alfaproject |
| alfaproject | https://github.com/alfaproject |
|
Apr 14, 2018
| https://github.com/angular/angular/pull/23345#pullrequestreview-112200406 |
|
View reviewed changes
| https://github.com/angular/angular/pull/23345/files/7cf605d02973d9b0c00e420a22c89c03e299e9da |
| tools/public_api_guard/core/core.d.ts | https://github.com/angular/angular/pull/23345/files/7cf605d02973d9b0c00e420a22c89c03e299e9da#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8 |
| alfaproject | https://github.com/alfaproject |
| Apr 14, 2018 | https://github.com/angular/angular/pull/23345#discussion_r181544951 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/23345#issuecomment-531395207 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/23345#event-2633595537 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23345 |
|
| https://github.com/alfaproject |
|
alfaproject
| https://github.com/alfaproject |
|
| https://github.com/angular/angular/pull/23345/files/7cf605d02973d9b0c00e420a22c89c03e299e9da |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
| https://github.com/angular/angular/pull/23345/files/e2a3a2f88088dc42f0269a4bdec9ac0553bb37c8 |
|
| https://github.com/trotyl |
|
trotyl
| https://github.com/trotyl |
|
| https://github.com/angular/angular/pull/23345/files/7cf605d02973d9b0c00e420a22c89c03e299e9da |
|
| https://github.com/kara |
|
kara
| https://github.com/kara |
|
| https://github.com/angular/angular/pull/23345/files/e2a3a2f88088dc42f0269a4bdec9ac0553bb37c8 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Please reload this page | https://github.com/angular/angular/pull/23345 |
|
| https://github.com/mhevery |
|
| https://github.com/mary-poppins |
|
| https://github.com/IgorMinar |
|
| https://github.com/alfaproject |
|
| https://github.com/vicb |
|
| https://github.com/kara |
|
| https://github.com/trotyl |
|
| https://github.com/jasonaden |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |