René's URL Explorer Experiment


Title: feat(service-worker): add support for configuring navigations URLs by gkalpak · Pull Request #23339 · angular/angular · GitHub

Open Graph Title: feat(service-worker): add support for configuring navigations URLs by gkalpak · Pull Request #23339 · angular/angular

X Title: feat(service-worker): add support for configuring navigations URLs by gkalpak · Pull Request #23339 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type [x] Feature What is the current behavior? The ServiceWorker will redirect navigation requests that don't match any asset or data group to the specified index file. The rules for a request to be classified as a navigation request are as follows: Its mode must be navigation. It must accept a text/html response. Its URL must match certain criteria (see below). By default, a navigation request can have any URL except for: URLs containing __. URLs to files (i.e. containing a file extension in the last path segment). While thse rules are fine in many cases, sometimes it is desirable to configure different rules for the URLs of navigation requests (e.g. ignore specific URLs and pass them through to the server). Issue Number: #20404 What is the new behavior? It is now possible to specify an optional navigationUrls list in ngsw-config.json, which contains URLs or simple globs (currently only recognizing !, * and **). Only requests whose URLs match any of the positive URLs/patterns and none of the negative ones (i.e. URLs/patterns starting with !) will be considered navigation requests (and handled accordingly by the SW). Does this PR introduce a breaking change? [ ] Yes [x] No Other information This is an alternative implementation to #23025. Fixes #20404.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/23339

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:442cdef2-f980-9185-a835-9b6bfd6d1a2f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAD4:33444D:1C57772:25AD88B:6B0163D1
html-safe-nonceadffcebe0ffcfddfe18db70fe950ff91274a1f2a6b44c14734fce361754f1fd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUQ0OjMzNDQ0RDoxQzU3NzcyOjI1QUQ4OEI6NkIwMTYzRDEiLCJ2aXNpdG9yX2lkIjoiNzU5MzY5ODU4MTM4Nzc2NDY4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ca1d46bd88b08a5df891db389557d53c183b752ffffbeda713a38aa7cef151c
hovercard-subject-tagpull_request:181242154
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/23339/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/23339/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23339%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23339%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23339/files
Reloadhttps://github.com/angular/angular/pull/23339/files
Reloadhttps://github.com/angular/angular/pull/23339/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:feat-sw-nav-urlshttps://github.com/gkalpak/angular/tree/feat-sw-nav-urls
Conversation 7 https://github.com/angular/angular/pull/23339
Commits 4 https://github.com/angular/angular/pull/23339/commits
Checks 0 https://github.com/angular/angular/pull/23339/checks
Files changed https://github.com/angular/angular/pull/23339/files
Please reload this pagehttps://github.com/angular/angular/pull/23339/files
feat(service-worker): add support for configuring navigations URLs https://github.com/angular/angular/pull/23339/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/23339/files
080e687 docs(service-worker): minor fixes/improvements gkalpak Apr 12, 2018 https://github.com/angular/angular/pull/23339/commits/080e68706cc6d61ef5adb8b461fba3a6106829a8
c383b1a refactor(service-worker): move common code into method gkalpak Apr 12, 2018 https://github.com/angular/angular/pull/23339/commits/c383b1ad3d5dfccaeeafc391e5bb3456af18bf60
8116c46 feat(service-worker): add support for configuring navigations URLs gkalpak Apr 12, 2018 https://github.com/angular/angular/pull/23339/commits/8116c46e64fdb0c27de9c784a151875259a7d618
b5e94eb fix(service-worker): let `*` match 0 characters in globs gkalpak Apr 12, 2018 https://github.com/angular/angular/pull/23339/commits/b5e94eb9a516e1917121667a8d507686fb8987b4
Clear filters https://github.com/angular/angular/pull/23339/files
Please reload this pagehttps://github.com/angular/angular/pull/23339/files
Please reload this pagehttps://github.com/angular/angular/pull/23339/files
service-worker-config.md https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
service-worker-devops.md https://github.com/angular/angular/pull/23339/files#diff-1b65d7d4fdba9698c561086e93bcaaa7e16227e421247e8c7655a00108cda84b
service-worker-getting-started.md https://github.com/angular/angular/pull/23339/files#diff-ddf4bce1de1e5ec429ec0c1e309435ce4500dae4533e3604e6dc85d3aac5c7ea
generator.ts https://github.com/angular/angular/pull/23339/files#diff-d54cb76dc096fbfddf81f1365842a4b1e48e1e5f2327cfac2a4fc41fc55dfaae
glob.ts https://github.com/angular/angular/pull/23339/files#diff-97885721f41b58f13bd4ff36c10b03fd424292f4ce941bb75dabf1ba5d904848
in.ts https://github.com/angular/angular/pull/23339/files#diff-95971dc289fc6f401dbef4e1a9caa5a276695c648681b758cc5a6abab4dca4c7
generator_spec.ts https://github.com/angular/angular/pull/23339/files#diff-85abc9d25a07b6853113b010046e6669d5deafb3084d3630679f67cf5aaae329
integration_spec.ts https://github.com/angular/angular/pull/23339/files#diff-67c0d8ed714da7c02a3f2c3311416fe15af718406693182a567e385f9ccda06d
app-version.ts https://github.com/angular/angular/pull/23339/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
driver.ts https://github.com/angular/angular/pull/23339/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
manifest.ts https://github.com/angular/angular/pull/23339/files#diff-ecc267405b6795f79d0d7d19f454bc155c377983e21aa7acbbfddc2024cd9ccd
util.ts https://github.com/angular/angular/pull/23339/files#diff-2512fe755e0642d856b95683bff29514087c05b9dc3e82ded2e251f9fda32f36
BUILD.bazel https://github.com/angular/angular/pull/23339/files#diff-c4dec2605ff25b4637d9a780732659967eb860a05aa0592908f45baef018f617
data_spec.ts https://github.com/angular/angular/pull/23339/files#diff-ce726552c10b23d283b00304019e026c3d1d279f4df832213174e1be536fe51d
happy_spec.ts https://github.com/angular/angular/pull/23339/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
mock.ts https://github.com/angular/angular/pull/23339/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
scope.ts https://github.com/angular/angular/pull/23339/files#diff-0d3439d9cebfc8e31c28b3dc7a2ce03c4218532c492f1397f849cbdbde175680
config.d.ts https://github.com/angular/angular/pull/23339/files#diff-68bfd010b922c3a7057e56d2ff69f65c745368830d0b7ad8f5c55751dde9c3d5
aio/content/guide/service-worker-config.mdhttps://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
View file https://github.com/gkalpak/angular/blob/b5e94eb9a516e1917121667a8d507686fb8987b4/aio/content/guide/service-worker-config.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
https://github.com/angular/angular/pull/23339/files#diff-2f89404c5bac36b8f289ed1cb4a963b5f30a37168520667a040a14896fb543d4
Please reload this pagehttps://github.com/angular/angular/pull/23339/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.