René's URL Explorer Experiment


Title: feat(router): add ability to recover from malformed url by skryvets · Pull Request #23283 · angular/angular · GitHub

Open Graph Title: feat(router): add ability to recover from malformed url by skryvets · Pull Request #23283 · angular/angular

X Title: feat(router): add ability to recover from malformed url by skryvets · Pull Request #23283 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? Using invalid character sequences (like %) in the query param throws an exception that can't be catched anywhere and causing the app to crash. Issue Number: 21468 What is the new behavior? Code that might throw an exception is wrapped inside the try/catch construction preventing app from crash. Does this PR introduce a breaking change? [ ] Yes [x] No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/23283

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:88bfda2e-41c0-5906-3f88-ff440234d7fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF9C:10531B:1013A1:149149:6B00F868
html-safe-nonce00cc4a9bd1cdb547bf4a7a3090669125432215b05986b5ae1fbc8e329b0cfac0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlDOjEwNTMxQjoxMDEzQTE6MTQ5MTQ5OjZCMDBGODY4IiwidmlzaXRvcl9pZCI6IjUyMzcyMTY2NDA3Mzg4NTA5MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdde14d1ea979a09676c2a366cc403f1dc693d3ab80333ab5ef6163d0e0506b41
hovercard-subject-tagpull_request:180552657
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/23283/files
twitter:imagehttps://avatars.githubusercontent.com/u/10011693?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10011693?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/23283/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23283%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F23283%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/23283/files
Reloadhttps://github.com/angular/angular/pull/23283/files
Reloadhttps://github.com/angular/angular/pull/23283/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
skryvetshttps://github.com/skryvets
angular:masterhttps://github.com/angular/angular/tree/master
skryvets:fix-malformed-url-errorhttps://github.com/skryvets/angular/tree/fix-malformed-url-error
Conversation 23 https://github.com/angular/angular/pull/23283
Commits 2 https://github.com/angular/angular/pull/23283/commits
Checks 0 https://github.com/angular/angular/pull/23283/checks
Files changed https://github.com/angular/angular/pull/23283/files
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
feat(router): add ability to recover from malformed url https://github.com/angular/angular/pull/23283/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/23283/files
a04a1f8 fix(router): add ability to recover from malformed url Apr 10, 2018 https://github.com/angular/angular/pull/23283/commits/a04a1f8f60d7307f69f818f435621d5377985821
630b1f3 fixup! fix(router): add ability to recover from malformed url jasonaden Apr 18, 2018 https://github.com/angular/angular/pull/23283/commits/630b1f30f8139ace084f2c544379bc738d09b0fa
Clear filters https://github.com/angular/angular/pull/23283/files
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
router.ts https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
router_module.ts https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
integration.spec.ts https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
router_testing_module.ts https://github.com/angular/angular/pull/23283/files#diff-4528f9089874a35754157408b0ea04517c5b6c07b813be02452c35dc06eb8574
router.d.ts https://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
packages/router/src/router.tshttps://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
View file https://github.com/skryvets/angular/blob/630b1f30f8139ace084f2c544379bc738d09b0fa/packages/router/src/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23283/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
skryvetshttps://github.com/skryvets
Apr 10, 2018https://github.com/angular/angular/pull/23283/files#r180367106
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
jasonadenhttps://github.com/jasonaden
Apr 10, 2018https://github.com/angular/angular/pull/23283/files#r180576790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/23283/files
https://github.com/angular/angular/pull/23283/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
packages/router/src/router_module.tshttps://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
View file https://github.com/skryvets/angular/blob/630b1f30f8139ace084f2c544379bc738d09b0fa/packages/router/src/router_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23283/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/23283/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
View file https://github.com/skryvets/angular/blob/630b1f30f8139ace084f2c544379bc738d09b0fa/packages/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23283/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/23283/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
packages/router/testing/src/router_testing_module.tshttps://github.com/angular/angular/pull/23283/files#diff-4528f9089874a35754157408b0ea04517c5b6c07b813be02452c35dc06eb8574
View file https://github.com/skryvets/angular/blob/630b1f30f8139ace084f2c544379bc738d09b0fa/packages/router/testing/src/router_testing_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23283/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23283/files#diff-4528f9089874a35754157408b0ea04517c5b6c07b813be02452c35dc06eb8574
https://github.com/angular/angular/pull/23283/files#diff-4528f9089874a35754157408b0ea04517c5b6c07b813be02452c35dc06eb8574
tools/public_api_guard/router/router.d.tshttps://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
View file https://github.com/skryvets/angular/blob/630b1f30f8139ace084f2c544379bc738d09b0fa/tools/public_api_guard/router/router.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/23283/{{ revealButtonHref }}
https://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
https://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
https://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
https://github.com/angular/angular/pull/23283/files#diff-24768702f2396eb124b706eabbf88087d5e745d6062b7eb58b505a6d2d28703c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.