| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8bb6d914-ea4d-e0b4-f5e3-3ddc36bdb66c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9304:19E4BB:20331B4:290BFAA:6B01723C |
| html-safe-nonce | e10f20210ee327f5c2ab497426822a584ae719560ee852aef5b9b1b61bec17ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzA0OjE5RTRCQjoyMDMzMUI0OjI5MEJGQUE6NkIwMTcyM0MiLCJ2aXNpdG9yX2lkIjoiODY0MDYwOTY1MDIwMDM3NTg2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | baaf54b2896e124d98d5c28ebacf0ea0aaf8041e0e4309728c252d3779cf0a0f |
| hovercard-subject-tag | pull_request:176188943 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/22883/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | PR Checklist
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Do... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/22883/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/22883/files |
| Reload | https://github.com/angular/angular/pull/22883/files |
| Reload | https://github.com/angular/angular/pull/22883/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-sw-offline | https://github.com/gkalpak/angular/tree/fix-sw-offline |
|
Conversation
20
| https://github.com/angular/angular/pull/22883 |
|
Commits
4
| https://github.com/angular/angular/pull/22883/commits |
|
Checks
0
| https://github.com/angular/angular/pull/22883/checks |
|
Files changed
| https://github.com/angular/angular/pull/22883/files |
| Please reload this page | https://github.com/angular/angular/pull/22883/files |
|
fix(service-worker): handle offline mode and ignore invalid only-if-cached requests
| https://github.com/angular/angular/pull/22883/files#top |
|
Show all changes
4 commits
| https://github.com/angular/angular/pull/22883/files |
|
68d78a9
test(service-worker): minor test fixes and refactorings
gkalpak Mar 19, 2018
| https://github.com/angular/angular/pull/22883/commits/68d78a9d8f5f8b05a3b39bbc6293739ff962a94a |
|
5f8b373
fix(service-worker): do not enter degraded mode when offline
gkalpak Mar 19, 2018
| https://github.com/angular/angular/pull/22883/commits/5f8b373c8c90f4e7b0b205b4cb43fe9b9e668151 |
|
b0002ba
fix(service-worker): ignore invalid `only-if-cached` requests
gkalpak Mar 20, 2018
| https://github.com/angular/angular/pull/22883/commits/b0002badcc4c2c342d70c9ec08867424579a4962 |
|
76109cb
fixup! fix(service-worker): ignore invalid `only-if-cached` requests
gkalpak Mar 26, 2018
| https://github.com/angular/angular/pull/22883/commits/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
|
Clear filters
| https://github.com/angular/angular/pull/22883/files |
| Please reload this page | https://github.com/angular/angular/pull/22883/files |
| Please reload this page | https://github.com/angular/angular/pull/22883/files |
|
driver.ts
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
happy_spec.ts
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
fetch.ts
| https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9 |
|
mock.ts
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
| packages/service-worker/worker/src/driver.ts | https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
View file
| https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/src/driver.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/22883/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
|
| https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
| packages/service-worker/worker/test/happy_spec.ts | https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
View file
| https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/test/happy_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/22883/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
|
| https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d |
| packages/service-worker/worker/testing/fetch.ts | https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9 |
|
View file
| https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/testing/fetch.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/22883/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9 |
|
| https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9 |
|
| https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9 |
| packages/service-worker/worker/testing/mock.ts | https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
View file
| https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/testing/mock.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/22883/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
| https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |