René's URL Explorer Experiment


Title: fix(service-worker): handle offline mode and ignore invalid `only-if-cached` requests by gkalpak · Pull Request #22883 · angular/angular · GitHub

Open Graph Title: fix(service-worker): handle offline mode and ignore invalid `only-if-cached` requests by gkalpak · Pull Request #22883 · angular/angular

X Title: fix(service-worker): handle offline mode and ignore invalid `only-if-cached` requests by gkalpak · Pull Request #22883 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type [x] Bugfix What is the current behavior? This PR fixes two issues: When trying to fetch ngsw.json (e.g. during checkForUpdate()) while either the client or the server are offline, the ServiceWorker would enter a degrade mode, where only existing clients would be served. This essentially means that the ServiceWorker doesn't work offline. Under some circumstances (possibly related to opening Chrome DevTools), requests are made with cache: 'only-if-cached' and mode: 'no-cors'. These request will eventually fail, because only-if-cached is only allowed to be used with mode: 'same-origin'. This is likely a bug in Chrome DevTools. See also #22362 (comment). Issue Number: #21636, #22362 What is the new behavior? Offline errors (status: 504) are treated differently than other fetch errors and the SW doesn't enter degraded mode. The ServiceWorker will remain in the current mode until connectivity to the server is restored. Invalid only-if-cached requests (i.e. with mode !== 'same-origin') are not handled by the SW. Does this PR introduce a breaking change? [ ] Yes [x] No Other information Fixes #21636 and #22362.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...

Opengraph URL: https://github.com/angular/angular/pull/22883

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4d2a241a-7cf6-3cb0-a524-a735519db6db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9042:2AAD2E:14DE293:1BD7261:6B0134FD
html-safe-nonce88fbf1cc32be25f7a77bad0c847477f1b4c7c5496dcbfd881bf6d15c0e15423c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQyOjJBQUQyRToxNERFMjkzOjFCRDcyNjE6NkIwMTM0RkQiLCJ2aXNpdG9yX2lkIjoiNjQxOTYwNzE3NDM4ODk4NzEzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50ce3ef80175ea970f996779def42237726222e624ca7d466ff0f7d1d2bf76b6
hovercard-subject-tagpull_request:176188943
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/22883/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Do...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/22883/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/22883/files
Reloadhttps://github.com/angular/angular/pull/22883/files
Reloadhttps://github.com/angular/angular/pull/22883/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-sw-offlinehttps://github.com/gkalpak/angular/tree/fix-sw-offline
Conversation 20 https://github.com/angular/angular/pull/22883
Commits 4 https://github.com/angular/angular/pull/22883/commits
Checks 0 https://github.com/angular/angular/pull/22883/checks
Files changed https://github.com/angular/angular/pull/22883/files
Please reload this pagehttps://github.com/angular/angular/pull/22883/files
fix(service-worker): handle offline mode and ignore invalid only-if-cached requests https://github.com/angular/angular/pull/22883/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/22883/files
68d78a9 test(service-worker): minor test fixes and refactorings gkalpak Mar 19, 2018 https://github.com/angular/angular/pull/22883/commits/68d78a9d8f5f8b05a3b39bbc6293739ff962a94a
5f8b373 fix(service-worker): do not enter degraded mode when offline gkalpak Mar 19, 2018 https://github.com/angular/angular/pull/22883/commits/5f8b373c8c90f4e7b0b205b4cb43fe9b9e668151
b0002ba fix(service-worker): ignore invalid `only-if-cached` requests gkalpak Mar 20, 2018 https://github.com/angular/angular/pull/22883/commits/b0002badcc4c2c342d70c9ec08867424579a4962
76109cb fixup! fix(service-worker): ignore invalid `only-if-cached` requests gkalpak Mar 26, 2018 https://github.com/angular/angular/pull/22883/commits/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853
Clear filters https://github.com/angular/angular/pull/22883/files
Please reload this pagehttps://github.com/angular/angular/pull/22883/files
Please reload this pagehttps://github.com/angular/angular/pull/22883/files
driver.ts https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
happy_spec.ts https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
fetch.ts https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
mock.ts https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
packages/service-worker/worker/src/driver.tshttps://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
View file https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/src/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22883/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
packages/service-worker/worker/test/happy_spec.tshttps://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
View file https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/test/happy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22883/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/22883/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
packages/service-worker/worker/testing/fetch.tshttps://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
View file https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/testing/fetch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22883/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
https://github.com/angular/angular/pull/22883/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
packages/service-worker/worker/testing/mock.tshttps://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
View file https://github.com/gkalpak/angular/blob/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853/packages/service-worker/worker/testing/mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22883/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/22883/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.