| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:1a82595e-ef68-28e8-b3a8-0fa6198e7b32 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB5A:2652DC:13CE92E:195D1B4:6B01157D |
| html-safe-nonce | ae8eff0c0824890fdca17d0b8dd9b69e61e70583e4e5529858ea747e423cb5b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjVBOjI2NTJEQzoxM0NFOTJFOjE5NUQxQjQ6NkIwMTE1N0QiLCJ2aXNpdG9yX2lkIjoiNzA5MTQ2NzA3ODg0NjE5MDk3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 227c19a56257423891ad650b73f285d5a7235fd329383ff8c35cf8b213dc0861 |
| hovercard-subject-tag | pull_request:176188943 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/22883 |
| twitter:image | https://opengraph.githubassets.com/7850602b99660537094c5cbad40dc7629b6771157c6ef07e020f79be11aa4f16/angular/angular/pull/22883 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7850602b99660537094c5cbad40dc7629b6771157c6ef07e020f79be11aa4f16/angular/angular/pull/22883 |
| og:image:alt | PR Checklist
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/22883#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/22883 |
| Reload | https://github.com/angular/angular/pull/22883 |
| Reload | https://github.com/angular/angular/pull/22883 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-sw-offline | https://github.com/gkalpak/angular/tree/fix-sw-offline |
| Conversation | https://github.com/angular/angular/pull/22883 |
| Commits4 (4) | https://github.com/angular/angular/pull/22883/commits |
| Checks | https://github.com/angular/angular/pull/22883/checks |
| Files changed | https://github.com/angular/angular/pull/22883/files |
| fix(service-worker): handle offline mode and ignore invalid only-if-cached requests | https://github.com/angular/angular/pull/22883#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-sw-offline | https://github.com/gkalpak/angular/tree/fix-sw-offline |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 20, 2018 | https://github.com/angular/angular/pull/22883#issue-306863635 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| used with mode: 'same-origin' | https://developer.mozilla.org/en-US/docs/Web/API/Request/cache |
| Failed to load resource: the server responded with a status of 504 (Gateway Timeout) #22362 (comment) | https://github.com/angular/angular/issues/22362#issuecomment-369116888 |
| #21636 | https://github.com/angular/angular/issues/21636 |
| #22362 | https://github.com/angular/angular/issues/22362 |
| #21636 | https://github.com/angular/angular/issues/21636 |
| #22362 | https://github.com/angular/angular/issues/22362 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 20, 2018 | https://github.com/angular/angular/pull/22883#event-1530889978 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| alxhub | https://github.com/alxhub |
| March 20, 2018 13:25 | https://github.com/angular/angular/pull/22883#event-1530890061 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
area: service-worker
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22 |
| Mar 20, 2018 | https://github.com/angular/angular/pull/22883#event-1530890779 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 20, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-374599346 |
| https://pr22883-aa7b71c.ngbuilds.io/ | https://pr22883-aa7b71c.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
|
[ServiceWorker] localhost took too long to respond. HTTP ERROR 504
#21636
| https://github.com/angular/angular/issues/21636 |
|
[Service Worker] Can't update sw if in SAFE_MODE
#22087
| https://github.com/angular/angular/issues/22087 |
|
feat(aio): Convert AIO to use the new Service Worker 5.0.0.
#19795
| https://github.com/angular/angular/pull/19795 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Mar 21, 2018
| https://github.com/angular/angular/pull/22883#pullrequestreview-105873066 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22883/files |
| packages/service-worker/worker/src/driver.ts | https://github.com/angular/angular/pull/22883/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1 |
| alxhub | https://github.com/alxhub |
| Mar 21, 2018 | https://github.com/angular/angular/pull/22883#discussion_r176209393 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| gkalpak | https://github.com/gkalpak |
| Mar 21, 2018 | https://github.com/angular/angular/pull/22883#discussion_r176214534 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| alxhub | https://github.com/alxhub |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22883#discussion_r176752826 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| gkalpak | https://github.com/gkalpak |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22883#discussion_r176790322 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/aa7b71c51b7e9c4aa275bf4539009ae51c05f66c..0535086f3b495842ef9beccda7a6660c45eb6ad8 |
| aa7b71c | https://github.com/angular/angular/commit/aa7b71c51b7e9c4aa275bf4539009ae51c05f66c |
| 0535086 | https://github.com/angular/angular/commit/0535086f3b495842ef9beccda7a6660c45eb6ad8 |
|
Compare
| https://github.com/angular/angular/compare/aa7b71c51b7e9c4aa275bf4539009ae51c05f66c..0535086f3b495842ef9beccda7a6660c45eb6ad8 |
| March 23, 2018 16:19 | https://github.com/angular/angular/pull/22883#event-1538237197 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-375724212 |
| https://pr22883-0535086.ngbuilds.io/ | https://pr22883-0535086.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| gkalpak | https://github.com/gkalpak |
| March 23, 2018 23:14 | https://github.com/angular/angular/pull/22883#commits-pushed-68d78a9 |
|
| https://github.com/gkalpak |
| test(service-worker): minor test fixes and refactorings | https://github.com/angular/angular/pull/22883/commits/68d78a9d8f5f8b05a3b39bbc6293739ff962a94a |
| 68d78a9 | https://github.com/angular/angular/pull/22883/commits/68d78a9d8f5f8b05a3b39bbc6293739ff962a94a |
|
| https://github.com/gkalpak |
| fix(service-worker): do not enter degraded mode when offline | https://github.com/angular/angular/pull/22883/commits/5f8b373c8c90f4e7b0b205b4cb43fe9b9e668151 |
| 5f8b373 | https://github.com/angular/angular/pull/22883/commits/5f8b373c8c90f4e7b0b205b4cb43fe9b9e668151 |
| angular#21636 | https://github.com/angular/angular/issues/21636 |
|
| https://github.com/gkalpak |
| fix(service-worker): ignore invalid only-if-cached requests | https://github.com/angular/angular/pull/22883/commits/b0002badcc4c2c342d70c9ec08867424579a4962 |
| b0002ba | https://github.com/angular/angular/pull/22883/commits/b0002badcc4c2c342d70c9ec08867424579a4962 |
| angular#22362 | https://github.com/angular/angular/issues/22362 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/0535086f3b495842ef9beccda7a6660c45eb6ad8..5fae6e7d0de4c3233d5f58272f8478623acb2be5 |
| 0535086 | https://github.com/angular/angular/commit/0535086f3b495842ef9beccda7a6660c45eb6ad8 |
| 5fae6e7 | https://github.com/angular/angular/commit/5fae6e7d0de4c3233d5f58272f8478623acb2be5 |
|
Compare
| https://github.com/angular/angular/compare/0535086f3b495842ef9beccda7a6660c45eb6ad8..5fae6e7d0de4c3233d5f58272f8478623acb2be5 |
| March 23, 2018 21:15 | https://github.com/angular/angular/pull/22883#event-1538773152 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-375802411 |
| https://pr22883-5fae6e7.ngbuilds.io/ | https://pr22883-5fae6e7.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 25, 2018
| https://github.com/angular/angular/pull/22883#ref-issue-308318443 |
|
Service Worker does not work for offline applications
#22976
| https://github.com/angular/angular/issues/22976 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/5fae6e7d0de4c3233d5f58272f8478623acb2be5..0235d689afab9a2232b4ede38473b4090f392f61 |
| 5fae6e7 | https://github.com/angular/angular/commit/5fae6e7d0de4c3233d5f58272f8478623acb2be5 |
| 0235d68 | https://github.com/angular/angular/commit/0235d689afab9a2232b4ede38473b4090f392f61 |
|
Compare
| https://github.com/angular/angular/compare/5fae6e7d0de4c3233d5f58272f8478623acb2be5..0235d689afab9a2232b4ede38473b4090f392f61 |
| March 26, 2018 10:54 | https://github.com/angular/angular/pull/22883#event-1540566616 |
|
| https://github.com/gkalpak |
| fixup! fix(service-worker): ignore invalid only-if-cached requests | https://github.com/angular/angular/pull/22883/commits/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
| 76109cb | https://github.com/angular/angular/pull/22883/commits/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/0235d689afab9a2232b4ede38473b4090f392f61..76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
| 0235d68 | https://github.com/angular/angular/commit/0235d689afab9a2232b4ede38473b4090f392f61 |
| 76109cb | https://github.com/angular/angular/commit/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
|
Compare
| https://github.com/angular/angular/compare/0235d689afab9a2232b4ede38473b4090f392f61..76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
| March 26, 2018 11:03 | https://github.com/angular/angular/pull/22883#event-1540582272 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 26, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-376129092 |
| https://pr22883-0235d68.ngbuilds.io/ | https://pr22883-0235d68.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 26, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-376130580 |
| 76109cb | https://github.com/angular/angular/commit/76109cb91bcdcebeee309f5a1d6bf1ba8bd5e853 |
| https://pr22883-76109cb.ngbuilds.io/ | https://pr22883-76109cb.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 27, 2018 | https://github.com/angular/angular/pull/22883#event-1542482918 |
| https://github.com/Aarchana |
| Aarchana | https://github.com/Aarchana |
| Mar 27, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-376618972 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 27, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-376638896 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 12665a7 | https://github.com/angular/angular/commit/12665a749c6bdcd7619ef4d8aef616cf4133129e |
| Mar 28, 2018 | https://github.com/angular/angular/pull/22883#event-1546100105 |
| alxhub | https://github.com/alxhub |
|
Mar 28, 2018
| https://github.com/angular/angular/pull/22883#ref-commit-9e9b8dd |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): do not enter degraded mode when offline ( | https://github.com/angular/angular/commit/9e9b8dd494cac7f1bd3a6f0effded7a15023ce1a |
| #22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/angular/angular/commit/9e9b8dd494cac7f1bd3a6f0effded7a15023ce1a |
| 9e9b8dd | https://github.com/angular/angular/commit/9e9b8dd494cac7f1bd3a6f0effded7a15023ce1a |
| #21636 | https://github.com/angular/angular/issues/21636 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| alxhub | https://github.com/alxhub |
|
Mar 28, 2018
| https://github.com/angular/angular/pull/22883#ref-commit-d9dc46e |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): ignore invalid | https://github.com/angular/angular/commit/d9dc46e651d34f3df7f8607bbef415c8a2d6a88d |
| only-if-cached | https://github.com/angular/angular/commit/d9dc46e651d34f3df7f8607bbef415c8a2d6a88d |
| requests ( | https://github.com/angular/angular/commit/d9dc46e651d34f3df7f8607bbef415c8a2d6a88d |
| #22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/angular/angular/commit/d9dc46e651d34f3df7f8607bbef415c8a2d6a88d |
| d9dc46e | https://github.com/angular/angular/commit/d9dc46e651d34f3df7f8607bbef415c8a2d6a88d |
| #22362 | https://github.com/angular/angular/issues/22362 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| alxhub | https://github.com/alxhub |
|
Mar 28, 2018
| https://github.com/angular/angular/pull/22883#ref-commit-d0f575b |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| test(service-worker): minor test fixes and refactorings ( | https://github.com/angular/angular/commit/d0f575bc54b037f029d6a444802ea86daa38f2a9 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/angular/angular/commit/d0f575bc54b037f029d6a444802ea86daa38f2a9 |
| d0f575b | https://github.com/angular/angular/commit/d0f575bc54b037f029d6a444802ea86daa38f2a9 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| alxhub | https://github.com/alxhub |
|
Mar 28, 2018
| https://github.com/angular/angular/pull/22883#ref-commit-ae9c25f |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): do not enter degraded mode when offline ( | https://github.com/angular/angular/commit/ae9c25ff3dd635115160f107135ddc26f43fac1c |
| #22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/angular/angular/commit/ae9c25ff3dd635115160f107135ddc26f43fac1c |
| ae9c25f | https://github.com/angular/angular/commit/ae9c25ff3dd635115160f107135ddc26f43fac1c |
| #21636 | https://github.com/angular/angular/issues/21636 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| alxhub | https://github.com/alxhub |
|
Mar 28, 2018
| https://github.com/angular/angular/pull/22883#ref-commit-0d4fe38 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): ignore invalid | https://github.com/angular/angular/commit/0d4fe38a09cd52a130cc57d3901649e61193ecc4 |
| only-if-cached | https://github.com/angular/angular/commit/0d4fe38a09cd52a130cc57d3901649e61193ecc4 |
| requests ( | https://github.com/angular/angular/commit/0d4fe38a09cd52a130cc57d3901649e61193ecc4 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/angular/angular/commit/0d4fe38a09cd52a130cc57d3901649e61193ecc4 |
| 0d4fe38 | https://github.com/angular/angular/commit/0d4fe38a09cd52a130cc57d3901649e61193ecc4 |
| #22362 | https://github.com/angular/angular/issues/22362 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| March 28, 2018 18:34 | https://github.com/angular/angular/pull/22883#event-1546291297 |
| https://github.com/jnrndn |
| jnrndn | https://github.com/jnrndn |
|
Mar 29, 2018
| https://github.com/angular/angular/pull/22883#ref-issue-309041985 |
|
PWA is not working in offline mode
ngcolombia/ngcolombia-2018#24
| https://github.com/ngcolombia/ngcolombia-2018/issues/24 |
| https://github.com/Aarchana |
| Aarchana | https://github.com/Aarchana |
| Mar 30, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-377628829 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Apr 2, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-377907892 |
| scheduled | https://github.com/angular/angular/blob/43d62029f0e2da0150ba6f09fd8989ca6391a355/docs/RELEASE_SCHEDULE.md |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Apr 3, 2018
| https://github.com/angular/angular/pull/22883#ref-issue-310734787 |
|
Angular service worker stop working after going offline
#23135
| https://github.com/angular/angular/issues/23135 |
| https://github.com/Aarchana |
| Aarchana | https://github.com/Aarchana |
| Apr 5, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-378980180 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Apr 24, 2018
| https://github.com/angular/angular/pull/22883#ref-issue-317314939 |
|
Service worker updates do not work on latest chrome (Chrome 66.0.3359.117 )
#23526
| https://github.com/angular/angular/issues/23526 |
| https://github.com/tobyStaff |
| tobyStaff | https://github.com/tobyStaff |
| May 4, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-386572380 |
| #22883 | https://github.com/angular/angular/pull/22883 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/probert94 |
| probert94 | https://github.com/probert94 |
| May 4, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-386583858 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 5, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-386798035 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/ALGDB |
| ALGDB | https://github.com/ALGDB |
| May 8, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-387410815 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| May 9, 2018 | https://github.com/angular/angular/pull/22883#issuecomment-387678981 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/22883#issuecomment-531269033 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/22883#event-2632610693 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/22883#ref-commit-d4aab32 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| test(service-worker): minor test fixes and refactorings ( | https://github.com/adhambaouz/angular/commit/d4aab32e292be3210f29839d33aec777e7b97ff4 |
| angular#22883 | https://github.com/angular/angular/pull/22883 |
| ) | https://github.com/adhambaouz/angular/commit/d4aab32e292be3210f29839d33aec777e7b97ff4 |
| d4aab32 | https://github.com/adhambaouz/angular/commit/d4aab32e292be3210f29839d33aec777e7b97ff4 |
| angular#22883 | https://github.com/angular/angular/pull/22883 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/22883#ref-commit-133fd31 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): do not enter degraded mode when offline ( | https://github.com/adhambaouz/angular/commit/133fd3132816aa4cf873ef06b2e871dab301aa5b |
| angular… | https://github.com/angular/angular/pull/22883 |
| 133fd31 | https://github.com/adhambaouz/angular/commit/133fd3132816aa4cf873ef06b2e871dab301aa5b |
| …#22883 | https://github.com/angular/angular/pull/22883 |
| angular#21636 | https://github.com/angular/angular/issues/21636 |
| angular#22883 | https://github.com/angular/angular/pull/22883 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/22883#ref-commit-5230dc4 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(service-worker): ignore invalid | https://github.com/adhambaouz/angular/commit/5230dc42e34393144ea516356b6dbf4665cb1636 |
| only-if-cached | https://github.com/adhambaouz/angular/commit/5230dc42e34393144ea516356b6dbf4665cb1636 |
| requests ( | https://github.com/adhambaouz/angular/commit/5230dc42e34393144ea516356b6dbf4665cb1636 |
| angula… | https://github.com/angular/angular/pull/22883 |
| 5230dc4 | https://github.com/adhambaouz/angular/commit/5230dc42e34393144ea516356b6dbf4665cb1636 |
| …r#22883 | https://github.com/angular/angular/pull/22883 |
| angular#22362 | https://github.com/angular/angular/issues/22362 |
| angular#22883 | https://github.com/angular/angular/pull/22883 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22883 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/22883/files/aa7b71c51b7e9c4aa275bf4539009ae51c05f66c |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: service-worker
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
[ServiceWorker] localhost took too long to respond. HTTP ERROR 504
| https://github.com/angular/angular/issues/21636 |
| Please reload this page | https://github.com/angular/angular/pull/22883 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/Aarchana |
|
| https://github.com/tobyStaff |
|
| https://github.com/probert94 |
|
| https://github.com/ALGDB |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |