| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:c6b292a0-ae35-3e4e-eb2b-9bae4609922b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B166:38C5CF:D105DB:10D199D:6B00EF2D |
| html-safe-nonce | 554f6f6ab6d8d400ed8614eebd1a61c14002d47ead0d91893796c26c40e99170 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTY2OjM4QzVDRjpEMTA1REI6MTBEMTk5RDo2QjAwRUYyRCIsInZpc2l0b3JfaWQiOiI4MTU0NDU3ODA1MTM1MzQzNDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d2256eaad29f8f3ebbc791172bc07e4e33af530f9a697331bd6d85d2e9ed97b0 |
| hovercard-subject-tag | pull_request:174226630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/22705 |
| twitter:image | https://opengraph.githubassets.com/9064309394fda9c36a250f31f985e30b287313f01cc5b3301024eb69278a34de/angular/angular/pull/22705 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9064309394fda9c36a250f31f985e30b287313f01cc5b3301024eb69278a34de/angular/angular/pull/22705 |
| og:image:alt | Fixes #22593
PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benbraou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/22705#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22705 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22705 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/22705 |
| Reload | https://github.com/angular/angular/pull/22705 |
| Reload | https://github.com/angular/angular/pull/22705 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| benbraou | https://github.com/benbraou |
| angular:master | https://github.com/angular/angular/tree/master |
| benbraou:issue22593 | https://github.com/benbraou/angular/tree/issue22593 |
| Conversation | https://github.com/angular/angular/pull/22705 |
| Commits2 (2) | https://github.com/angular/angular/pull/22705/commits |
| Checks | https://github.com/angular/angular/pull/22705/checks |
| Files changed | https://github.com/angular/angular/pull/22705/files |
| fix(compiler-cli): use numeric comparison for TypeScript version | https://github.com/angular/angular/pull/22705#top |
| benbraou | https://github.com/benbraou |
| angular:master | https://github.com/angular/angular/tree/master |
| benbraou:issue22593 | https://github.com/benbraou/angular/tree/issue22593 |
|
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 11, 2018 | https://github.com/angular/angular/pull/22705#issue-304167694 |
| #22593 | https://github.com/angular/angular/issues/22593 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #22593 | https://github.com/angular/angular/issues/22593 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 11, 2018 | https://github.com/angular/angular/pull/22705#event-1515078354 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
|
Mar 11, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-102886114 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/src/transformers/program.ts | https://github.com/angular/angular/pull/22705/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b |
| benbraou | https://github.com/benbraou |
| Mar 11, 2018 | https://github.com/angular/angular/pull/22705#discussion_r173658864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #22701 | https://github.com/angular/angular/pull/22701 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/4e23a0b9696520ae540b0a0768eb00543abe02ad..c21f67feb3c76ce99c3c5ea7f02c35a9cf99d1bb |
| 4e23a0b | https://github.com/angular/angular/commit/4e23a0b9696520ae540b0a0768eb00543abe02ad |
| c21f67f | https://github.com/angular/angular/commit/c21f67feb3c76ce99c3c5ea7f02c35a9cf99d1bb |
|
Compare
| https://github.com/angular/angular/compare/4e23a0b9696520ae540b0a0768eb00543abe02ad..c21f67feb3c76ce99c3c5ea7f02c35a9cf99d1bb |
| March 11, 2018 16:12 | https://github.com/angular/angular/pull/22705#event-1515091640 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 11, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-372127445 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#event-1516945391 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-372420731 |
| @benbraou | https://github.com/benbraou |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-372439711 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#event-1517131626 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 12, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-103231910 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/src/diagnostics/typescript_symbols.ts | https://github.com/angular/angular/pull/22705/files#diff-6349b7a394baff5383c0991078e193dd1e3a2086ca4630bfc3c83aa232e737d7 |
| vicb | https://github.com/vicb |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#discussion_r173957237 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#discussion_r173975009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 12, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-372474139 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/b9412eb76fdbc5d07ed40ff1878978be1412dc8a..51bb8b6a54deede9b0812dead994cf426a4e8929 |
| b9412eb | https://github.com/angular/angular/commit/b9412eb76fdbc5d07ed40ff1878978be1412dc8a |
| 51bb8b6 | https://github.com/angular/angular/commit/51bb8b6a54deede9b0812dead994cf426a4e8929 |
|
Compare
| https://github.com/angular/angular/compare/b9412eb76fdbc5d07ed40ff1878978be1412dc8a..51bb8b6a54deede9b0812dead994cf426a4e8929 |
| March 13, 2018 03:43 | https://github.com/angular/angular/pull/22705#event-1517713083 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 13, 2018 | https://github.com/angular/angular/pull/22705#event-1517716101 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 13, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-372544079 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
|
Mar 13, 2018
| https://github.com/angular/angular/pull/22705#ref-pullrequest-304117686 |
|
test(compiler-cli): add tests for supported TS versions
#22701
| https://github.com/angular/angular/pull/22701 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 22, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106256320 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/src/transformers/program.ts | https://github.com/angular/angular/pull/22705/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b |
| vicb | https://github.com/vicb |
| Mar 22, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176534744 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| vicb | https://github.com/vicb |
| Mar 22, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176534853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176857129 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 22, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106256571 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/test/diagnostics/typescript_version_spec.ts | https://github.com/angular/angular/pull/22705/files#diff-d4f3fa87f5dfd6b3c15469ebddeed7c995073bde309ed346ccd68c96b814ec4e |
| vicb | https://github.com/vicb |
| Mar 22, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176534930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176855350 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 22, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106256739 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/test/diagnostics/typescript_version_spec.ts | https://github.com/angular/angular/pull/22705/files#diff-d4f3fa87f5dfd6b3c15469ebddeed7c995073bde309ed346ccd68c96b814ec4e |
| vicb | https://github.com/vicb |
| Mar 22, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176535065 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176855377 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 22, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106257135 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| vicb | https://github.com/vicb |
| https://github.com/angular/angular/pull/22705#pullrequestreview-106257135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
|
Mar 23, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106638897 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/test/diagnostics/typescript_version_spec.ts | https://github.com/angular/angular/pull/22705/files#diff-d4f3fa87f5dfd6b3c15469ebddeed7c995073bde309ed346ccd68c96b814ec4e |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176855350 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| packages/compiler-cli/test/diagnostics/typescript_version_spec.ts | https://github.com/angular/angular/pull/22705/files#diff-d4f3fa87f5dfd6b3c15469ebddeed7c995073bde309ed346ccd68c96b814ec4e |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176855377 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| packages/compiler-cli/test/diagnostics/typescript_version_spec.ts | https://github.com/angular/angular/pull/22705/files#diff-d4f3fa87f5dfd6b3c15469ebddeed7c995073bde309ed346ccd68c96b814ec4e |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176855451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vicb | https://github.com/vicb |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/51bb8b6a54deede9b0812dead994cf426a4e8929..e3cc3a69f3d38b7023bb6eb18eb397591cd5fb32 |
| 51bb8b6 | https://github.com/angular/angular/commit/51bb8b6a54deede9b0812dead994cf426a4e8929 |
| e3cc3a6 | https://github.com/angular/angular/commit/e3cc3a69f3d38b7023bb6eb18eb397591cd5fb32 |
|
Compare
| https://github.com/angular/angular/compare/51bb8b6a54deede9b0812dead994cf426a4e8929..e3cc3a69f3d38b7023bb6eb18eb397591cd5fb32 |
| March 23, 2018 20:56 | https://github.com/angular/angular/pull/22705#event-1538743982 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 23, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-375811276 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/ea67dc695b2246d3e8c8974f1c32941fbe4126ba..387826e8f27d15b4565667e292c3094d62e86dcd |
| ea67dc6 | https://github.com/angular/angular/commit/ea67dc695b2246d3e8c8974f1c32941fbe4126ba |
| 387826e | https://github.com/angular/angular/commit/387826e8f27d15b4565667e292c3094d62e86dcd |
|
Compare
| https://github.com/angular/angular/compare/ea67dc695b2246d3e8c8974f1c32941fbe4126ba..387826e8f27d15b4565667e292c3094d62e86dcd |
| March 24, 2018 15:21 | https://github.com/angular/angular/pull/22705#event-1539236804 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 24, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-375904987 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/387826e8f27d15b4565667e292c3094d62e86dcd..fec2264536ae4d03029b12c7a27231dfa9dcef66 |
| 387826e | https://github.com/angular/angular/commit/387826e8f27d15b4565667e292c3094d62e86dcd |
| fec2264 | https://github.com/angular/angular/commit/fec2264536ae4d03029b12c7a27231dfa9dcef66 |
|
Compare
| https://github.com/angular/angular/compare/387826e8f27d15b4565667e292c3094d62e86dcd..fec2264536ae4d03029b12c7a27231dfa9dcef66 |
| March 24, 2018 19:55 | https://github.com/angular/angular/pull/22705#event-1539338442 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 25, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106715614 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/src/diagnostics/typescript_symbols.ts | https://github.com/angular/angular/pull/22705/files#diff-6349b7a394baff5383c0991078e193dd1e3a2086ca4630bfc3c83aa232e737d7 |
| vicb | https://github.com/vicb |
| Mar 25, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176925574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 25, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176943923 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
Mar 25, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-106715744 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files |
| packages/compiler-cli/src/diagnostics/typescript_symbols.ts | https://github.com/angular/angular/pull/22705/files#diff-6349b7a394baff5383c0991078e193dd1e3a2086ca4630bfc3c83aa232e737d7 |
| vicb | https://github.com/vicb |
| Mar 25, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176925705 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| benbraou | https://github.com/benbraou |
| Mar 25, 2018 | https://github.com/angular/angular/pull/22705#discussion_r176943930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#event-1546990659 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377103567 |
| http://test/OCL:190874633:BASE:190874643:1522291696988:7171a71f | http://test/OCL:190874633:BASE:190874643:1522291696988:7171a71f |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#event-1547117406 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#event-1547117575 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377125379 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377299828 |
| @vicb | https://github.com/vicb |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/8a695657283f591e38a9d17f4e6871c7b7ecebca..85cf698564f783fee181750d936e7dbc9558b865 |
| 8a69565 | https://github.com/angular/angular/commit/8a695657283f591e38a9d17f4e6871c7b7ecebca |
| 85cf698 | https://github.com/angular/angular/commit/85cf698564f783fee181750d936e7dbc9558b865 |
|
Compare
| https://github.com/angular/angular/compare/8a695657283f591e38a9d17f4e6871c7b7ecebca..85cf698564f783fee181750d936e7dbc9558b865 |
| March 29, 2018 16:52 | https://github.com/angular/angular/pull/22705#event-1548338137 |
|
| https://github.com/benbraou |
| fix(compiler-cli): use numeric comparison for TypeScript version | https://github.com/angular/angular/pull/22705/commits/00ebb33be81e0fd4ecd01b836467d5997b2d305e |
| 00ebb33 | https://github.com/angular/angular/pull/22705/commits/00ebb33be81e0fd4ecd01b836467d5997b2d305e |
| angular#22593 | https://github.com/angular/angular/issues/22593 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/85cf698564f783fee181750d936e7dbc9558b865..1b5a3ec883d12c144dc3d838ec3dc44a48163602 |
| 85cf698 | https://github.com/angular/angular/commit/85cf698564f783fee181750d936e7dbc9558b865 |
| 1b5a3ec | https://github.com/angular/angular/commit/1b5a3ec883d12c144dc3d838ec3dc44a48163602 |
|
Compare
| https://github.com/angular/angular/compare/85cf698564f783fee181750d936e7dbc9558b865..1b5a3ec883d12c144dc3d838ec3dc44a48163602 |
| March 29, 2018 17:39 | https://github.com/angular/angular/pull/22705#event-1548426026 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377314994 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
|
| https://github.com/benbraou |
| build(compiler-cli): include new test files in bazel config | https://github.com/angular/angular/pull/22705/commits/afd8ed34378193b4fd774f3934685dc7c94ceaef |
| afd8ed3 | https://github.com/angular/angular/pull/22705/commits/afd8ed34378193b4fd774f3934685dc7c94ceaef |
| angular#22593 | https://github.com/angular/angular/issues/22593 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| force-pushed | https://github.com/angular/angular/compare/1b5a3ec883d12c144dc3d838ec3dc44a48163602..afd8ed34378193b4fd774f3934685dc7c94ceaef |
| 1b5a3ec | https://github.com/angular/angular/commit/1b5a3ec883d12c144dc3d838ec3dc44a48163602 |
| afd8ed3 | https://github.com/angular/angular/commit/afd8ed34378193b4fd774f3934685dc7c94ceaef |
|
Compare
| https://github.com/angular/angular/compare/1b5a3ec883d12c144dc3d838ec3dc44a48163602..afd8ed34378193b4fd774f3934685dc7c94ceaef |
| March 29, 2018 18:20 | https://github.com/angular/angular/pull/22705#event-1548504571 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377327187 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377339775 |
| http://test/OCL:190874633:BASE:190965443:1522350276162:99bb7658 | http://test/OCL:190874633:BASE:190965443:1522350276162:99bb7658 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/alexeagle |
| alexeagle | https://github.com/alexeagle |
|
Mar 29, 2018
| https://github.com/angular/angular/pull/22705#pullrequestreview-108174253 |
|
View reviewed changes
| https://github.com/angular/angular/pull/22705/files/afd8ed34378193b4fd774f3934685dc7c94ceaef |
| alexeagle | https://github.com/alexeagle |
| https://github.com/angular/angular/pull/22705#pullrequestreview-108174253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#event-1548863713 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377382946 |
| @benbraou | https://github.com/benbraou |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#event-1548866232 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
| Mar 29, 2018 | https://github.com/angular/angular/pull/22705#issuecomment-377383188 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/ocombe |
| ocombe | https://github.com/ocombe |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Mar 30, 2018 | https://github.com/angular/angular/pull/22705#event-1549658789 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 193737a | https://github.com/angular/angular/commit/193737a1eaf66145d922998863fbbb03afa03908 |
| Mar 30, 2018 | https://github.com/angular/angular/pull/22705#event-1549856026 |
| alxhub | https://github.com/alxhub |
|
Mar 30, 2018
| https://github.com/angular/angular/pull/22705#ref-commit-a5f0939 |
|
| https://github.com/benbraou |
|
| https://github.com/alxhub |
| build(compiler-cli): include new test files in bazel config ( | https://github.com/angular/angular/commit/a5f0939eae754adaa64cc613cac44dd528395529 |
| #22705 | https://github.com/angular/angular/pull/22705 |
| ) | https://github.com/angular/angular/commit/a5f0939eae754adaa64cc613cac44dd528395529 |
| a5f0939 | https://github.com/angular/angular/commit/a5f0939eae754adaa64cc613cac44dd528395529 |
| #22593 | https://github.com/angular/angular/issues/22593 |
| #22705 | https://github.com/angular/angular/pull/22705 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
| March 30, 2018 17:20 | https://github.com/angular/angular/pull/22705#event-1550052194 |
| https://github.com/benbraou |
| benbraou | https://github.com/benbraou |
|
Mar 30, 2018
| https://github.com/angular/angular/pull/22705#ref-issue-304091548 |
|
no tests for disableTypeScriptVersionCheck angularCompilerOptions flag
#22699
| https://github.com/angular/angular/issues/22699 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/22705#issuecomment-531207283 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/22705#event-2632082905 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22705 |
|
| https://github.com/rafaelss95 |
|
rafaelss95
| https://github.com/rafaelss95 |
|
| https://github.com/angular/angular/pull/22705/files/83f016275e5a86afe47021090669b6e35f0d345d |
|
| https://github.com/alexeagle |
|
alexeagle
| https://github.com/alexeagle |
|
| https://github.com/angular/angular/pull/22705/files/afd8ed34378193b4fd774f3934685dc7c94ceaef |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
| https://github.com/angular/angular/pull/22705/files/8a695657283f591e38a9d17f4e6871c7b7ecebca |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
|
| https://github.com/vicb |
|
vicb
| https://github.com/vicb |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
Compiler TypeScript version checking too simplistic
| https://github.com/angular/angular/issues/22593 |
| Please reload this page | https://github.com/angular/angular/pull/22705 |
|
| https://github.com/benbraou |
|
| https://github.com/vicb |
|
| https://github.com/alexeagle |
|
| https://github.com/rafaelss95 |
|
| https://github.com/ocombe |
|
| https://github.com/kara |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |