René's URL Explorer Experiment


Title: fix(forms): handle form groups/arrays own pending async validation by benbraou · Pull Request #22575 · angular/angular · GitHub

Open Graph Title: fix(forms): handle form groups/arrays own pending async validation by benbraou · Pull Request #22575 · angular/angular

X Title: fix(forms): handle form groups/arrays own pending async validation by benbraou · Pull Request #22575 · angular/angular

Description: introduce a boolean to track form groups/arrays own pending async validation to distinguish between pending state due to children and pending state due to own validation Fixes #10064 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? Scenario: An async validator is set up on a form control/ array Async validators are set up on child form controls All of the child controls validation is successful but the form control/ array validator has not resolved yet Currently, the form control/array is considered valid even if its own validator has not resolved yet Issue Number: N/A #10064 What is the new behavior? The form control/array is in pending state if its own validator has not resolved yet and none of its children is invalid Does this PR introduce a breaking change? [ ] Yes [x] No Other information

Open Graph Description: introduce a boolean to track form groups/arrays own pending async validation to distinguish between pending state due to children and pending state due to own validation Fixes #10064 PR Checklist P...

X Description: introduce a boolean to track form groups/arrays own pending async validation to distinguish between pending state due to children and pending state due to own validation Fixes #10064 PR Checklist P...

Opengraph URL: https://github.com/angular/angular/pull/22575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93d29879-ad1d-3a41-3f40-19305d2784b3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED40:2E985C:AED23:E65B2:6B015966
html-safe-nonce9626f50185b217b443ac24b87768594fdd30aae7a6ca3981fc9d562824c91bb7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDQwOjJFOTg1QzpBRUQyMzpFNjVCMjo2QjAxNTk2NiIsInZpc2l0b3JfaWQiOiI5NjkyNjQ1Mzg3MDY4NjAzOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb4b1049dffa42fa709e0bb0fd87200cc40c105fc915f3c5a9f7b2ef52768d3a0
hovercard-subject-tagpull_request:172690652
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/22575/files
twitter:imagehttps://avatars.githubusercontent.com/u/14368835?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14368835?s=400&v=4
og:image:altintroduce a boolean to track form groups/arrays own pending async validation to distinguish between pending state due to children and pending state due to own validation Fixes #10064 PR Checklist P...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/22575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/22575/files
Reloadhttps://github.com/angular/angular/pull/22575/files
Reloadhttps://github.com/angular/angular/pull/22575/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
benbraouhttps://github.com/benbraou
angular:masterhttps://github.com/angular/angular/tree/master
benbraou:issue10064https://github.com/benbraou/angular/tree/issue10064
Conversation 59 https://github.com/angular/angular/pull/22575
Commits 1 https://github.com/angular/angular/pull/22575/commits
Checks 0 https://github.com/angular/angular/pull/22575/checks
Files changed https://github.com/angular/angular/pull/22575/files
Please reload this pagehttps://github.com/angular/angular/pull/22575/files
fix(forms): handle form groups/arrays own pending async validation https://github.com/angular/angular/pull/22575/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/22575/files
a83fcc1 fix(forms): handle form groups/arrays own pending async validation benbraou Jun 13, 2020 https://github.com/angular/angular/pull/22575/commits/a83fcc13cc22d175532409a2eddc2be7107de272
Clear filters https://github.com/angular/angular/pull/22575/files
Please reload this pagehttps://github.com/angular/angular/pull/22575/files
Please reload this pagehttps://github.com/angular/angular/pull/22575/files
model.ts https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
form_group_spec.ts https://github.com/angular/angular/pull/22575/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
reactive_integration_spec.ts https://github.com/angular/angular/pull/22575/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
packages/forms/src/model.tshttps://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
View file https://github.com/benbraou/angular/blob/a83fcc13cc22d175532409a2eddc2be7107de272/packages/forms/src/model.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/22575/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
Please reload this pagehttps://github.com/angular/angular/pull/22575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.