René's URL Explorer Experiment


Title: fix(upgrade): need to call markForCheck on child changeDetectorRef by smdunn · Pull Request #22209 · angular/angular · GitHub

Open Graph Title: fix(upgrade): need to call markForCheck on child changeDetectorRef by smdunn · Pull Request #22209 · angular/angular

X Title: fix(upgrade): need to call markForCheck on child changeDetectorRef by smdunn · Pull Request #22209 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: [x ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit [n/a ] Tests for the changes have been added (for bug fixes / features) [n/a ] Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [ x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? I found a bug within matCheckbox. I added a disabled class to the checkbox based on a method call. When disabled, the checkbox had class disabled and therefore had grey css etc, but if it was still clicked on, it had a click event which added a disabled class to the input within the checkbox. When the disabled class was removed from the outer matCheckbox, the disabled class remained on the input, so even though the checkbox appeared not to be disabled, it couldn't accept any more input. Issue Number: 9763 What is the new behavior? Clicking on a disabled checkbox should not change it in any way. Does this PR introduce a breaking change? [ ] Yes [x ] No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: [x ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit [n/a...

X Description: PR Checklist Please check if your PR fulfills the following requirements: [x ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit [n/a...

Opengraph URL: https://github.com/angular/angular/pull/22209

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:92e3d232-9c28-6121-4c6a-2a85229abb06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE17E:1EC9BC:1D07899:24FDD4D:6B016023
html-safe-nonce3072cb50375b06c3bd8e92c79bd0fe010f60e86829aa943645809c29f5bd6b11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTdFOjFFQzlCQzoxRDA3ODk5OjI0RkRENEQ6NkIwMTYwMjMiLCJ2aXNpdG9yX2lkIjoiNDcyOTAzMjk1MzQ3NTE5NDkxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1fa15971f042ce20dabd0e853ebf05c3677890c5d1bd31de187c1e3ad747650
hovercard-subject-tagpull_request:168972552
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/22209/files
twitter:imagehttps://avatars.githubusercontent.com/u/14301831?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14301831?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: [x ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit [n/a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/22209/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22209%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F22209%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/22209/files
Reloadhttps://github.com/angular/angular/pull/22209/files
Reloadhttps://github.com/angular/angular/pull/22209/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
smdunnhttps://github.com/smdunn
angular:masterhttps://github.com/angular/angular/tree/master
smdunn:smdunn-matcheckbox-issuehttps://github.com/smdunn/angular/tree/smdunn-matcheckbox-issue
Conversation 26 https://github.com/angular/angular/pull/22209
Commits 1 https://github.com/angular/angular/pull/22209/commits
Checks 0 https://github.com/angular/angular/pull/22209/checks
Files changed https://github.com/angular/angular/pull/22209/files
Please reload this pagehttps://github.com/angular/angular/pull/22209/files
fix(upgrade): need to call markForCheck on child changeDetectorRef https://github.com/angular/angular/pull/22209/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/22209/files
72a319c fix(upgrade): correctly handle downgraded `OnPush` components smdunn809 Feb 13, 2018 https://github.com/angular/angular/pull/22209/commits/72a319cd10af844ab85ba3fb1ebc43be1b1fb032
Clear filters https://github.com/angular/angular/pull/22209/files
Please reload this pagehttps://github.com/angular/angular/pull/22209/files
Please reload this pagehttps://github.com/angular/angular/pull/22209/files
downgrade_component_adapter.ts https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
downgrade_component_spec.ts https://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
packages/upgrade/src/common/downgrade_component_adapter.tshttps://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
View file https://github.com/smdunn/angular/blob/72a319cd10af844ab85ba3fb1ebc43be1b1fb032/packages/upgrade/src/common/downgrade_component_adapter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
https://github.com/angular/angular/pull/22209/files#diff-bb2018371e37c47d156198873689700037ff6e5f0893f5ccc0ef6a50191cc7ed
packages/upgrade/test/static/integration/downgrade_component_spec.tshttps://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
View file https://github.com/smdunn/angular/blob/72a319cd10af844ab85ba3fb1ebc43be1b1fb032/packages/upgrade/test/static/integration/downgrade_component_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/22209/{{ revealButtonHref }}
https://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
https://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
https://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
https://github.com/angular/angular/pull/22209/files#diff-cd9e6e11e01ecf3b569d3b77b8f1d20965324779c3ba23447582ed4cdd161cd9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.