René's URL Explorer Experiment


Title: feat(ivy): support deep queries through view boundaries by pkozlowski-opensource · Pull Request #21700 · angular/angular · GitHub

Open Graph Title: feat(ivy): support deep queries through view boundaries by pkozlowski-opensource · Pull Request #21700 · angular/angular

X Title: feat(ivy): support deep queries through view boundaries by pkozlowski-opensource · Pull Request #21700 · angular/angular

Description: @mhevery this is still WIP (requires rebase, proper description and more tests), but opening it early on so we can discuss data structure / impl choices. The general idea is that both a container (LContainer) and a view (LView) have a pointer to all queries "active" for a given container / view. When encountering a container and view instructions, we are cloning LQuery predicates (queries) to have new place (arrays) to store matching nodes from sub-views. I feel like I've missed millions of use-cases here, but at the same time feel like I'm digging a deeper and deeper rabbit hole, so opening early PR so we can have discussion about exact data structures and algs.

Open Graph Description: @mhevery this is still WIP (requires rebase, proper description and more tests), but opening it early on so we can discuss data structure / impl choices. The general idea is that both a container (...

X Description: @mhevery this is still WIP (requires rebase, proper description and more tests), but opening it early on so we can discuss data structure / impl choices. The general idea is that both a container (...

Opengraph URL: https://github.com/angular/angular/pull/21700

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ea26536-72e1-e156-026e-627bab7a2348
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB644:2B9CDD:59D9691:78F31BB:6A5DEACA
html-safe-nonce9a4f6a08a0a9b45504ecf027bf6833ff38832533c6542e278f691a4fdd2caea8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjQ0OjJCOUNERDo1OUQ5NjkxOjc4RjMxQkI6NkE1REVBQ0EiLCJ2aXNpdG9yX2lkIjoiNjAxMzY1Njc5OTgxOTcyMTQxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf69d93ddedf61106ce16fc5e1cd03ea763696718c627a41514e2aa9d5bfe51e4
hovercard-subject-tagpull_request:164357995
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/21700/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:alt@mhevery this is still WIP (requires rebase, proper description and more tests), but opening it early on so we can discuss data structure / impl choices. The general idea is that both a container (...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None8e8f322dc74b1a8d5bafb296008dbb96bb4a0bc6ee2d6f30844ab111697c520d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ae00b343090b49d0d18b8184187f51a39ed917c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/21700/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21700%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21700%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/21700/files
Reloadhttps://github.com/angular/angular/pull/21700/files
Reloadhttps://github.com/angular/angular/pull/21700/files
Please reload this pagehttps://github.com/angular/angular/pull/21700/files
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.4k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 982 https://github.com/angular/angular/issues
Pull requests 169 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:queries_in_embed_views_with_predicatehttps://github.com/pkozlowski-opensource/angular/tree/queries_in_embed_views_with_predicate
Conversation 11 https://github.com/angular/angular/pull/21700
Commits 1 https://github.com/angular/angular/pull/21700/commits
Checks 0 https://github.com/angular/angular/pull/21700/checks
Files changed https://github.com/angular/angular/pull/21700/files
Please reload this pagehttps://github.com/angular/angular/pull/21700/files
feat(ivy): support deep queries through view boundaries https://github.com/angular/angular/pull/21700/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/21700/files
064a6ef feat(ivy): support deep queries through view boundaries pkozlowski-opensource Jan 17, 2018 https://github.com/angular/angular/pull/21700/commits/064a6ef23fa903a09e9f2514c6eba3f853a162ad
Clear filters https://github.com/angular/angular/pull/21700/files
Please reload this pagehttps://github.com/angular/angular/pull/21700/files
Please reload this pagehttps://github.com/angular/angular/pull/21700/files
instructions.ts https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
container.ts https://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
query.ts https://github.com/angular/angular/pull/21700/files#diff-69117963b1d32b84d015f8ab4292aaaf7e08029682b9169fe01111a753d4100c
view.ts https://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
node_manipulation.ts https://github.com/angular/angular/pull/21700/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
query.ts https://github.com/angular/angular/pull/21700/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
util.ts https://github.com/angular/angular/pull/21700/files#diff-6dc36b061eded4c0e849c7254aaf4d0797d9818c991a5615c0427ccb7182410a
query_spec.ts https://github.com/angular/angular/pull/21700/files#diff-0a98936137ffb7d2fa68c2eb4201fa62755ab2b0731d020f7289343b07a9ab0f
util_spec.ts https://github.com/angular/angular/pull/21700/files#diff-05fa005f390d06e70dad98679aac86326f76b93051716e9f1b139b2d7abddd16
packages/core/src/render3/instructions.tshttps://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
View file https://github.com/pkozlowski-opensource/angular/blob/064a6ef23fa903a09e9f2514c6eba3f853a162ad/packages/core/src/render3/instructions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21700/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
https://github.com/angular/angular/pull/21700/files#diff-ab0b05b1497e0a2e6be221256f96aad94a3010cb815abaf9072ae23db20566fc
packages/core/src/render3/interfaces/container.tshttps://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
View file https://github.com/pkozlowski-opensource/angular/blob/064a6ef23fa903a09e9f2514c6eba3f853a162ad/packages/core/src/render3/interfaces/container.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21700/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/21700/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
packages/core/src/render3/interfaces/query.tshttps://github.com/angular/angular/pull/21700/files#diff-69117963b1d32b84d015f8ab4292aaaf7e08029682b9169fe01111a753d4100c
View file https://github.com/pkozlowski-opensource/angular/blob/064a6ef23fa903a09e9f2514c6eba3f853a162ad/packages/core/src/render3/interfaces/query.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21700/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21700/files#diff-69117963b1d32b84d015f8ab4292aaaf7e08029682b9169fe01111a753d4100c
https://github.com/angular/angular/pull/21700/files#diff-69117963b1d32b84d015f8ab4292aaaf7e08029682b9169fe01111a753d4100c
https://github.com/angular/angular/pull/21700/files#diff-69117963b1d32b84d015f8ab4292aaaf7e08029682b9169fe01111a753d4100c
packages/core/src/render3/interfaces/view.tshttps://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
View file https://github.com/pkozlowski-opensource/angular/blob/064a6ef23fa903a09e9f2514c6eba3f853a162ad/packages/core/src/render3/interfaces/view.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21700/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
https://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
https://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
https://github.com/angular/angular/pull/21700/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
packages/core/src/render3/node_manipulation.tshttps://github.com/angular/angular/pull/21700/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
View file https://github.com/pkozlowski-opensource/angular/blob/064a6ef23fa903a09e9f2514c6eba3f853a162ad/packages/core/src/render3/node_manipulation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21700/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21700/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
https://github.com/angular/angular/pull/21700/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
https://github.com/angular/angular/pull/21700/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
Please reload this pagehttps://github.com/angular/angular/pull/21700/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.