René's URL Explorer Experiment


Title: fix(benchpress): should still support selenium_webdriver < 3.6.0 by marclaval · Pull Request #21477 · angular/angular · GitHub

Open Graph Title: fix(benchpress): should still support selenium_webdriver < 3.6.0 by marclaval · Pull Request #21477 · angular/angular

X Title: fix(benchpress): should still support selenium_webdriver < 3.6.0 by marclaval · Pull Request #21477 · angular/angular

Description: Since #21399, benchmarks fail to run locally. The reason root cause is how TS transpiles this new code. It is a known issue which was fixed in microsoft/TypeScript#12346 with a new option: downlevelIteration. As discussed with @alexeagle, instead of changing our compiler options right now, we can also work around it.

Open Graph Description: Since #21399, benchmarks fail to run locally. The reason root cause is how TS transpiles this new code. It is a known issue which was fixed in microsoft/TypeScript#12346 with a new option: downleve...

X Description: Since #21399, benchmarks fail to run locally. The reason root cause is how TS transpiles this new code. It is a known issue which was fixed in microsoft/TypeScript#12346 with a new option: downleve...

Opengraph URL: https://github.com/angular/angular/pull/21477

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db022b0e-474f-500d-c2a7-b4b4610b525a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id894C:134361:73B585:9A6DB0:6B00D7EA
html-safe-nonce799a17c45bd66e6c514919e294497e57fc4fb514a58343e38abc7dbec0ad28fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTRDOjEzNDM2MTo3M0I1ODU6OUE2REIwOjZCMDBEN0VBIiwidmlzaXRvcl9pZCI6IjI1NjgxNTk0MDU2Mjc0NjM2NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace5ce88599459ba71adcd4274d279b0abb4bc5eeb578c60d7e0e6573325d211e8
hovercard-subject-tagpull_request:162446424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/21477/files
twitter:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
og:image:altSince #21399, benchmarks fail to run locally. The reason root cause is how TS transpiles this new code. It is a known issue which was fixed in microsoft/TypeScript#12346 with a new option: downleve...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/21477/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21477%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21477%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/21477/files
Reloadhttps://github.com/angular/angular/pull/21477/files
Reloadhttps://github.com/angular/angular/pull/21477/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests139 (139)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
marclavalhttps://github.com/marclaval
angular:masterhttps://github.com/angular/angular/tree/master
marclaval:fixBenchpressLocallyhttps://github.com/marclaval/angular/tree/fixBenchpressLocally
Conversation 1 https://github.com/angular/angular/pull/21477
Commits 1 https://github.com/angular/angular/pull/21477/commits
Checks 0 https://github.com/angular/angular/pull/21477/checks
Files changed https://github.com/angular/angular/pull/21477/files
Please reload this pagehttps://github.com/angular/angular/pull/21477/files
fix(benchpress): should still support selenium_webdriver < 3.6.0 https://github.com/angular/angular/pull/21477/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/21477/files
8ef566b fix(benchpress): should still support selenium_webdriver < 3.6.0 marclaval Jan 11, 2018 https://github.com/angular/angular/pull/21477/commits/8ef566bd037d4143fc62467683e421fc52adea0d
Clear filters https://github.com/angular/angular/pull/21477/files
Please reload this pagehttps://github.com/angular/angular/pull/21477/files
Please reload this pagehttps://github.com/angular/angular/pull/21477/files
packages/benchpress/src/webdriver/selenium_webdriver_adapter.tshttps://github.com/angular/angular/pull/21477/files#diff-32a982019a295e3be204711c64795d186f3d010ca1d4c0face47312a8f6c300e
View file https://github.com/marclaval/angular/blob/8ef566bd037d4143fc62467683e421fc52adea0d/packages/benchpress/src/webdriver/selenium_webdriver_adapter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/21477/{{ revealButtonHref }}
https://github.com/angular/angular/pull/21477/files#diff-32a982019a295e3be204711c64795d186f3d010ca1d4c0face47312a8f6c300e
https://github.com/angular/angular/pull/21477/files#diff-32a982019a295e3be204711c64795d186f3d010ca1d4c0face47312a8f6c300e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.