| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aa5ec5a3-f49e-04be-0be1-6589a8f0ba3f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9F8:2463BD:981808:C62592:6B00E0BF |
| html-safe-nonce | e6454cf615cb2b64c5218d15e374af67af32b9d43a1521e217a40b8ed29a1e35 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUY4OjI0NjNCRDo5ODE4MDg6QzYyNTkyOjZCMDBFMEJGIiwidmlzaXRvcl9pZCI6IjQwNTU4MTIzOTQ3ODg2NDMwMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5df4ec47bd822b9dbe93a5e75479966dcfa1337cad99ef537d673467d205cdc5 |
| hovercard-subject-tag | pull_request:161445454 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/21342/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a8a62c25af7ec2a39aac227157ade6d12c016ab8a0050ebf687fd621c45d2de6/angular/angular/pull/21342 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8a62c25af7ec2a39aac227157ade6d12c016ab8a0050ebf687fd621c45d2de6/angular/angular/pull/21342 |
| og:image:alt | Unfortunately the version of @angular/service-worker that we are using (^1.0.0-beta.16)
contains an implicit any which is the only thing preventing the enforcement of noImplicitAny.
This looks like... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petebacondarwin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/21342#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21342 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21342 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/21342 |
| Reload | https://github.com/angular/angular/pull/21342 |
| Reload | https://github.com/angular/angular/pull/21342 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:aio-strict | https://github.com/petebacondarwin/angular/tree/aio-strict |
| Conversation | https://github.com/angular/angular/pull/21342 |
| Commits1 (1) | https://github.com/angular/angular/pull/21342/commits |
| Checks | https://github.com/angular/angular/pull/21342/checks |
| Files changed | https://github.com/angular/angular/pull/21342/files |
| style(aio): enforce strict TypeScript checks | https://github.com/angular/angular/pull/21342#top |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:aio-strict | https://github.com/petebacondarwin/angular/tree/aio-strict |
|
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 5, 2018 | https://github.com/angular/angular/pull/21342#issue-286429377 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| #20646 | https://github.com/angular/angular/issues/20646 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
comp: aio
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20aio%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Jan 5, 2018 | https://github.com/angular/angular/pull/21342#event-1412126046 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| gkalpak | https://github.com/gkalpak |
| January 5, 2018 23:01 | https://github.com/angular/angular/pull/21342#event-1412126058 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 5, 2018 | https://github.com/angular/angular/pull/21342#event-1412126102 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 5, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-355690005 |
| https://pr21342-78cebb9.ngbuilds.io/ | https://pr21342-78cebb9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 9, 2018
| https://github.com/angular/angular/pull/21342#pullrequestreview-87330649 |
|
View reviewed changes
| https://github.com/angular/angular/pull/21342/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/21342#pullrequestreview-87330649 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/app.component.spec.ts | https://github.com/angular/angular/pull/21342/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
| gkalpak | https://github.com/gkalpak |
| Jan 8, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160248236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160427770 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160449084 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/sw-updates/sw-updates.service.spec.ts | https://github.com/angular/angular/pull/21342/files#diff-f99ff2c4e5a12744e0d49da5efe50c2048bcdfb1cc57f7c814cc097dedbf4fe2 |
| gkalpak | https://github.com/gkalpak |
| Jan 8, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160256185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160641203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/layout/doc-viewer/doc-viewer.component.ts | https://github.com/angular/angular/pull/21342/files#diff-527c75fb16a8bb28392b62e83569cebec9d3e97e1582ecf0738faea10054e59a |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160378673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160632782 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| gkalpak | https://github.com/gkalpak |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160642306 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160667830 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/custom-icon-registry.spec.ts | https://github.com/angular/angular/pull/21342/files#diff-4f023b92d8dff784607410102f8f9c13b2ec5465c0ac592ef6feb594255b06f3 |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160379834 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160635437 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/location.service.ts | https://github.com/angular/angular/pull/21342/files#diff-e9b6ebdf12cabe23c2e492783fcba8b60984f821d45142c767d81d163d944a9b |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160381954 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160642799 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/angular/angular/blob/master/aio/src/app/shared/location.service.spec.ts#L272 | https://github.com/angular/angular/blob/master/aio/src/app/shared/location.service.spec.ts#L272 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/location.service.ts | https://github.com/angular/angular/pull/21342/files#diff-e9b6ebdf12cabe23c2e492783fcba8b60984f821d45142c767d81d163d944a9b |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160382471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160636006 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/angular/angular/blob/master/aio/src/app/shared/location.service.spec.ts#L339 | https://github.com/angular/angular/blob/master/aio/src/app/shared/location.service.spec.ts#L339 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/location.service.ts | https://github.com/angular/angular/pull/21342/files#diff-e9b6ebdf12cabe23c2e492783fcba8b60984f821d45142c767d81d163d944a9b |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160383599 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160637738 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/scroll-spy.service.spec.ts | https://github.com/angular/angular/pull/21342/files#diff-a96a1dd4bcc061d2fc23f1189a56371e92331788953541c72a581f38b9814252 |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160385948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160638595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/shared/scroll.service.spec.ts | https://github.com/angular/angular/pull/21342/files#diff-f3d6db3f956c33200674a022791e1ce8c6dc177a43855bf4dac1973952ca52dc |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160386784 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160638977 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| aio/src/app/search/interfaces.ts | https://github.com/angular/angular/pull/21342/files#diff-ca2bbb5f61541d50524b769a704345137e22205b887ff13d96df5891fda3a968 |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160388401 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#discussion_r160667983 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356516051 |
| #19795 | https://github.com/angular/angular/pull/19795 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356565491 |
| @IgorMinar | https://github.com/IgorMinar |
| #19795 | https://github.com/angular/angular/pull/19795 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/d1aa41eea8337bb8f0aec09903263c01eee3ac35..40a4e68a83844764e458e6b2775c030e33b9e3c8 |
| d1aa41e | https://github.com/angular/angular/commit/d1aa41eea8337bb8f0aec09903263c01eee3ac35 |
| 40a4e68 | https://github.com/angular/angular/commit/40a4e68a83844764e458e6b2775c030e33b9e3c8 |
|
Compare
| https://github.com/angular/angular/compare/d1aa41eea8337bb8f0aec09903263c01eee3ac35..40a4e68a83844764e458e6b2775c030e33b9e3c8 |
| January 10, 2018 10:45 | https://github.com/angular/angular/pull/21342#event-1417405331 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356566943 |
| https://pr21342-d1aa41e.ngbuilds.io/ | https://pr21342-d1aa41e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356567466 |
| https://pr21342-40a4e68.ngbuilds.io/ | https://pr21342-40a4e68.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/40a4e68a83844764e458e6b2775c030e33b9e3c8..124c34e609aac5934110eaec13ecb31cd533a6d1 |
| 40a4e68 | https://github.com/angular/angular/commit/40a4e68a83844764e458e6b2775c030e33b9e3c8 |
| 124c34e | https://github.com/angular/angular/commit/124c34e609aac5934110eaec13ecb31cd533a6d1 |
|
Compare
| https://github.com/angular/angular/compare/40a4e68a83844764e458e6b2775c030e33b9e3c8..124c34e609aac5934110eaec13ecb31cd533a6d1 |
| January 10, 2018 14:55 | https://github.com/angular/angular/pull/21342#event-1417831053 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356628828 |
| https://pr21342-124c34e.ngbuilds.io/ | https://pr21342-124c34e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Jan 10, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356666339 |
| @petebacondarwin | https://github.com/petebacondarwin |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 11, 2018
| https://github.com/angular/angular/pull/21342#pullrequestreview-88154703 |
|
View reviewed changes
| https://github.com/angular/angular/pull/21342/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/21342#pullrequestreview-88154703 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Jan 11, 2018 | https://github.com/angular/angular/pull/21342#event-1419698872 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/124c34e609aac5934110eaec13ecb31cd533a6d1..d133c0e07facf642fb3c6a7efc1d7665f7392080 |
| 124c34e | https://github.com/angular/angular/commit/124c34e609aac5934110eaec13ecb31cd533a6d1 |
| d133c0e | https://github.com/angular/angular/commit/d133c0e07facf642fb3c6a7efc1d7665f7392080 |
|
Compare
| https://github.com/angular/angular/compare/124c34e609aac5934110eaec13ecb31cd533a6d1..d133c0e07facf642fb3c6a7efc1d7665f7392080 |
| January 11, 2018 14:29 | https://github.com/angular/angular/pull/21342#event-1419880698 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 11, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356952544 |
| https://pr21342-d133c0e.ngbuilds.io/ | https://pr21342-d133c0e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 11, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-356956329 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
|
| https://github.com/petebacondarwin |
| style(aio): enforce strict TypeScript checks | https://github.com/angular/angular/pull/21342/commits/537e4d07667adc4f12c5a2594fb8aa8017122f8a |
| 537e4d0 | https://github.com/angular/angular/pull/21342/commits/537e4d07667adc4f12c5a2594fb8aa8017122f8a |
| angular#20646 | https://github.com/angular/angular/issues/20646 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/d133c0e07facf642fb3c6a7efc1d7665f7392080..537e4d07667adc4f12c5a2594fb8aa8017122f8a |
| d133c0e | https://github.com/angular/angular/commit/d133c0e07facf642fb3c6a7efc1d7665f7392080 |
| 537e4d0 | https://github.com/angular/angular/commit/537e4d07667adc4f12c5a2594fb8aa8017122f8a |
|
Compare
| https://github.com/angular/angular/compare/d133c0e07facf642fb3c6a7efc1d7665f7392080..537e4d07667adc4f12c5a2594fb8aa8017122f8a |
| January 11, 2018 18:46 | https://github.com/angular/angular/pull/21342#event-1420369190 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 11, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-357025575 |
| 537e4d0 | https://github.com/angular/angular/commit/537e4d07667adc4f12c5a2594fb8aa8017122f8a |
| https://pr21342-537e4d0.ngbuilds.io/ | https://pr21342-537e4d0.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 11, 2018 | https://github.com/angular/angular/pull/21342#issuecomment-357082520 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 12, 2018 | https://github.com/angular/angular/pull/21342#event-1422264085 |
| alexeagle | https://github.com/alexeagle |
|
Jan 12, 2018
| https://github.com/angular/angular/pull/21342#ref-commit-71dd92b |
|
| https://github.com/petebacondarwin |
|
| https://github.com/alexeagle |
| style(aio): enforce strict TypeScript checks ( | https://github.com/angular/angular/commit/71dd92bbb846bc7e8d705514ef02b05820f5542f |
| #21342 | https://github.com/angular/angular/pull/21342 |
| ) | https://github.com/angular/angular/commit/71dd92bbb846bc7e8d705514ef02b05820f5542f |
| 71dd92b | https://github.com/angular/angular/commit/71dd92bbb846bc7e8d705514ef02b05820f5542f |
| #20646 | https://github.com/angular/angular/issues/20646 |
| #21342 | https://github.com/angular/angular/pull/21342 |
| https://github.com/alexeagle |
| alexeagle | https://github.com/alexeagle |
| c5c6d84 | https://github.com/angular/angular/commit/c5c6d84fe6bca821dee283cedd691a620a79e4e4 |
| Jan 12, 2018 | https://github.com/angular/angular/pull/21342#event-1422648743 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| January 16, 2018 11:04 | https://github.com/angular/angular/pull/21342#event-1425907250 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/21342#issuecomment-531096974 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/21342#event-2631192961 |
| adhambaouz | https://github.com/adhambaouz |
|
Nov 20, 2026
| https://github.com/angular/angular/pull/21342#ref-commit-4335020 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/alexeagle |
| style(aio): enforce strict TypeScript checks ( | https://github.com/adhambaouz/angular/commit/4335020177731521cd95405fe95d9bb1aa3f1431 |
| angular#21342 | https://github.com/angular/angular/pull/21342 |
| ) | https://github.com/adhambaouz/angular/commit/4335020177731521cd95405fe95d9bb1aa3f1431 |
| 4335020 | https://github.com/adhambaouz/angular/commit/4335020177731521cd95405fe95d9bb1aa3f1431 |
| angular#20646 | https://github.com/angular/angular/issues/20646 |
| angular#21342 | https://github.com/angular/angular/pull/21342 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21342 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/21342/files/124c34e609aac5934110eaec13ecb31cd533a6d1 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
Enable strictNullChecks mode for aio codebase
| https://github.com/angular/angular/issues/20646 |
| Please reload this page | https://github.com/angular/angular/pull/21342 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/mary-poppins |
|
| https://github.com/IgorMinar |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |