René's URL Explorer Experiment


Title: fix(compiler): report an error for recursive module references by chuckjaz · Pull Request #21054 · angular/angular · GitHub

Open Graph Title: fix(compiler): report an error for recursive module references by chuckjaz · Pull Request #21054 · angular/angular

X Title: fix(compiler): report an error for recursive module references by chuckjaz · Pull Request #21054 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Modules that directly or indirectly export or imported themselves reports an error instead of generating a stack fault. Fixes: #19979 PR Type What kind of change does this PR introduce? [x] Bugfix...

X Description: Modules that directly or indirectly export or imported themselves reports an error instead of generating a stack fault. Fixes: #19979 PR Type What kind of change does this PR introduce? [x] Bugfix...

Opengraph URL: https://github.com/angular/angular/pull/21054

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2474b3f3-f9ee-f8a0-a85f-0e137dc5a4bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA7C:291B58:FE2F00:1411584:6B014B7B
html-safe-nonce4dc6b4bb4d42d371907da7c4b884e78e71e3df2c603e068d8aed833fd335ebcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTdDOjI5MUI1ODpGRTJGMDA6MTQxMTU4NDo2QjAxNEI3QiIsInZpc2l0b3JfaWQiOiIxMDk3ODMxODc2NDUxNzE1OTYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac80aaa2440f076e10eab4ac4305cbaac3f4908c88682a27fbb03a0d10c66724bb
hovercard-subject-tagpull_request:158719882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/21054/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e1e183552209e39df11c0b170559f786c3e224d627fdd1c50f11dec9ca39340a/angular/angular/pull/21054
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e1e183552209e39df11c0b170559f786c3e224d627fdd1c50f11dec9ca39340a/angular/angular/pull/21054
og:image:altModules that directly or indirectly export or imported themselves reports an error instead of generating a stack fault. Fixes: #19979 PR Type What kind of change does this PR introduce? [x] Bugfix...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechuckjaz
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/21054#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21054
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21054
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/21054
Reloadhttps://github.com/angular/angular/pull/21054
Reloadhttps://github.com/angular/angular/pull/21054
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
chuckjaz:i19979https://github.com/chuckjaz/angular/tree/i19979
Conversationhttps://github.com/angular/angular/pull/21054
Commits1 (1)https://github.com/angular/angular/pull/21054/commits
Checkshttps://github.com/angular/angular/pull/21054/checks
Files changedhttps://github.com/angular/angular/pull/21054/files
fix(compiler): report an error for recursive module referenceshttps://github.com/angular/angular/pull/21054#top
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
chuckjaz:i19979https://github.com/chuckjaz/angular/tree/i19979
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
Dec 16, 2017https://github.com/angular/angular/pull/21054#issue-282583532
#19979https://github.com/angular/angular/issues/19979
#19979https://github.com/angular/angular/issues/19979
Please reload this pagehttps://github.com/angular/angular/pull/21054
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 16, 2017https://github.com/angular/angular/pull/21054#event-1390540573
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
force-pushedhttps://github.com/angular/angular/compare/af85bb3f9f7c1e1057e3a5721225557749638a98..c179cde89dac10858e1abd2320d2f7d19ffe4286
af85bb3https://github.com/angular/angular/commit/af85bb3f9f7c1e1057e3a5721225557749638a98
c179cdehttps://github.com/angular/angular/commit/c179cde89dac10858e1abd2320d2f7d19ffe4286
Compare https://github.com/angular/angular/compare/af85bb3f9f7c1e1057e3a5721225557749638a98..c179cde89dac10858e1abd2320d2f7d19ffe4286
December 16, 2017 01:01https://github.com/angular/angular/pull/21054#event-1390558031
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 16, 2017https://github.com/angular/angular/pull/21054#event-1390558211
https://github.com/vicb
vicbhttps://github.com/vicb
Dec 18, 2017 https://github.com/angular/angular/pull/21054#pullrequestreview-84223891
View reviewed changes https://github.com/angular/angular/pull/21054/files
packages/compiler-cli/test/ngc_spec.tshttps://github.com/angular/angular/pull/21054/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4
vicbhttps://github.com/vicb
Dec 18, 2017https://github.com/angular/angular/pull/21054#discussion_r157561530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/21054
https://github.com/chuckjaz
fix(compiler): report an error for recursive module referenceshttps://github.com/angular/angular/pull/21054/commits/9aad9bb7ee0211a4769b78bc55f69292d4012402
9aad9bbhttps://github.com/angular/angular/pull/21054/commits/9aad9bb7ee0211a4769b78bc55f69292d4012402
angular#19979https://github.com/angular/angular/issues/19979
https://github.com/vicb
vicbhttps://github.com/vicb
Dec 18, 2017 https://github.com/angular/angular/pull/21054#pullrequestreview-84224725
View reviewed changes https://github.com/angular/angular/pull/21054/files
vicbhttps://github.com/vicb
https://github.com/angular/angular/pull/21054#pullrequestreview-84224725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/21054
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
force-pushedhttps://github.com/angular/angular/compare/c179cde89dac10858e1abd2320d2f7d19ffe4286..9aad9bb7ee0211a4769b78bc55f69292d4012402
c179cdehttps://github.com/angular/angular/commit/c179cde89dac10858e1abd2320d2f7d19ffe4286
9aad9bbhttps://github.com/angular/angular/commit/9aad9bb7ee0211a4769b78bc55f69292d4012402
Compare https://github.com/angular/angular/compare/c179cde89dac10858e1abd2320d2f7d19ffe4286..9aad9bb7ee0211a4769b78bc55f69292d4012402
December 18, 2017 18:25https://github.com/angular/angular/pull/21054#event-1392675560
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Dec 19, 2017 https://github.com/angular/angular/pull/21054#pullrequestreview-84312080
View reviewed changes https://github.com/angular/angular/pull/21054/files/9aad9bb7ee0211a4769b78bc55f69292d4012402
https://github.com/chuckjaz
chuckjazhttps://github.com/chuckjaz
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Dec 19, 2017https://github.com/angular/angular/pull/21054#event-1395161513
https://github.com/alxhub
alxhubhttps://github.com/alxhub
33c0ee3https://github.com/angular/angular/commit/33c0ee3441dc6b3e2e097d87640f9b163abd6950
Dec 20, 2017https://github.com/angular/angular/pull/21054#event-1396691031
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/21054#issuecomment-531078945
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/21054
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular/pull/21054#event-2631067268
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F21054
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/21054/files/9aad9bb7ee0211a4769b78bc55f69292d4012402
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/21054/files/c179cde89dac10858e1abd2320d2f7d19ffe4286
Please reload this pagehttps://github.com/angular/angular/pull/21054
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
ERROR in RangeError: Maximum call stack size exceeded on production build and faulty export on module https://github.com/angular/angular/issues/19979
Please reload this pagehttps://github.com/angular/angular/pull/21054
https://github.com/chuckjaz
https://github.com/mhevery
https://github.com/vicb
https://github.com/alxhub
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.