René's URL Explorer Experiment


Title: feat(compiler): allow ngIf to use the ngIf expression directly as a guard by chuckjaz · Pull Request #20972 · angular/angular · GitHub

Open Graph Title: feat(compiler): allow ngIf to use the ngIf expression directly as a guard by chuckjaz · Pull Request #20972 · angular/angular

X Title: feat(compiler): allow ngIf to use the ngIf expression directly as a guard by chuckjaz · Pull Request #20972 · angular/angular

Description: Allows a directive to use the expression passed directly to a property as a guard instead of filtering the type through a type guard function. This more accurately matches the intent of the ngIf usage of its template enabling better type inference. Moved NgIf to using this type of guard instead of a function guard. Closes: #20967 PR Type What kind of change does this PR introduce? [x] Feature What is the current behavior? #20967 Using the type guard mechanism introduced in e7d9cb3 the following expression is not narrowed as expected.

{{person.name}
because the type guard function only infers that the expression !!person is true but does not further infer that implies person is not undefined causing person.name to report that person might be undefined. What is the new behavior? The code generated for an *ngIf uses the guard expression directly as the template guard instead of using a type guard function. This allows TypeScript to infer the correct types for person in the above example. Does this PR introduce a breaking change? [ ] Yes [x] No

Open Graph Description: Allows a directive to use the expression passed directly to a property as a guard instead of filtering the type through a type guard function. This more accurately matches the intent of the ngIf us...

X Description: Allows a directive to use the expression passed directly to a property as a guard instead of filtering the type through a type guard function. This more accurately matches the intent of the ngIf us...

Opengraph URL: https://github.com/angular/angular/pull/20972

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0a27271-916d-2ff3-ba32-5a0e68071dd2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BDC:D5B7F:84EFE2:AE928D:6B025738
html-safe-nonce730c0e108e2167c3786d77b5afd12592cce06a6352d36af5c30985f0dfaf62e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkRDOkQ1QjdGOjg0RUZFMjpBRTkyOEQ6NkIwMjU3MzgiLCJ2aXNpdG9yX2lkIjoiNzU3NjU2NjA0Mjc0MzQyODkyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaafc163f8fa04a239987dabcb97025d1d269011ebf602578021ca89280f5e372
hovercard-subject-tagpull_request:157961488
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/20972/files
twitter:imagehttps://avatars.githubusercontent.com/u/372013?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/372013?s=400&v=4
og:image:altAllows a directive to use the expression passed directly to a property as a guard instead of filtering the type through a type guard function. This more accurately matches the intent of the ngIf us...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/20972/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20972%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20972%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/20972/files
Reloadhttps://github.com/angular/angular/pull/20972/files
Reloadhttps://github.com/angular/angular/pull/20972/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
chuckjaz:i20967https://github.com/chuckjaz/angular/tree/i20967
Conversation 4 https://github.com/angular/angular/pull/20972
Commits 1 https://github.com/angular/angular/pull/20972/commits
Checks 0 https://github.com/angular/angular/pull/20972/checks
Files changed https://github.com/angular/angular/pull/20972/files
Please reload this pagehttps://github.com/angular/angular/pull/20972/files
feat(compiler): allow ngIf to use the ngIf expression directly as a guard https://github.com/angular/angular/pull/20972/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/20972/files
c97ce64 feat(compiler): allow ngIf to use the ngIf expression directly as a g… chuckjaz Dec 12, 2017 https://github.com/angular/angular/pull/20972/commits/c97ce64317fcf2cd780adc3d5e8794f9143d69f0
Clear filters https://github.com/angular/angular/pull/20972/files
Please reload this pagehttps://github.com/angular/angular/pull/20972/files
Please reload this pagehttps://github.com/angular/angular/pull/20972/files
ng_if.ts https://github.com/angular/angular/pull/20972/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
check_types_spec.ts https://github.com/angular/angular/pull/20972/files#diff-8576cf2cb8c40dd3e4ae3914c55ba1e0a2ca2616d3ca63a6da90ccdb126e9123
static_reflector.ts https://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
expression_converter.ts https://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
type_check_compiler.ts https://github.com/angular/angular/pull/20972/files#diff-966b1b6f96a8480836f8e42ce99e4e5f5315c3621e38b46c866fa9290d89bc40
common.d.ts https://github.com/angular/angular/pull/20972/files#diff-8f04e04e51db03a1fa86550e492017d75859c13236cac866e8727c788a843710
packages/common/src/directives/ng_if.tshttps://github.com/angular/angular/pull/20972/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
View file https://github.com/chuckjaz/angular/blob/c97ce64317fcf2cd780adc3d5e8794f9143d69f0/packages/common/src/directives/ng_if.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20972/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20972/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
https://github.com/angular/angular/pull/20972/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd
packages/compiler-cli/test/diagnostics/check_types_spec.tshttps://github.com/angular/angular/pull/20972/files#diff-8576cf2cb8c40dd3e4ae3914c55ba1e0a2ca2616d3ca63a6da90ccdb126e9123
View file https://github.com/chuckjaz/angular/blob/c97ce64317fcf2cd780adc3d5e8794f9143d69f0/packages/compiler-cli/test/diagnostics/check_types_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20972/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20972/files#diff-8576cf2cb8c40dd3e4ae3914c55ba1e0a2ca2616d3ca63a6da90ccdb126e9123
https://github.com/angular/angular/pull/20972/files#diff-8576cf2cb8c40dd3e4ae3914c55ba1e0a2ca2616d3ca63a6da90ccdb126e9123
packages/compiler/src/aot/static_reflector.tshttps://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
View file https://github.com/chuckjaz/angular/blob/c97ce64317fcf2cd780adc3d5e8794f9143d69f0/packages/compiler/src/aot/static_reflector.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20972/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
https://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
https://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
https://github.com/angular/angular/pull/20972/files#diff-8d77cc7e48aeb2df183f57f41bff57d3014b18ae89f9d39a3dc0b469237a01b4
packages/compiler/src/compiler_util/expression_converter.tshttps://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
View file https://github.com/chuckjaz/angular/blob/c97ce64317fcf2cd780adc3d5e8794f9143d69f0/packages/compiler/src/compiler_util/expression_converter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20972/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
https://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
https://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
https://github.com/angular/angular/pull/20972/files#diff-90361fe3df79fa539acec02d1812a9564d9ff27983fee077f398b69a525fafab
Please reload this pagehttps://github.com/angular/angular/pull/20972/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.