| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:35ae9cb6-8c68-a5a1-77a6-6a4869843d27 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D8A8:2652DC:12E48A7:1837DF1:6B011075 |
| html-safe-nonce | 86d323203558d8628c980496e46270c655b8669dee17ff3d7762bbe1b9b44ed2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEE4OjI2NTJEQzoxMkU0OEE3OjE4MzdERjE6NkIwMTEwNzUiLCJ2aXNpdG9yX2lkIjoiNDEzODI4NTg5ODY5OTcwNjQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cda855f32bf01a4abd4e5f143f8b9e82ebe29f9392ea430cc778a90279ea6dc7 |
| hovercard-subject-tag | pull_request:157776428 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/20955/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/492f9ab7d93532d933a44381f21e52d3b635d1e1dc61ea657dcf0927e51d00de/angular/angular/pull/20955 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/492f9ab7d93532d933a44381f21e52d3b635d1e1dc61ea657dcf0927e51d00de/angular/angular/pull/20955 |
| og:image:alt | Using angular element inside angular had an issue with one way binding.
Reason explained here
PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gogakoreli |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/20955#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20955 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20955 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/20955 |
| Reload | https://github.com/angular/angular/pull/20955 |
| Reload | https://github.com/angular/angular/pull/20955 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gogakoreli | https://github.com/gogakoreli |
| angular:labs/elements | https://github.com/angular/angular/tree/labs/elements |
| Conversation | https://github.com/angular/angular/pull/20955 |
| Commits4 (4) | https://github.com/angular/angular/pull/20955/commits |
| Checks | https://github.com/angular/angular/pull/20955/checks |
| Files changed | https://github.com/angular/angular/pull/20955/files |
| fix(elements): fixed one way binding issue | https://github.com/angular/angular/pull/20955#top |
| gogakoreli | https://github.com/gogakoreli |
| angular:labs/elements | https://github.com/angular/angular/tree/labs/elements |
|
| https://github.com/gogakoreli |
| gogakoreli | https://github.com/gogakoreli |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#issue-281313747 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| Reason explained here | https://developers.google.com/web/fundamentals/web-components/best-practices#lazy-properties |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
|
| https://github.com/gogakoreli |
| Fixed one way binding issue | https://github.com/angular/angular/pull/20955/commits/399587e7f95edab9ef6ddaf14a3fca2157b055a2 |
| 399587e | https://github.com/angular/angular/pull/20955/commits/399587e7f95edab9ef6ddaf14a3fca2157b055a2 |
| https://developers.google.com/web/fundamentals/web-components/best-practices#lazy-properties | https://developers.google.com/web/fundamentals/web-components/best-practices#lazy-properties |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-350995280 |
| https://cla.developers.google.com/ | https://cla.developers.google.com/ |
| your existing CLA data | https://cla.developers.google.com/clas |
| email is set on your git commits | https://help.github.com/articles/setting-your-email-in-git/ |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#event-1383136098 |
| https://github.com/gogakoreli |
| gogakoreli | https://github.com/gogakoreli |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-350996081 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-350996089 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#event-1383141392 |
| https://github.com/gogakoreli |
| gogakoreli | https://github.com/gogakoreli |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#event-1383148016 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 12, 2017
| https://github.com/angular/angular/pull/20955#pullrequestreview-82774587 |
|
View reviewed changes
| https://github.com/angular/angular/pull/20955/files/399587e7f95edab9ef6ddaf14a3fca2157b055a2 |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/20955#pullrequestreview-82774587 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| packages/elements/src/ng-element.ts | https://github.com/angular/angular/pull/20955/files/399587e7f95edab9ef6ddaf14a3fca2157b055a2#diff-18b4032c390200d440d4df619c8e8fe09ecbc6610e383979e7be18339429f0f6 |
| gkalpak | https://github.com/gkalpak |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156318826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| line 289 | https://github.com/angular/angular/pull/20955/files#diff-b9835a8f3bd5303fb28263190a46af84R289 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| gogakoreli | https://github.com/gogakoreli |
| Dec 13, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156577661 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| gkalpak | https://github.com/gkalpak |
| Dec 14, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156895925 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| gogakoreli | https://github.com/gogakoreli |
| Dec 14, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156931087 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
PR target: TBD
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20TBD%22 |
| Dec 12, 2017 | https://github.com/angular/angular/pull/20955#event-1383193553 |
|
| https://github.com/gogakoreli |
| move properties check to constructor | https://github.com/angular/angular/pull/20955/commits/2c5e811bc5e6fa4f794ff38ecd8b84a59ee3cc25 |
| 2c5e811 | https://github.com/angular/angular/pull/20955/commits/2c5e811bc5e6fa4f794ff38ecd8b84a59ee3cc25 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 14, 2017
| https://github.com/angular/angular/pull/20955#pullrequestreview-83444642 |
|
View reviewed changes
| https://github.com/angular/angular/pull/20955/files/2c5e811bc5e6fa4f794ff38ecd8b84a59ee3cc25 |
| packages/elements/src/ng-element.ts | https://github.com/angular/angular/pull/20955/files/399587e7f95edab9ef6ddaf14a3fca2157b055a2..2c5e811bc5e6fa4f794ff38ecd8b84a59ee3cc25#diff-18b4032c390200d440d4df619c8e8fe09ecbc6610e383979e7be18339429f0f6 |
| gkalpak | https://github.com/gkalpak |
| Dec 14, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156895268 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| packages/elements/src/ng-element.ts | https://github.com/angular/angular/pull/20955/files/399587e7f95edab9ef6ddaf14a3fca2157b055a2#diff-18b4032c390200d440d4df619c8e8fe09ecbc6610e383979e7be18339429f0f6 |
| gkalpak | https://github.com/gkalpak |
| Dec 14, 2017 | https://github.com/angular/angular/pull/20955#discussion_r156895925 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| gogakoreli | https://github.com/gogakoreli |
| December 14, 2017 14:14 | https://github.com/angular/angular/pull/20955#commits-pushed-97750f3 |
|
| https://github.com/gogakoreli |
| fix(elements): fixed one way binding | https://github.com/angular/angular/pull/20955/commits/97750f3e4cf301cad0aa1372a890a794115f89ff |
| 97750f3 | https://github.com/angular/angular/pull/20955/commits/97750f3e4cf301cad0aa1372a890a794115f89ff |
|
| https://github.com/gkalpak |
| test(elements): add missing test (and fix formatting) | https://github.com/angular/angular/pull/20955/commits/debddb82420581c5fd579dcc93472ea1f910f3c6 |
| debddb8 | https://github.com/angular/angular/pull/20955/commits/debddb82420581c5fd579dcc93472ea1f910f3c6 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Dec 20, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-353171530 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 20, 2017 | https://github.com/angular/angular/pull/20955#event-1396823039 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 20, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-353171742 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 20, 2017 | https://github.com/angular/angular/pull/20955#event-1396825600 |
| https://github.com/gogakoreli |
| gogakoreli | https://github.com/gogakoreli |
| Dec 20, 2017 | https://github.com/angular/angular/pull/20955#issuecomment-353177731 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/splincode |
| splincode | https://github.com/splincode |
| Mar 15, 2018 | https://github.com/angular/angular/pull/20955#issuecomment-373477623 |
| @gogakoreli | https://github.com/gogakoreli |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 15, 2018 | https://github.com/angular/angular/pull/20955#issuecomment-373519934 |
| @gogakoreli | https://github.com/gogakoreli |
| #22413 | https://github.com/angular/angular/pull/22413 |
| #22413 | https://github.com/angular/angular/pull/22413 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 15, 2018 | https://github.com/angular/angular/pull/20955#event-1524280546 |
| https://github.com/gogakoreli |
| gogakoreli | https://github.com/gogakoreli |
| Mar 16, 2018 | https://github.com/angular/angular/pull/20955#issuecomment-373636427 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jul 4, 2019
| https://github.com/angular/angular/pull/20955#ref-pullrequest-464001613 |
|
fix(elements): handle inputs set before upgrade
#31416
| https://github.com/angular/angular/pull/31416 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/20955#issuecomment-531192017 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/20955#event-2631946018 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20955 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/20955/files/2c5e811bc5e6fa4f794ff38ecd8b84a59ee3cc25 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Please reload this page | https://github.com/angular/angular/pull/20955 |
|
| https://github.com/gogakoreli |
|
| https://github.com/googlebot |
|
| https://github.com/gkalpak |
|
| https://github.com/splincode |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |