René's URL Explorer Experiment


Title: fix(forms): ensure to emit status change events on subsequent value-update / validations by kgopi · Pull Request #20806 · angular/angular · GitHub

Open Graph Title: fix(forms): ensure to emit status change events on subsequent value-update / validations by kgopi · Pull Request #20806 · angular/angular

X Title: fix(forms): ensure to emit status change events on subsequent value-update / validations by kgopi · Pull Request #20806 · angular/angular

Description: fix(forms): ensure to emit status change events on subsequent value-update / validations RCA: During initialization of FormControl, emitEvent is getting passed as false to updateValueAndValidity function, in turn the same value got passed to the _runAsyncValidator function. (sets status = 'PENDING') and asyncValidator will be invoked. When we set the FormControl to the FormGroup via FormGroup.setcontrol, internally it is calling updateValueAndValidity (on FormGroup) function with emitEvent as undefined, it causes status change event to be emitted on FormGroup instance. (causes 'PENDING' status change event) When the asyncValidator (of FormControl) got resolved, setErrors function is getting invoked by passing the lexical scoped variable emitEvent (false in this case). As emitEvent value is false, susbsequent status change events are not getting notified !! If I understand correctly, status-change-events needs to be notified on value update / validations. Please correct me, If I am wrong. Issue: #20424 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? Issue Number: #20424 What is the new behavior? Does this PR introduce a breaking change? [ ] Yes [x] No Other information

Open Graph Description: fix(forms): ensure to emit status change events on subsequent value-update / validations RCA: During initialization of FormControl, emitEvent is getting passed as false to updateValueAndValidity fu...

X Description: fix(forms): ensure to emit status change events on subsequent value-update / validations RCA: During initialization of FormControl, emitEvent is getting passed as false to updateValueAndValidity fu...

Opengraph URL: https://github.com/angular/angular/pull/20806

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce44145e-c23f-6a83-2f33-f02b02f396c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5F8:8226C:E21E0:129DC6:6B015FCE
html-safe-nonce5a2b733c7ca35aae3ac3a9eeb3ef573f13e19128ad2f9170c389ba262d3458e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUY4OjgyMjZDOkUyMUUwOjEyOURDNjo2QjAxNUZDRSIsInZpc2l0b3JfaWQiOiI4ODg2MjQ2NDYyMDE1NDk2MTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ef39bfa2ab12de05289c4af15342ff20029b86a721862274db59fa0f1f564e8
hovercard-subject-tagpull_request:156522561
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/20806/files
twitter:imagehttps://avatars.githubusercontent.com/u/10814274?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10814274?s=400&v=4
og:image:altfix(forms): ensure to emit status change events on subsequent value-update / validations RCA: During initialization of FormControl, emitEvent is getting passed as false to updateValueAndValidity fu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/20806/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20806%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20806%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/20806/files
Reloadhttps://github.com/angular/angular/pull/20806/files
Reloadhttps://github.com/angular/angular/pull/20806/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
kgopihttps://github.com/kgopi
angular:masterhttps://github.com/angular/angular/tree/master
kgopi:20424https://github.com/kgopi/angular/tree/20424
Conversation 22 https://github.com/angular/angular/pull/20806
Commits 1 https://github.com/angular/angular/pull/20806/commits
Checks 0 https://github.com/angular/angular/pull/20806/checks
Files changed https://github.com/angular/angular/pull/20806/files
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
fix(forms): ensure to emit status change events on subsequent value-update / validations https://github.com/angular/angular/pull/20806/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/20806/files
0722c28 fix(forms): ensure to emit status change events on subsequent value-u… kgopi Dec 5, 2017 https://github.com/angular/angular/pull/20806/commits/0722c284278a37e82ae82069d06c9c903e6fe16f
Clear filters https://github.com/angular/angular/pull/20806/files
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
model.ts https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
form_group_spec.ts https://github.com/angular/angular/pull/20806/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
packages/forms/src/model.tshttps://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
View file https://github.com/kgopi/angular/blob/0722c284278a37e82ae82069d06c9c903e6fe16f/packages/forms/src/model.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20806/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
petebacondarwinhttps://github.com/petebacondarwin
Jan 8, 2020https://github.com/angular/angular/pull/20806/files#r364260440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 9, 2020https://github.com/angular/angular/pull/20806/files#r364513981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 15, 2020https://github.com/angular/angular/pull/20806/files#r440409114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
https://github.com/angular/angular/pull/20806/files#diff-61abe7c733b66d542f4f5bd4365382ab7c6a7a55327e3b7cb09d46b6c376b561
packages/forms/test/form_group_spec.tshttps://github.com/angular/angular/pull/20806/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
View file https://github.com/kgopi/angular/blob/0722c284278a37e82ae82069d06c9c903e6fe16f/packages/forms/test/form_group_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20806/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20806/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 15, 2020https://github.com/angular/angular/pull/20806/files#r440416887
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 15, 2020https://github.com/angular/angular/pull/20806/files#r440427657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 16, 2020https://github.com/angular/angular/pull/20806/files#r440522846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#22575https://github.com/angular/angular/pull/22575
#22575https://github.com/angular/angular/pull/22575
#22575https://github.com/angular/angular/pull/22575
Please reload this pagehttps://github.com/angular/angular/pull/20806/files
https://github.com/angular/angular/pull/20806/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.