René's URL Explorer Experiment


Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular · GitHub

Open Graph Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular

X Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular

Description: url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? Currently the baseHref is not being removed when syncing the URL from AngularJS to Angular. Issue Number: 20061 What is the new behavior? The baseHref is now removed before calling navigateByUrl which fixes navigation problems / seemingly infinite redirects. Does this PR introduce a breaking change? [ ] Yes [x] No Other information I know there is a commit against this issue already but I feel this is a more robust way to address the issue. This change, rather than parsing and splicing url fragments and inferring the baseHref, uses LocationStrategy's getBaseHref() and simply removes it before navigating. Seems less fragile AND more importantly will also work in the case where somebody manually sets APP_BASE_HREF. Another item of note is there was no spec file covering this method. I attempted to add one but get odd results when trying to call setupLocationSync from within my test. When calling setupLocationSync from within a test my assertion would not be reached whereas without the call to setupLocationSync it does. Perhaps this is why there is no test? In any case, I am willing to add one but might need some guidance.

Open Graph Description: url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...

X Description: url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...

Opengraph URL: https://github.com/angular/angular/pull/20467

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:31c5b367-cf75-711b-ceed-681d1257651c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97B8:363D8E:21CB267:2AE88F8:6B015F32
html-safe-nonced73004743ab284d15647dec73c25e98bbe750b99ffe9a2afd891e79ab5e00ef3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0I4OjM2M0Q4RToyMUNCMjY3OjJBRTg4Rjg6NkIwMTVGMzIiLCJ2aXNpdG9yX2lkIjoiNzA3NDc5MTY0OTI3NjE1Nzc0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4544b18c3b92b58d4266155e603a56c17c2f178bf09277a1ddca5aa469ceac32
hovercard-subject-tagpull_request:152907133
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/20467/files
twitter:imagehttps://avatars.githubusercontent.com/u/799293?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/799293?s=400&v=4
og:image:alturl.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/20467/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/20467/files
Reloadhttps://github.com/angular/angular/pull/20467/files
Reloadhttps://github.com/angular/angular/pull/20467/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
zbuhlerhttps://github.com/zbuhler
angular:masterhttps://github.com/angular/angular/tree/master
zbuhler:baseHref-fixhttps://github.com/zbuhler/angular/tree/baseHref-fix
Conversation 9 https://github.com/angular/angular/pull/20467
Commits 4 https://github.com/angular/angular/pull/20467/commits
Checks 0 https://github.com/angular/angular/pull/20467/checks
Files changed https://github.com/angular/angular/pull/20467/files
Please reload this pagehttps://github.com/angular/angular/pull/20467/files
fix(upgrade): account for baseHref when calling navigateByUrl https://github.com/angular/angular/pull/20467/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/20467/files
0e07cb1 fix(upgrade): account for baseHref when calling navigateByUrl Nov 15, 2017 https://github.com/angular/angular/pull/20467/commits/0e07cb14326d0e6b0ae2f9df643d90458dad01ac
7172c77 Fixing spacing / linting issue in my commit. zbuhler Nov 15, 2017 https://github.com/angular/angular/pull/20467/commits/7172c773ae4f446fdae5906d6e9e1cfe3d6024dc
8331558 style(upgrade): Revert whitespace change zbuhler Nov 16, 2017 https://github.com/angular/angular/pull/20467/commits/8331558c2b0999ce55785a2bc8b8ed67f3e9966c
29580ff style(upgrade): Remove additional whitespace zbuhler Nov 16, 2017 https://github.com/angular/angular/pull/20467/commits/29580ff371e325ea151ddcb8f097824c1f813cd4
Clear filters https://github.com/angular/angular/pull/20467/files
Please reload this pagehttps://github.com/angular/angular/pull/20467/files
Please reload this pagehttps://github.com/angular/angular/pull/20467/files
packages/router/upgrade/src/upgrade.tshttps://github.com/angular/angular/pull/20467/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
View file https://github.com/zbuhler/angular/blob/29580ff371e325ea151ddcb8f097824c1f813cd4/packages/router/upgrade/src/upgrade.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20467/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20467/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/20467/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/20467/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.