René's URL Explorer Experiment


Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular · GitHub

Open Graph Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular

X Title: fix(upgrade): account for baseHref when calling navigateByUrl by zbuhler · Pull Request #20467 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...

X Description: url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...

Opengraph URL: https://github.com/angular/angular/pull/20467

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a826f0da-a62e-b246-3efb-4843e1f9d359
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC526:1087D4:1A45472:23158F9:6B015B2F
html-safe-nonce14693baaadb88efbfc94897efeccc9cb345df813836d364fad26992aecccc6bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTI2OjEwODdENDoxQTQ1NDcyOjIzMTU4Rjk6NkIwMTVCMkYiLCJ2aXNpdG9yX2lkIjoiNzMzNjQyMjQ5ODM5NDc5MDcwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ec71b35e4d089c4863ed1b2b4cf214b9911d7c7e476f94454b5868bc79e2603
hovercard-subject-tagpull_request:152907133
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/20467/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1497798caf4ddb28bfa136c2b63d55a004e602c56707f7a140da8d96fa0dd6bb/angular/angular/pull/20467
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1497798caf4ddb28bfa136c2b63d55a004e602c56707f7a140da8d96fa0dd6bb/angular/angular/pull/20467
og:image:alturl.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The comm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezbuhler
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/20467#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/20467
Reloadhttps://github.com/angular/angular/pull/20467
Reloadhttps://github.com/angular/angular/pull/20467
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
zbuhlerhttps://github.com/zbuhler
angular:masterhttps://github.com/angular/angular/tree/master
zbuhler:baseHref-fixhttps://github.com/zbuhler/angular/tree/baseHref-fix
Conversationhttps://github.com/angular/angular/pull/20467
Commits4 (4)https://github.com/angular/angular/pull/20467/commits
Checkshttps://github.com/angular/angular/pull/20467/checks
Files changedhttps://github.com/angular/angular/pull/20467/files
fix(upgrade): account for baseHref when calling navigateByUrlhttps://github.com/angular/angular/pull/20467#top
zbuhlerhttps://github.com/zbuhler
angular:masterhttps://github.com/angular/angular/tree/master
zbuhler:baseHref-fixhttps://github.com/zbuhler/angular/tree/baseHref-fix
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
Nov 15, 2017https://github.com/angular/angular/pull/20467#issue-274333912
Please reload this pagehttps://github.com/angular/angular/pull/20467
#20061https://github.com/angular/angular/issues/20061
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
20061https://github.com/angular/angular/issues/20061
Please reload this pagehttps://github.com/angular/angular/pull/20467
fix(upgrade): account for baseHref when calling navigateByUrlhttps://github.com/angular/angular/pull/20467/commits/0e07cb14326d0e6b0ae2f9df643d90458dad01ac
0e07cb1https://github.com/angular/angular/pull/20467/commits/0e07cb14326d0e6b0ae2f9df643d90458dad01ac
angular#20061https://github.com/angular/angular/issues/20061
https://github.com/googlebot
googlebothttps://github.com/googlebot
Nov 15, 2017https://github.com/angular/angular/pull/20467#issuecomment-344756488
https://cla.developers.google.com/https://cla.developers.google.com/
your existing CLA datahttps://cla.developers.google.com/clas
email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Nov 15, 2017https://github.com/angular/angular/pull/20467#event-1344052338
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
Nov 15, 2017https://github.com/angular/angular/pull/20467#issuecomment-344756944
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/googlebot
googlebothttps://github.com/googlebot
Nov 15, 2017https://github.com/angular/angular/pull/20467#issuecomment-344756965
login herehttps://cla.developers.google.com/
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
Nov 15, 2017https://github.com/angular/angular/pull/20467#issuecomment-344760414
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/googlebot
googlebothttps://github.com/googlebot
Nov 15, 2017https://github.com/angular/angular/pull/20467#issuecomment-344760421
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Nov 15, 2017https://github.com/angular/angular/pull/20467#event-1344076504
zbuhlerhttps://github.com/zbuhler
November 15, 2017 16:16https://github.com/angular/angular/pull/20467#commits-pushed-7172c77
https://github.com/zbuhler
Fixing spacing / linting issue in my commit.https://github.com/angular/angular/pull/20467/commits/7172c773ae4f446fdae5906d6e9e1cfe3d6024dc
7172c77https://github.com/angular/angular/pull/20467/commits/7172c773ae4f446fdae5906d6e9e1cfe3d6024dc
https://github.com/zbuhler
style(upgrade): Revert whitespace changehttps://github.com/angular/angular/pull/20467/commits/8331558c2b0999ce55785a2bc8b8ed67f3e9966c
8331558https://github.com/angular/angular/pull/20467/commits/8331558c2b0999ce55785a2bc8b8ed67f3e9966c
https://github.com/zbuhler
style(upgrade): Remove additional whitespacehttps://github.com/angular/angular/pull/20467/commits/29580ff371e325ea151ddcb8f097824c1f813cd4
29580ffhttps://github.com/angular/angular/pull/20467/commits/29580ff371e325ea151ddcb8f097824c1f813cd4
https://github.com/benedikt-roth
benedikt-rothhttps://github.com/benedikt-roth
Nov 16, 2017https://github.com/angular/angular/pull/20467#issuecomment-344824965
#20244https://github.com/angular/angular/pull/20244
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 16, 2017https://github.com/angular/angular/pull/20467#issuecomment-344906390
https://github.com/angular/angular/pull/20244/files#r151214896https://github.com/angular/angular/pull/20244/files#r151214896
#20244https://github.com/angular/angular/pull/20244
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
comp: upgrade/static https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%2Fstatic%22
Nov 16, 2017https://github.com/angular/angular/pull/20467#event-1344980656
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
Nov 16, 2017https://github.com/angular/angular/pull/20467#issuecomment-344967454
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
Nov 16, 2017https://github.com/angular/angular/pull/20467#event-1345400594
https://github.com/zbuhler
zbuhlerhttps://github.com/zbuhler
November 16, 2017 15:57https://github.com/angular/angular/pull/20467#event-1345402519
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/20467#issuecomment-531012139
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/20467#event-2630609249
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467
Please reload this pagehttps://github.com/angular/angular/pull/20467
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect https://github.com/angular/angular/issues/20061
Please reload this pagehttps://github.com/angular/angular/pull/20467
https://github.com/zbuhler
https://github.com/googlebot
https://github.com/benedikt-roth
https://github.com/gkalpak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.