| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a826f0da-a62e-b246-3efb-4843e1f9d359 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C526:1087D4:1A45472:23158F9:6B015B2F |
| html-safe-nonce | 14693baaadb88efbfc94897efeccc9cb345df813836d364fad26992aecccc6bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTI2OjEwODdENDoxQTQ1NDcyOjIzMTU4Rjk6NkIwMTVCMkYiLCJ2aXNpdG9yX2lkIjoiNzMzNjQyMjQ5ODM5NDc5MDcwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4ec71b35e4d089c4863ed1b2b4cf214b9911d7c7e476f94454b5868bc79e2603 |
| hovercard-subject-tag | pull_request:152907133 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/20467/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1497798caf4ddb28bfa136c2b63d55a004e602c56707f7a140da8d96fa0dd6bb/angular/angular/pull/20467 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1497798caf4ddb28bfa136c2b63d55a004e602c56707f7a140da8d96fa0dd6bb/angular/angular/pull/20467 |
| og:image:alt | url.pathname needs to remove baseHref otherwise it repeatedly gets added causing numerous redirects
Fixes #20061
PR Checklist
Please check if your PR fulfills the following requirements:
The comm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zbuhler |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/20467#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/20467 |
| Reload | https://github.com/angular/angular/pull/20467 |
| Reload | https://github.com/angular/angular/pull/20467 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| zbuhler | https://github.com/zbuhler |
| angular:master | https://github.com/angular/angular/tree/master |
| zbuhler:baseHref-fix | https://github.com/zbuhler/angular/tree/baseHref-fix |
| Conversation | https://github.com/angular/angular/pull/20467 |
| Commits4 (4) | https://github.com/angular/angular/pull/20467/commits |
| Checks | https://github.com/angular/angular/pull/20467/checks |
| Files changed | https://github.com/angular/angular/pull/20467/files |
| fix(upgrade): account for baseHref when calling navigateByUrl | https://github.com/angular/angular/pull/20467#top |
| zbuhler | https://github.com/zbuhler |
| angular:master | https://github.com/angular/angular/tree/master |
| zbuhler:baseHref-fix | https://github.com/zbuhler/angular/tree/baseHref-fix |
|
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issue-274333912 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| #20061 | https://github.com/angular/angular/issues/20061 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| 20061 | https://github.com/angular/angular/issues/20061 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| fix(upgrade): account for baseHref when calling navigateByUrl | https://github.com/angular/angular/pull/20467/commits/0e07cb14326d0e6b0ae2f9df643d90458dad01ac |
| 0e07cb1 | https://github.com/angular/angular/pull/20467/commits/0e07cb14326d0e6b0ae2f9df643d90458dad01ac |
| angular#20061 | https://github.com/angular/angular/issues/20061 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344756488 |
| https://cla.developers.google.com/ | https://cla.developers.google.com/ |
| your existing CLA data | https://cla.developers.google.com/clas |
| email is set on your git commits | https://help.github.com/articles/setting-your-email-in-git/ |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#event-1344052338 |
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344756944 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344756965 |
| login here | https://cla.developers.google.com/ |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344760414 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344760421 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Nov 15, 2017 | https://github.com/angular/angular/pull/20467#event-1344076504 |
| zbuhler | https://github.com/zbuhler |
| November 15, 2017 16:16 | https://github.com/angular/angular/pull/20467#commits-pushed-7172c77 |
|
| https://github.com/zbuhler |
| Fixing spacing / linting issue in my commit. | https://github.com/angular/angular/pull/20467/commits/7172c773ae4f446fdae5906d6e9e1cfe3d6024dc |
| 7172c77 | https://github.com/angular/angular/pull/20467/commits/7172c773ae4f446fdae5906d6e9e1cfe3d6024dc |
|
| https://github.com/zbuhler |
| style(upgrade): Revert whitespace change | https://github.com/angular/angular/pull/20467/commits/8331558c2b0999ce55785a2bc8b8ed67f3e9966c |
| 8331558 | https://github.com/angular/angular/pull/20467/commits/8331558c2b0999ce55785a2bc8b8ed67f3e9966c |
|
| https://github.com/zbuhler |
| style(upgrade): Remove additional whitespace | https://github.com/angular/angular/pull/20467/commits/29580ff371e325ea151ddcb8f097824c1f813cd4 |
| 29580ff | https://github.com/angular/angular/pull/20467/commits/29580ff371e325ea151ddcb8f097824c1f813cd4 |
| https://github.com/benedikt-roth |
| benedikt-roth | https://github.com/benedikt-roth |
| Nov 16, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344824965 |
| #20244 | https://github.com/angular/angular/pull/20244 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Nov 16, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344906390 |
| https://github.com/angular/angular/pull/20244/files#r151214896 | https://github.com/angular/angular/pull/20244/files#r151214896 |
| #20244 | https://github.com/angular/angular/pull/20244 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: upgrade/static
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20upgrade%2Fstatic%22 |
| Nov 16, 2017 | https://github.com/angular/angular/pull/20467#event-1344980656 |
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| Nov 16, 2017 | https://github.com/angular/angular/pull/20467#issuecomment-344967454 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| Nov 16, 2017 | https://github.com/angular/angular/pull/20467#event-1345400594 |
| https://github.com/zbuhler |
| zbuhler | https://github.com/zbuhler |
| November 16, 2017 15:57 | https://github.com/angular/angular/pull/20467#event-1345402519 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 12, 2019 | https://github.com/angular/angular/pull/20467#issuecomment-531012139 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 12, 2019 | https://github.com/angular/angular/pull/20467#event-2630609249 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20467 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
Changing baseHref in Angular along with the Upgrade Module to work with AngularJS router causes infinite redirect
| https://github.com/angular/angular/issues/20061 |
| Please reload this page | https://github.com/angular/angular/pull/20467 |
|
| https://github.com/zbuhler |
|
| https://github.com/googlebot |
|
| https://github.com/benedikt-roth |
|
| https://github.com/gkalpak |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |