René's URL Explorer Experiment


Title: fix(upgrade): need to take base uri into account in setUpLocationSync by observstream · Pull Request #20244 · angular/angular · GitHub

Open Graph Title: fix(upgrade): need to take base uri into account in setUpLocationSync by observstream · Pull Request #20244 · angular/angular

X Title: fix(upgrade): need to take base uri into account in setUpLocationSync by observstream · Pull Request #20244 · angular/angular

Description: The url.pathname passes the base uri as part of the url instead of removing it Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? I am modifying the setUpLocationSync in packages/router/upgrade/src/upgrade.ts to take the base tag into account when navigating by url Issue Number: 20061 What is the new behavior? The base tag is removed from the pathname before the router navigates to the specified url. This stops an infinite loop from occurring when navigating between Angular and AngularJS. Does this PR introduce a breaking change? [ ] Yes [x] No Other information

Open Graph Description: The url.pathname passes the base uri as part of the url instead of removing it Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows ou...

X Description: The url.pathname passes the base uri as part of the url instead of removing it Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows ou...

Opengraph URL: https://github.com/angular/angular/pull/20244

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ffb67e76-c394-fbf3-45da-3db82a5fbe7f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C4A:11EACE:1C58E64:25C9743:6B016409
html-safe-nonce0fc9e0e858f62bfc40fb37987dcb04f8b8ea22d3308846dbf8c8dd0eb7121549
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzRBOjExRUFDRToxQzU4RTY0OjI1Qzk3NDM6NkIwMTY0MDkiLCJ2aXNpdG9yX2lkIjoiODcwNTk2MTM2NTc3MDE2NzMwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1090043f91ca5b698c7015c616ca569f60e6e83df1ea0e223eb8bdfe3f13a307
hovercard-subject-tagpull_request:151177602
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/20244/files
twitter:imagehttps://avatars.githubusercontent.com/u/2252877?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2252877?s=400&v=4
og:image:altThe url.pathname passes the base uri as part of the url instead of removing it Fixes #20061 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows ou...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/20244/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20244%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F20244%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/20244/files
Reloadhttps://github.com/angular/angular/pull/20244/files
Reloadhttps://github.com/angular/angular/pull/20244/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
observstreamhttps://github.com/observstream
angular:masterhttps://github.com/angular/angular/tree/master
observstream:base-href-duplicationhttps://github.com/observstream/angular/tree/base-href-duplication
Conversation 90 https://github.com/angular/angular/pull/20244
Commits 5 https://github.com/angular/angular/pull/20244/commits
Checks 0 https://github.com/angular/angular/pull/20244/checks
Files changed https://github.com/angular/angular/pull/20244/files
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
fix(upgrade): need to take base uri into account in setUpLocationSync https://github.com/angular/angular/pull/20244/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/20244/files
f37a640 fix(router): take base uri into account in `setUpLocationSync()` observstream Nov 7, 2017 https://github.com/angular/angular/pull/20244/commits/f37a640e045811bab8de9d29dfaf1c3140d2f80c
505d0e6 fixup! fix(router): take base uri into account in `setUpLocationSync()` gkalpak Mar 1, 2018 https://github.com/angular/angular/pull/20244/commits/505d0e6cb6ab2e57781a91f64fd4322614670067
26f948b fixup! fix(router): take base uri into account in `setUpLocationSync()` gkalpak Mar 1, 2018 https://github.com/angular/angular/pull/20244/commits/26f948b7d2e9ba92469809e82ba6429940e3afe5
a659c48 fixup! fix(router): take base uri into account in `setUpLocationSync()` gkalpak Jun 11, 2018 https://github.com/angular/angular/pull/20244/commits/a659c48964dda934faa86aa5e9572f427a0d7723
d2af25f fixup! fix(router): take base uri into account in `setUpLocationSync()` gkalpak Aug 6, 2018 https://github.com/angular/angular/pull/20244/commits/d2af25f3ca506113d180ce129e9bc5df6ea07fef
Clear filters https://github.com/angular/angular/pull/20244/files
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
karma-js.conf.js https://github.com/angular/angular/pull/20244/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
BUILD.bazel https://github.com/angular/angular/pull/20244/files#diff-5f85704b0c06b4d1fbd10c09a845e8d710f3b9eddd059cd809eb70bb07cfa310
karma-test-shim.js https://github.com/angular/angular/pull/20244/files#diff-88ad8ce8e5433b55d4d8aa8c713852a9b3a029cb6282234ed6f95d00ed75f8be
karma.conf.js https://github.com/angular/angular/pull/20244/files#diff-b17b334cb375e0f26d357fbd621c21e8e5b78381d3e3810f188cb450bfbdbba3
BUILD.bazel https://github.com/angular/angular/pull/20244/files#diff-9fba4fe8132e9fd9f31c0f8039fd0792f6f1fb6973a22f5982c66a81abc39ebf
upgrade.ts https://github.com/angular/angular/pull/20244/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
BUILD.bazel https://github.com/angular/angular/pull/20244/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
upgrade.spec.ts https://github.com/angular/angular/pull/20244/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
karma-js.conf.jshttps://github.com/angular/angular/pull/20244/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/karma-js.conf.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
https://github.com/angular/angular/pull/20244/files#diff-9b1bddce9707b93c8b3eaefb4d54fe77f013401d2039ac2a2ca70a43d5dfacce
packages/router/BUILD.bazelhttps://github.com/angular/angular/pull/20244/files#diff-5f85704b0c06b4d1fbd10c09a845e8d710f3b9eddd059cd809eb70bb07cfa310
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-5f85704b0c06b4d1fbd10c09a845e8d710f3b9eddd059cd809eb70bb07cfa310
https://github.com/angular/angular/pull/20244/files#diff-5f85704b0c06b4d1fbd10c09a845e8d710f3b9eddd059cd809eb70bb07cfa310
packages/router/karma-test-shim.jshttps://github.com/angular/angular/pull/20244/files#diff-88ad8ce8e5433b55d4d8aa8c713852a9b3a029cb6282234ed6f95d00ed75f8be
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/karma-test-shim.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-88ad8ce8e5433b55d4d8aa8c713852a9b3a029cb6282234ed6f95d00ed75f8be
https://github.com/angular/angular/pull/20244/files#diff-88ad8ce8e5433b55d4d8aa8c713852a9b3a029cb6282234ed6f95d00ed75f8be
packages/router/karma.conf.jshttps://github.com/angular/angular/pull/20244/files#diff-b17b334cb375e0f26d357fbd621c21e8e5b78381d3e3810f188cb450bfbdbba3
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/karma.conf.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-b17b334cb375e0f26d357fbd621c21e8e5b78381d3e3810f188cb450bfbdbba3
gkalpakhttps://github.com/gkalpak
Feb 27, 2018https://github.com/angular/angular/pull/20244/files#r171051952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
observstreamhttps://github.com/observstream
Feb 27, 2018https://github.com/angular/angular/pull/20244/files#r171104809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
observstreamhttps://github.com/observstream
Feb 28, 2018https://github.com/angular/angular/pull/20244/files#r171107736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
gkalpakhttps://github.com/gkalpak
Feb 28, 2018https://github.com/angular/angular/pull/20244/files#r171240243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
observstreamhttps://github.com/observstream
Feb 28, 2018https://github.com/angular/angular/pull/20244/files#r171287824
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
See herehttps://github.com/jahumes/angular/blob/85247ffc3371cbb799715d3c796a01d23ed5e261/packages/router/karma-test-shim.js#L48-L49
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
alexeaglehttps://github.com/alexeagle
May 2, 2018https://github.com/angular/angular/pull/20244/files#r185671526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
alexeaglehttps://github.com/alexeagle
Jun 8, 2018https://github.com/angular/angular/pull/20244/files#r194146785
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
gkalpakhttps://github.com/gkalpak
Jun 8, 2018https://github.com/angular/angular/pull/20244/files#r194147674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
https://github.com/angular/angular/pull/20244/files#diff-b17b334cb375e0f26d357fbd621c21e8e5b78381d3e3810f188cb450bfbdbba3
packages/router/upgrade/BUILD.bazelhttps://github.com/angular/angular/pull/20244/files#diff-9fba4fe8132e9fd9f31c0f8039fd0792f6f1fb6973a22f5982c66a81abc39ebf
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/upgrade/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-9fba4fe8132e9fd9f31c0f8039fd0792f6f1fb6973a22f5982c66a81abc39ebf
packages/router/upgrade/src/upgrade.tshttps://github.com/angular/angular/pull/20244/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/upgrade/src/upgrade.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com/angular/angular/pull/20244/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/20244/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
https://github.com/angular/angular/pull/20244/files#diff-83b44a29b6f59c4903b027f6e3e08b1e7f29a06a4034d9bdefb72f1ca3f1d8e4
alfaprojecthttps://github.com/alfaproject
Mar 1, 2018https://github.com/angular/angular/pull/20244/files#r171719295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
mafredrihttps://github.com/mafredri
Mar 1, 2018https://github.com/angular/angular/pull/20244/files#r171721829
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/20244/files
packages/router/upgrade/test/BUILD.bazelhttps://github.com/angular/angular/pull/20244/files#diff-7ebdb73bb63bb69396d1d6fae188cb14ddcd90ea4a58d97083393455803c8405
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/upgrade/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
packages/router/upgrade/test/upgrade.spec.tshttps://github.com/angular/angular/pull/20244/files#diff-357950df916cd8f1f26389b2f28be316278b885bfa99c738fc7c3864b25438c7
View file https://github.com/observstream/angular/blob/d2af25f3ca506113d180ce129e9bc5df6ea07fef/packages/router/upgrade/test/upgrade.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/20244/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.