| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:97a9edef-6a7a-3211-3dcd-b69a092727a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B13A:DB09F:915377:BAEE45:6B00EF2D |
| html-safe-nonce | 70bf80d1872e25d5a92dbb00491675c2fb777cea2bf856af37a8b3e563612057 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTNBOkRCMDlGOjkxNTM3NzpCQUVFNDU6NkIwMEVGMkQiLCJ2aXNpdG9yX2lkIjoiOTA2ODczMjY3MzE2NTQyMjM4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c100064d5ee13973da73893233378bd102ec2240d838e06b50e0d15d69d09137 |
| hovercard-subject-tag | pull_request:148440647 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/19904/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c134b6e37b1a5c07f666c755ed1cf56b3959f0c567c8ecc213e2558c75be59e0/angular/angular/pull/19904 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c134b6e37b1a5c07f666c755ed1cf56b3959f0c567c8ecc213e2558c75be59e0/angular/angular/pull/19904 |
| og:image:alt | PR Checklist
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/19904#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F19904 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F19904 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/19904 |
| Reload | https://github.com/angular/angular/pull/19904 |
| Reload | https://github.com/angular/angular/pull/19904 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:build-upgrade-jasmine | https://github.com/gkalpak/angular/tree/build-upgrade-jasmine |
| Conversation | https://github.com/angular/angular/pull/19904 |
| Commits9 (9) | https://github.com/angular/angular/pull/19904/commits |
| Checks | https://github.com/angular/angular/pull/19904/checks |
| Files changed | https://github.com/angular/angular/pull/19904/files |
| build: upgrade jasmine (and related typings) to latest version | https://github.com/angular/angular/pull/19904#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:build-upgrade-jasmine | https://github.com/gkalpak/angular/tree/build-upgrade-jasmine |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#issue-268089629 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| DefinitelyTyped | https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b7e43ef2bbfd5f045e12203f952bfe11afd03230/types/jasminewd2/index.d.ts#L9-L15 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#event-1308080874 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
PR target: TBD
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22PR%20target%3A%20TBD%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#event-1308081824 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339044329 |
| https://pr19904-3e2ed3c.ngbuilds.io/ | https://pr19904-3e2ed3c.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/3e2ed3cc3a7858ef99826934c46bda2ca2ad6779..bc82db9e133ea79b6663b4e8df31da30b37ac308 |
| 3e2ed3c | https://github.com/angular/angular/commit/3e2ed3cc3a7858ef99826934c46bda2ca2ad6779 |
| bc82db9 | https://github.com/angular/angular/commit/bc82db9e133ea79b6663b4e8df31da30b37ac308 |
|
Compare
| https://github.com/angular/angular/compare/3e2ed3cc3a7858ef99826934c46bda2ca2ad6779..bc82db9e133ea79b6663b4e8df31da30b37ac308 |
| October 24, 2017 17:34 | https://github.com/angular/angular/pull/19904#event-1308271363 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 24, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71607337 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| tools/types-ext/jasminewd2.d.ts | https://github.com/angular/angular/pull/19904/files#diff-d9d424cf597719a8ed841ad325b7cfb54e4ceff05a999823a8c1fd568bfedfd1 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146636531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 24, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71607450 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| tools/types-ext/jasminewd2.d.ts | https://github.com/angular/angular/pull/19904/files#diff-d9d424cf597719a8ed841ad325b7cfb54e4ceff05a999823a8c1fd568bfedfd1 |
| gkalpak | https://github.com/gkalpak |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146636625 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339076875 |
| https://pr19904-bc82db9.ngbuilds.io/ | https://pr19904-bc82db9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/bc82db9e133ea79b6663b4e8df31da30b37ac308..c0746edd92f43f2112b00270dba66accf8581002 |
| bc82db9 | https://github.com/angular/angular/commit/bc82db9e133ea79b6663b4e8df31da30b37ac308 |
| c0746ed | https://github.com/angular/angular/commit/c0746edd92f43f2112b00270dba66accf8581002 |
|
Compare
| https://github.com/angular/angular/compare/bc82db9e133ea79b6663b4e8df31da30b37ac308..c0746edd92f43f2112b00270dba66accf8581002 |
| October 24, 2017 18:13 | https://github.com/angular/angular/pull/19904#event-1308345852 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 24, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339085669 |
| https://pr19904-c0746ed.ngbuilds.io/ | https://pr19904-c0746ed.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/c0746edd92f43f2112b00270dba66accf8581002..c4c20aeee43c262e86ebe7445bcce0995e6f5e97 |
| c0746ed | https://github.com/angular/angular/commit/c0746edd92f43f2112b00270dba66accf8581002 |
| c4c20ae | https://github.com/angular/angular/commit/c4c20aeee43c262e86ebe7445bcce0995e6f5e97 |
|
Compare
| https://github.com/angular/angular/compare/c0746edd92f43f2112b00270dba66accf8581002..c4c20aeee43c262e86ebe7445bcce0995e6f5e97 |
| October 25, 2017 07:54 | https://github.com/angular/angular/pull/19904#event-1309300907 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#event-1309303675 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/c4c20aeee43c262e86ebe7445bcce0995e6f5e97..9316f5ba9641891353e559b5645d5e6b68c6b3fd |
| c4c20ae | https://github.com/angular/angular/commit/c4c20aeee43c262e86ebe7445bcce0995e6f5e97 |
| 9316f5b | https://github.com/angular/angular/commit/9316f5ba9641891353e559b5645d5e6b68c6b3fd |
|
Compare
| https://github.com/angular/angular/compare/c4c20aeee43c262e86ebe7445bcce0995e6f5e97..9316f5ba9641891353e559b5645d5e6b68c6b3fd |
| October 25, 2017 08:02 | https://github.com/angular/angular/pull/19904#event-1309313076 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339250088 |
| https://pr19904-c4c20ae.ngbuilds.io/ | https://pr19904-c4c20ae.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339251300 |
| https://pr19904-9316f5b.ngbuilds.io/ | https://pr19904-9316f5b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/9316f5ba9641891353e559b5645d5e6b68c6b3fd..5a789666110469fb31c6935b526ba62b88468921 |
| 9316f5b | https://github.com/angular/angular/commit/9316f5ba9641891353e559b5645d5e6b68c6b3fd |
| 5a78966 | https://github.com/angular/angular/commit/5a789666110469fb31c6935b526ba62b88468921 |
|
Compare
| https://github.com/angular/angular/compare/9316f5ba9641891353e559b5645d5e6b68c6b3fd..5a789666110469fb31c6935b526ba62b88468921 |
| October 25, 2017 09:27 | https://github.com/angular/angular/pull/19904#event-1309459032 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339274477 |
| https://pr19904-5a78966.ngbuilds.io/ | https://pr19904-5a78966.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 25, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71809664 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| packages/common/test/pipes/date_pipe_spec.ts | https://github.com/angular/angular/pull/19904/files#diff-d7f470cbcf40651c6dfb024826e4269b21718b99ad83ff7f86704df11cb430c8 |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146813260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| ocombe | https://github.com/ocombe |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146864950 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 25, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71815578 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| packages/compiler-cli/test/metadata/collector_spec.ts | https://github.com/angular/angular/pull/19904/files#diff-5504cc717b0668e556404e2f3b63e451ef939d6eff7cfbf90f9e78eafc617428 |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146818545 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/angular/angular/pull/19904/files#diff-93cb4d146755c3214602a83de1c313f2R455 |
| here | https://github.com/angular/angular/pull/19904/files#diff-cdf1f6981339577e6b2003f82efb749eL118 |
| here | https://github.com/angular/angular/pull/19904/files#diff-0cb86a67c64e9b1b291919678078a500R275 |
| @tbosch | https://github.com/tbosch |
| @chuckjaz | https://github.com/chuckjaz |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| chuckjaz | https://github.com/chuckjaz |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146906160 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 25, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71816937 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| packages/core/test/linker/source_map_integration_node_only_spec.ts | https://github.com/angular/angular/pull/19904/files#diff-4e9c2286b20ab1c7774e662670b922629af6fa0d5e33337eba0e6df910afabf3 |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146819717 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @tbosch | https://github.com/tbosch |
| @chuckjaz | https://github.com/chuckjaz |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| mhevery | https://github.com/mhevery |
| Jul 2, 2018 | https://github.com/angular/angular/pull/19904#discussion_r199610893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 25, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71819550 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| packages/router/src/url_tree.ts | https://github.com/angular/angular/pull/19904/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9 |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146821802 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| IgorMinar | https://github.com/IgorMinar |
| Nov 2, 2017 | https://github.com/angular/angular/pull/19904#discussion_r148640588 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasonaden | https://github.com/jasonaden |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| Nov 2, 2017 | https://github.com/angular/angular/pull/19904#discussion_r148654182 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| Nov 29, 2017 | https://github.com/angular/angular/pull/19904#discussion_r153821866 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 25, 2017
| https://github.com/angular/angular/pull/19904#pullrequestreview-71823539 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files |
| tools/types-ext/jasminewd2.d.ts | https://github.com/angular/angular/pull/19904/files#diff-d9d424cf597719a8ed841ad325b7cfb54e4ceff05a999823a8c1fd568bfedfd1 |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146825049 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vikerman | https://github.com/vikerman |
| jasminewd | https://github.com/angular/jasminewd |
| DefinitelyTyped | https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jasminewd2 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| alexeagle | https://github.com/alexeagle |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#discussion_r146908737 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/5a789666110469fb31c6935b526ba62b88468921..8a3b7dae774a2715d63cb45cccd9d56d503697a6 |
| 5a78966 | https://github.com/angular/angular/commit/5a789666110469fb31c6935b526ba62b88468921 |
| 8a3b7da | https://github.com/angular/angular/commit/8a3b7dae774a2715d63cb45cccd9d56d503697a6 |
|
Compare
| https://github.com/angular/angular/compare/5a789666110469fb31c6935b526ba62b88468921..8a3b7dae774a2715d63cb45cccd9d56d503697a6 |
| October 25, 2017 11:17 | https://github.com/angular/angular/pull/19904#event-1309643213 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#event-1309643605 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 25, 2017 | https://github.com/angular/angular/pull/19904#issuecomment-339299834 |
| https://pr19904-8a3b7da.ngbuilds.io/ | https://pr19904-8a3b7da.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/8a3b7dae774a2715d63cb45cccd9d56d503697a6..4e2adb23d550990889bc33ae8e97cf763fe3fd83 |
| 8a3b7da | https://github.com/angular/angular/commit/8a3b7dae774a2715d63cb45cccd9d56d503697a6 |
| 4e2adb2 | https://github.com/angular/angular/commit/4e2adb23d550990889bc33ae8e97cf763fe3fd83 |
|
Compare
| https://github.com/angular/angular/compare/8a3b7dae774a2715d63cb45cccd9d56d503697a6..4e2adb23d550990889bc33ae8e97cf763fe3fd83 |
| October 25, 2017 23:06 | https://github.com/angular/angular/pull/19904#event-1310928280 |
| gkalpak | https://github.com/gkalpak |
| July 5, 2018 21:53 | https://github.com/angular/angular/pull/19904#commits-pushed-0b9619d |
|
| https://github.com/gkalpak |
| test: make NgMatchers type-aware | https://github.com/angular/angular/pull/19904/commits/0b9619dacbe4926c171c12adc98a5069c933eb13 |
| 0b9619d | https://github.com/angular/angular/pull/19904/commits/0b9619dacbe4926c171c12adc98a5069c933eb13 |
|
| https://github.com/gkalpak |
| refactor: infer type for it() assertion functions | https://github.com/angular/angular/pull/19904/commits/d9b5d4a623a48b74fa35143d4c7f2ff383e5764e |
| d9b5d4a | https://github.com/angular/angular/pull/19904/commits/d9b5d4a623a48b74fa35143d4c7f2ff383e5764e |
|
| https://github.com/gkalpak |
| build: upgrade jasmine to 2.99.x and fix tests | https://github.com/angular/angular/pull/19904/commits/af521c36443fd0778aeaf496be2acb6eedc8ef5f |
| af521c3 | https://github.com/angular/angular/pull/19904/commits/af521c36443fd0778aeaf496be2acb6eedc8ef5f |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/1fdac95da2b3f7f172dff9451eefe7383e9ad34f..97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9 |
| 1fdac95 | https://github.com/angular/angular/commit/1fdac95da2b3f7f172dff9451eefe7383e9ad34f |
| 97dfaf3 | https://github.com/angular/angular/commit/97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9 |
|
Compare
| https://github.com/angular/angular/compare/1fdac95da2b3f7f172dff9451eefe7383e9ad34f..97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9 |
| July 5, 2018 19:07 | https://github.com/angular/angular/pull/19904#event-1718807772 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 5, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402824623 |
| https://pr19904-1fdac95.ngbuilds.io/ | https://pr19904-1fdac95.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 5, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402826648 |
| https://pr19904-97dfaf3.ngbuilds.io/ | https://pr19904-97dfaf3.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9..0f35833529e6094feaf485ca8e69fdf98185b726 |
| 97dfaf3 | https://github.com/angular/angular/commit/97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9 |
| 0f35833 | https://github.com/angular/angular/commit/0f35833529e6094feaf485ca8e69fdf98185b726 |
|
Compare
| https://github.com/angular/angular/compare/97dfaf3dd78b09fc407ecdc3bad9b28e35ac53d9..0f35833529e6094feaf485ca8e69fdf98185b726 |
| July 5, 2018 19:45 | https://github.com/angular/angular/pull/19904#event-1718874522 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402922858 |
| https://pr19904-0f35833.ngbuilds.io/ | https://pr19904-0f35833.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
|
| https://github.com/gkalpak |
| refactor: re-organize and "modernize" cjs-jasmine scripts | https://github.com/angular/angular/pull/19904/commits/a1fa87de6c71fc67bf7e7331390c3953e9701cc2 |
| a1fa87d | https://github.com/angular/angular/pull/19904/commits/a1fa87de6c71fc67bf7e7331390c3953e9701cc2 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/0f35833529e6094feaf485ca8e69fdf98185b726..1a3f52c83b51fd3e83ab36a99c412e9b83dbd6e7 |
| 0f35833 | https://github.com/angular/angular/commit/0f35833529e6094feaf485ca8e69fdf98185b726 |
| 1a3f52c | https://github.com/angular/angular/commit/1a3f52c83b51fd3e83ab36a99c412e9b83dbd6e7 |
|
Compare
| https://github.com/angular/angular/compare/0f35833529e6094feaf485ca8e69fdf98185b726..1a3f52c83b51fd3e83ab36a99c412e9b83dbd6e7 |
| July 6, 2018 06:17 | https://github.com/angular/angular/pull/19904#event-1719559248 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402939454 |
| https://pr19904-1a3f52c.ngbuilds.io/ | https://pr19904-1a3f52c.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402968913 |
| https://pr19904-b3a3be0.ngbuilds.io/ | https://pr19904-b3a3be0.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402976365 |
| https://pr19904-8071de3.ngbuilds.io/ | https://pr19904-8071de3.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| July 6, 2018 12:51 | https://github.com/angular/angular/pull/19904#commits-pushed-f83f603 |
|
| https://github.com/gkalpak |
| test: run unit tests in random order | https://github.com/angular/angular/pull/19904/commits/f83f60326597f5b2e38ab12750a0f50c05148abe |
| f83f603 | https://github.com/angular/angular/pull/19904/commits/f83f60326597f5b2e38ab12750a0f50c05148abe |
|
| https://github.com/gkalpak |
| build: upgrade jasmine to 3.1.0 | https://github.com/angular/angular/pull/19904/commits/964a12225f5210a59d21ba2955f0e8e838c43c1b |
| 964a122 | https://github.com/angular/angular/pull/19904/commits/964a12225f5210a59d21ba2955f0e8e838c43c1b |
|
| https://github.com/gkalpak |
| build: upgrade karma and related dependencies | https://github.com/angular/angular/pull/19904/commits/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
| 0ebba85 | https://github.com/angular/angular/pull/19904/commits/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-402989024 |
| 0ebba85 | https://github.com/angular/angular/commit/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
| https://pr19904-0ebba85.ngbuilds.io/ | https://pr19904-0ebba85.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403024774 |
| @mhevery | https://github.com/mhevery |
| @rkirov | https://github.com/rkirov |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403091655 |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403091674 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| http://test/OCL:203500801:BASE:203501165:1530900687238:5ce75398 | http://test/OCL:203500801:BASE:203501165:1530900687238:5ce75398 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/alfaproject |
| alfaproject | https://github.com/alfaproject |
|
Jul 6, 2018
| https://github.com/angular/angular/pull/19904#pullrequestreview-135094086 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
| packages/benchpress/test/webdriver/chrome_driver_extension_spec.ts | https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22#diff-9ba8714539bbcbd69b676ba9114da2641eddbfef839126a6527cf6f352579263 |
| alfaproject | https://github.com/alfaproject |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200718479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| mhevery | https://github.com/mhevery |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200736111 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200746795 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200747240 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| mhevery | https://github.com/mhevery |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200764721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/alfaproject |
| alfaproject | https://github.com/alfaproject |
|
Jul 6, 2018
| https://github.com/angular/angular/pull/19904#pullrequestreview-135094167 |
|
View reviewed changes
| https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
| packages/common/http/test/client_spec.ts | https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22#diff-9bd3e0ec36dc94530c743ce6e81ad7d168043e55d4838c5a1d0a2890734ad587 |
| alfaproject | https://github.com/alfaproject |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200718567 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| mhevery | https://github.com/mhevery |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200736126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| gkalpak | https://github.com/gkalpak |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#discussion_r200747008 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403113635 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403113793 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403116430 |
| https://pr19904-edb5217.ngbuilds.io/ | https://pr19904-edb5217.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Jul 6, 2018 | https://github.com/angular/angular/pull/19904#issuecomment-403141823 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jul 10, 2018
| https://github.com/angular/angular/pull/19904#ref-pullrequest-339746505 |
|
Revert #24803 on branch 6.0.x
#24809
| https://github.com/angular/angular/pull/24809 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Sep 19, 2018
| https://github.com/angular/angular/pull/19904#ref-pullrequest-361018821 |
|
[jasminewd2] Add DoneFn to supporting functions
DefinitelyTyped/DefinitelyTyped#28957
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28957 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/19904#issuecomment-531369057 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F19904 |
|
| https://github.com/alfaproject |
|
alfaproject
| https://github.com/alfaproject |
|
| https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/19904/files/0ebba850f8638f8c14cde9bd64c90938bb171f22 |
|
| https://github.com/chuckjaz |
|
chuckjaz
| https://github.com/chuckjaz |
|
| https://github.com/angular/angular/pull/19904/files/5a789666110469fb31c6935b526ba62b88468921 |
|
| https://github.com/alexeagle |
|
alexeagle
| https://github.com/alexeagle |
|
| https://github.com/angular/angular/pull/19904/files/15f1b21cdf33c245bba06d3a685f7900434a5e8f |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/19904/files/15f1b21cdf33c245bba06d3a685f7900434a5e8f |
|
| https://github.com/ocombe |
|
ocombe
| https://github.com/ocombe |
|
| https://github.com/angular/angular/pull/19904/files/cd7457a1962c26d0ce5256625340e74fdc546936 |
|
| https://github.com/jasonaden |
|
jasonaden
| https://github.com/jasonaden |
|
| https://github.com/angular/angular/pull/19904/files/15f1b21cdf33c245bba06d3a685f7900434a5e8f |
|
| https://github.com/hansl |
|
hansl
| https://github.com/hansl |
|
| https://github.com/angular/angular/pull/19904/files/15f1b21cdf33c245bba06d3a685f7900434a5e8f |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Please reload this page | https://github.com/angular/angular/pull/19904 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/IgorMinar |
|
| https://github.com/jasonaden |
|
| https://github.com/alexeagle |
|
| https://github.com/alfaproject |
|
| https://github.com/mhevery |
|
| https://github.com/googlebot |
|
| https://github.com/ocombe |
|
| https://github.com/chuckjaz |
|
| https://github.com/hansl |
|
| https://github.com/alxhub |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |