René's URL Explorer Experiment


Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular · GitHub

Open Graph Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular

X Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular

Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group separator. I added more tests to avoid further problems of the same kind. Does this PR introduce a breaking change? [x] No

Open Graph Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...

X Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...

Opengraph URL: https://github.com/angular/angular/pull/18932

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4899769e-06c6-5513-4abd-1ad4df6046a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA19A:3DD488:1D12DBC:24E25FE:6B015E96
html-safe-noncebe46c70416c9615b5542b5f1a0b3a0e46f78a66c91fc886f7176679e5df39636
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTlBOjNERDQ4ODoxRDEyREJDOjI0RTI1RkU6NkIwMTVFOTYiLCJ2aXNpdG9yX2lkIjoiMjEwODgxOTgzODgwMDU4NDM0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac219963450a8d446471beed61e99ca4686ebf0e0a23a20284ddfcad2d032efa45
hovercard-subject-tagpull_request:138215744
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/18932/files
twitter:imagehttps://avatars.githubusercontent.com/u/265378?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/265378?s=400&v=4
og:image:altPR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/18932/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18932%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18932%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18932/files
Reloadhttps://github.com/angular/angular/pull/18932/files
Reloadhttps://github.com/angular/angular/pull/18932/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-currency-pipehttps://github.com/ocombe/angular/tree/fix-currency-pipe
Conversation 6 https://github.com/angular/angular/pull/18932
Commits 1 https://github.com/angular/angular/pull/18932/commits
Checks 0 https://github.com/angular/angular/pull/18932/checks
Files changed https://github.com/angular/angular/pull/18932/files
Please reload this pagehttps://github.com/angular/angular/pull/18932/files
fix(common): use correct group separator for currency pipe https://github.com/angular/angular/pull/18932/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/18932/files
fca719d fix(common): use correct group separator for currency pipe ocombe Aug 29, 2017 https://github.com/angular/angular/pull/18932/commits/fca719d43e73934035d6071447c8b22227819c0b
Clear filters https://github.com/angular/angular/pull/18932/files
Please reload this pagehttps://github.com/angular/angular/pull/18932/files
Please reload this pagehttps://github.com/angular/angular/pull/18932/files
locale_data_api.ts https://github.com/angular/angular/pull/18932/files#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
number_pipe_spec.ts https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
packages/common/src/i18n/locale_data_api.tshttps://github.com/angular/angular/pull/18932/files#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
View file https://github.com/ocombe/angular/blob/fca719d43e73934035d6071447c8b22227819c0b/packages/common/src/i18n/locale_data_api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18932/files#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
https://github.com/angular/angular/pull/18932/files#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
packages/common/test/pipes/number_pipe_spec.tshttps://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
View file https://github.com/ocombe/angular/blob/fca719d43e73934035d6071447c8b22227819c0b/packages/common/test/pipes/number_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18932/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com/angular/angular/pull/18932/files#diff-5481f0f152b34e89498ed52b08f54353e8e3df12fb8188f42f81d80b22c1f6c2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.