René's URL Explorer Experiment


Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular · GitHub

Open Graph Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular

X Title: fix(common): use correct group separator for currency pipe by ocombe · Pull Request #18932 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...

X Description: PR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...

Opengraph URL: https://github.com/angular/angular/pull/18932

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b8e6ad63-a322-d064-a315-879a6be2a545
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98A6:2E124E:1B95681:232F865:6B015B28
html-safe-nonceffb19d2007cf00b994fbf0d720b75e6cd2b11c68504f325e5b8b04abf2e6e689
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEE2OjJFMTI0RToxQjk1NjgxOjIzMkY4NjU6NkIwMTVCMjgiLCJ2aXNpdG9yX2lkIjoiNzA1NTg0OTQ3NzcwMTE5NjU4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9411d9036e588ad5c958e259d2e68a632cad6ed6ab8eb7ee075d18619b9427b0
hovercard-subject-tagpull_request:138215744
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18932/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/91051061fbfaff19c8cf72e1510a72364409862aa5871561268fc93399a21418/angular/angular/pull/18932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/91051061fbfaff19c8cf72e1510a72364409862aa5871561268fc93399a21418/angular/angular/pull/18932
og:image:altPR Type What kind of change does this PR introduce? [x] Bugfix What is the current behavior? The currency pipe used the wrong group separator What is the new behavior? It uses the correct group se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameocombe
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18932#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18932
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18932
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18932
Reloadhttps://github.com/angular/angular/pull/18932
Reloadhttps://github.com/angular/angular/pull/18932
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-currency-pipehttps://github.com/ocombe/angular/tree/fix-currency-pipe
Conversationhttps://github.com/angular/angular/pull/18932
Commits1 (1)https://github.com/angular/angular/pull/18932/commits
Checkshttps://github.com/angular/angular/pull/18932/checks
Files changedhttps://github.com/angular/angular/pull/18932/files
fix(common): use correct group separator for currency pipehttps://github.com/angular/angular/pull/18932#top
ocombehttps://github.com/ocombe
angular:masterhttps://github.com/angular/angular/tree/master
ocombe:fix-currency-pipehttps://github.com/ocombe/angular/tree/fix-currency-pipe
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 29, 2017https://github.com/angular/angular/pull/18932#issue-253710069
Please reload this pagehttps://github.com/angular/angular/pull/18932
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/ocombe
ocombehttps://github.com/ocombe
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225922846
https://github.com/ocombe
ocombehttps://github.com/ocombe
vicbhttps://github.com/vicb
August 29, 2017 15:36https://github.com/angular/angular/pull/18932#event-1225922854
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225923263
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/0879a3b87e7a34c98ef378ea50e35657d9148fa4..8ab7b033081f5f579c1465b5ae13aa5de10e7355
0879a3bhttps://github.com/angular/angular/commit/0879a3b87e7a34c98ef378ea50e35657d9148fa4
8ab7b03https://github.com/angular/angular/commit/8ab7b033081f5f579c1465b5ae13aa5de10e7355
Compare https://github.com/angular/angular/compare/0879a3b87e7a34c98ef378ea50e35657d9148fa4..8ab7b033081f5f579c1465b5ae13aa5de10e7355
August 29, 2017 15:39https://github.com/angular/angular/pull/18932#event-1225927596
https://github.com/ocombe
ocombehttps://github.com/ocombe
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225928318
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/8ab7b033081f5f579c1465b5ae13aa5de10e7355..4b6143a4bc56f098f287371c1892bba2cec584e8
8ab7b03https://github.com/angular/angular/commit/8ab7b033081f5f579c1465b5ae13aa5de10e7355
4b6143ahttps://github.com/angular/angular/commit/4b6143a4bc56f098f287371c1892bba2cec584e8
Compare https://github.com/angular/angular/compare/8ab7b033081f5f579c1465b5ae13aa5de10e7355..4b6143a4bc56f098f287371c1892bba2cec584e8
August 29, 2017 15:50https://github.com/angular/angular/pull/18932#event-1225949205
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225949380
https://github.com/angular
angularhttps://github.com/angular
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225950484
https://github.com/angular
angularhttps://github.com/angular
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225950537
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1225951717
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#issuecomment-325710581
https://pr18932-4b6143a.ngbuilds.io/https://pr18932-4b6143a.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 29, 2017 https://github.com/angular/angular/pull/18932#pullrequestreview-59302419
View reviewed changes https://github.com/angular/angular/pull/18932/files
https://github.com/ocombe
fix(common): use correct group separator for currency pipehttps://github.com/angular/angular/pull/18932/commits/fca719d43e73934035d6071447c8b22227819c0b
fca719dhttps://github.com/angular/angular/pull/18932/commits/fca719d43e73934035d6071447c8b22227819c0b
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/4b6143a4bc56f098f287371c1892bba2cec584e8..9a865f912dfcaff214b57a236653bceacdf01c9b
4b6143ahttps://github.com/angular/angular/commit/4b6143a4bc56f098f287371c1892bba2cec584e8
9a865f9https://github.com/angular/angular/commit/9a865f912dfcaff214b57a236653bceacdf01c9b
Compare https://github.com/angular/angular/compare/4b6143a4bc56f098f287371c1892bba2cec584e8..9a865f912dfcaff214b57a236653bceacdf01c9b
August 29, 2017 16:54https://github.com/angular/angular/pull/18932#event-1226065771
https://github.com/googlebot
googlebothttps://github.com/googlebot
Aug 29, 2017https://github.com/angular/angular/pull/18932#issuecomment-325726662
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1226065921
https://github.com/angular
angularhttps://github.com/angular
googlebothttps://github.com/googlebot
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1226066361
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#issuecomment-325732044
https://pr18932-9a865f9.ngbuilds.io/https://pr18932-9a865f9.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/vicb
vicbhttps://github.com/vicb
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1226116260
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/9a865f912dfcaff214b57a236653bceacdf01c9b..4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd
9a865f9https://github.com/angular/angular/commit/9a865f912dfcaff214b57a236653bceacdf01c9b
4cd1696https://github.com/angular/angular/commit/4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd
Compare https://github.com/angular/angular/compare/9a865f912dfcaff214b57a236653bceacdf01c9b..4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd
August 29, 2017 17:56https://github.com/angular/angular/pull/18932#event-1226173985
https://github.com/ocombe
ocombehttps://github.com/ocombe
juleskremerhttps://github.com/juleskremer
August 29, 2017 18:03https://github.com/angular/angular/pull/18932#event-1226184873
https://github.com/ocombe
ocombehttps://github.com/ocombe
force-pushedhttps://github.com/angular/angular/compare/4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd..fca719d43e73934035d6071447c8b22227819c0b
4cd1696https://github.com/angular/angular/commit/4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd
fca719dhttps://github.com/angular/angular/commit/fca719d43e73934035d6071447c8b22227819c0b
Compare https://github.com/angular/angular/compare/4cd169656eeb7459d3fe5a7dc5a4d4cd26cd1ebd..fca719d43e73934035d6071447c8b22227819c0b
August 29, 2017 18:09https://github.com/angular/angular/pull/18932#event-1226195966
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#issuecomment-325747810
https://pr18932-4cd1696.ngbuilds.io/https://pr18932-4cd1696.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/vicb
vicbhttps://github.com/vicb
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Aug 29, 2017https://github.com/angular/angular/pull/18932#event-1226197946
https://github.com/ocombe
ocombehttps://github.com/ocombe
juleskremerhttps://github.com/juleskremer
August 29, 2017 18:13https://github.com/angular/angular/pull/18932#event-1226201679
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 29, 2017https://github.com/angular/angular/pull/18932#issuecomment-325751554
fca719dhttps://github.com/angular/angular/commit/fca719d43e73934035d6071447c8b22227819c0b
https://pr18932-fca719d.ngbuilds.io/https://pr18932-fca719d.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
4ec5e28https://github.com/angular/angular/commit/4ec5e282d9dc842ba430077f0f8e32cebbf7fcbc
Aug 30, 2017https://github.com/angular/angular/pull/18932#event-1226776495
https://github.com/ocombe
ocombehttps://github.com/ocombe
August 30, 2017 09:20https://github.com/angular/angular/pull/18932#event-1227223384
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18932#issuecomment-530720438
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18932#event-2628279593
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18932
https://github.com/vicb
vicb https://github.com/vicb
https://github.com/angular/angular/pull/18932/files/4b6143a4bc56f098f287371c1892bba2cec584e8
Please reload this pagehttps://github.com/angular/angular/pull/18932
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Please reload this pagehttps://github.com/angular/angular/pull/18932
https://github.com/ocombe
https://github.com/mary-poppins
https://github.com/googlebot
https://github.com/vicb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.