René's URL Explorer Experiment


Title: refactor(common): refactor i18n code to ease tree shaking by vicb · Pull Request #18857 · angular/angular · GitHub

Open Graph Title: refactor(common): refactor i18n code to ease tree shaking by vicb · Pull Request #18857 · angular/angular

X Title: refactor(common): refactor i18n code to ease tree shaking by vicb · Pull Request #18857 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The former structure was causing a circular dependency error in g3. This PR re-organize the code and "fixes" minor issues to remove this CD. Please review the first commit only. (You can ...

X Description: The former structure was causing a circular dependency error in g3. This PR re-organize the code and "fixes" minor issues to remove this CD. Please review the first commit only. (...

Opengraph URL: https://github.com/angular/angular/pull/18857

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b2c508d-78d3-2baf-0e4f-b5ecb55e8640
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA838:2F8EE0:3EF3E:52FE6:6B0156BB
html-safe-nonce1827c26ed85256763e936a47cfd5f440c635e60962e2a5cd7e63cd9cb9b0a91c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODM4OjJGOEVFMDozRUYzRTo1MkZFNjo2QjAxNTZCQiIsInZpc2l0b3JfaWQiOiIxNjgwNDg4MDU4OTUwMDgwMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc849e2489850966354f2a16393cb7d4d1a40c9714702b19679a330337ccce502
hovercard-subject-tagpull_request:137345445
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18857/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1c642103c5ea19e5fd162db352fdfcbc2487fd849d45454c03e55d7f28c84580/angular/angular/pull/18857
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1c642103c5ea19e5fd162db352fdfcbc2487fd849d45454c03e55d7f28c84580/angular/angular/pull/18857
og:image:altThe former structure was causing a circular dependency error in g3. This PR re-organize the code and "fixes" minor issues to remove this CD. Please review the first commit only. (You can ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevicb
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18857#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18857
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18857
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18857
Reloadhttps://github.com/angular/angular/pull/18857
Reloadhttps://github.com/angular/angular/pull/18857
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
vicb:0823-intlhttps://github.com/vicb/angular/tree/0823-intl
Conversationhttps://github.com/angular/angular/pull/18857
Commits2 (2)https://github.com/angular/angular/pull/18857/commits
Checkshttps://github.com/angular/angular/pull/18857/checks
Files changedhttps://github.com/angular/angular/pull/18857/files
refactor(common): refactor i18n code to ease tree shakinghttps://github.com/angular/angular/pull/18857#top
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
vicb:0823-intlhttps://github.com/vicb/angular/tree/0823-intl
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 24, 2017https://github.com/angular/angular/pull/18857#issue-252452763
Please reload this pagehttps://github.com/angular/angular/pull/18857
Please reload this pagehttps://github.com/angular/angular/pull/18857
vicbhttps://github.com/vicb
August 23, 2017 17:20https://github.com/angular/angular/pull/18857#commits-pushed-d691bb3
https://github.com/vicb
refactor(common): refactor i18n code to ease tree shakinghttps://github.com/angular/angular/pull/18857/commits/d691bb3bd4c4c7d20073f5f98e4236adf97d8472
d691bb3https://github.com/angular/angular/pull/18857/commits/d691bb3bd4c4c7d20073f5f98e4236adf97d8472
https://github.com/vicb
refactor(common): update generated i18n datahttps://github.com/angular/angular/pull/18857/commits/e9e8bfaebf32c82e336c422007b5ca769089bc42
e9e8bfahttps://github.com/angular/angular/pull/18857/commits/e9e8bfaebf32c82e336c422007b5ca769089bc42
https://github.com/vicb
vicbhttps://github.com/vicb
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
Aug 24, 2017https://github.com/angular/angular/pull/18857#event-1218864452
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 24, 2017https://github.com/angular/angular/pull/18857#event-1218864484
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 24, 2017 https://github.com/angular/angular/pull/18857#pullrequestreview-58251637
View reviewed changes https://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472
packages/common/src/i18n/locale_data.tshttps://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472#diff-76e6a88b0a64daaf3795764d820033fd8fe2c957278e8c2bea77f1c0351ca455
vicbhttps://github.com/vicb
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r134903447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ocombehttps://github.com/ocombe
Please reload this pagehttps://github.com/angular/angular/pull/18857
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r134947875
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Aug 24, 2017https://github.com/angular/angular/pull/18857#issuecomment-324499523
e9e8bfahttps://github.com/angular/angular/commit/e9e8bfaebf32c82e336c422007b5ca769089bc42
https://pr18857-e9e8bfa.ngbuilds.io/https://pr18857-e9e8bfa.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 24, 2017 https://github.com/angular/angular/pull/18857#pullrequestreview-58299758
View reviewed changes https://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472
packages/common/src/i18n/locale_data.tshttps://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472#diff-76e6a88b0a64daaf3795764d820033fd8fe2c957278e8c2bea77f1c0351ca455
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r134947875
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
packages/common/src/i18n/locale_data_api.tshttps://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r134948440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@StephenFluinhttps://github.com/StephenFluin
Please reload this pagehttps://github.com/angular/angular/pull/18857
vicbhttps://github.com/vicb
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r135060544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@StephenFluinhttps://github.com/StephenFluin
Please reload this pagehttps://github.com/angular/angular/pull/18857
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r135084681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
packages/common/src/i18n/locale_data_api.tshttps://github.com/angular/angular/pull/18857/files/d691bb3bd4c4c7d20073f5f98e4236adf97d8472#diff-6ae44b665474df44ef4527f678979454c7d0bbadb9e51cef25c6557e30b83113
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r134949088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
vicbhttps://github.com/vicb
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r135059890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
ocombehttps://github.com/ocombe
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r135060637
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
vicbhttps://github.com/vicb
Aug 24, 2017https://github.com/angular/angular/pull/18857#discussion_r135081248
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 24, 2017 https://github.com/angular/angular/pull/18857#ref-pullrequest-251724188
feat(common): generate i18n data file locale_all file for closure #18813 https://github.com/angular/angular/pull/18813
https://github.com/vicb
vicbhttps://github.com/vicb
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Aug 24, 2017https://github.com/angular/angular/pull/18857#event-1220030808
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Aug 28, 2017 https://github.com/angular/angular/pull/18857#pullrequestreview-59009185
View reviewed changes https://github.com/angular/angular/pull/18857/files/e9e8bfaebf32c82e336c422007b5ca769089bc42
https://github.com/ocombe
ocombehttps://github.com/ocombe
Aug 28, 2017 https://github.com/angular/angular/pull/18857#pullrequestreview-59013907
View reviewed changes https://github.com/angular/angular/pull/18857/files/e9e8bfaebf32c82e336c422007b5ca769089bc42
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 28, 2017https://github.com/angular/angular/pull/18857#issuecomment-325430820
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 28, 2017 https://github.com/angular/angular/pull/18857#ref-pullrequest-253412201
i18n code refactoring (intl removal) #18907 https://github.com/angular/angular/pull/18907
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 28, 2017https://github.com/angular/angular/pull/18857#issuecomment-325435214
#18907https://github.com/angular/angular/pull/18907
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/vicb
vicbhttps://github.com/vicb
Aug 28, 2017https://github.com/angular/angular/pull/18857#event-1224236343
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18857#issuecomment-530720232
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular/pull/18857#event-2628278017
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18857
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/18857/files/e9e8bfaebf32c82e336c422007b5ca769089bc42
https://github.com/ocombe
ocombe https://github.com/ocombe
https://github.com/angular/angular/pull/18857/files/e9e8bfaebf32c82e336c422007b5ca769089bc42
Please reload this pagehttps://github.com/angular/angular/pull/18857
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Please reload this pagehttps://github.com/angular/angular/pull/18857
https://github.com/vicb
https://github.com/mary-poppins
https://github.com/IgorMinar
https://github.com/ocombe
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.