René's URL Explorer Experiment


Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular · GitHub

Open Graph Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular

X Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular

Description: Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [X] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] angular.io application / infrastructure changes [ ] Other... Please describe: What is the current behavior? myGroup.setControl('ctrl', new FormControl({ value: 'Control is disabled', disabled: true })); // Input dom element has disabled attribute. Correct. myGroup.setControl('ctrl', new FormControl({ value: 'Control should be enabled', disabled: false })); // Input dom element still has disabled attribute. WRONG! Should not have. Full issue with plunker demo: #17806 What is the new behavior? myGroup.setControl('ctrl', new FormControl({ value: 'Control is disabled', disabled: true })); // Input dom element has disabled attribute. Correct. myGroup.setControl('ctrl', new FormControl({ value: 'Control should be enabled', disabled: false })); // Input dom element does not have disabled attribute anymore. Correct. Does this PR introduce a breaking change? [ ] Yes [X] No

Open Graph Description: Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...

X Description: Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...

Opengraph URL: https://github.com/angular/angular/pull/18575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b507d4dd-06ac-4b2a-5545-2a96c94d9232
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE97E:AC6A2:1A0249:223910:6B0164A7
html-safe-noncea64157ecf47050f97a96aadc00e5e261954ed3c90b19d68429f0ddeffe45c7f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTdFOkFDNkEyOjFBMDI0OToyMjM5MTA6NkIwMTY0QTciLCJ2aXNpdG9yX2lkIjoiNzE4Nzg5NjA4MjU1MzIwMTgzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e7302b74703f70b86a8e48db51e4517920fb0a21138c9a5cde8a39d8d50f6a9
hovercard-subject-tagpull_request:134534964
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/18575/files
twitter:imagehttps://avatars.githubusercontent.com/u/5166666?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5166666?s=400&v=4
og:image:altUpdate the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/18575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18575/files
Reloadhttps://github.com/angular/angular/pull/18575/files
Reloadhttps://github.com/angular/angular/pull/18575/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dzonatanhttps://github.com/dzonatan
angular:masterhttps://github.com/angular/angular/tree/master
dzonatan:fix-form-control-disabled-instantiationhttps://github.com/dzonatan/angular/tree/fix-form-control-disabled-instantiation
Conversation 18 https://github.com/angular/angular/pull/18575
Commits 1 https://github.com/angular/angular/pull/18575/commits
Checks 0 https://github.com/angular/angular/pull/18575/checks
Files changed https://github.com/angular/angular/pull/18575/files
Please reload this pagehttps://github.com/angular/angular/pull/18575/files
fix(forms): fix disabled attribute handling https://github.com/angular/angular/pull/18575/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/18575/files
bfadd8b fix(forms): fix disabled attribute handling dzonatan Aug 7, 2017 https://github.com/angular/angular/pull/18575/commits/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
Clear filters https://github.com/angular/angular/pull/18575/files
Please reload this pagehttps://github.com/angular/angular/pull/18575/files
Please reload this pagehttps://github.com/angular/angular/pull/18575/files
form_control_directive.ts https://github.com/angular/angular/pull/18575/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
shared.ts https://github.com/angular/angular/pull/18575/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
reactive_integration_spec.ts https://github.com/angular/angular/pull/18575/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
packages/forms/src/directives/reactive_directives/form_control_directive.tshttps://github.com/angular/angular/pull/18575/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
View file https://github.com/dzonatan/angular/blob/bfadd8b51bac7f18cbf902660de9d49f365bd4b2/packages/forms/src/directives/reactive_directives/form_control_directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18575/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
https://github.com/angular/angular/pull/18575/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
packages/forms/src/directives/shared.tshttps://github.com/angular/angular/pull/18575/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
View file https://github.com/dzonatan/angular/blob/bfadd8b51bac7f18cbf902660de9d49f365bd4b2/packages/forms/src/directives/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18575/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
https://github.com/angular/angular/pull/18575/files#diff-3789e3828d9614afa6689aca734fb4fb120cff7c91e401a79947791da4624375
packages/forms/test/reactive_integration_spec.tshttps://github.com/angular/angular/pull/18575/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
View file https://github.com/dzonatan/angular/blob/bfadd8b51bac7f18cbf902660de9d49f365bd4b2/packages/forms/test/reactive_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18575/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18575/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com/angular/angular/pull/18575/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.