| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0b6ad9b7-61ba-3a2f-99ac-4bc659774331 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB90:19F84C:1D1F2FA:2516EF4:6B0147EB |
| html-safe-nonce | bb1d785167784293d86c858c4ef0f5d21798292b732625e2be19a7460e68c8ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjkwOjE5Rjg0QzoxRDFGMkZBOjI1MTZFRjQ6NkIwMTQ3RUIiLCJ2aXNpdG9yX2lkIjoiNDIwNzA4NzIxNTAxNDg5MTMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8271869bd939e4c591975fcc79a90f0263321f96efb85c4a81772019266f938e |
| hovercard-subject-tag | pull_request:134534964 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18575/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8880732b4456cbbd51534711e67d43e0eebf0cd876e24c926806364782baf01f/angular/angular/pull/18575 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8880732b4456cbbd51534711e67d43e0eebf0cd876e24c926806364782baf01f/angular/angular/pull/18575 |
| og:image:alt | Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl().
Fixes #17806
PR Checklist
Please check if your PR fulfills the following re... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dzonatan |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/18575#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/18575 |
| Reload | https://github.com/angular/angular/pull/18575 |
| Reload | https://github.com/angular/angular/pull/18575 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| dzonatan | https://github.com/dzonatan |
| angular:master | https://github.com/angular/angular/tree/master |
| dzonatan:fix-form-control-disabled-instantiation | https://github.com/dzonatan/angular/tree/fix-form-control-disabled-instantiation |
| Conversation | https://github.com/angular/angular/pull/18575 |
| Commits1 (1) | https://github.com/angular/angular/pull/18575/commits |
| Checks | https://github.com/angular/angular/pull/18575/checks |
| Files changed | https://github.com/angular/angular/pull/18575/files |
| fix(forms): fix disabled attribute handling | https://github.com/angular/angular/pull/18575#top |
| dzonatan | https://github.com/dzonatan |
| angular:master | https://github.com/angular/angular/tree/master |
| dzonatan:fix-form-control-disabled-instantiation | https://github.com/dzonatan/angular/tree/fix-form-control-disabled-instantiation |
|
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Aug 7, 2017 | https://github.com/angular/angular/pull/18575#issue-248542299 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| #17806 | https://github.com/angular/angular/issues/17806 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #17806 | https://github.com/angular/angular/issues/17806 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Aug 7, 2017 | https://github.com/angular/angular/pull/18575#event-1196206015 |
|
| https://github.com/dzonatan |
| fix(forms): fix disabled attribute handling | https://github.com/angular/angular/pull/18575/commits/bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| bfadd8b | https://github.com/angular/angular/pull/18575/commits/bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| angular#17806 | https://github.com/angular/angular/issues/17806 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| force-pushed | https://github.com/angular/angular/compare/59f6d7fb62f30f98d45dfb76e68bd5e58f705528..bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| 59f6d7f | https://github.com/angular/angular/commit/59f6d7fb62f30f98d45dfb76e68bd5e58f705528 |
| bfadd8b | https://github.com/angular/angular/commit/bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
|
Compare
| https://github.com/angular/angular/compare/59f6d7fb62f30f98d45dfb76e68bd5e58f705528..bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| August 7, 2017 22:04 | https://github.com/angular/angular/pull/18575#event-1196219120 |
| https://github.com/vicb |
| vicb | https://github.com/vicb |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: forms
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22 |
| Aug 8, 2017 | https://github.com/angular/angular/pull/18575#event-1197709423 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
|
Aug 16, 2017
| https://github.com/angular/angular/pull/18575#ref-issue-246080572 |
|
Updating disabled state after replacing FormGroup.
#18381
| https://github.com/angular/angular/issues/18381 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Aug 25, 2017 | https://github.com/angular/angular/pull/18575#issuecomment-324839207 |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Oct 2, 2017 | https://github.com/angular/angular/pull/18575#issuecomment-333475733 |
| https://camo.githubusercontent.com/985931559b5dc130e756dd4173bb1de1ee5b367f69c9489e1d86956ab46746fb/68747470733a2f2f692e696d6775722e636f6d2f746874387651372e706e67 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
|
Nov 23, 2017
| https://github.com/angular/angular/pull/18575#ref-issue-269445759 |
|
Enable a reactive form using the FormControlDirective
#20008
| https://github.com/angular/angular/issues/20008 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
Dec 20, 2017
| https://github.com/angular/angular/pull/18575#pullrequestreview-84629819 |
|
View reviewed changes
| https://github.com/angular/angular/pull/18575/files/bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| kara | https://github.com/kara |
| https://github.com/angular/angular/pull/18575#pullrequestreview-84629819 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#event-1395206141 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#event-1396612845 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| kara | https://github.com/kara |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#event-1396612931 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#event-1396613044 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#issuecomment-353139519 |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Dec 20, 2017 | https://github.com/angular/angular/pull/18575#issuecomment-353143796 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/trotyl |
| trotyl | https://github.com/trotyl |
| Dec 21, 2017 | https://github.com/angular/angular/pull/18575#issuecomment-353242314 |
| @dzonatan | https://github.com/dzonatan |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/rvirji-va |
| rvirji-va | https://github.com/rvirji-va |
| Feb 2, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-362676781 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| @dzonatan | https://github.com/dzonatan |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/rvirji-va |
| rvirji-va | https://github.com/rvirji-va |
| Feb 7, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-363878304 |
| @alxhub | https://github.com/alxhub |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/LisaTatum |
| LisaTatum | https://github.com/LisaTatum |
| Mar 8, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-371628148 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/LisaTatum |
| LisaTatum | https://github.com/LisaTatum |
| Mar 18, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-374051490 |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Apr 20, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-383023142 |
| @alxhub | https://github.com/alxhub |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/banjankri |
| banjankri | https://github.com/banjankri |
| May 30, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-393081948 |
| @alxhub | https://github.com/alxhub |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
|
Jun 4, 2018
| https://github.com/angular/angular/pull/18575#ref-issue-297513042 |
|
Maximum call stack size exceeded
angular/angular-cli#9636
| https://github.com/angular/angular-cli/issues/9636 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Aug 8, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-411308173 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/banjankri |
| banjankri | https://github.com/banjankri |
| Sep 10, 2018 | https://github.com/angular/angular/pull/18575#issuecomment-419792301 |
| @alxhub | https://github.com/alxhub |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
| Sep 18, 2018 | https://github.com/angular/angular/pull/18575#event-1853677418 |
| https://github.com/jasonaden |
| jasonaden | https://github.com/jasonaden |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 29, 2019 | https://github.com/angular/angular/pull/18575#event-2105012968 |
| https://github.com/kara |
| kara | https://github.com/kara |
| Sep 9, 2019 | https://github.com/angular/angular/pull/18575#event-2619517144 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Sep 13, 2019 | https://github.com/angular/angular/pull/18575#issuecomment-531111113 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
|
Dec 4, 2019
| https://github.com/angular/angular/pull/18575#ref-issue-273808292 |
|
When replacing form control which has async validator the status from statusChange stays PENDING
#20424
| https://github.com/angular/angular/issues/20424 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 9, 2020
| https://github.com/angular/angular/pull/18575#ref-pullrequest-562805830 |
|
fix(forms): Call setDisabledState in in reactive directives when appropriate
#35311
| https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Nov 17, 2020 | https://github.com/angular/angular/pull/18575#issuecomment-729214626 |
| #35311 | https://github.com/angular/angular/pull/35311 |
| #35311 | https://github.com/angular/angular/pull/35311 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Nov 17, 2020 | https://github.com/angular/angular/pull/18575#event-4007546898 |
| https://github.com/dzonatan |
| dzonatan | https://github.com/dzonatan |
| Nov 17, 2020 | https://github.com/angular/angular/pull/18575#issuecomment-729219638 |
| https://user-images.githubusercontent.com/5166666/99451583-135b1180-292b-11eb-92b2-8a62ae13e6c9.png |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Dec 19, 2020 | https://github.com/angular/angular/pull/18575#issuecomment-748496154 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Dec 19, 2020 | https://github.com/angular/angular/pull/18575#event-4132598704 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575 |
|
| https://github.com/kara |
|
kara
| https://github.com/kara |
|
| https://github.com/angular/angular/pull/18575/files/bfadd8b51bac7f18cbf902660de9d49f365bd4b2 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
area: forms
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
FormControl does not reflect the new disabled value
| https://github.com/angular/angular/issues/17806 |
| Please reload this page | https://github.com/angular/angular/pull/18575 |
|
| https://github.com/dzonatan |
|
| https://github.com/alxhub |
|
| https://github.com/trotyl |
|
| https://github.com/rvirji-va |
|
| https://github.com/LisaTatum |
|
| https://github.com/banjankri |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/kara |
|
| https://github.com/vicb |
|
| https://github.com/jasonaden |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |