René's URL Explorer Experiment


Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular · GitHub

Open Graph Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular

X Title: fix(forms): fix disabled attribute handling by dzonatan · Pull Request #18575 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...

X Description: Update the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...

Opengraph URL: https://github.com/angular/angular/pull/18575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b6ad9b7-61ba-3a2f-99ac-4bc659774331
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB90:19F84C:1D1F2FA:2516EF4:6B0147EB
html-safe-noncebb1d785167784293d86c858c4ef0f5d21798292b732625e2be19a7460e68c8ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjkwOjE5Rjg0QzoxRDFGMkZBOjI1MTZFRjQ6NkIwMTQ3RUIiLCJ2aXNpdG9yX2lkIjoiNDIwNzA4NzIxNTAxNDg5MTMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8271869bd939e4c591975fcc79a90f0263321f96efb85c4a81772019266f938e
hovercard-subject-tagpull_request:134534964
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/18575/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8880732b4456cbbd51534711e67d43e0eebf0cd876e24c926806364782baf01f/angular/angular/pull/18575
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8880732b4456cbbd51534711e67d43e0eebf0cd876e24c926806364782baf01f/angular/angular/pull/18575
og:image:altUpdate the disabled attribute of DOM element when setting a new FormControl instance either directly or via setControl(). Fixes #17806 PR Checklist Please check if your PR fulfills the following re...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedzonatan
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/18575#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18575
Reloadhttps://github.com/angular/angular/pull/18575
Reloadhttps://github.com/angular/angular/pull/18575
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
dzonatanhttps://github.com/dzonatan
angular:masterhttps://github.com/angular/angular/tree/master
dzonatan:fix-form-control-disabled-instantiationhttps://github.com/dzonatan/angular/tree/fix-form-control-disabled-instantiation
Conversationhttps://github.com/angular/angular/pull/18575
Commits1 (1)https://github.com/angular/angular/pull/18575/commits
Checkshttps://github.com/angular/angular/pull/18575/checks
Files changedhttps://github.com/angular/angular/pull/18575/files
fix(forms): fix disabled attribute handlinghttps://github.com/angular/angular/pull/18575#top
dzonatanhttps://github.com/dzonatan
angular:masterhttps://github.com/angular/angular/tree/master
dzonatan:fix-form-control-disabled-instantiationhttps://github.com/dzonatan/angular/tree/fix-form-control-disabled-instantiation
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Aug 7, 2017https://github.com/angular/angular/pull/18575#issue-248542299
Please reload this pagehttps://github.com/angular/angular/pull/18575
#17806https://github.com/angular/angular/issues/17806
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#17806https://github.com/angular/angular/issues/17806
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 7, 2017https://github.com/angular/angular/pull/18575#event-1196206015
https://github.com/dzonatan
fix(forms): fix disabled attribute handlinghttps://github.com/angular/angular/pull/18575/commits/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
bfadd8bhttps://github.com/angular/angular/pull/18575/commits/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
angular#17806https://github.com/angular/angular/issues/17806
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
force-pushedhttps://github.com/angular/angular/compare/59f6d7fb62f30f98d45dfb76e68bd5e58f705528..bfadd8b51bac7f18cbf902660de9d49f365bd4b2
59f6d7fhttps://github.com/angular/angular/commit/59f6d7fb62f30f98d45dfb76e68bd5e58f705528
bfadd8bhttps://github.com/angular/angular/commit/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
Compare https://github.com/angular/angular/compare/59f6d7fb62f30f98d45dfb76e68bd5e58f705528..bfadd8b51bac7f18cbf902660de9d49f365bd4b2
August 7, 2017 22:04https://github.com/angular/angular/pull/18575#event-1196219120
https://github.com/vicb
vicbhttps://github.com/vicb
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: forms https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
Aug 8, 2017https://github.com/angular/angular/pull/18575#event-1197709423
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Aug 16, 2017 https://github.com/angular/angular/pull/18575#ref-issue-246080572
Updating disabled state after replacing FormGroup. #18381 https://github.com/angular/angular/issues/18381
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Aug 25, 2017https://github.com/angular/angular/pull/18575#issuecomment-324839207
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Oct 2, 2017https://github.com/angular/angular/pull/18575#issuecomment-333475733
https://camo.githubusercontent.com/985931559b5dc130e756dd4173bb1de1ee5b367f69c9489e1d86956ab46746fb/68747470733a2f2f692e696d6775722e636f6d2f746874387651372e706e67
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Nov 23, 2017 https://github.com/angular/angular/pull/18575#ref-issue-269445759
Enable a reactive form using the FormControlDirective #20008 https://github.com/angular/angular/issues/20008
https://github.com/kara
karahttps://github.com/kara
Dec 20, 2017 https://github.com/angular/angular/pull/18575#pullrequestreview-84629819
View reviewed changes https://github.com/angular/angular/pull/18575/files/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
karahttps://github.com/kara
https://github.com/angular/angular/pull/18575#pullrequestreview-84629819
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/kara
karahttps://github.com/kara
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 20, 2017https://github.com/angular/angular/pull/18575#event-1395206141
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 20, 2017https://github.com/angular/angular/pull/18575#event-1396612845
https://github.com/alxhub
alxhubhttps://github.com/alxhub
karahttps://github.com/kara
Dec 20, 2017https://github.com/angular/angular/pull/18575#event-1396612931
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Dec 20, 2017https://github.com/angular/angular/pull/18575#event-1396613044
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Dec 20, 2017https://github.com/angular/angular/pull/18575#issuecomment-353139519
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Dec 20, 2017https://github.com/angular/angular/pull/18575#issuecomment-353143796
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/trotyl
trotylhttps://github.com/trotyl
Dec 21, 2017https://github.com/angular/angular/pull/18575#issuecomment-353242314
@dzonatanhttps://github.com/dzonatan
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/rvirji-va
rvirji-vahttps://github.com/rvirji-va
Feb 2, 2018https://github.com/angular/angular/pull/18575#issuecomment-362676781
Please reload this pagehttps://github.com/angular/angular/pull/18575
@dzonatanhttps://github.com/dzonatan
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/rvirji-va
rvirji-vahttps://github.com/rvirji-va
Feb 7, 2018https://github.com/angular/angular/pull/18575#issuecomment-363878304
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/LisaTatum
LisaTatumhttps://github.com/LisaTatum
Mar 8, 2018https://github.com/angular/angular/pull/18575#issuecomment-371628148
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/LisaTatum
LisaTatumhttps://github.com/LisaTatum
Mar 18, 2018https://github.com/angular/angular/pull/18575#issuecomment-374051490
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Apr 20, 2018https://github.com/angular/angular/pull/18575#issuecomment-383023142
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/banjankri
banjankrihttps://github.com/banjankri
May 30, 2018https://github.com/angular/angular/pull/18575#issuecomment-393081948
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Jun 4, 2018 https://github.com/angular/angular/pull/18575#ref-issue-297513042
Maximum call stack size exceeded angular/angular-cli#9636 https://github.com/angular/angular-cli/issues/9636
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Aug 8, 2018https://github.com/angular/angular/pull/18575#issuecomment-411308173
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/banjankri
banjankrihttps://github.com/banjankri
Sep 10, 2018https://github.com/angular/angular/pull/18575#issuecomment-419792301
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/kara
karahttps://github.com/kara
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Sep 18, 2018https://github.com/angular/angular/pull/18575#event-1853677418
https://github.com/jasonaden
jasonadenhttps://github.com/jasonaden
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 29, 2019https://github.com/angular/angular/pull/18575#event-2105012968
https://github.com/kara
karahttps://github.com/kara
Sep 9, 2019https://github.com/angular/angular/pull/18575#event-2619517144
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Sep 13, 2019https://github.com/angular/angular/pull/18575#issuecomment-531111113
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Dec 4, 2019 https://github.com/angular/angular/pull/18575#ref-issue-273808292
When replacing form control which has async validator the status from statusChange stays PENDING #20424 https://github.com/angular/angular/issues/20424
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 9, 2020 https://github.com/angular/angular/pull/18575#ref-pullrequest-562805830
fix(forms): Call setDisabledState in in reactive directives when appropriate #35311 https://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 17, 2020https://github.com/angular/angular/pull/18575#issuecomment-729214626
#35311https://github.com/angular/angular/pull/35311
#35311https://github.com/angular/angular/pull/35311
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 17, 2020https://github.com/angular/angular/pull/18575#event-4007546898
https://github.com/dzonatan
dzonatanhttps://github.com/dzonatan
Nov 17, 2020https://github.com/angular/angular/pull/18575#issuecomment-729219638
https://user-images.githubusercontent.com/5166666/99451583-135b1180-292b-11eb-92b2-8a62ae13e6c9.png
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 19, 2020https://github.com/angular/angular/pull/18575#issuecomment-748496154
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 19, 2020https://github.com/angular/angular/pull/18575#event-4132598704
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18575
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/18575/files/bfadd8b51bac7f18cbf902660de9d49f365bd4b2
Please reload this pagehttps://github.com/angular/angular/pull/18575
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
area: forms https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
FormControl does not reflect the new disabled value https://github.com/angular/angular/issues/17806
Please reload this pagehttps://github.com/angular/angular/pull/18575
https://github.com/dzonatan
https://github.com/alxhub
https://github.com/trotyl
https://github.com/rvirji-va
https://github.com/LisaTatum
https://github.com/banjankri
https://github.com/AndrewKushnir
https://github.com/kara
https://github.com/vicb
https://github.com/jasonaden
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.