René's URL Explorer Experiment


Title: feat(aio): lazy-load embedded components by gkalpak · Pull Request #18428 · angular/angular · GitHub

Open Graph Title: feat(aio): lazy-load embedded components by gkalpak · Pull Request #18428 · angular/angular

X Title: feat(aio): lazy-load embedded components by gkalpak · Pull Request #18428 · angular/angular

Description: This is a first rough version (but functional nonetheless 😃). Shout-out to @filipesilva for useful pointers and insights. TODO: Bring the size down. Add/update tests. Do not hide the progress bar while embedded components are being prepared (loaded, compiled, etc). Do not swap contents until embedded components are ready to avoid FOUC (Flash Of Uncompiled Components). Animate leaving/entering views. Fixes #15629 and #16127.

Open Graph Description: This is a first rough version (but functional nonetheless 😃). Shout-out to @filipesilva for useful pointers and insights. TODO: Bring the size down. Add/update tests. Do not hide the progress b...

X Description: This is a first rough version (but functional nonetheless 😃). Shout-out to @filipesilva for useful pointers and insights. TODO: Bring the size down. Add/update tests. Do not hide the progress b...

Opengraph URL: https://github.com/angular/angular/pull/18428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cf38b33c-05cf-2841-7300-82d795930a4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DD4:3D4705:C4B3C8:FE333E:6B00ED28
html-safe-nonceef09c006604c0c7523886c89741121937c72440b5b5d23599e00e03472c3dedd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REQ0OjNENDcwNTpDNEIzQzg6RkUzMzNFOjZCMDBFRDI4IiwidmlzaXRvcl9pZCI6IjQwMDczOTQ1NTQxNTA5NzI3MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac524c9fc603378c4eea3620c656737aaaa29a102a0697a0798a4ca10ffb9951a6
hovercard-subject-tagpull_request:133274027
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/18428/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altThis is a first rough version (but functional nonetheless 😃). Shout-out to @filipesilva for useful pointers and insights. TODO: Bring the size down. Add/update tests. Do not hide the progress b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/18428/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18428%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18428%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18428/files
Reloadhttps://github.com/angular/angular/pull/18428/files
Reloadhttps://github.com/angular/angular/pull/18428/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:feat-aio-defer-embeddedhttps://github.com/gkalpak/angular/tree/feat-aio-defer-embedded
Conversation 62 https://github.com/angular/angular/pull/18428
Commits 8 https://github.com/angular/angular/pull/18428/commits
Checks 0 https://github.com/angular/angular/pull/18428/checks
Files changed https://github.com/angular/angular/pull/18428/files
Please reload this pagehttps://github.com/angular/angular/pull/18428/files
feat(aio): lazy-load embedded components https://github.com/angular/angular/pull/18428/files#top
Show all changes 8 commits https://github.com/angular/angular/pull/18428/files
0924132 feat(aio): lazy-load embedded components gkalpak Jul 31, 2017 https://github.com/angular/angular/pull/18428/commits/0924132092891bb363c17486856169fc06394ce7
4cc6998 fix(aio): do not show new document until embedded components are ready gkalpak Nov 23, 2017 https://github.com/angular/angular/pull/18428/commits/4cc6998a54a9ff48c0eed10c313c01da04905cfc
7d7750e feat(aio): animate the leaving/entering documents gkalpak Nov 23, 2017 https://github.com/angular/angular/pull/18428/commits/7d7750ecf0d175320f0b2d9ab2bc8bad4ec194af
d3dcf03 fix(aio): fix embedded ToC and improve ToC, destroying components and… gkalpak Nov 27, 2017 https://github.com/angular/angular/pull/18428/commits/d3dcf03bf0b39bfcc42c7137dc8c98a006d8d664
d6f0a66 build(aio): upgrade to latest `rxjs` gkalpak Nov 29, 2017 https://github.com/angular/angular/pull/18428/commits/d6f0a669815f065d0696734f424f8bc76aceb8f3
3dbfd32 build(aio): upgrade to latest `@angular/*` gkalpak Nov 23, 2017 https://github.com/angular/angular/pull/18428/commits/3dbfd32dc4f3c6f5853d5c7d5823df719a3f49c8
1b774ce build(aio): upgrade to latest `@angular/material` and `@angular/cdk` gkalpak Nov 24, 2017 https://github.com/angular/angular/pull/18428/commits/1b774ce377ce15fec4980a30550c2b91d841ec61
2d6ed50 build(aio): upgrade to latest `@angular/cli` gkalpak Nov 23, 2017 https://github.com/angular/angular/pull/18428/commits/2d6ed50fcf07d7f65ff240834d66cf474f54ec28
Clear filters https://github.com/angular/angular/pull/18428/files
Please reload this pagehttps://github.com/angular/angular/pull/18428/files
Please reload this pagehttps://github.com/angular/angular/pull/18428/files
package.json https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc
_payload-limits.json https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
app.component.html https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b
app.component.spec.ts https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
app.component.ts https://github.com/angular/angular/pull/18428/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce
app.module.spec.ts https://github.com/angular/angular/pull/18428/files#diff-2665acf63a1455cd950e288be7e5cb7e405aa8dbde87d3dd404d72467a007f68
app.module.ts https://github.com/angular/angular/pull/18428/files#diff-5f257ddc5d754f2304a8caef5ba8ed212fee97bb0e4ef743c619093bdb234d11
embed-components.module.ts https://github.com/angular/angular/pull/18428/files#diff-5d84407b359cbe68593476358b89aa665d5f2c7c1028d246e6b47dda13436611
embed-components.service.spec.ts https://github.com/angular/angular/pull/18428/files#diff-8a85932dfa2918fc7a371542aaaf8dd0c3cb7eddb1816655ad1d8a12cd88e806
embed-components.service.ts https://github.com/angular/angular/pull/18428/files#diff-7789fcea66d58bae4277fbc572a27d25dd7817e8548e79965594361e7bfea130
code.component.ts https://github.com/angular/angular/pull/18428/files#diff-7ed67467b6bd4fcd3af11c2945e4246b0adc8f6d85b9cabde594bc435d7b0eba
embedded.module.ts https://github.com/angular/angular/pull/18428/files#diff-d9c24b71dd416a85b1737c72e0467d4f9ab0bf56ac2442a1649b69334c88a6b2
doc-viewer.component.spec.ts https://github.com/angular/angular/pull/18428/files#diff-f18ad9b6dfe20cb2d709b9dfd519ccd7ce77929cb6dda9aeabf5b9addbaf5626
doc-viewer.component.ts https://github.com/angular/angular/pull/18428/files#diff-527c75fb16a8bb28392b62e83569cebec9d3e97e1582ecf0738faea10054e59a
toc.component.html https://github.com/angular/angular/pull/18428/files#diff-8279e591ba5c9cbcea39fb7f0fa316e18b9cb5fac7b5d4641a6ec536ef26512e
toc.component.spec.ts https://github.com/angular/angular/pull/18428/files#diff-987522dd3f04e7692af161ed4c609f045e39a05fd2b07bb52a504ba56bdf4b64
toc.component.ts https://github.com/angular/angular/pull/18428/files#diff-ee8865fa1696291025471c8c065bafa5f30ebc61aaefdb74033d8c2f69314412
custom-icon-registry.ts https://github.com/angular/angular/pull/18428/files#diff-a7a1fab6b6e85c2fbdd4f5e927d2eb968ef7d19cafe8feea4624c20e8673363e
scroll.service.ts https://github.com/angular/angular/pull/18428/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922
_typography.scss https://github.com/angular/angular/pull/18428/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e
doc-viewer-utils.ts https://github.com/angular/angular/pull/18428/files#diff-3e2c48acb188a9a713d3bfa2c3cfd3c41a8fd6238c0b7e787e59ed7407c8d571
embed-components-utils.ts https://github.com/angular/angular/pull/18428/files#diff-e7c396025133acfe21277c3642e517bd07e945fe3515fec316a6a5945c2a79dd
yarn.lock https://github.com/angular/angular/pull/18428/files#diff-1af839e804ad15434c3c1ce54d144820b5f53e19ba15567ddc26d0122a9f6bea
aio/package.jsonhttps://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc
View file https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18428/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc
https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc
https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc
aio/scripts/_payload-limits.jsonhttps://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
View file https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/scripts/_payload-limits.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18428/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
aio/src/app/app.component.htmlhttps://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b
View file https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/src/app/app.component.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18428/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b
https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b
aio/src/app/app.component.spec.tshttps://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
View file https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18428/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2
Please reload this pagehttps://github.com/angular/angular/pull/18428/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.