| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cf38b33c-05cf-2841-7300-82d795930a4f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DD4:3D4705:C4B3C8:FE333E:6B00ED28 |
| html-safe-nonce | ef09c006604c0c7523886c89741121937c72440b5b5d23599e00e03472c3dedd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REQ0OjNENDcwNTpDNEIzQzg6RkUzMzNFOjZCMDBFRDI4IiwidmlzaXRvcl9pZCI6IjQwMDczOTQ1NTQxNTA5NzI3MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 524c9fc603378c4eea3620c656737aaaa29a102a0697a0798a4ca10ffb9951a6 |
| hovercard-subject-tag | pull_request:133274027 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/18428/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | This is a first rough version (but functional nonetheless 😃).
Shout-out to @filipesilva for useful pointers and insights.
TODO:
Bring the size down.
Add/update tests.
Do not hide the progress b... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/18428/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18428%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18428%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/18428/files |
| Reload | https://github.com/angular/angular/pull/18428/files |
| Reload | https://github.com/angular/angular/pull/18428/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:feat-aio-defer-embedded | https://github.com/gkalpak/angular/tree/feat-aio-defer-embedded |
|
Conversation
62
| https://github.com/angular/angular/pull/18428 |
|
Commits
8
| https://github.com/angular/angular/pull/18428/commits |
|
Checks
0
| https://github.com/angular/angular/pull/18428/checks |
|
Files changed
| https://github.com/angular/angular/pull/18428/files |
| Please reload this page | https://github.com/angular/angular/pull/18428/files |
|
feat(aio): lazy-load embedded components
| https://github.com/angular/angular/pull/18428/files#top |
|
Show all changes
8 commits
| https://github.com/angular/angular/pull/18428/files |
|
0924132
feat(aio): lazy-load embedded components
gkalpak Jul 31, 2017
| https://github.com/angular/angular/pull/18428/commits/0924132092891bb363c17486856169fc06394ce7 |
|
4cc6998
fix(aio): do not show new document until embedded components are ready
gkalpak Nov 23, 2017
| https://github.com/angular/angular/pull/18428/commits/4cc6998a54a9ff48c0eed10c313c01da04905cfc |
|
7d7750e
feat(aio): animate the leaving/entering documents
gkalpak Nov 23, 2017
| https://github.com/angular/angular/pull/18428/commits/7d7750ecf0d175320f0b2d9ab2bc8bad4ec194af |
|
d3dcf03
fix(aio): fix embedded ToC and improve ToC, destroying components and…
gkalpak Nov 27, 2017
| https://github.com/angular/angular/pull/18428/commits/d3dcf03bf0b39bfcc42c7137dc8c98a006d8d664 |
|
d6f0a66
build(aio): upgrade to latest `rxjs`
gkalpak Nov 29, 2017
| https://github.com/angular/angular/pull/18428/commits/d6f0a669815f065d0696734f424f8bc76aceb8f3 |
|
3dbfd32
build(aio): upgrade to latest `@angular/*`
gkalpak Nov 23, 2017
| https://github.com/angular/angular/pull/18428/commits/3dbfd32dc4f3c6f5853d5c7d5823df719a3f49c8 |
|
1b774ce
build(aio): upgrade to latest `@angular/material` and `@angular/cdk`
gkalpak Nov 24, 2017
| https://github.com/angular/angular/pull/18428/commits/1b774ce377ce15fec4980a30550c2b91d841ec61 |
|
2d6ed50
build(aio): upgrade to latest `@angular/cli`
gkalpak Nov 23, 2017
| https://github.com/angular/angular/pull/18428/commits/2d6ed50fcf07d7f65ff240834d66cf474f54ec28 |
|
Clear filters
| https://github.com/angular/angular/pull/18428/files |
| Please reload this page | https://github.com/angular/angular/pull/18428/files |
| Please reload this page | https://github.com/angular/angular/pull/18428/files |
|
package.json
| https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc |
|
_payload-limits.json
| https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84 |
|
app.component.html
| https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b |
|
app.component.spec.ts
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
app.component.ts
| https://github.com/angular/angular/pull/18428/files#diff-1f1b0f61d69d97efb20c38573759f7a0d5d4e5090648a4019c2f9175d56783ce |
|
app.module.spec.ts
| https://github.com/angular/angular/pull/18428/files#diff-2665acf63a1455cd950e288be7e5cb7e405aa8dbde87d3dd404d72467a007f68 |
|
app.module.ts
| https://github.com/angular/angular/pull/18428/files#diff-5f257ddc5d754f2304a8caef5ba8ed212fee97bb0e4ef743c619093bdb234d11 |
|
embed-components.module.ts
| https://github.com/angular/angular/pull/18428/files#diff-5d84407b359cbe68593476358b89aa665d5f2c7c1028d246e6b47dda13436611 |
|
embed-components.service.spec.ts
| https://github.com/angular/angular/pull/18428/files#diff-8a85932dfa2918fc7a371542aaaf8dd0c3cb7eddb1816655ad1d8a12cd88e806 |
|
embed-components.service.ts
| https://github.com/angular/angular/pull/18428/files#diff-7789fcea66d58bae4277fbc572a27d25dd7817e8548e79965594361e7bfea130 |
|
code.component.ts
| https://github.com/angular/angular/pull/18428/files#diff-7ed67467b6bd4fcd3af11c2945e4246b0adc8f6d85b9cabde594bc435d7b0eba |
|
embedded.module.ts
| https://github.com/angular/angular/pull/18428/files#diff-d9c24b71dd416a85b1737c72e0467d4f9ab0bf56ac2442a1649b69334c88a6b2 |
|
doc-viewer.component.spec.ts
| https://github.com/angular/angular/pull/18428/files#diff-f18ad9b6dfe20cb2d709b9dfd519ccd7ce77929cb6dda9aeabf5b9addbaf5626 |
|
doc-viewer.component.ts
| https://github.com/angular/angular/pull/18428/files#diff-527c75fb16a8bb28392b62e83569cebec9d3e97e1582ecf0738faea10054e59a |
|
toc.component.html
| https://github.com/angular/angular/pull/18428/files#diff-8279e591ba5c9cbcea39fb7f0fa316e18b9cb5fac7b5d4641a6ec536ef26512e |
|
toc.component.spec.ts
| https://github.com/angular/angular/pull/18428/files#diff-987522dd3f04e7692af161ed4c609f045e39a05fd2b07bb52a504ba56bdf4b64 |
|
toc.component.ts
| https://github.com/angular/angular/pull/18428/files#diff-ee8865fa1696291025471c8c065bafa5f30ebc61aaefdb74033d8c2f69314412 |
|
custom-icon-registry.ts
| https://github.com/angular/angular/pull/18428/files#diff-a7a1fab6b6e85c2fbdd4f5e927d2eb968ef7d19cafe8feea4624c20e8673363e |
|
scroll.service.ts
| https://github.com/angular/angular/pull/18428/files#diff-b1f2cac076d6b6220d6381cce4f84172643936fac22bf0984b85d02f6b962922 |
|
_typography.scss
| https://github.com/angular/angular/pull/18428/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e |
|
doc-viewer-utils.ts
| https://github.com/angular/angular/pull/18428/files#diff-3e2c48acb188a9a713d3bfa2c3cfd3c41a8fd6238c0b7e787e59ed7407c8d571 |
|
embed-components-utils.ts
| https://github.com/angular/angular/pull/18428/files#diff-e7c396025133acfe21277c3642e517bd07e945fe3515fec316a6a5945c2a79dd |
|
yarn.lock
| https://github.com/angular/angular/pull/18428/files#diff-1af839e804ad15434c3c1ce54d144820b5f53e19ba15567ddc26d0122a9f6bea |
| aio/package.json | https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc |
|
View file
| https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/package.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18428/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc |
|
| https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc |
|
| https://github.com/angular/angular/pull/18428/files#diff-98a57dea22234200232c309cd1413fe58abca658dae9547dda4b2a976f472ffc |
| aio/scripts/_payload-limits.json | https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84 |
|
View file
| https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/scripts/_payload-limits.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18428/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84 |
|
| https://github.com/angular/angular/pull/18428/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84 |
| aio/src/app/app.component.html | https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b |
|
View file
| https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/src/app/app.component.html |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18428/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b |
|
| https://github.com/angular/angular/pull/18428/files#diff-ef0fea8cdebdc14fe7aa9360aa01943d0c681993aa7eb64d40a6874646fb3f9b |
| aio/src/app/app.component.spec.ts | https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
View file
| https://github.com/gkalpak/angular/blob/2d6ed50fcf07d7f65ff240834d66cf474f54ec28/aio/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/18428/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
|
| https://github.com/angular/angular/pull/18428/files#diff-a836216e0cc55f7f87daafaadd093e59855d8385a70837d2df4f128e85d828c2 |
| Please reload this page | https://github.com/angular/angular/pull/18428/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |