René's URL Explorer Experiment


Title: feat(compiler-cli): automatically lower lambda expressions in metadata by chuckjaz · Pull Request #18390 · angular/angular · GitHub

Open Graph Title: feat(compiler-cli): automatically lower lambda expressions in metadata by chuckjaz · Pull Request #18390 · angular/angular

X Title: feat(compiler-cli): automatically lower lambda expressions in metadata by chuckjaz · Pull Request #18390 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [x] Feature What is the current behavior? When a lambda expression is used in an Angular decorator an error is reported during AOT requesting the user rewrite the expression. What is the new behavior? The expression is automatically rewritten to an exported reference. NOTE: This is not yet enabled in ngc as it requires the transform based compiler which is not yet the default. Does this PR introduce a breaking change? [ ] Yes [x] No

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/18390

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bba4cee9-a894-787f-501f-0d047580389d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8A2:216F0D:5DEDB:73BF8:6B00F221
html-safe-nonced88dbc64930938ae2aaaf820461493739e753a70f778e4127086cda960954a05
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEEyOjIxNkYwRDo1REVEQjo3M0JGODo2QjAwRjIyMSIsInZpc2l0b3JfaWQiOiIxMTI0MTkyNTg5Mzk1MzU5MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac65685983dd379f6e9ac391cdbee0165da3b4f3b157cb45e43ff88daff89b5d13
hovercard-subject-tagpull_request:132856921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/18390/files
twitter:imagehttps://avatars.githubusercontent.com/u/372013?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/372013?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/18390/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18390%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F18390%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/18390/files
Reloadhttps://github.com/angular/angular/pull/18390/files
Reloadhttps://github.com/angular/angular/pull/18390/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
chuckjaz:expression-lowering-3https://github.com/chuckjaz/angular/tree/expression-lowering-3
Conversation 17 https://github.com/angular/angular/pull/18390
Commits 2 https://github.com/angular/angular/pull/18390/commits
Checks 0 https://github.com/angular/angular/pull/18390/checks
Files changed https://github.com/angular/angular/pull/18390/files
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
feat(compiler-cli): automatically lower lambda expressions in metadata https://github.com/angular/angular/pull/18390/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/18390/files
5e6e5af feat(tsc-wrapped): allow values to be substituted by collector clients chuckjaz Jul 26, 2017 https://github.com/angular/angular/pull/18390/commits/5e6e5af7208ee71c57db726aae8ca797d13820c4
30bd96d feat(compiler-cli): automatically lower lambda expressions in metadata chuckjaz Jul 13, 2017 https://github.com/angular/angular/pull/18390/commits/30bd96dad205a81aaae7a0c89db102247c96b857
Clear filters https://github.com/angular/angular/pull/18390/files
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
compiler_host.ts https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
path_mapped_compiler_host.ts https://github.com/angular/angular/pull/18390/files#diff-6316e87b5dbd9f4d9ee9e6157a0b8d62c0f0742abf89ddda131148a107e25115
api.ts https://github.com/angular/angular/pull/18390/files#diff-6be45432905608c44eb83e52b9f1c975f6667c8cde6aa3cae0def55502a33fcc
entry_points.ts https://github.com/angular/angular/pull/18390/files#diff-48e70e75402613f5e22ee424d89fcd53f4841c9a6e959000149ee0ffe57c66d4
lower_expressions.ts https://github.com/angular/angular/pull/18390/files#diff-0ef644edbad753b9be64013215eb744402d1591fa6fc74cb3a0ca1361a0ee243
module_filename_resolver.ts https://github.com/angular/angular/pull/18390/files#diff-fa4e4f7cf6e88b3996dced1d7165ffedf7c24df0fb1546ac9870ee540e46c6e7
program.ts https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
ngc_spec.ts https://github.com/angular/angular/pull/18390/files#diff-2188572d51633f43041e93d72c423e9cef07193ceae30d13203847d970577ef4
lower_expressions_spec.ts https://github.com/angular/angular/pull/18390/files#diff-f2a8a4c1ac4b950b2edaa681c203abdb7d358b0d5e2779ee3c20ef4af97db46b
collector.ts https://github.com/angular/angular/pull/18390/files#diff-dc66d1a6ab925e628948eddb41f57865945b3afeb917c35592d2403761e6af0b
evaluator.ts https://github.com/angular/angular/pull/18390/files#diff-ced2de0ceb6289771eceb7f6feac8e51818668ce530df16d0bde4f18d70e4f35
collector_spec.ts https://github.com/angular/angular/pull/18390/files#diff-5e24f60e9894569fde40c3743eebee4780fdbfff8e9ae57c1a72c13d843605a7
evaluator_spec.ts https://github.com/angular/angular/pull/18390/files#diff-9ae4b0b0338a1cc8db13351655a0f5f6af35f47e518e6812c68873c14a275865
main_spec.ts https://github.com/angular/angular/pull/18390/files#diff-53bef76b9572e7a70c8d031c55afe5066993c127d6907512c0a8862e19605f84
symbols_spec.ts https://github.com/angular/angular/pull/18390/files#diff-c9c8f4e7205800d52f8d1fb905f4188803b19668e00cfa70123a0a47ded9e755
tsc_spec.ts https://github.com/angular/angular/pull/18390/files#diff-69e2aa5dc04fca89989084f2be30df66c6b65a5eebbae29e259c98ad73a1d916
packages/compiler-cli/src/compiler_host.tshttps://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/compiler_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
https://github.com/angular/angular/pull/18390/files#diff-a1a07d327676523a5ea23f46b76666cefdb4a1ae7b8898b332963311f8ec44b0
packages/compiler-cli/src/path_mapped_compiler_host.tshttps://github.com/angular/angular/pull/18390/files#diff-6316e87b5dbd9f4d9ee9e6157a0b8d62c0f0742abf89ddda131148a107e25115
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/path_mapped_compiler_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-6316e87b5dbd9f4d9ee9e6157a0b8d62c0f0742abf89ddda131148a107e25115
https://github.com/angular/angular/pull/18390/files#diff-6316e87b5dbd9f4d9ee9e6157a0b8d62c0f0742abf89ddda131148a107e25115
packages/compiler-cli/src/transformers/api.tshttps://github.com/angular/angular/pull/18390/files#diff-6be45432905608c44eb83e52b9f1c975f6667c8cde6aa3cae0def55502a33fcc
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/transformers/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-6be45432905608c44eb83e52b9f1c975f6667c8cde6aa3cae0def55502a33fcc
https://github.com/angular/angular/pull/18390/files#diff-6be45432905608c44eb83e52b9f1c975f6667c8cde6aa3cae0def55502a33fcc
packages/compiler-cli/src/transformers/entry_points.tshttps://github.com/angular/angular/pull/18390/files#diff-48e70e75402613f5e22ee424d89fcd53f4841c9a6e959000149ee0ffe57c66d4
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/transformers/entry_points.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-48e70e75402613f5e22ee424d89fcd53f4841c9a6e959000149ee0ffe57c66d4
packages/compiler-cli/src/transformers/lower_expressions.tshttps://github.com/angular/angular/pull/18390/files#diff-0ef644edbad753b9be64013215eb744402d1591fa6fc74cb3a0ca1361a0ee243
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/transformers/lower_expressions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
vicbhttps://github.com/vicb
Jul 27, 2017https://github.com/angular/angular/pull/18390/files#r129984448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
chuckjazhttps://github.com/chuckjaz
Jul 28, 2017https://github.com/angular/angular/pull/18390/files#r130188102
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
packages/compiler-cli/src/transformers/module_filename_resolver.tshttps://github.com/angular/angular/pull/18390/files#diff-fa4e4f7cf6e88b3996dced1d7165ffedf7c24df0fb1546ac9870ee540e46c6e7
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/transformers/module_filename_resolver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-fa4e4f7cf6e88b3996dced1d7165ffedf7c24df0fb1546ac9870ee540e46c6e7
packages/compiler-cli/src/transformers/program.tshttps://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
View file https://github.com/chuckjaz/angular/blob/30bd96dad205a81aaae7a0c89db102247c96b857/packages/compiler-cli/src/transformers/program.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/18390/{{ revealButtonHref }}
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
https://github.com/angular/angular/pull/18390/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
Please reload this pagehttps://github.com/angular/angular/pull/18390/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.